Re: [igb] add DROP_EN to each RX queue config if TX flow control is disabled

2014-09-14 Thread Adrian Chadd
On 13 September 2014 13:09, Eric Joyner ricer...@gmail.com wrote: This looks good to me. The only comment I have is that according to the I350 datasheet, DROP_EN is already set on all the queues but 0 by default, but I haven't checked for the other adapters covered by igb. Right, but the

Re: [igb] add DROP_EN to each RX queue config if TX flow control is disabled

2014-09-13 Thread Eric Joyner
This looks good to me. The only comment I have is that according to the I350 datasheet, DROP_EN is already set on all the queues but 0 by default, but I haven't checked for the other adapters covered by igb. --- - Eric Joyner On Mon, Sep 8, 2014 at 10:12 PM, Adrian Chadd adr...@freebsd.org

[igb] add DROP_EN to each RX queue config if TX flow control is disabled

2014-09-08 Thread Adrian Chadd
Hi, This patch enables the DROP_EN flag to each RX queue if TX flow control is disabled. It (mostly) mirrors what the ixgbe driver does. This prevents a single full RX ring from stalling the rest of the RX rings. How's it look? (indenting and such aside, thanks google.) -a Index: