Re: [rfc] tcp timer update for RSS

2014-07-01 Thread Eggert, Lars
Hi, [elars@stanley:/home/elars/src] 1 ⌀ grep -r IP_RSSCPUID sys sys/netinet/in.h:/* 71 - XXX was IP_RSSCPUID - can recycle whenever */ sys/netinet/ip_output.c:case IP_RSSCPUID: kernel compilation with RSS currently fails, because IP_RSSCPUID is still used in ip_output.c. Lars

Re: [rfc] tcp timer update for RSS

2014-07-01 Thread Adrian Chadd
On 1 July 2014 06:14, Eggert, Lars l...@netapp.com wrote: Hi, [elars@stanley:/home/elars/src] 1 ⌀ grep -r IP_RSSCPUID sys sys/netinet/in.h:/* 71 - XXX was IP_RSSCPUID - can recycle whenever */ sys/netinet/ip_output.c:case IP_RSSCPUID: kernel compilation with RSS currently

Re: [rfc] tcp timer update for RSS

2014-07-01 Thread Adrian Chadd
On 1 July 2014 06:14, Eggert, Lars l...@netapp.com wrote: Hi, [elars@stanley:/home/elars/src] 1 ⌀ grep -r IP_RSSCPUID sys sys/netinet/in.h:/* 71 - XXX was IP_RSSCPUID - can recycle whenever */ sys/netinet/ip_output.c:case IP_RSSCPUID: kernel compilation with RSS currently

Re: [rfc] tcp timer update for RSS

2014-05-17 Thread Bentkofsky, Michael
Hi Adrian, I haven't had the chance to look this over carefully yet as we're at BSDCan. I think I understand what you're trying to achieve by aligning the per-CPU timer processing per core. In principal that sounds reasonable, although I am unsure if you were trying to solve a particular

Re: [rfc] tcp timer update for RSS

2014-05-17 Thread Adrian Chadd
On 17 May 2014 07:44, Bentkofsky, Michael mbentkof...@verisign.com wrote: Hi Adrian, I haven’t had the chance to look this over carefully yet as we’re at BSDCan. I think I understand what you’re trying to achieve by aligning the per-CPU timer processing per core. In principal that sounds

Re: [rfc] tcp timer update for RSS

2014-05-17 Thread Adrian Chadd
.. and as a note - it'll all be behind #ifdef RSS. -a On 17 May 2014 07:49, Adrian Chadd adr...@freebsd.org wrote: On 17 May 2014 07:44, Bentkofsky, Michael mbentkof...@verisign.com wrote: Hi Adrian, I haven’t had the chance to look this over carefully yet as we’re at BSDCan. I think I

Re: [rfc] tcp timer update for RSS

2014-05-16 Thread Adrian Chadd
Ok, I've given this a whirl on a slightly larger system. There's no 10Gbit/sec in it yet, but it's stable under 64,000 sockets at 1Gbit/sec. I'm going to commit this over the next couple of days unless there are any objections. The defaults are still the same so it won't affect the rest of you.

Re: [rfc] tcp timer update for RSS

2014-05-16 Thread Adrian Chadd
On 16 May 2014 10:47, Adrian Chadd adr...@freebsd.org wrote: Ok, I've given this a whirl on a slightly larger system. There's no 10Gbit/sec in it yet, but it's stable under 64,000 sockets at 1Gbit/sec. I'm going to commit this over the next couple of days unless there are any objections. The

[rfc] tcp timer update for RSS

2014-05-14 Thread Adrian Chadd
Hi, here's a completely untested patch for discussion. I'm emailing it out mostly as a is this a good idea patch rather than a it should just be committed patch. The RSS stuff from Robert maps connections to pcbgroups based on the RSS hash, but it doesn't map the TCP timers the same way. So by

Re: [rfc] tcp timer update for RSS

2014-05-14 Thread Adrian Chadd
.. and i've done a little more than no testing, so far so good. http://people.freebsd.org/~adrian/norse/20140514-tcp-rss-timers-2.diff This adds IP_FLOWID, IP_FLOWTYPE and IP_RSSCPUID to fetch the socket flowid, flowtype and cpuid from the inp. It's mostly for debugging for now. Thanks, -a