Re: vlan support trouble in if_sis driver ?

2008-12-12 Thread Pyun YongHyeon
On Fri, Dec 12, 2008 at 06:12:58PM +0300, Vladimir Ermakov wrote: Pyun YongHyeon wrote: Thanks. Patch committed to HEAD(r185784). MFC? sis(4) supports two kind of controllers. One was made by SiS and the other was manufactured by National Semiconductor. So I

Re: vlan support trouble in if_sis driver ?

2008-12-11 Thread Pyun YongHyeon
On Tue, Dec 09, 2008 at 10:04:18AM +0300, Vladimir Ermakov wrote: Pyun YongHyeon wrote: On Mon, Dec 08, 2008 at 01:17:08PM +0300, Vladimir Ermakov wrote: Pyun YongHyeon wrote: Good. Would you show me the output of pciconf -lcv? If I don't see any oddities in the output, I would

Re: vlan support trouble in if_sis driver ?

2008-12-08 Thread Vladimir Ermakov
Pyun YongHyeon wrote: Good. Would you show me the output of pciconf -lcv? If I don't see any oddities in the output, I would commit the patch. what tests need to try? If parent interface sis0 still works as expected(i.e. without VLAN) there is no need to test other cases, I guess.

Re: vlan support trouble in if_sis driver ?

2008-12-08 Thread Pyun YongHyeon
On Mon, Dec 08, 2008 at 01:17:08PM +0300, Vladimir Ermakov wrote: Pyun YongHyeon wrote: Good. Would you show me the output of pciconf -lcv? If I don't see any oddities in the output, I would commit the patch. what tests need to try? If parent interface sis0 still works as

Re: vlan support trouble in if_sis driver ?

2008-12-07 Thread Pyun YongHyeon
On Sat, Dec 06, 2008 at 09:55:52PM +0300, Vladimir Ermakov wrote: I don't have sis(4) hardwares so I'm not sure it's bug. Since you see Ierrs on parent interface sis0, I guess the hardware might set a giant bit when it receives VLAN frames. Driver might think it received errored

Re: vlan support trouble in if_sis driver ?

2008-12-06 Thread Vladimir Ermakov
I don't have sis(4) hardwares so I'm not sure it's bug. Since you see Ierrs on parent interface sis0, I guess the hardware might set a giant bit when it receives VLAN frames. Driver might think it received errored frames which in turn make driver drop these VLAN frames. Thanks,

vlan support trouble in if_sis driver ?

2008-12-05 Thread Vladimir Ermakov
Hello Using sis card (SiS 900) sis0: SiS 900 10/100BaseTX port 0xe800-0xe8ff mem 0xed16-0xed160fff irq 19 at device 4.0 on pci0 # uname -a FreeBSD damask 7.0-RELEASE FreeBSD 7.0-RELEASE #0: Sun Feb 24 19:59:52 UTC 2008 [EMAIL PROTECTED]:/usr/obj/usr/src/sys/GENERIC i386 #

Re: vlan support trouble in if_sis driver ?

2008-12-05 Thread Pyun YongHyeon
On Fri, Dec 05, 2008 at 04:42:53PM +0300, Vladimir Ermakov wrote: Hello Using sis card (SiS 900) sis0: SiS 900 10/100BaseTX port 0xe800-0xe8ff mem 0xed16-0xed160fff irq 19 at device 4.0 on pci0 # uname -a FreeBSD damask 7.0-RELEASE FreeBSD 7.0-RELEASE #0: Sun Feb 24