Re: Replace bcopy() to update ether_addr

2012-08-22 Thread Mitya
22.08.2012 05:07, Bruce Evans написал: On Mon, Aug 20, 2012 at 05:46:12PM +0300, Mitya wrote: Hi. I found some overhead code in /src/sys/net/if_ethersubr.c and /src/sys/netgraph/ng_ether.c It contains strings, like bcopy(src, dst, ETHER_ADDR_LEN); When src and dst are struct ether_addr*, and

Re: Replace bcopy() to update ether_addr

2012-08-22 Thread Bruce Evans
mitya wrote: 22.08.2012 05:07, Bruce Evans íàïèñàë: On Mon, Aug 20, 2012 at 05:46:12PM +0300, Mitya wrote: Hi. I found some overhead code in /src/sys/net/if_ethersubr.c and /src/sys/netgraph/ng_ether.c It contains strings, like bcopy(src, dst, ETHER_ADDR_LEN); When src and dst are

Re: Replace bcopy() to update ether_addr

2012-08-22 Thread John Baldwin
On Tuesday, August 21, 2012 12:34:42 pm Adrian Chadd wrote: Hi, What about just creating an ETHER_ADDR_COPY(dst, src) and putting that in a relevant include file, then hide the ugliness there? The same benefits will likely appear when copying wifi MAC addresses to/from headers. Thanks,

Re: Replace bcopy() to update ether_addr

2012-08-22 Thread Warner Losh
On Aug 22, 2012, at 6:02 AM, John Baldwin wrote: On Tuesday, August 21, 2012 12:34:42 pm Adrian Chadd wrote: Hi, What about just creating an ETHER_ADDR_COPY(dst, src) and putting that in a relevant include file, then hide the ugliness there? The same benefits will likely appear when

speed tests (Re: Replace bcopy() to update ether_addr)

2012-08-22 Thread Luigi Rizzo
On Wed, Aug 22, 2012 at 02:32:21AM +, Bruce Evans wrote: luigi wrote: even more orthogonal: I found that copying 8n + (5, 6 or 7) bytes was much much slower than copying a multiple of 8 bytes. For n=0, 1,2,4,8 bytes are efficient, other cases are slow (turned into 2 or 3

Re: speed tests (Re: Replace bcopy() to update ether_addr)

2012-08-22 Thread Mitya
22.08.2012 17:36, Luigi Rizzo написал: On Wed, Aug 22, 2012 at 02:32:21AM +, Bruce Evans wrote: luigi wrote: even more orthogonal: I found that copying 8n + (5, 6 or 7) bytes was much much slower than copying a multiple of 8 bytes. For n=0, 1,2,4,8 bytes are efficient, other cases are

Re: speed tests (Re: Replace bcopy() to update ether_addr)

2012-08-22 Thread Luigi Rizzo
On Wed, Aug 22, 2012 at 05:26:47PM +0300, Mitya wrote: 22.08.2012 17:36, Luigi Rizzo ??: On Wed, Aug 22, 2012 at 02:32:21AM +, Bruce Evans wrote: luigi wrote: even more orthogonal: I found that copying 8n + (5, 6 or 7) bytes was much much slower than copying a multiple of

Re: Replace bcopy() to update ether_addr

2012-08-22 Thread Adrian Chadd
On 22 August 2012 05:02, John Baldwin j...@freebsd.org wrote: On Tuesday, August 21, 2012 12:34:42 pm Adrian Chadd wrote: Hi, What about just creating an ETHER_ADDR_COPY(dst, src) and putting that in a relevant include file, then hide the ugliness there? The same benefits will likely appear

Re: Replace bcopy() to update ether_addr

2012-08-22 Thread Warner Losh
On Aug 22, 2012, at 12:54 PM, Adrian Chadd wrote: On 22 August 2012 05:02, John Baldwin j...@freebsd.org wrote: On Tuesday, August 21, 2012 12:34:42 pm Adrian Chadd wrote: Hi, What about just creating an ETHER_ADDR_COPY(dst, src) and putting that in a relevant include file, then hide the

Re: Replace bcopy() to update ether_addr

2012-08-22 Thread John Baldwin
On Wednesday, August 22, 2012 2:54:07 pm Adrian Chadd wrote: On 22 August 2012 05:02, John Baldwin j...@freebsd.org wrote: On Tuesday, August 21, 2012 12:34:42 pm Adrian Chadd wrote: Hi, What about just creating an ETHER_ADDR_COPY(dst, src) and putting that in a relevant include file,

Re: kern/170713: [cxgb] Driver must be loaded after boot due to timing issues checking for kern.ipc.nmb* values set via /boot/loader.conf

2012-08-22 Thread Navdeep Parhar
The following reply was made to PR kern/170713; it has been noted by GNATS. From: Navdeep Parhar n...@freebsd.org To: bug-follo...@freebsd.org, yaneg...@gmail.com Cc: Subject: Re: kern/170713: [cxgb] Driver must be loaded after boot due to timing issues checking for kern.ipc.nmb* values set

Re: kern/170904: [ath] ath driver: configure related parameters when radar detection (DFS) is enabled

2012-08-22 Thread gjb
Old Synopsis: ath driver: configure related parameters when radar detection (DFS) is enabled New Synopsis: [ath] ath driver: configure related parameters when radar detection (DFS) is enabled Class-Changed-From-To: change-request-sw-bug Class-Changed-By: gjb Class-Changed-When: Thu Aug 23

Re: kern/170904: [ath] ath driver: configure related parameters when radar detection (DFS) is enabled

2012-08-22 Thread gjb
Synopsis: [ath] ath driver: configure related parameters when radar detection (DFS) is enabled Class-Changed-From-To: sw-bug-change-request Class-Changed-By: gjb Class-Changed-When: Thu Aug 23 03:40:21 UTC 2012 Class-Changed-Why: Undo class change with previous edit.

Re: kern/170904: [ath] ath driver: configure related parameters when radar detection (DFS) is enabled

2012-08-22 Thread linimon
Synopsis: [ath] ath driver: configure related parameters when radar detection (DFS) is enabled Responsible-Changed-From-To: freebsd-net-freebsd-wireless Responsible-Changed-By: linimon Responsible-Changed-When: Thu Aug 23 03:47:27 UTC 2012 Responsible-Changed-Why: Set more canonical assignment.

Re: kern/170713: [cxgb] Driver must be loaded after boot due to timing issues checking for kern.ipc.nmb* values set via /boot/loader.conf

2012-08-22 Thread Garrett Cooper
The following reply was made to PR kern/170713; it has been noted by GNATS. From: Garrett Cooper yaneg...@gmail.com To: Navdeep Parhar n...@freebsd.org Cc: bug-follo...@freebsd.org Subject: Re: kern/170713: [cxgb] Driver must be loaded after boot due to timing issues checking for kern.ipc.nmb*