[Bug 204438] setsockopt() handling of kern.ipc.maxsockbuf limit

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438 --- Comment #18 from Cameron Sparr --- @Alfred, I guess on Linux there is no way to warn about that, users would have to check the buffer size limits themselves. In conclusion, should I change my patch to do what

[Bug 204438] setsockopt() handling of kern.ipc.maxsockbuf limit

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438 --- Comment #19 from Alfred Perlstein --- For now it makes sense to implement the sysctls as described in comment #15. changing the behavior at this point seems a bad idea. -- You are receiving this mail because: You

[Bug 204438] setsockopt() handling of kern.ipc.maxsockbuf limit

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438 --- Comment #17 from Alfred Perlstein --- That is interesting... how to applications warn "your system doesn't have sufficient buffering enabled for performance" ? -- You are receiving this mail because: You are the

[Bug 204438] setsockopt() handling of kern.ipc.maxsockbuf limit

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438 --- Comment #16 from Cameron Sparr --- I forgot that it's actually spelled out pretty clearly in the comments of the code: /* Don't error on this BSD doesn't and if you think * about it this is right. Otherwise

[Bug 204438] setsockopt() handling of kern.ipc.maxsockbuf limit

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438 --- Comment #15 from Alfred Perlstein --- > Re (1) do you mean that when kern.ipc.maxsockbuf gets set, scale the sb_max > value up by the inverse of sb_max_adj? ie, kern.ipc.maxsockbuf * 2304 / 2048. > In that case,

[Bug 204438] setsockopt() handling of kern.ipc.maxsockbuf limit

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438 Alfred Perlstein changed: What|Removed |Added CC|

[Bug 204438] setsockopt() handling of kern.ipc.maxsockbuf limit

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438 --- Comment #14 from Cameron Sparr --- @Alfred, thanks for the background info Re (1) do you mean that when kern.ipc.maxsockbuf gets set, scale the sb_max value up by the inverse of sb_max_adj? ie,

[Bug 204438] setsockopt() handling of kern.ipc.maxsockbuf limit

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438 Kubilay Kocak changed: What|Removed |Added Flags||mfc-stable9?,

[Bug 204438] setsockopt() handling of kern.ipc.maxsockbuf limit

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438 Kubilay Kocak changed: What|Removed |Added Keywords|needs-patch |patch ---

[Bug 204438] setsockopt() handling of kern.ipc.maxsockbuf limit

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438 --- Comment #12 from Kubilay Kocak --- Looks like I missed the review creation, ignore my last comment, except for the 'needs a committer/assignee' bit ;D -- You are receiving this mail because: You are the assignee

[Differential] [Updated, 12 lines] D4129: Bug 204438 - setsockopt() handling of kern.ipc.maxsockbuf limit

cameronsparr_gmail.com removed rS FreeBSD src repository as the repository for this revision. cameronsparr_gmail.com updated this revision to Diff 10121. cameronsparr_gmail.com added a comment. spaces to tabs CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D4129?vs=10120=10121

[Differential] [Updated] D4129: Bug 204438 - setsockopt() handling of kern.ipc.maxsockbuf limit

cameronsparr_gmail.com updated the summary for this revision. REVISION DETAIL https://reviews.freebsd.org/D4129 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: cameronsparr_gmail.com, Contributor Reviewers, network Cc: freebsd-net-list, imp

[Bug 204438] setsockopt() handling of kern.ipc.maxsockbuf limit

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438 --- Comment #6 from Cameron Sparr --- Created attachment 163023 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=163023=edit Patch of the diff in the URL section. Changes behavior of setsockopt This change

[Bug 204438] setsockopt() handling of kern.ipc.maxsockbuf limit

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438 --- Comment #8 from Allan Jude --- There is a command line tool for Phabricator called 'arcanist' (devel/php5-arcanist) that simplifies posting patches to PHabriactor. It works with svn and git. Or, via the

[Bug 204438] setsockopt() handling of kern.ipc.maxsockbuf limit

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438 --- Comment #9 from NGie Cooper --- This wiki page describes how our current code review process works: https://wiki.freebsd.org/CodeReview -- You are receiving this mail because: You are the assignee for the bug.

[Bug 204438] setsockopt() handling of kern.ipc.maxsockbuf limit

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438 --- Comment #7 from Cameron Sparr --- @Kubilay I realized that I actually have no idea how to use svn/phabricator, so I'm just going to attach a patch to this case. Let me know how it looks, thank you. -- You are

[Bug 204438] setsockopt() handling of kern.ipc.maxsockbuf limit

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438 Cameron Sparr changed: What|Removed |Added URL|https://github.com/sparrc/f

[Differential] [Updated] D4129: Bug 204438 - setsockopt() handling of kern.ipc.maxsockbuf limit

cameronsparr_gmail.com added a reviewer: network. cameronsparr_gmail.com added a subscriber: freebsd-net-list. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D4129 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To:

[Bug 204438] setsockopt() handling of kern.ipc.maxsockbuf limit

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438 --- Comment #10 from Cameron Sparr --- Got it, thanks for the link, I put up a review on phabricator. May I suggest you put a link to the wiki (https://wiki.freebsd.org/CodeReview) on the homepage of the phabricator

[Bug 204438] setsockopt() handling of kern.ipc.maxsockbuf limit

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438 NGie Cooper changed: What|Removed |Added Assignee|freebsd-b...@freebsd.org

[Bug 204438] setsockopt() handling of kern.ipc.maxsockbuf limit

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438 Hiren Panchasara changed: What|Removed |Added CC|