Re: Choice of private ioctl approach

2014-10-06 Thread Andrew Rybchenko
Hello John, On 09/30/2014 07:31 PM, John Baldwin wrote: On Monday, September 29, 2014 8:36:22 am Andrew Rybchenko wrote: Hello, we need to add private ioctl to the driver sfxge(4) to make FW update, do internal diagnostics commands etc. We see at least two approaches in other drivers: 1.

Re: Choice of private ioctl approach

2014-09-30 Thread John Baldwin
On Monday, September 29, 2014 8:36:22 am Andrew Rybchenko wrote: Hello, we need to add private ioctl to the driver sfxge(4) to make FW update, do internal diagnostics commands etc. We see at least two approaches in other drivers: 1. SIOCGPRIVATE_0/ SIOCGPRIVATE_1 on net device 2.

Choice of private ioctl approach

2014-09-29 Thread Andrew Rybchenko
Hello, we need to add private ioctl to the driver sfxge(4) to make FW update, do internal diagnostics commands etc. We see at least two approaches in other drivers: 1. SIOCGPRIVATE_0/ SIOCGPRIVATE_1 on net device 2. dedicated char device with its own ioctl's Is there any recommendations on