Re: suspend/resume regression

2015-07-29 Thread Kevin Oberman
On Wed, Jul 29, 2015 at 5:58 AM, Claude Buisson clbuis...@orange.fr wrote: On 07/26/2015 00:54, Kevin Oberman wrote: John, I'm concerned that two issues may be getting conflated. The issue I thought we were looking at was the failure of some systems (T520, X220, T430) to resume after a

Re: suspend/resume regression

2015-07-29 Thread Claude Buisson
On 07/29/2015 23:53, Kevin Oberman wrote: On Wed, Jul 29, 2015 at 5:58 AM, Claude Buisson clbuis...@orange.fr wrote: On 07/26/2015 00:54, Kevin Oberman wrote: John, I'm concerned that two issues may be getting conflated. The issue I thought we were looking at was the failure of some

Re: suspend/resume regression

2015-07-29 Thread John Baldwin
On Saturday, July 25, 2015 03:54:40 PM Kevin Oberman wrote: John, I'm concerned that two issues may be getting conflated. The issue I thought we were looking at was the failure of some systems (T520, X220, T430) to resume after a number of PCI enhancements were MFCed. This is completely

Re: suspend/resume regression

2015-07-29 Thread Claude Buisson
On 07/26/2015 00:54, Kevin Oberman wrote: John, I'm concerned that two issues may be getting conflated. The issue I thought we were looking at was the failure of some systems (T520, X220, T430) to resume after a number of PCI enhancements were MFCed. This is completely unrelated to the USB

Re: suspend/resume regression

2015-07-29 Thread Kevin Oberman
On Wed, Jul 29, 2015 at 3:47 PM, Claude Buisson clbuis...@orange.fr wrote: On 07/29/2015 23:53, Kevin Oberman wrote: On Wed, Jul 29, 2015 at 5:58 AM, Claude Buisson clbuis...@orange.fr wrote: On 07/26/2015 00:54, Kevin Oberman wrote: John, I'm concerned that two issues may be getting

Re: suspend/resume regression

2015-07-25 Thread Kevin Oberman
John, I'm concerned that two issues may be getting conflated. The issue I thought we were looking at was the failure of some systems (T520, X220, T430) to resume after a number of PCI enhancements were MFCed. This is completely unrelated to the USB issue I was experiencing when trying to test

Re: suspend/resume regression

2015-07-25 Thread Adrian Chadd
Hi, Yes, the USB device suspend/resume thing is a more generic suspend/resume problem. Warner has some ideas - eg, registering a is this a new device? method; the device driver will check if the device has changed upon resume and optionally go through a detach/reattach process. So for USB it

Re: suspend/resume regression

2015-07-22 Thread John Baldwin
On Saturday, July 18, 2015 10:22:33 PM Kevin Oberman wrote: I just confirmed that my system resumes on HEAD of July 16 but fails on 10.2-BETA2. So the problem limited to 10. I'm guessing that some other change made to pci that has not been MFCed is the cause, but it is only causing a problem

Re: suspend/resume regression

2015-07-22 Thread Kevin Oberman
On Tue, Jul 21, 2015 at 3:56 PM, John Baldwin j...@freebsd.org wrote: On Saturday, July 18, 2015 10:22:33 PM Kevin Oberman wrote: I just confirmed that my system resumes on HEAD of July 16 but fails on 10.2-BETA2. So the problem limited to 10. I'm guessing that some other change made to

Re: suspend/resume regression

2015-07-18 Thread Kevin Oberman
I just confirmed that my system resumes on HEAD of July 16 but fails on 10.2-BETA2. So the problem limited to 10. I'm guessing that some other change made to pci that has not been MFCed is the cause, but it is only causing a problem on some hardware. I have seen no reports about systems other than

Re: suspend/resume regression

2015-07-18 Thread Kevin Oberman
Hold the phone! Just found a SATA drive. I will be installing HEAD on it shortly. I won't update the ticket until I get that tested. Kevin Oberman, Network Engineer, Retired E-mail: rkober...@gmail.com PGP Fingerprint: D03FB98AFA78E3B78C1694B318AB39EF1B055683 On Sat, Jul 18, 2015 at 4:34 PM,

Re: suspend/resume regression

2015-07-18 Thread Kevin Oberman
I think it works on HEAD. I suspended OK and tried to resume. The resume initiated and my screen came on... only to tell me that da0p2 was not available. I seem to recall that this was a known issue when running on a USB attached disk. The failure came much further along than on stable where it

Re: suspend/resume regression

2015-07-18 Thread Joseph Mingrone
Head worked for me. Joseph Mingrone j...@ftfl.ca writes: On head, resume worked, but the fn-f4 keybinding didn't suspend. I had to use zzz. Joseph Mingrone j...@ftfl.ca writes: No problem with -head on the X220 as well. Joseph signature.asc Description: PGP signature

Re: suspend/resume regression

2015-07-15 Thread Kevin Oberman
On Wed, Jul 15, 2015 at 12:07 PM, John Baldwin j...@freebsd.org wrote: On Tuesday, July 14, 2015 03:10:59 PM Brandon J. Wandersee wrote: Please forgive me if this seems impudent, but has there been any progress on this? The status of the bug report hasn't changed since it was opened. I

Re: suspend/resume regression

2015-07-15 Thread John Baldwin
On Tuesday, July 14, 2015 03:10:59 PM Brandon J. Wandersee wrote: Please forgive me if this seems impudent, but has there been any progress on this? The status of the bug report hasn't changed since it was opened. I don't mean to be rude, and I certainly appreciate the effort that's gone

Re: suspend/resume regression

2015-07-14 Thread Brandon J . Wandersee
Please forgive me if this seems impudent, but has there been any progress on this? The status of the bug report hasn't changed since it was opened. I don't mean to be rude, and I certainly appreciate the effort that's gone into this already (especially Kevin's detective work), but support for

Re: suspend/resume regression

2015-06-30 Thread Kevin Oberman
On Tue, Jun 30, 2015 at 8:45 AM, John Baldwin j...@freebsd.org wrote: I'm traveling and AFK for a week or so more, but I did test this MFC including suspend/resume with CardBus, etc. on a T440 before committing it. It would be good to know if HEAD works for you. If it does then there's

Re: suspend/resume regression

2015-06-30 Thread John Baldwin
I'm traveling and AFK for a week or so more, but I did test this MFC including suspend/resume with CardBus, etc. on a T440 before committing it. It would be good to know if HEAD works for you. If it does then there's likely another fix from HEAD that you need merged. -- John Baldwin On

Re: suspend/resume regression

2015-06-29 Thread Kevin Oberman
On Sun, Jun 28, 2015 at 11:07 PM, Adrian Chadd adrian.ch...@gmail.com wrote: Ok, so which subset of changes is the culprit? (sorry, I'm tired.. :( ) The merge of 281874 broke it. Unfortunately, this is a fairly large and important change that touches five files, mainly dev/pci/pci.c and

Re: suspend/resume regression

2015-06-29 Thread Adrian Chadd
Ok, so which subset of changes is the culprit? (sorry, I'm tired.. :( ) -a On 28 June 2015 at 22:45, Kevin Oberman rkober...@gmail.com wrote: On Sun, Jun 28, 2015 at 4:54 PM, Kevin Oberman rkober...@gmail.com wrote: On Sun, Jun 28, 2015 at 10:38 AM, Joseph Mingrone j...@ftfl.ca wrote:

Re: suspend/resume regression

2015-06-28 Thread Joseph Mingrone
Kevin Oberman rkober...@gmail.com writes: I have narrowed it to between 283990 and 284074. Have to crash, so maybe someone else will track it down by tomorrow. I only see a handfull (10) commits in there that look like possible causes. 280434 is compiling right now as the prime candidate.

Re: suspend/resume regression

2015-06-28 Thread Kevin Oberman
On Sat, Jun 27, 2015 at 8:03 PM, Brandon J. Wandersee brandon.wander...@gmail.com wrote: Kevin Oberman writes: On Sat, Jun 27, 2015 at 3:13 PM, Joseph Mingrone j...@ftfl.ca wrote: Adrian Chadd adrian.ch...@gmail.com writes: does it always fail now? Yes. The behaviour I described

Re: suspend/resume regression

2015-06-28 Thread Claude Buisson
On 06/28/2015 09:12, Kevin Oberman wrote: On Sat, Jun 27, 2015 at 8:03 PM, Brandon J. Wandersee brandon.wander...@gmail.com wrote: Kevin Oberman writes: On Sat, Jun 27, 2015 at 3:13 PM, Joseph Mingrone j...@ftfl.ca wrote: Adrian Chadd adrian.ch...@gmail.com writes: does it always fail

Re: suspend/resume regression

2015-06-28 Thread Kevin Oberman
OK. This time I'm REALLY adding jhb@ to the CC. Guess my first cup of tea had not kicked in. Kevin Oberman, Network Engineer, Retired E-mail: rkober...@gmail.com PGP Fingerprint: D03FB98AFA78E3B78C1694B318AB39EF1B055683 On Sun, Jun 28, 2015 at 9:29 AM, Kevin Oberman rkober...@gmail.com wrote:

Re: suspend/resume regression

2015-06-28 Thread Kevin Oberman
On Sun, Jun 28, 2015 at 3:27 AM, Joseph Mingrone j...@ftfl.ca wrote: Kevin Oberman rkober...@gmail.com writes: I have narrowed it to between 283990 and 284074. Have to crash, so maybe someone else will track it down by tomorrow. I only see a handfull (10) commits in there that look like

Re: suspend/resume regression

2015-06-28 Thread Kevin Oberman
On Sun, Jun 28, 2015 at 9:29 AM, Kevin Oberman rkober...@gmail.com wrote: On Sun, Jun 28, 2015 at 3:27 AM, Joseph Mingrone j...@ftfl.ca wrote: Kevin Oberman rkober...@gmail.com writes: I have narrowed it to between 283990 and 284074. Have to crash, so maybe someone else will track it down

Re: suspend/resume regression

2015-06-28 Thread Joseph Mingrone
Adrian Chadd adrian.ch...@gmail.com writes: ok. I've updated my x230 to the latest -head and itis okay at suspend/resume. No problem with -head on the X220 as well. I can go acquire an x220 (now that they're cheap) to have as another reference laptop. You might ping Allan Jude. If I'm not

Re: suspend/resume regression

2015-06-28 Thread Adrian Chadd
Hi, ok. I've updated my x230 to the latest -head and itis okay at suspend/resume. I can go acquire an x220 (now that they're cheap) to have as another reference laptop. I don't run stable/10 on anything, so it may be something odd with what he MFCed and what's in stable/10. I'll update the

Re: suspend/resume regression

2015-06-28 Thread Kevin Oberman
On Sun, Jun 28, 2015 at 10:38 AM, Joseph Mingrone j...@ftfl.ca wrote: Adrian Chadd adrian.ch...@gmail.com writes: ok. I've updated my x230 to the latest -head and it is okay at suspend/resume. No problem with -head on the X220 as well. I can go acquire an x220 (now that they're cheap)

Re: suspend/resume regression

2015-06-28 Thread Adrian Chadd
Thanks for digging into this! (two laptops are now running -head from today, all iswell. I'll update the t400 tomorrow.) -a On 28 June 2015 at 16:54, Kevin Oberman rkober...@gmail.com wrote: On Sun, Jun 28, 2015 at 10:38 AM, Joseph Mingrone j...@ftfl.ca wrote: Adrian Chadd

Re: suspend/resume regression

2015-06-28 Thread Kevin Oberman
On Sun, Jun 28, 2015 at 4:54 PM, Kevin Oberman rkober...@gmail.com wrote: On Sun, Jun 28, 2015 at 10:38 AM, Joseph Mingrone j...@ftfl.ca wrote: Adrian Chadd adrian.ch...@gmail.com writes: ok. I've updated my x230 to the latest -head and it is okay at suspend/resume. No problem with -head

Re: suspend/resume regression

2015-06-27 Thread Adrian Chadd
does it always fail now? -a On 26 June 2015 at 14:06, Joseph Mingrone j...@ftfl.ca wrote: This is on a Lenovo X220. Suspend/resume was working until some time between late April and last week's STABLE snapshot. Suspend always seems to work, but there are two issues with resume. 1) When

Re: suspend/resume regression

2015-06-27 Thread Adrian Chadd
Hi, please start binary searching. I'll update my x230 tonight when I get home and see if -head is broken. -adrian On 27 June 2015 at 15:48, Kevin Oberman rkober...@gmail.com wrote: On Sat, Jun 27, 2015 at 3:13 PM, Joseph Mingrone j...@ftfl.ca wrote: Adrian Chadd adrian.ch...@gmail.com

Re: suspend/resume regression

2015-06-27 Thread Joseph Mingrone
Adrian Chadd adrian.ch...@gmail.com writes: does it always fail now? Yes. The behaviour I described is, so far with 15-20 tries, consistent. signature.asc Description: PGP signature

Re: suspend/resume regression

2015-06-27 Thread Kevin Oberman
On Sat, Jun 27, 2015 at 3:13 PM, Joseph Mingrone j...@ftfl.ca wrote: Adrian Chadd adrian.ch...@gmail.com writes: does it always fail now? Yes. The behaviour I described is, so far with 15-20 tries, consistent. I confirm that I see the similar behavior on my T520 ThinkPad, Sandy Bridge

Re: suspend/resume regression

2015-06-27 Thread Joseph Mingrone
Kevin Oberman rkober...@gmail.com writes: On Sat, Jun 27, 2015 at 3:13 PM, Joseph Mingrone j...@ftfl.ca wrote: Adrian Chadd adrian.ch...@gmail.com writes: does it always fail now? Yes. The behaviour I described is, so far with 15-20 tries, consistent. I confirm that I see the similar

Re: suspend/resume regression

2015-06-27 Thread Joseph Mingrone
Adrian Chadd adrian.ch...@gmail.com writes: please start binary searching. I'll update my x230 tonight when I get home and see if -head is broken. On head, resume worked, but the fn-f4 keybinding didn't suspend. I had to use zzz. I'm trying different different revisions and I'll report back

Re: suspend/resume regression

2015-06-27 Thread Brandon J . Wandersee
Kevin Oberman writes: On Sat, Jun 27, 2015 at 3:13 PM, Joseph Mingrone j...@ftfl.ca wrote: Adrian Chadd adrian.ch...@gmail.com writes: does it always fail now? Yes. The behaviour I described is, so far with 15-20 tries, consistent. I confirm that I see the similar behavior on my T520

suspend/resume regression

2015-06-26 Thread Joseph Mingrone
This is on a Lenovo X220. Suspend/resume was working until some time between late April and last week's STABLE snapshot. Suspend always seems to work, but there are two issues with resume. 1) When i915kms isn't loaded, then resuming works, but the screen doesn't come back on. I'm able to ssh