emaste created this revision.
emaste added reviewers: jhibbits, bapt, brooks.
emaste added subscribers: freebsd-toolchain-list, jhibbits.
REVISION SUMMARY
Reported by: @jhibbits
REVISION DETAIL
https://reviews.freebsd.org/D3237
AFFECTED FILES
usr.bin/ar/ar.c
CHANGE DETAILS
diff --git
emaste created this revision.
emaste added reviewers: bapt, brooks, imp.
emaste added a subscriber: freebsd-toolchain-list.
REVISION SUMMARY
Posting for comment, review and testing.
REVISION DETAIL
https://reviews.freebsd.org/D3238
AFFECTED FILES
UPDATING
gnu/usr.bin/binutils/Makefile
This revision was automatically updated to reflect the committed changes.
Closed by commit rS285844: ar: add -U (unique) option to disable -D
(deterministic) mode (authored by emaste).
CHANGED PRIOR TO COMMIT
https://reviews.freebsd.org/D3175?vs=7235id=7268#toc
REPOSITORY
rS FreeBSD src
This revision was automatically updated to reflect the committed changes.
Closed by commit rS285845: readelf: avoid division by zero on section entry
size (authored by emaste).
CHANGED PRIOR TO COMMIT
https://reviews.freebsd.org/D2338?vs=7069id=7269#toc
REPOSITORY
rS FreeBSD src repository
emaste created this revision.
emaste added reviewers: bapt, brooks.
emaste added a subscriber: freebsd-toolchain-list.
REVISION SUMMARY
Ar cannot handle UIDs with more than 6 digits, and there's little value in
storing the mtime, uid, gid and mode anyhow. Turn on deterministic (-D) mode
by
emaste updated this revision to Diff 7272.
emaste added a comment.
Add note of -D default in man page.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D3190?vs=7271id=7272
REVISION DETAIL
https://reviews.freebsd.org/D3190
AFFECTED FILES
usr.bin/ar/ar.1
usr.bin/ar/ar.c
CHANGE
emaste created this revision.
emaste added reviewers: brooks, bapt.
emaste added a subscriber: freebsd-toolchain-list.
REVISION SUMMARY
I'd like to make ar(1) produce deterministic output by default. In order to
do so we'll first need an option to turn off deterministic mode.
Note that
emaste added a comment.
Yes - sorry for the delay. I realized I had a newer implementation that
factored the divide-by-zero checks into a helper function, and uploaded the
new diff a few days ago.
REVISION DETAIL
https://reviews.freebsd.org/D2338
EMAIL PREFERENCES
emaste created this revision.
emaste added a reviewer: kib.
emaste added subscribers: davide, dim, freebsd-toolchain-list, kib.
REVISION SUMMARY
Fault in the buffer prior to writing as a workaround for poor performance due
to interaction with kernel fs deadlock avoidance code. See the comment
emaste created this revision.
emaste added a reviewer: andrew.
emaste added a subscriber: freebsd-toolchain-list.
Herald added subscribers: emaste, bdrewery.
REVISION SUMMARY
ELF Tool Chain elfcopy is nearly a drop-in replacement for GNU objcopy (but
does not currently support PE output,
emaste added a comment.
In https://reviews.freebsd.org/D2887#56056, @bapt wrote:
Why not always build elfcopy and just make a hardlink objcopy if
MK_ELFCOPY_AS_OBJCOPY is set?
That will make elfcopy always available to users
That's a possibility, although I think I'd prefer to
emaste accepted this revision.
REPOSITORY
rS FreeBSD src repository
BRANCH
/head
REVISION DETAIL
https://reviews.freebsd.org/D1932
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: dim, theraven, emaste
Cc: freebsd-toolchain
emaste added a comment.
In https://reviews.freebsd.org/D1932#49686, @imp wrote:
it is a very de-facto standard that many ports rely on.
Many ports will choose CC if it exists, but I'm not sure they rely on it.
Autoconf and cmake builds will try a list and if they pick c++ next they'll be
This revision was automatically updated to reflect the committed changes.
Closed by commit rS283108: Update crunch bootstrapping test for recent fixes
(authored by emaste).
CHANGED PRIOR TO COMMIT
https://reviews.freebsd.org/D2576?vs=5456id=5476#toc
REPOSITORY
rS FreeBSD src repository
emaste created this revision.
emaste added a reviewer: imp.
emaste added a subscriber: freebsd-toolchain.
REVISION SUMMARY
- r277259 crunchide: Correct 64-bit section header offset
- r281674 crunchide: always include both 32- and 64-bit ELF support
With built-in cross-size support we
emaste created this revision.
emaste added a reviewer: brooks.
emaste added a subscriber: freebsd-toolchain.
REVISION DETAIL
https://reviews.freebsd.org/D2408
AFFECTED FILES
usr.bin/Makefile
usr.bin/cxxfilt/Makefile
CHANGE DETAILS
diff --git a/usr.bin/cxxfilt/Makefile
emaste added a comment.
Oh - we also need either:
diff --git a/gnu/usr.bin/cc/Makefile b/gnu/usr.bin/cc/Makefile
index abc9876..12ee7f8 100644
--- a/gnu/usr.bin/cc/Makefile
+++ b/gnu/usr.bin/cc/Makefile
@@ -12,7 +12,10 @@ SUBDIR+= cpp
.endif
.if ${MK_CXX} != no
-SUBDIR+=
This revision was automatically updated to reflect the committed changes.
Closed by commit rS282285: Add ELF Tool Chain's c++filt to the build (authored
by emaste).
CHANGED PRIOR TO COMMIT
https://reviews.freebsd.org/D2408?vs=5108id=5123#toc
REPOSITORY
rS FreeBSD src repository
REVISION
emaste added inline comments.
INLINE COMMENTS
gnu/usr.bin/cc/Makefile:16 Sigh, this is backwards.
Will update to `== no` - i.e., build GCC's c++filt in the
`WITHOUT_ELFTOOLCHAIN_TOOLS` case.
REVISION DETAIL
https://reviews.freebsd.org/D2408
EMAIL PREFERENCES
emaste created this revision.
emaste added a subscriber: freebsd-toolchain.
REVISION SUMMARY
Variations reported in:
https://sourceforge.net/p/elftoolchain/tickets/439
https://sourceforge.net/p/elftoolchain/tickets/444
https://sourceforge.net/p/elftoolchain/tickets/445
emaste added inline comments.
INLINE COMMENTS
Makefile.inc1:1469 I believe @imp suggested we still need it unconditionally
when crossbuilding, and also note that usr.sbin/crunch is added for
`${BOOTSTRAPPING} 114` in bootstrap-tools. I wonder if we can just
promote usr.sbin/crunch to an
emaste added a comment.
! In D2305#4, @emaste wrote:
I believe @imp suggested we still need it unconditionally when crossbuilding,
and also note that usr.sbin/crunch is added for `${BOOTSTRAPPING} 114`
in bootstrap-tools. I wonder if we can just promote usr.sbin/crunch to an
emaste created this revision.
emaste added a reviewer: imp.
emaste added a subscriber: freebsd-toolchain.
REVISION SUMMARY
Reported by antiAgainst in ELF Tool Chain ticket 442
https://sourceforge.net/p/elftoolchain/tickets/442/
REVISION DETAIL
https://reviews.freebsd.org/D2317
AFFECTED
emaste requested changes to this revision.
emaste added a comment.
This revision now requires changes to proceed.
`_crunchide` here is still needed for cross-builds (but should be addressed by
D2314).
`_crunch` in the context not provided in this diff is the one that needs to be
updated
I
emaste added a comment.
This review can be abandoned - the original issue is now fixed.
We can open another review for a future change to make it unconditional.
REVISION DETAIL
https://reviews.freebsd.org/D2305
To: rodrigc, imp, emaste
Cc: freebsd-toolchain
emaste closed this revision.
emaste added a comment.
Committed here: https://sourceforge.net/p/elftoolchain/code/3187, will come
into FreeBSD with the next ELF Tool Chain import
REVISION DETAIL
https://reviews.freebsd.org/D2317
To: emaste, imp
Cc: freebsd-toolchain
emaste added a comment.
! In D2302#4, @andrew wrote:
Would it be difficult to have a warning if the package is not installed?
Perhaps
```
.else
@echo arm64 skipped - install aarch64-binutils port or package to build
```
emaste created this revision.
emaste added reviewers: imp, andrew.
emaste added a subscriber: freebsd-toolchain.
REVISION SUMMARY
arm64 relies on an external binutils port or package because the in-tree
linker from binutils 2.17.50 does not support arm64. Add arm64 to universe if
the linker
emaste added inline comments.
INLINE COMMENTS
Makefile:383 Also add
```
universe_epilogue: universe_arm64_skip
```
REVISION DETAIL
https://reviews.freebsd.org/D2302
To: emaste, imp, andrew
Cc: freebsd-toolchain
___
emaste updated this revision to Diff 4849.
emaste added a comment.
Add a message if we skip arm64 because we don't have binutils
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D2302?vs=4846id=4849
REVISION DETAIL
https://reviews.freebsd.org/D2302
AFFECTED FILES
Makefile
To:
emaste closed this revision.
emaste updated this revision to Diff 4865.
emaste added a comment.
Closed by commit rS281629 (authored by @emaste).
CHANGED PRIOR TO COMMIT
https://reviews.freebsd.org/D2302?vs=4849id=4865#toc
REVISION DETAIL
https://reviews.freebsd.org/D2302
AFFECTED FILES
emaste added a subscriber: emaste.
REVISION DETAIL
https://reviews.freebsd.org/D2285
To: rodrigc, jmg
Cc: emaste, dim, freebsd-toolchain
___
freebsd-toolchain@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To
emaste accepted this revision.
emaste added a comment.
This revision is now accepted and ready to land.
LGTM
BRANCH
/head
REVISION DETAIL
https://reviews.freebsd.org/D2187
To: dim, rodrigc, imp, bapt, emaste
Cc: emaste, imp, freebsd-toolchain
___
emaste created this revision.
emaste added a reviewer: imp.
emaste added a subscriber: freebsd-toolchain.
REVISION SUMMARY
ELF toolchain readelf lacked some functionality at the time other tools (like
size, strip, nm, etc.) were switched over to the ELF toolchain versions. This
has been
emaste added a comment.
exp-run is here:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198950
REVISION DETAIL
https://reviews.freebsd.org/D2156
To: emaste, imp, bapt
Cc: freebsd-toolchain
___
freebsd-toolchain@freebsd.org mailing list
emaste created this revision.
emaste added reviewers: andrew, imp.
emaste added a subscriber: freebsd-toolchain.
REVISION SUMMARY
In cross-build cases it is possible we won't have a cross-strip during the
the rescue build. Binaries are already stripped on install anyhow, so there is
no need
emaste added a comment.
This supports aarch64 builds by installing the aarch64-binutils port and adding
`CROSS_BINUTILS_PREFIX=/usr/local/aarch64-freebsd/bin/` to the make command
line.
REVISION DETAIL
https://reviews.freebsd.org/D1974
To: emaste, bapt
Cc: andrew, freebsd-toolchain
emaste added a subscriber: andrew.
REVISION DETAIL
https://reviews.freebsd.org/D1974
To: emaste, bapt
Cc: andrew, freebsd-toolchain
___
freebsd-toolchain@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To
emaste closed this revision.
emaste updated this revision to Diff 3999.
emaste added a comment.
Closed by commit rS279328 (authored by @emaste).
CHANGED PRIOR TO COMMIT
https://reviews.freebsd.org/D1974?vs=3998id=3999#toc
REVISION DETAIL
https://reviews.freebsd.org/D1974
AFFECTED FILES
emaste created this revision.
emaste added a reviewer: bapt.
emaste added a subscriber: freebsd-toolchain.
REVISION SUMMARY
Right now `CROSS_BINUTILS_PATH` is honoured only when `XCC` is set, i.e. an
out-of-tree compiler. Allow `CROSS_BINUTILS_PATH` to pass through to a -B
option also when
emaste added a comment.
See also D1819
REVISION DETAIL
https://reviews.freebsd.org/D1826
To: emaste
Cc: freebsd-toolchain
___
freebsd-toolchain@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send
emaste added a reviewer: br.
REVISION DETAIL
https://reviews.freebsd.org/D1819
To: emaste, gnn, rpaulo, br
Cc: rpaulo, freebsd-toolchain
___
freebsd-toolchain@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To
emaste added reviewers: kostikbel, rpaulo.
REVISION DETAIL
https://reviews.freebsd.org/D1826
To: emaste, kostikbel, rpaulo
Cc: freebsd-toolchain
___
freebsd-toolchain@freebsd.org mailing list
emaste created this revision.
emaste added a subscriber: freebsd-toolchain.
REVISION SUMMARY
In practice .rela debug relocations often use the the .debug_* sections as
the symbol, which has the value 0:
```
Relocation section '.rela.debug_info' at offset 0xd18 contains 205 entries:
emaste created this revision.
emaste added a reviewer: gnn.
emaste added a subscriber: freebsd-toolchain.
REVISION SUMMARY
Some architectures have .rel relocations for debug data, so handle it in
addition to .rela.
Issue discovered from ctfconvert on un-linked ARM object files.
REVISION
emaste closed this revision.
emaste updated this revision to Diff 3500.
emaste added a comment.
Closed by commit rS277843 (authored by @emaste).
CHANGED PRIOR TO COMMIT
https://reviews.freebsd.org/D1682?vs=3447id=3500#toc
REVISION DETAIL
https://reviews.freebsd.org/D1682
AFFECTED FILES
emaste created this revision.
emaste added a subscriber: freebsd-toolchain.
REVISION SUMMARY
Strip is often used to modify existing files, rather than creating new files.
If the existing file has hard links or is a symbolic link, act as if editing
the file in place and preserve the links.
emaste retitled this revision from elfcopy: Consider program name to start
after last - to elfcopy: Select mode by the end of the program name.
emaste updated the summary for this revision.
emaste updated this revision to Diff 3418.
emaste added a comment.
Output a warning if the program name
emaste updated this revision to Diff 3417.
emaste added a comment.
This revision now requires review to proceed.
Just compare the end of the program name with strip/mcs rather than looking for
a dash. This is the way it's done in FreeBSD ar/ranlib already, and allows
names like bsdstrip. Also
emaste created this revision.
emaste added a subscriber: freebsd-toolchain.
REVISION SUMMARY
For 64-bit binaries the Elf_Ehdr e_shoff is at offset 40, not 44. Instead of
using an incorrect hardcoded offset, let the compiler figure it out for us with
offsetof().
REVISION DETAIL
emaste added a reviewer: pfg.
REVISION DETAIL
https://reviews.freebsd.org/D1543
To: emaste, pfg
Cc: freebsd-toolchain
___
freebsd-toolchain@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any
emaste closed this revision.
emaste added a comment.
Committed as rS277259
REVISION DETAIL
https://reviews.freebsd.org/D1543
To: emaste, pfg, imp
Cc: freebsd-toolchain
___
freebsd-toolchain@freebsd.org mailing list
emaste created this revision.
emaste added reviewers: bapt, andrew.
emaste added a subscriber: freebsd-toolchain.
REVISION DETAIL
https://reviews.freebsd.org/D1516
AFFECTED FILES
devel/aarch64-binutils/Makefile
devel/binutils/files/patch-aarch64.diff
To: emaste, bapt, andrew
Cc:
emaste closed this revision.
emaste updated this revision to Diff 3160.
emaste added a comment.
Closed by commit rP376986 (authored by @emaste).
CHANGED PRIOR TO COMMIT
https://reviews.freebsd.org/D1516?vs=3147id=3160#toc
REVISION DETAIL
https://reviews.freebsd.org/D1516
AFFECTED FILES
emaste created this revision.
emaste added a subscriber: freebsd-toolchain.
REVISION SUMMARY
Set ARCHIVE_EXTRACT_SECURE_SYMLINKS and ARCHIVE_EXTRACT_SECURE_NODOTDOT as in
bsdtar to prevent extraction of archive entries whose pathnames contain .. or
whose target directory would be altered by a
emaste added a comment.
Apart from the bit of ugliness in lib/Makefile
Perhaps the ugliness needs a comment, at least.
Also a BSD.debug.mk entry for `WITH_DEBUG_FILES=yes`?
REVISION DETAIL
https://reviews.freebsd.org/D1505
To: dim, andrew, bapt, imp, emaste
Cc: freebsd-toolchain
emaste added a comment.
Note that I also did not introduce yet another WITH_LIBCLANG_RT knob,
This is fine in my opinion; we don't need another knob.
REVISION DETAIL
https://reviews.freebsd.org/D1505
To: dim, andrew, bapt, imp, emaste
Cc: freebsd-toolchain
emaste added a subscriber: emaste.
BRANCH
/head
REVISION DETAIL
https://reviews.freebsd.org/D1468
To: andrew, loos, sbruno, rpaulo, ian, dim, imp
Cc: emaste, freebsd-toolchain
___
freebsd-toolchain@freebsd.org mailing list
emaste added a comment.
! In D1446#10, @andrew wrote:
We will also need llvm r92 to build the kernel without using floating
point registers.
Can we bring this one directly into HEAD?
BRANCH
/head
REVISION DETAIL
https://reviews.freebsd.org/D1446
To: andrew, emaste, dim
Cc:
emaste added a comment.
I imported this change then merged to my arm64 branch and it looks fine to me.
REVISION DETAIL
https://reviews.freebsd.org/D1446
To: dim, andrew, emaste
Cc: freebsd-toolchain, emaste
___
freebsd-toolchain@freebsd.org mailing
emaste added a subscriber: freebsd-toolchain.
REVISION DETAIL
https://reviews.freebsd.org/D1446
To: andrew, emaste, dim
Cc: freebsd-toolchain, emaste
___
freebsd-toolchain@freebsd.org mailing list
emaste accepted this revision.
This revision is now accepted and ready to land.
BRANCH
/head
INLINE COMMENTS
lib/clang/include/AArch64GenAsmMatcher.inc:1 Please unexpand these before
checkin.
SVN does the expansion on checkout. I'm not sure if they're collapsed on
checkin, or stored
emaste closed this revision.
emaste updated this revision to Diff 3002.
emaste added a comment.
Closed by commit rS276705 (authored by @emaste).
CHANGED PRIOR TO COMMIT
https://reviews.freebsd.org/D1428?vs=2980id=3002#toc
REVISION DETAIL
https://reviews.freebsd.org/D1428
AFFECTED FILES
emaste created this revision.
emaste added a subscriber: freebsd-toolchain.
REVISION SUMMARY
Previously elftoolchain readelf(1) only displayed correct names for Linux
note types.
Upstream elftoolchain ticket #473
https://sourceforge.net/p/elftoolchain/tickets/473/
REVISION DETAIL
emaste added a comment.
! In D1428#3, @rpaulo wrote:
This looks odd. Why are we relying on magic numbers instead of
constants/enums like before?
Some of the constants in the previous version are Linux-specific, and don't
exist in our ELF headers.
We could make up our own constants (e.g.
emaste closed this revision.
emaste updated this revision to Diff 2813.
emaste added a comment.
Closed by commit rS276061 (authored by @emaste).
CHANGED PRIOR TO COMMIT
https://reviews.freebsd.org/D1341?vs=2791id=2813#toc
REVISION DETAIL
https://reviews.freebsd.org/D1341
AFFECTED FILES
emaste updated the test plan for this revision.
REVISION DETAIL
https://reviews.freebsd.org/D1341
To: emaste
Cc: freebsd-toolchain
___
freebsd-toolchain@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To
emaste closed this revision.
emaste updated this revision to Diff 2778.
emaste added a comment.
Closed by commit rS275862 (authored by @emaste).
CHANGED PRIOR TO COMMIT
https://reviews.freebsd.org/D1327?vs=2767id=2778#toc
REVISION DETAIL
https://reviews.freebsd.org/D1327
AFFECTED FILES
68 matches
Mail list logo