[Differential] [Accepted] D1819: libdwarf: Handle .rel relocations

2015-02-11 Thread rpaulo (Rui Paulo)
rpaulo added a subscriber: rpaulo. rpaulo accepted this revision. rpaulo added a reviewer: rpaulo. rpaulo added a comment. This revision is now accepted and ready to land. Reviewed. REVISION DETAIL https://reviews.freebsd.org/D1819 To: emaste, gnn, rpaulo Cc: rpaulo, freebsd-toolchain

[Differential] [Accepted] D1682: Preserve hard symbolic links when modifying source file

2015-01-27 Thread rpaulo (Rui Paulo)
rpaulo accepted this revision. rpaulo added a reviewer: rpaulo. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1682 To: emaste, rpaulo Cc: freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing list

[Differential] [Changed Subscribers] D1428: readelf: Handle note types from different operating systems

2015-01-03 Thread rpaulo (Rui Paulo)
rpaulo added a subscriber: rpaulo. rpaulo added a comment. This looks odd. Why are we relying on magic numbers instead of constants/enums like before? REVISION DETAIL https://reviews.freebsd.org/D1428 To: emaste Cc: rpaulo, freebsd-toolchain ___

[Differential] [Commented On] D1428: readelf: Handle note types from different operating systems

2015-01-03 Thread rpaulo (Rui Paulo)
rpaulo added a comment. ! In D1428#5, @emaste wrote: ! In D1428#3, @rpaulo wrote: This looks odd. Why are we relying on magic numbers instead of constants/enums like before? Some of the constants in the previous version are Linux-specific, and don't exist in our ELF headers. We could