Re: [ft-devel] Searching for an FT2 tester program

2009-04-05 Thread Werner LEMBERG

David wrote:

 I would also prefer if you do *not* modify public header files (e.g.
 ftimage.h), the corresponding declarations you want to add could
 instead be placed in internal/ftobjs.h

Oran, in case this is still true, please fix it.


Werner


___
Freetype-devel mailing list
Freetype-devel@nongnu.org
http://lists.nongnu.org/mailman/listinfo/freetype-devel


RE: [ft-devel] Searching for an FT2 tester program

2009-04-05 Thread Oran Agra
Hi,
Here's what I wrote him regarding this request.
Please tell me if you still want me to move these to ftobjs.h?



Arranging a set of patches where each of them is a meaningful unit of changes 
takes a lot of work.

I'll do that again, but I hope that's the last time I have to do that.

 

Regarding ftimage.h and ftrender.h,

These macros that declared there might be necessary if a user needs to 
instantiate an FT_Outline_Funcs or FT_Raster_Funcs or FT_Glyph_Class struct in 
his code and needs the code to be compatible with PIC.

 

Regarding the rest of the changes in ftmodapi.h and ftrender,

I don’t know if a user is expected to implement a renderer or a module 
externally (on his own), but if he does then he might need these macros too.

If not, then why are FT_Renderer_Class and FT_Module_Class structs exposed to 
the user?

 
Anyway, if you do decide to move these macros to another header, we can do that 
after the current set of patches I'm preparing.

Thanks.

Oran.

-Original Message-
From: Werner LEMBERG [mailto:w...@gnu.org] 
Sent: Sunday, April 05, 2009 12:06 PM
To: o...@monfort.co.il; freetype-devel@nongnu.org
Subject: Re: [ft-devel] Searching for an FT2 tester program


David wrote:

 I would also prefer if you do *not* modify public header files (e.g.
 ftimage.h), the corresponding declarations you want to add could
 instead be placed in internal/ftobjs.h

Oran, in case this is still true, please fix it.


Werner




___
Freetype-devel mailing list
Freetype-devel@nongnu.org
http://lists.nongnu.org/mailman/listinfo/freetype-devel


Re: [ft-devel] Searching for an FT2 tester program

2009-04-05 Thread Werner LEMBERG
 Arranging a set of patches where each of them is a meaningful unit
 of changes takes a lot of work.

 I'll do that again, but I hope that's the last time I have to do
 that.

I've answered that already -- use your changes as-is, and apply
possible fixes on top of it (including possible fixes to the header
issues).

 Regarding ftimage.h and ftrender.h,

 These macros that declared there might be necessary if a user needs
 to instantiate an FT_Outline_Funcs or FT_Raster_Funcs or
 FT_Glyph_Class struct in his code and needs the code to be
 compatible with PIC.

A general remark: It is not possible (and probably never will be) to
add a (font) driver on the application side; it must always be
integrated into the FreeType library source code tree.  Maybe some
time a good guy is willing to clean up the interface so that a driver
can really be plugged in externally, but I think it is really not
worth the trouble.  It seems that your macros in ftimage.h are not
affected by this limitation, but I'm not sure about the added stuff in
ftrender.h.

 I don’t know if a user is expected to implement a renderer or a
 module externally (on his own), but if he does then he might need
 these macros too.

Currently I think the answer is `no' to both.

 If not, then why are FT_Renderer_Class and FT_Module_Class structs
 exposed to the user?

I think this is a historical accident.  IMHO, the whole module class
stuff should be simplified since the later implemented `service'
feature works much better.

 Anyway, if you do decide to move these macros to another header, we
 can do that after the current set of patches I'm preparing.

Yep.


Werner
___
Freetype-devel mailing list
Freetype-devel@nongnu.org
http://lists.nongnu.org/mailman/listinfo/freetype-devel


RE: [ft-devel] Searching for an FT2 tester program

2009-04-05 Thread Oran Agra
Hi,
I've pushed the PIC changes into GIT (including moving the changes from the 
public headers to ftobjs.h).

Please let me know if there are any problems.
I've checked that it builds with the jam system (non PIC) with VS2005.
And also that the PIC version builds with the custom build I'm using (ADS and 
RVCT for BREW).
Also verified that ftview works on a simple font.

I imagine some makefiles should be updated.
And a lot of testing is needed.

Btw, I've found a broken link in:
http://freetype.sourceforge.net/developer.html#anongit
The link to https://savannah.gnu.org/maintenance/UsingGit needs to be with http 
and not https.




___
Freetype-devel mailing list
Freetype-devel@nongnu.org
http://lists.nongnu.org/mailman/listinfo/freetype-devel


Re: [ft-devel] Searching for an FT2 tester program

2009-04-05 Thread Werner LEMBERG
 I've pushed the PIC changes into GIT (including moving the changes
 from the public headers to ftobjs.h).

Congrats!  It will take some time until I've reviewed it completely.

And thanks for your big efforts!

 Btw, I've found a broken link in:
 http://freetype.sourceforge.net/developer.html#anongit The link to
 https://savannah.gnu.org/maintenance/UsingGit needs to be with http
 and not https.

I'll forward it to the Savannah maintainers.


Werner


___
Freetype-devel mailing list
Freetype-devel@nongnu.org
http://lists.nongnu.org/mailman/listinfo/freetype-devel


Re: [ft-devel] Searching for an FT2 tester program

2009-04-05 Thread Werner LEMBERG

 Btw, I've found a broken link in:
 http://freetype.sourceforge.net/developer.html#anongit The link to
 https://savannah.gnu.org/maintenance/UsingGit needs to be with http
 and not https.

Oops!  This is related to FreeType :-)  Fixed, thanks.

[Interestingly, both http and https works for me (even if I'm not
logged in) with my Firefox browser.]


Werner


___
Freetype-devel mailing list
Freetype-devel@nongnu.org
http://lists.nongnu.org/mailman/listinfo/freetype-devel


Re: [ft-devel] Searching for an FT2 tester program

2009-04-05 Thread David Turner
2009/4/5 Oran Agra o...@monfort.co.il

 Hi,
 I've pushed the PIC changes into GIT (including moving the changes from the
 public headers to ftobjs.h).

 Please let me know if there are any problems.
 I've checked that it builds with the jam system (non PIC) with VS2005.
 And also that the PIC version builds with the custom build I'm using (ADS
 and RVCT for BREW).
 Also verified that ftview works on a simple font.


Thanks a lot Oran, this is really great work.



 I imagine some makefiles should be updated.
 And a lot of testing is needed.

 Btw, I've found a broken link in:
 http://freetype.sourceforge.net/developer.html#anongit
 The link to https://savannah.gnu.org/maintenance/UsingGit needs to be with
 http and not https.




 ___
 Freetype-devel mailing list
 Freetype-devel@nongnu.org
 http://lists.nongnu.org/mailman/listinfo/freetype-devel

___
Freetype-devel mailing list
Freetype-devel@nongnu.org
http://lists.nongnu.org/mailman/listinfo/freetype-devel