[fricas-devel] [PATCH] small fixes for previous commits

2017-03-23 Thread oldk1331
Add a missing testcase title and add obsolete messages to nil and null. --- a/src/algebra/list.spad +++ b/src/algebra/list.spad @@ -229,9 +229,10 @@ Exports ==> ListAggregate S with nil : () -> % ++ nil() returns the empty list. +++ This function is obsolete, use

Re: [fricas-devel] [PATCH] documentation for permgrps.spad

2017-03-23 Thread oldk1331
> By 'literate' I mean formatted text. Do you mean '\spad{}' markup? > I don't know how you feel about a third party (me) > writing comments for other peoples code? Documentation and comments should be treated as code, of course everyone can and should improve. > I don't feel qualified to try

[fricas-devel] [PATCH] documentation for permgrps.spad

2017-03-23 Thread Martin Baker
I have added some documentation to permgrps in patch here: https://github.com/martinbaker/fricasAlgTop/blob/master/permgrps2.patch This contains documentation only, no code changes. By 'documentation' I mean comments + literate. By 'literate' I mean formatted text. I have not tried to follow

Re: [fricas-devel] simplify(exp) gives error

2017-03-23 Thread Bill Page
On 23 March 2017 at 13:09, Waldek Hebisch wrote: > Bill Page wrote: >> >> On 22 March 2017 at 23:29, oldk1331 wrote: >> >> BTW: For 'exp' using 'opex' as indicated in other messages >> >> is reasonable. But I am sceptical about large scale >> >>

Re: [fricas-devel] simplify(exp) gives error

2017-03-23 Thread Waldek Hebisch
oldk1331 wrote: > > This patch only fixes usage of 'exp'. And it should be applied > after my other patch 'fix simplifyExp: make it recursive'. I have applied this patch with a previous patch (hopefully the one you intended). A patch normally should not create known problems, so the two should

Re: [fricas-devel] simplify(exp) gives error

2017-03-23 Thread Waldek Hebisch
Bill Page wrote: > > On 22 March 2017 at 23:29, oldk1331 wrote: > >> BTW: For 'exp' using 'opex' as indicated in other messages > >> is reasonable. But I am sceptical about large scale > >> attempt at fixining behaviour of other operators -- there > >> are more tricky cases.

Re: [fricas-devel] simplify(exp) gives error

2017-03-23 Thread Bill Page
On 22 March 2017 at 23:29, oldk1331 wrote: >> BTW: For 'exp' using 'opex' as indicated in other messages >> is reasonable. But I am sceptical about large scale >> attempt at fixining behaviour of other operators -- there >> are more tricky cases. > > This patch only fixes

Re: [fricas-devel] [PATCH] fix OutputForm for AssociationListAggregate

2017-03-23 Thread oldk1331
> I like the proposal with an explicit domain KeyValue better than relying > on unspecified exports of Record. > > Such a definition would probably simplify the condition for = in XHashTable Yes, that's the motivation. It'll allow proper '=' and '<'. > However, I am not sure about the name of

Re: [fricas-devel] [PATCH] fix OutputForm for AssociationListAggregate

2017-03-23 Thread Ralf Hemmecke
> Another function '=' has similar problems, but in order > to properly fix this, I need to define a new domain > KeyValue(Key, Entry), which is an abstraction over > Record(key: Key, entry : Entry), so it will have > proper '=' defined in KeyValue. I like the proposal with an explicit domain