Martin Baker wrote:
>
> Yes I know void()$Void is needed but is 'return'?
No, logically 'void()$Void' is redundant: correct code can not
look at Void value. 'void()$Void' is useful for working around
compiler bugs, but if there is no but to work around it is
better to omit it.
--
On 29/03/18 14:12, oldk1331 wrote:
On Wed, Mar 28, 2018 at 5:43 PM, Martin Baker wrote:
However something looks funny about the patch, do you need both => and
return void()$Void ? is the 'return' redundant? Its been a long time and I
may have forgotten something.
Martin
Martin Baker wrote:
>
> On 29/03/18 14:12, oldk1331 wrote:> You see, without explicity a "return
> void()$Void", some
> > other value may be returned, but again, there's nothing
> > interesting to do with a value of Void type.
>
> That's not my point. You have changed the code to this:
>
>
On 29/03/18 14:12, oldk1331 wrote:> You see, without explicity a "return
void()$Void", some
other value may be returned, but again, there's nothing
interesting to do with a value of Void type.
That's not my point. You have changed the code to this:
every?(leaf?, c) =>
s : String := concat
On Wed, Mar 28, 2018 at 5:43 PM, Martin Baker wrote:
> Hi oldk1331,
>
> (should I call you oldk1331?)
That's fine, I perfer a little anonymity online.
> However something looks funny about the patch, do you need both => and
> return void()$Void ? is the 'return' redundant?
>
> Sorry about that. Can you review a small cleanup in html.spad?
>
> --- a/src/algebra/html.spad
> +++ b/src/algebra/html.spad
> @@ -380,12 +380,8 @@
>if enableGrid then
> if tagName = "table" then enableGrid := false
> if tagName = "tr" then enableGrid := false
> -
Hi oldk1331,
(should I call you oldk1331?)
I tried it and it seems to work OK.
Here is a test case:
)set output algebra off
)set output html on
a=b
Without this condition 'a','=' and 'b' would appear on separate lines
but both with and without the patch they are correctly combined onto one
Sorry about that. Can you review a small cleanup in html.spad?
--- a/src/algebra/html.spad
+++ b/src/algebra/html.spad
@@ -380,12 +380,8 @@
if enableGrid then
if tagName = "table" then enableGrid := false
if tagName = "tr" then enableGrid := false
- b : List Boolean
oldk1331,
Thanks for fixing the typos in html.spad but I'm not sure about the
americanisation of the word 'customise'!
Martin
--
You received this message because you are subscribed to the Google Groups "FriCAS -
computer algebra system" group.
To unsubscribe from this group and stop