Re: Implicit SSL PROT level defaults to Clear

2008-12-23 Thread Kevin Conaway
Do you want me to update the patch for FTPSERVER-247 to change the field name from sslRequired to implicitSsl? On Mon, Dec 22, 2008 at 3:09 PM, Kevin Conaway kevin.cona...@gmail.comwrote: On Mon, Dec 22, 2008 at 3:03 PM, Niklas Gustavsson nik...@protocol7.comwrote: On Mon, Dec 22, 2008 at

Re: Implicit SSL PROT level defaults to Clear

2008-12-23 Thread Niklas Gustavsson
On Tue, Dec 23, 2008 at 4:13 PM, Kevin Conaway kevin.cona...@gmail.com wrote: Do you want me to update the patch for FTPSERVER-247 to change the field name from sslRequired to implicitSsl? Please do, and if you got the time, feel free to add support from the XML config and some tests :-)

Re: Implicit SSL PROT level defaults to Clear

2008-12-23 Thread Kevin Conaway
Will do. Is it possible to have this included in the 1.0.0 release? I know you're only looking to do bug fixes right now but this fix is low impact, opt in and I think it would great increase the flexibility of the final product On Tue, Dec 23, 2008 at 3:03 PM, Niklas Gustavsson

Re: Implicit SSL PROT level defaults to Clear

2008-12-22 Thread Kevin Conaway
I have created an issue in Jira and attached a patch: https://issues.apache.org/jira/browse/FTPSERVER-247 On Wed, Dec 17, 2008 at 5:32 PM, Kevin Conaway kevin.cona...@gmail.comwrote: Fair enough. I could add a new parameter called forceSsl to the DataConnectionConfig. The

Re: Implicit SSL PROT level defaults to Clear

2008-12-17 Thread Kevin Conaway
I apologize for replying to myself but I have some more thoughts. To me, the implied part of implicit SSL means that at the application level, the user isn't aware that the FTP session is being conducted over SSL. Having to issue a PROT command to set the data protection level violates the

Re: Implicit SSL PROT level defaults to Clear

2008-12-17 Thread Sai Pullabhotla
There are cases where a client/server just want a secure channel on the control connection (encrypt user name and password), but not the data itself. I don't think it is a good idea to change the default, but it would be nice to add a new option to the dataConnection to force SSL. Sai Pullabhotla

Re: Implicit SSL PROT level defaults to Clear

2008-12-17 Thread David Latorre
Hello Kevin, As you already said we are following the RFC here and -although I admit that makes little sense in these days- Sai is right that it is quite common to have only the control channel encrypted: I even saw a client (gFtp maybe?) that didn't support SSL for the data channel. And there

Re: Implicit SSL PROT level defaults to Clear

2008-12-17 Thread Sai Pullabhotla
Is that even necessary? The DataConnectionConfig already has an SslConfiguration property. If that property is set, doesn't that imply that the data channel should use SSL? The SSL Configuration for the data connection tells the server that if a Client wants to use a secure channel, use the

Re: Implicit SSL PROT level defaults to Clear

2008-12-17 Thread Kevin Conaway
Fair enough. I could add a new parameter called forceSsl to the DataConnectionConfig. The IoDataConnectionFactory would then use SSL for the data channel if forceSsl is true. Does that sound appropriate? On Wed, Dec 17, 2008 at 4:43 PM, Sai Pullabhotla sai.pullabho...@jmethods.com wrote: Is