Re: [patch] Read DIR -- Read DIR/config

). I don't think being more verbose always helps readability though. For example, I'd use a function: Execute app app_args in place of Test (X app) Exec exec app app_args /Simon Griph

Re: Issue with the new (=2007-02-04) move parsing code

=== RCS file: /home/cvs/fvwm/fvwm/ChangeLog,v retrieving revision 1.2958 diff -u -r1.2958 ChangeLog --- ChangeLog 1 Aug 2007 21:02:31 - 1.2958 +++ ChangeLog 4 Aug 2007 14:53:39 - @@ -1,3 +1,11 @@ +2007-08-04 Simon Griph simon

Re: [patch] Read DIR -- Read DIR/config

On 04/08/07, Simon Griph [EMAIL PROTECTED] wrote: I don't think being more verbose always helps readability though. It does in this case. You'd have to remember that: Read SomeDirectory is actually doing: Read SomeDirectory/config That's non-obvious at a glance what's happening. So I

Re: [patch] Read DIR -- Read DIR/config

me. :) -- Thomas Adam Do you always prefer the explicit? What about Read file vs Read $[FVWM_USERDIR]/file ? You made a good point though. Readability is important. /Simon Griph

Re: [patch] Read DIR -- Read DIR/config

then apply the patch themselves. /Simon Griph

Re: Issue with the new (=2007-02-04) move parsing code

to understand my own code. :-) I have no objection to that. ;-) /Simon Griph

[patch] Combining EdgeCommand and EdgeLeaveCommand

to EdgeCommand, a warning if these arguments are omitted and a warning for using EdgeLeaveCommand. The patch is attached. Including the part that makes EdgeCommand bind a command to all four edges if the direction argument is omitted. /Simon Griph fvwm-edge-command.diff.gz Description: application/gzip

[patch] support for external image loaders via imlib2

parsing code from PImageLoadSvg into the new PImageParseRenderOpts function so that it can be used by both image loaders. /Simon Griph fvwm-imlib2.diff.gz Description: application/gzip

[patch] enable icon dithering by default for display depths = 8

The man page states that dithering is the default for display depths = 8. Apparently icons seams to be an exception. This patch makes dithering the default for icons as well. /Simon Griph Index: ChangeLog === RCS file: /home/cvs

Re: [bugfix] FvwmButtons: bitmap icons are drawn with incorrect colors

the patch? I didn't remove them manually. Apparently, my version of diff excludes trailing newlines at the end of a file from the context. /Simon Griph

Issue with the new (=2007-02-04) move parsing code

the window to 50 50. /Simon Griph Index: ChangeLog === RCS file: /home/cvs/fvwm/fvwm/ChangeLog,v retrieving revision 1.2955 diff -u -r1.2955 ChangeLog --- ChangeLog 26 Jul 2007 09:23:02 - 1.2955 +++ ChangeLog 31 Jul 2007 11:31:28

[bugfix] FvwmButtons: bitmap icons are drawn with incorrect colors

/ChangeLog,v retrieving revision 1.1262 diff -u -r1.1262 ChangeLog --- modules/ChangeLog 22 Jul 2007 23:01:50 - 1.1262 +++ modules/ChangeLog 23 Jul 2007 14:00:55 - @@ -1,3 +1,10 @@ +2007-07-23 Simon Griph simon(at)griph(dot)se + + * FvwmButtons/draw.h (RedrawButton

[bugfix] FvwmButtons: ActiveColorset without ActiveIcon/ActiveTitle

With ... *FvwmButtons: (ActiveColorset 1) ... the button isn't redrawn on EnterNotify. Se attached patch for a fix. /Simon Griph Index: NEWS === RCS file: /home/cvs/fvwm/fvwm/NEWS,v retrieving revision 1.705 diff -u -r1.705

Re: [bugfix] FvwmButtons: ActiveColorset without ActiveIcon/ActiveTitle

Looks like FvwmButtons is ignoring more LeaveNotify events than it should. I don't know if this is how it should be fixed, but looking for an existing subwindow of the XCrossingEvent seems to work well enough. Se the attached patch. /Simon Griph Index: modules/ChangeLog

small fix

Someone missed to add extra conditions when changing from unsigned to signed. /Simon Griph Index: libs/PictureImageLoader.c === RCS file: /home/cvs/fvwm/fvwm/libs/PictureImageLoader.c,v retrieving revision 1.33 diff -u -r1.33

Re: [patches] CursorStyle: ARGB mouse cursors

as before. PImageLoadBitmap was no more than a wrapped call to XReadBitmapFile, which I decided to move into PImageLoadPixmapFromFile. The reason is that all image loader functions now returns the images data as a 32 bit array, but XReadBitmapFile returns a pixmap. /Simon Griph

[patch] svg html doc output

none uniform scaling and transposing to the svg rendering option code. Useful for none square images. /Simon Griph fvwm-svg-doc.diff.gz Description: application/gzip fvwm-svg-doc-images.tar.gz Description: application/gzip

Re: [patches] CursorStyle: ARGB mouse cursors

from the regular fvwm image loader and then use it to create mouse cursors. Each intermediate patch step is usable, meaning that if you don't have time to look through all parts at ones, you could start out with part 1, apply that part, and leave the other parts for later. /Simon Griph

[bugfix] Condition separation

revision 1.2933 diff -u -r1.2933 ChangeLog --- ChangeLog 3 Jul 2007 07:27:38 - 1.2933 +++ ChangeLog 7 Jul 2007 18:38:48 - @@ -1,3 +1,11 @@ +2007-07-07 Simon Griph simon(at)griph(dot)se + + * NEWS: + * fvwm/conditional.c (CreateConditionMask): + bugfix: Condition

SVG patch revision one

* fixed sscanf portability issues * simplified Separate rendering options from path * moved Frsvg_init() calls to fvwm/fvwm.c, bin/fvwm-root.c, lib/fvwmlib.c * added Fsvg.h to libfvwm_a_SOURCES * added librsvg2-dev to Build-Depends (debain/control.in) /Simon fvwm-svg-r1.diff.gz Description:

Re: SVG patch revision one

* fixed sscanf portability issues * simplified Separate rendering options from path * moved Frsvg_init() calls to fvwm/fvwm.c, bin/fvwm-root.c, lib/fvwmlib.c * added Fsvg.h to libfvwm_a_SOURCES * added librsvg2-dev to Build-Depends (debain/control.in) * removed unnecessary tests /Simon