CVS domivogt: * Use int instead of unsinged int in many places.

2007-01-13 Thread FVWM CVS
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: domivogt07/01/13 09:07:14 Modified files: . : ChangeLog fvwm : add_window.c builtins.c colorset.c cursor.c events.c events.h ewmh.c ewmh.h ewmh_events.c

Re: CVS domivogt: * Use int instead of unsinged int in many places.

2007-01-13 Thread Viktor Griph
On Sat, 13 Jan 2007, FVWM CVS wrote: * Use int instead of unsinged int in many places. but gcc4.1 complains on passing wrongly signed types to function taking pointers as arguments: Graphics.c:849: warning: pointer targets in passing argument 5 of XQueryBestTile differ in signedness

Re: CVS domivogt: * Use int instead of unsinged int in many places.

2007-01-13 Thread Viktor Griph
On Sat, 13 Jan 2007, Dominik Vogt wrote: On Sat, Jan 13, 2007 at 05:41:43PM +0100, Viktor Griph wrote: On Sat, 13 Jan 2007, FVWM CVS wrote: * Use int instead of unsinged int in many places. but gcc4.1 complains on passing wrongly signed types to function taking pointers as arguments:

Re: CVS domivogt: * Use int instead of unsinged int in many places.

2007-01-13 Thread Dominik Vogt
On Sat, Jan 13, 2007 at 09:11:51PM +0100, Viktor Griph wrote: On Sat, 13 Jan 2007, Dominik Vogt wrote: On Sat, Jan 13, 2007 at 05:41:43PM +0100, Viktor Griph wrote: On Sat, 13 Jan 2007, FVWM CVS wrote: * Use int instead of unsinged int in many places. but gcc4.1 complains on passing

Re: CVS domivogt: * Use int instead of unsinged int in many places.

2007-01-13 Thread Dominik Vogt
On Sat, Jan 13, 2007 at 09:11:51PM +0100, Viktor Griph wrote: I'd rather have the arithmetic fixed. The problem is that it's almost impossible to do. Simple calculations like x = y / z Can have very surprising results if y is signed and z is unsigned. One really shouldn't ever use unsigned