Re: Compilation warnings in Flocale.c

2007-08-28 Thread seventh guardian
On 8/28/07, seventh guardian [EMAIL PROTECTED] wrote: OOPS: $ make CFLAGS=-g -O2 -Wall -Wpointer-arith -fno-strict-aliasing -Werror make all-recursive make[1]: Entering directory `/home/renato/apps/cvs/fvwm' Making all in libs make[2]: Entering directory `/home/renato/apps/cvs/fvwm/libs'

Compilation warnings in Flocale.c

2007-08-28 Thread seventh guardian
OOPS: $ make CFLAGS=-g -O2 -Wall -Wpointer-arith -fno-strict-aliasing -Werror make all-recursive make[1]: Entering directory `/home/renato/apps/cvs/fvwm' Making all in libs make[2]: Entering directory `/home/renato/apps/cvs/fvwm/libs' if gcc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I/usr/include

Re: Compilation warnings in Flocale.c

2007-08-28 Thread seventh guardian
On 8/28/07, Viktor Griph [EMAIL PROTECTED] wrote: On Tue, 28 Aug 2007, seventh guardian wrote: On 8/28/07, Dominik Vogt [EMAIL PROTECTED] wrote: On Tue, Aug 28, 2007 at 02:13:20PM +0100, seventh guardian wrote: On 8/28/07, seventh guardian [EMAIL PROTECTED] wrote: OOPS: $ make

Re: Compilation warnings in Flocale.c

2007-08-28 Thread seventh guardian
On 8/28/07, seventh guardian [EMAIL PROTECTED] wrote: On 8/28/07, seventh guardian [EMAIL PROTECTED] wrote: On 8/28/07, Dominik Vogt [EMAIL PROTECTED] wrote: On Tue, Aug 28, 2007 at 02:13:20PM +0100, seventh guardian wrote: On 8/28/07, seventh guardian [EMAIL PROTECTED] wrote: OOPS:

Re: Compilation warnings in Flocale.c

2007-08-28 Thread Dominik Vogt
On Tue, Aug 28, 2007 at 03:12:25PM +0100, seventh guardian wrote: On 8/28/07, Dominik Vogt [EMAIL PROTECTED] wrote: Hum but now gcc complains about the const char * vs. char *: (...) cc1: warnings being treated as errors Flocale.c: In function 'FlocaleGetFftFont':

Re: Compilation warnings in Flocale.c

2007-08-28 Thread Viktor Griph
On Tue, 28 Aug 2007, Dominik Vogt wrote: On Tue, Aug 28, 2007 at 02:55:26PM +0100, seventh guardian wrote: On 8/28/07, seventh guardian [EMAIL PROTECTED] wrote: On 8/28/07, Dominik Vogt [EMAIL PROTECTED] wrote: On Tue, Aug 28, 2007 at 02:13:20PM +0100, seventh guardian wrote: On 8/28/07,

Re: Compilation warnings in Flocale.c

2007-08-28 Thread seventh guardian
On 8/28/07, Dominik Vogt [EMAIL PROTECTED] wrote: On Tue, Aug 28, 2007 at 02:55:26PM +0100, seventh guardian wrote: On 8/28/07, seventh guardian [EMAIL PROTECTED] wrote: On 8/28/07, Dominik Vogt [EMAIL PROTECTED] wrote: On Tue, Aug 28, 2007 at 02:13:20PM +0100, seventh guardian wrote:

Re: Compilation warnings in Flocale.c

2007-08-28 Thread Dominik Vogt
Using strcasecmp is wrong, since that would mean that anyonw entering the smae font as the fallback would have a memory leak. The test is there to not try to free string literals. I see. But on the other hand, it wasn't comparing pointers, it was comparing a pointer with a string

Re: Compilation warnings in Flocale.c

2007-08-28 Thread seventh guardian
On 8/28/07, Viktor Griph [EMAIL PROTECTED] wrote: On Tue, 28 Aug 2007, Dominik Vogt wrote: On Tue, Aug 28, 2007 at 02:55:26PM +0100, seventh guardian wrote: On 8/28/07, seventh guardian [EMAIL PROTECTED] wrote: (...) cc1: warnings being treated as errors Flocale.c: In function