Re: [RFC] New parser framework for testing

2021-11-18 Thread Dominik Vogt
On Thu, Nov 18, 2021 at 03:31:46PM +, Thomas Adam wrote: > On Thu, Nov 18, 2021 at 02:19:11PM +0100, Dominik Vogt wrote: > > Most of the tests were meant to catch parsing bugs, leaks and > > crashes. A mor organised approach in the future would be good. > > Maybe it would even be possible to

Re: [RFC] New parser framework for testing

2021-11-18 Thread Thomas Adam
On Thu, Nov 18, 2021 at 02:19:11PM +0100, Dominik Vogt wrote: > Most of the tests were meant to catch parsing bugs, leaks and > crashes. A mor organised approach in the future would be good. > Maybe it would even be possible to generate test cases for > commands programmatically from the BNF. It

Re: [RFC] New parser framework for testing

2021-11-18 Thread Dominik Vogt
We need to put the results and suggestions of this discusstion in a file. > On Thu, Nov 18, 2021 at 12:31:09AM +0100, Dominik Vogt wrote: > > Anyway, we need > > infrastructure for automated testing. > > We used to have something like that but it fell into bitrot and I removed it > years ago.

Re: [RFC] New parser framework for testing

2021-11-18 Thread Thomas Adam
On Thu, Nov 18, 2021 at 12:31:09AM +0100, Dominik Vogt wrote: > I haven't found anything yet either. Anyway, we need > infrastructure for automated testing. That shouldn't involve much > more than a testing directory, a Makefile with a "test" target, > and a couple of files that can be fed into

Re: [RFC] New parser framework for testing

2021-11-17 Thread Dominik Vogt
On Wed, Nov 17, 2021 at 10:40:56PM +, Thomas Adam wrote: > On Wed, Nov 17, 2021 at 08:40:09PM +0100, Dominik Vogt wrote: > > 'k, the patched code didn't immediately crash, so here it is (two > > patches). Please test. > > I've applied those two patches on a branch called `new-parser`. > > So

Re: [RFC] New parser framework for testing

2021-11-17 Thread Thomas Adam
On Wed, Nov 17, 2021 at 08:40:09PM +0100, Dominik Vogt wrote: > 'k, the patched code didn't immediately crash, so here it is (two > patches). Please test. I've applied those two patches on a branch called `new-parser`. So far, I've tested this on approximately five different configuration files

[RFC] New parser framework for testing

2021-11-17 Thread Dominik Vogt
'k, the patched code didn't immediately crash, so here it is (two patches). Please test. What this is about: > The whole point in the completed part of the work was to make the > command line parser pluggable. As far as I remember, that part > was done, but needed more testing by users. Now