Re: [bug] Style PositionPlacement Center confused in multi monitor setup

2021-12-16 Thread Dominik Vogt
On Fri, Dec 17, 2021 at 01:00:53AM +, Hegel3DReloaded wrote: > On Friday, December 17th, 2021 at 1:38 AM, Dominik Vogt > wrote: > > > Should be fixed now. > > > > However, I find it really annoying that screens now have to be > > specified by name. >

Re: [bug] Style PositionPlacement Center confused in multi monitor setup

2021-12-16 Thread Dominik Vogt
On Fri, Dec 17, 2021 at 12:42:25AM +, Hegel3DReloaded wrote: > On Friday, December 17th, 2021 at 1:18 AM, Dominik Vogt > wrote: > > > When __pl_position_get_pos_simple() enconters a "center" argument > > it replaces it with DEFAULT_PLACEMENT_POS_CENTER_STRING

Re: [bug] Style PositionPlacement Center confused in multi monitor setup

2021-12-16 Thread Dominik Vogt
On Fri, Dec 17, 2021 at 12:13:42AM +, Hegel3DReloaded wrote: > On Friday, December 17th, 2021 at 12:18 AM, Dominik Vogt > wrote: > > On Thu, Dec 16, 2021 at 07:18:23PM +, Hegel3DReloaded wrote: > > >> xrandr --output Virtual-1 --mode 1400x1050 --primary --outpu

Re: [bug] Style PositionPlacement Center confused in multi monitor setup

2021-12-16 Thread Dominik Vogt
On Fri, Dec 17, 2021 at 01:18:17AM +0100, Dominik Vogt wrote: > On Thu, Dec 16, 2021 at 04:23:35PM +, Hegel3DReloaded wrote: > > I have opened an issue about PositionPlacement Center style: after > > the recent changes, in multi monitor mode, this centers window > &g

Re: [bug] Style PositionPlacement Center confused in multi monitor setup

2021-12-16 Thread Dominik Vogt
but that ignores the window's screen if specified. Also, some places of the code expect screens specified as "@g", " @c", "@p" while others use "g", "c" and "p". Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: [bug] Style PositionPlacement Center confused in multi monitor setup

2021-12-16 Thread Dominik Vogt
On Thu, Dec 16, 2021 at 07:18:23PM +, Hegel3DReloaded wrote: > xrandr --output Virtual-1 --mode 1400x1050 --primary --output Virtual-2 > --mode 1400x1050 --right-of Virtual-1 And how do I get these virtual screens? Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: [bug] Style PositionPlacement Center confused in multi monitor setup

2021-12-16 Thread Dominik Vogt
t fvwm3 release, this was not the case. Using dv/pager-noaspect where > the current > issues have been resolved couple days ago. It is repeatable on the current > master. You forgot instructions to reproduce. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-13 Thread Dominik Vogt
is ignoring Style for panel: > > PositionPlacement $[infostore.frontpanel.pos.placement] > > ... where infostore.frontpanel.pos.placement is "screen c 50-50w -0p ewmhiwa" Oh, I had noticed that but thought it was something to fix in the move_loop rewrite. It's fixed now. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-13 Thread Dominik Vogt
On Mon, Dec 13, 2021 at 07:40:06AM +, Hegel3DReloaded wrote: > On Monday, December 13th, 2021 at 2:14 AM, Dominik Vogt > wrote: > > On Mon, Dec 13, 2021 at 12:22:47AM +, Hegel3DReloaded wrote: > > > > Is this has something to do with intensive work you and Thoma

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-12 Thread Dominik Vogt
On Mon, Dec 13, 2021 at 12:32:53AM +, Hegel3DReloaded wrote: > On Monday, December 13th, 2021 at 1:18 AM, Dominik Vogt > wrote: > > On Mon, Dec 13, 2021 at 12:12:30AM +, Hegel3DReloaded wrote: > > > > "Move +32768p +32768p", > > > Side note: Th

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-12 Thread Dominik Vogt
> > moment we have a myriad of places where parsing is done, and its > > very tedious to even execute all code paths. > > Is this has something to do with intensive work you and Thomas did > couple weeks ago with new parser? Yes, I fixed a leak at the cost of introducing a crash. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-12 Thread Dominik Vogt
On Mon, Dec 13, 2021 at 12:12:30AM +, Hegel3DReloaded wrote: > On Monday, December 13th, 2021 at 12:46 AM, Hegel3DReloaded > wrote: > > On Sunday, December 12th, 2021 at 12:40 PM, Dominik Vogt > > dominik.v...@gmx.de wrote: > > > > The dv/pager-noaspect should

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-12 Thread Dominik Vogt
On Sun, Dec 12, 2021 at 11:46:05PM +, Hegel3DReloaded wrote: > On Sunday, December 12th, 2021 at 12:40 PM, Dominik Vogt > wrote: > > > On Sat, Dec 04, 2021 at 02:04:48PM +, Hegel3DReloaded wrote: > > >> Sounds ok. Which branch should I checkout to test this?

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-12 Thread Dominik Vogt
On Sat, Dec 04, 2021 at 02:04:48PM +, Hegel3DReloaded wrote: > On Sat, Dec 04, 2021 at 02:13:06PM +0100, Dominik Vogt wrote: > >> On Sat, Dec 04, 2021 at 02:03:46PM +0100, Dominik Vogt wrote: > > >> Maybe the scaling argument can be set to "auto" or somet

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-04 Thread Dominik Vogt
esizing the window when the desktop layout is changed, but it doesn't work yet. The resize_pager_window() call from list_new_page() doesn't work. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-04 Thread Dominik Vogt
On Sat, Dec 04, 2021 at 02:13:06PM +0100, Dominik Vogt wrote: > On Sat, Dec 04, 2021 at 02:03:46PM +0100, Dominik Vogt wrote: > > Maybe the scaling argument can be set to "auto" or something to > > keep the desktopscale within reasonable limits? (The example with >

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-04 Thread Dominik Vogt
On Sat, Dec 04, 2021 at 02:03:46PM +0100, Dominik Vogt wrote: > Maybe the scaling argument can be set to "auto" or something to > keep the desktopscale within reasonable limits? (The example with > desktopsize 50x1 earlkier in the discussion showed that the pager > c

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-04 Thread Dominik Vogt
On Sat, Dec 04, 2021 at 11:14:09AM +, Hegel3DReloaded wrote: > On Saturday, December 4th, 2021 at 11:39 AM, Dominik Vogt > wrote: > > > Okay, that is a real problem. The pager definitely needs to react > > to changes of the desktop layout, be it by attaching or detachin

Re: Rename back to fvwm.

2021-12-04 Thread Dominik Vogt
On Sat, Dec 04, 2021 at 10:24:23AM +, Hegel3DReloaded wrote: > On Saturday, December 4th, 2021 at 11:00 AM, Dominik Vogt > wrote: > > > Fvwm is the only project I'm aware of that changes its name with > > each major version. Let's _please_ go back to "fvw

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-04 Thread Dominik Vogt
iao Dominik ^_^ ^_^ -- Dominik Vogt

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-04 Thread Dominik Vogt
use the default size. (a) and (b) are real bugs that break my config. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Rename back to fvwm.

2021-12-04 Thread Dominik Vogt
ancient times. The same thing will happen again. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: Snap rewrite #2

2021-12-02 Thread Dominik Vogt
On Thu, Dec 02, 2021 at 11:25:07AM -0700, Jaimos Skriletz wrote: > On Thu, Dec 2, 2021 at 10:46 AM Dominik Vogt wrote: > > > > This is about an accident during elastic paging development, but > > it feels "good" to me. I've secretly always hated the "sna

Snap rewrite #2

2021-12-02 Thread Dominik Vogt
ntrol during mouse movement. With Shift the window moves much faster (factor 8) and with Conrol slower (factor 0.5). Now that the fixed offset between pointer and window position doesn't exist anymore, it's easy to do things like this. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-11-30 Thread Dominik Vogt
is that; someone thinks the current size is too small and wants to make it 50% bigger? Or the pager is in the way, and instead of closing, lowering, shading, iconifying or sending it to some container one makes the window smaller? What is so special about the pager that it Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-11-30 Thread Dominik Vogt
the window or not allows the most freedom for users. But why would anybody want that? Does anybody really use a standalone pager, and if so, ever resizes it? Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: [RFC] Re: Idea: "elastic" move

2021-11-29 Thread Dominik Vogt
On Mon, Nov 29, 2021 at 11:04:04PM +0100, Dominik Vogt wrote: > On Sun, Nov 21, 2021 at 03:29:29PM +0100, Dominik Vogt wrote: > > 1. When an interactive move starts: > > > >... > > - Warp the pointer to the middle of the screen. There it can > >

Re: [PATCH] Re: Crashes with monitor_resolve_name

2021-11-28 Thread Dominik Vogt
Updated patch in dv/monitor-parsing-fix. Doesn't take care of the NULL m->Desktops crash. Don't know how to reproduce. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-11-27 Thread Dominik Vogt
On Sat, Nov 27, 2021 at 02:44:07PM -0700, Jaimos Skriletz wrote: > On Sat, Nov 27, 2021 at 1:59 PM Dominik Vogt wrote: > > > > From commit 601c5c294a6a48fd402fbfca02b62142796167eb > > > > >* Improved use of sizehints to set both minimum window size, and to >

FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-11-27 Thread Dominik Vogt
r manually, and insde FvwmButtons it's really harmful. Can I remove this please? (See attached patch.) Ciao Dominik ^_^ ^_^ -- Dominik Vogt From 72857bb298ac74707efbdd372fc83943218a3219 Mon Sep 17 00:00:00 2001 From: Dominik Vogt Date: Sat, 27 Nov 2021 21:57:29 +0100 Subject: [PATCH] Remove as

Re: [PATCH] Re: Crashes with monitor_resolve_name

2021-11-27 Thread Dominik Vogt
On Sat, Nov 27, 2021 at 08:30:52PM +0100, Dominik Vogt wrote: > On Sat, Nov 27, 2021 at 07:02:29PM +0100, Dominik Vogt wrote: > > There are some NULL pointer crashes and bugs telated to > > moitor_resove_ame(): > > Attempt to fix these, please proof read the patch.

[PATCH] Re: Crashes with monitor_resolve_name

2021-11-27 Thread Dominik Vogt
On Sat, Nov 27, 2021 at 07:02:29PM +0100, Dominik Vogt wrote: > There are some NULL pointer crashes and bugs telated to > moitor_resove_ame(): Attempt to fix these, please proof read the patch. * Parsing fixes. * monitor_resolve_name() does not crash if scr == NULL but returns

Crashes with monitor_resolve_name

2021-11-27 Thread Dominik Vogt
tor name is not documented in the man page). -- Are there other places with unusual monitor name parsing? Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: Flocale leak

2021-11-26 Thread Dominik Vogt
On Fri, Nov 26, 2021 at 01:03:40PM +0100, Dominik Vogt wrote: > Stuck with this one, ideas welcome: > > On Wed, Nov 24, 2021 at 03:22:54PM +0100, Dominik Vogt wrote: > > ==8482== 38 (16 direct, 22 indirect) bytes in 1 blocks are definitely lost > > in loss record

Re: Flocale leak

2021-11-26 Thread Dominik Vogt
Stuck with this one, ideas welcome: On Wed, Nov 24, 2021 at 03:22:54PM +0100, Dominik Vogt wrote: > ==8482== 38 (16 direct, 22 indirect) bytes in 1 blocks are definitely lost in > loss record 184 of 536 > ==8482==at 0x48386AF: malloc (in > /usr/lib/x86_64-linux-

Window title leak

2021-11-25 Thread Dominik Vogt
(or whatever) * Open FvwmConsole and type style rxvt startsonpage 0 0 destroystyle rxvt (Any style option causes this.) * Quit fvwm So, a title is allocated and leaked. It must have to do with the style update procedure. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: UPDATE_FVWM_SCREEN macro?

2021-11-25 Thread Dominik Vogt
On Thu, Nov 25, 2021 at 10:56:19PM +, Thomas Adam wrote: > On Wed, Nov 24, 2021 at 03:43:47PM +0100, Dominik Vogt wrote: > > Does anybody know why this is a macro and not a function? > > (screen.h) > > Because when I wrote it, it wasn't as complex as it is now. >

Re: memleak in FScreenParseGeometryWithScreen

2021-11-25 Thread Dominik Vogt
On Thu, Nov 25, 2021 at 11:04:25PM +, Thomas Adam wrote: > On Wed, Nov 24, 2021 at 03:13:34PM +0100, Dominik Vogt wrote: > > From FScreen.c:FScreenParseGeometryWithScreen(): > > > > I can't fix this because I don't understand what the code does. > > I will fix thi

Transforming program names

2021-11-25 Thread Dominik Vogt
t that's a different topic.) It seems there is no need to change anything. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

UPDATE_FVWM_SCREEN macro?

2021-11-24 Thread Dominik Vogt
desk_add_fw((fw)); \ BroadcastConfig(M_CONFIGURE_WINDOW, (fw)); \ } while(0) The "do { ... } while (0)" was probably written by me. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Flocale leak

2021-11-24 Thread Dominik Vogt
98C: HandleMapRequestKeepRaised (events.c:3068) ==8482==by 0x136DC3: HandleMapRequest (events.c:3005) ==8482==by 0x138D50: dispatch_event (events.c:4186) ==8482==by 0x139B1C: HandleEvents (events.c:4232) ==8482==by 0x158DE5: main (fvwm3.c:2547) Ciao Dominik ^_^ ^_^ -- Dominik Vogt

memleak in FScreenParseGeometryWithScreen

2021-11-24 Thread Dominik Vogt
inside the function and can be fixed there. 2) LEAK B is in the callers. None of the callers I checked is aware that *screen_return has to be free()'d. 3) *screen_return contains the geometry portion of the string, but callers expect it to contain the screen portion. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: Commit 3f61e78 breaks fvwm3 -v

2021-11-24 Thread Dominik Vogt
e. It was really difficult to rewrite the logic, and the tests missed that case. Fixed on master. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Committed Xinerama cleanup and a restructuring patch

2021-11-23 Thread Dominik Vogt
Just committed 1) The Xinerama cleanup. 2) A big patch that makes move_resize.c and some related places in other files use the types position, size_rect and rectangle. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: [PATCH/RFC] Xinerama

2021-11-22 Thread Dominik Vogt
On Tue, Nov 23, 2021 at 01:44:52AM +0100, Dominik Vogt wrote: > Menu foomenu monitor c c > > Should place the menu in the middle of the current monitor. Or Menu foomenu c-20 c+30 should place it 20% of the monitor size left from the center and 30% below the center. Ciao

Re: [PATCH/RFC] Xinerama

2021-11-22 Thread Dominik Vogt
On Mon, Nov 22, 2021 at 11:52:38PM +, Thomas Adam wrote: > On Tue, Nov 23, 2021 at 12:31:15AM +0100, Dominik Vogt wrote: > > The old manmage said: > > > > XineramaRoot > > > > the root window of the whole Xinerama screen. Equivalent to > > "

NEW_PARSER.md

2021-11-22 Thread Dominik Vogt
The file now contains an overview of the current parser implementation. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: [PATCH/RFC] Xinerama

2021-11-22 Thread Dominik Vogt
On Mon, Nov 22, 2021 at 10:46:20PM +, Thomas Adam wrote: > On Mon, Nov 22, 2021 at 11:26:53PM +0100, Dominik Vogt wrote: > > On Sun, Nov 21, 2021 at 12:39:07AM +0100, Dominik Vogt wrote: > > > Patch attached. Can you please double check and fill in the gaps? > &

Re: [PATCH/RFC] Xinerama

2021-11-22 Thread Dominik Vogt
On Sun, Nov 21, 2021 at 12:39:07AM +0100, Dominik Vogt wrote: > Patch attached. Can you please double check and fill in the gaps? > (see comments belo). > > > > ./fvwm/menus.c: fXineramaRoot = False; > > > ./fvwm/menus.c: else if (StrEquals(tok,"xin

Re: [RFC] parser branches ready for commit

2021-11-22 Thread Dominik Vogt
On Mon, Nov 22, 2021 at 06:16:02PM +, Thomas Adam wrote: > On Mon, Nov 22, 2021 at 12:02:33AM +0100, Dominik Vogt wrote: > > Mostly done, except a couple of comments where there's still work > > to do. > > OK, I'll wait for those. These won't go away anytime soon. Fir

Re: Idea: "elastic" move

2021-11-21 Thread Dominik Vogt
On Sun, Nov 21, 2021 at 03:29:29PM +0100, Dominik Vogt wrote: > - If the viewport jumps use some kind of smooth animation. > This may be especially important if the viewport snaps to a > full page when the move ends. Tried this with the attached patch. It's n

Re: Snapping issue

2021-11-21 Thread Dominik Vogt
On Sun, Nov 21, 2021 at 02:09:53AM -0700, Jaimos Skriletz wrote: > On Sat, Nov 20, 2021 at 5:22 PM Dominik Vogt wrote: > > 2) Please break up the calculations in DoSnapGrid into multiple > >lines unsing temp variable. It's too hard to read = hard to > >maint

Re: Snapping issue

2021-11-21 Thread Dominik Vogt
On Sun, Nov 21, 2021 at 02:09:53AM -0700, Jaimos Skriletz wrote: > On Sat, Nov 20, 2021 at 5:22 PM Dominik Vogt wrote: > > > > > > 1) Can we safely assume that the "bool" C type is available in > >every relevant compiler? > > The bool type is used el

Re: Idea: "elastic" move

2021-11-21 Thread Dominik Vogt
the original "P" in the sketch. Thus it can continue moving in all directions. Of course, the window does not follow the warp. The (P)ointer to (W)indow offset is internally adjusted to a new value. Your other comments make sense. There are no answers at the moment. First we need to play with it and see how it feels. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: [RFC] parser branches ready for commit

2021-11-21 Thread Dominik Vogt
On Sun, Nov 21, 2021 at 09:23:20PM +, Thomas Adam wrote: > On Sun, Nov 21, 2021 at 02:38:09PM +0100, Dominik Vogt wrote: > > The parser branch is a ready as it will be without people testing > > it more. The upstream branch dv/master hat the latest, merged > > together p

Re: [RFC] parser branches ready for commit

2021-11-21 Thread Dominik Vogt
On Sun, Nov 21, 2021 at 09:23:20PM +, Thomas Adam wrote: > On Sun, Nov 21, 2021 at 02:38:09PM +0100, Dominik Vogt wrote: > > The parser branch is a ready as it will be without people testing > > it more. The upstream branch dv/master hat the latest, merged > > together p

Idea: "elastic" move

2021-11-21 Thread Dominik Vogt
- If elastic paging works nicely, it should become the default behaviour. To disable it, you have to turn it off explicitly - an empty config still has it on. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

[RFC] parser branches ready for commit

2021-11-21 Thread Dominik Vogt
e disabled by debug defines in functions.c and cmdparser_old.c.) Ciao Dominik ^_^ ^_^ -- Dominik Vogt

dv Branches

2021-11-21 Thread Dominik Vogt
^_^ ^_^ -- Dominik Vogt

Re: [PATCH] (6) Man page changes -- second attempt

2021-11-21 Thread Dominik Vogt
On Sat, Nov 20, 2021 at 02:37:29PM -0700, Jaimos Skriletz wrote: > Lintian found a few minor typos in the manual pages. Patch attached. Thanks; applied them to my working branch. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: [PATCH - parser] (4) updates

2021-11-21 Thread Dominik Vogt
On Sat, Nov 20, 2021 at 10:58:54PM +, Thomas Adam wrote: > On Sat, Nov 20, 2021 at 03:16:02PM +0100, Dominik Vogt wrote: > > Look at commit ba9f161998f7da942996bcf0d3f96baa8b249070. You > > added new-parser.md, but also committed a complete reindentation > > of functi

Re: Snapping issue

2021-11-20 Thread Dominik Vogt
Dominik ^_^ ^_^ -- Dominik Vogt

Re: Snapping issue

2021-11-20 Thread Dominik Vogt
On Sat, Nov 20, 2021 at 04:17:41PM -0700, Jaimos Skriletz wrote: > On Sun, Nov 14, 2021 at 10:57 AM Dominik Vogt wrote: > > > > The snapping code is really an unmaintainable mess. Some thoughts > > on how it might be rewritten: > > > > Here are some though

git access

2021-11-20 Thread Dominik Vogt
be happy with my own branches without committing to master myself.) Ciao Dominik ^_^ ^_^ -- Dominik Vogt

[PATCH/RFC] Xinerama

2021-11-20 Thread Dominik Vogt
On Sat, Nov 20, 2021 at 10:24:46PM +, Thomas Adam wrote: > On Sat, Nov 20, 2021 at 03:54:10PM +0100, Dominik Vogt wrote: > > On Sat, Nov 20, 2021 at 02:15:58PM +, Thomas Adam wrote: > > > On Sat, Nov 20, 2021, 14:13 Dominik Vogt wrote: > > > > > > >

fork-bomb like functions

2021-11-20 Thread Dominik Vogt
; maybe limit that to 1000. -- Another problem: It's possible to add items to functions that are currently in use. addtofunc foo i bar addtofunc bar i addtofunc foo i bar # hangs: foo Not sure if we should just forbid to add items to running functions. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

[PATCH] (9) master and new parser patches

2021-11-20 Thread Dominik Vogt
command line option. I'm not sure if we should really delete this. Should probably rather be a "bugopts" option. parser branch on top of master: 0007-0009: Current cleaned up version of the parser parches Ciao Dominik ^_^ ^_^ -- Dominik

Re: Xinerama

2021-11-20 Thread Dominik Vogt
On Sat, Nov 20, 2021 at 03:54:10PM +0100, Dominik Vogt wrote: > On Sat, Nov 20, 2021 at 02:15:58PM +, Thomas Adam wrote: > > On Sat, Nov 20, 2021, 14:13 Dominik Vogt wrote: > > > > > Is Xinerama still useful for anything or can we remove it? > > > >

Re: Xinerama

2021-11-20 Thread Dominik Vogt
On Sat, Nov 20, 2021 at 02:15:58PM +, Thomas Adam wrote: > On Sat, Nov 20, 2021, 14:13 Dominik Vogt wrote: > > > Is Xinerama still useful for anything or can we remove it? > > > It has already been removed. Where are you seeing references to it? Everywhere.

Re: [PATCH - parser] (4) updates

2021-11-20 Thread Dominik Vogt
On Sat, Nov 20, 2021 at 11:17:52AM +, Thomas Adam wrote: > On Sat, Nov 20, 2021 at 10:51:51AM +0100, Dominik Vogt wrote: > > It works on my local branch but not the one in Git because of the > > reindentation commit. Can we please not reindent patches that are > > st

Xinerama

2021-11-20 Thread Dominik Vogt
Is Xinerama still useful for anything or can we remove it? Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: [PATCH - parser] (4) updates

2021-11-20 Thread Dominik Vogt
ncludes it before defining that or after. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: [PATCH - parser] (4) updates

2021-11-20 Thread Dominik Vogt
patch you also committed changes to functions.c that cause this problem. * Reindented whole file. * Reordered include files, which causes the error. Patch attached to back out the functions.c changes. Ciao Dominik ^_^ ^_^ -- Dominik Vogt From e599b80d529bd75892e04d47f32558ac17018ec1 Mon Sep 1

[PATCH] (6) Various small changes

2021-11-19 Thread Dominik Vogt
a memory leak. Ciao Dominik ^_^ ^_^ -- Dominik Vogt From c81eb2cf991a5af850850ecf87d38bf6851bd788 Mon Sep 17 00:00:00 2001 From: Dominik Vogt Date: Sat, 20 Nov 2021 00:31:31 +0100 Subject: [PATCH 1/6] Fix uninitialised varibles. --- libs/FScreen.c | 24 1 file ch

Re: [PATCH - parser] (4) updates

2021-11-19 Thread Dominik Vogt
On Fri, Nov 19, 2021 at 03:15:43PM +, Thomas Adam wrote: > On Fri, Nov 19, 2021 at 03:09:35PM +, Thomas Adam wrote: > > On Fri, Nov 19, 2021 at 02:54:53AM +0100, Dominik Vogt wrote: > > > A couple of patches for the parser branch: > > > > > > 0001: So

Re: [RFC] Fake a global monitor when RandR is not available.

2021-11-19 Thread Dominik Vogt
On Fri, Nov 19, 2021 at 01:48:51PM +, Thomas Adam wrote: > On Fri, Nov 19, 2021 at 02:53:32AM +0100, Dominik Vogt wrote: > > On Fri, Nov 19, 2021 at 02:14:57AM +0100, Dominik Vogt wrote: > > > For debugging I need to run another fvwm in xnest, but that > >

[PATCH - parser] (4) updates

2021-11-18 Thread Dominik Vogt
A couple of patches for the parser branch: 0001: Some cleanup. 0002: The randr simulation patch from the other message. 0003: Fix function depth handling and an uninitialised function argument. (I.e. a crash) Ciao Dominik ^_^ ^_^ -- Dominik Vogt From

Re: [RFC] Fake a global monitor when RandR is not available.

2021-11-18 Thread Dominik Vogt
On Fri, Nov 19, 2021 at 02:14:57AM +0100, Dominik Vogt wrote: > For debugging I need to run another fvwm in xnest, but that > doesn't support randr. > > The attached patch mocks up a global monitor to use if init fails. > It works at the first glance, but the patch is not very

[RFC] Fake a global monitor when RandR is not available.

2021-11-18 Thread Dominik Vogt
For debugging I need to run another fvwm in xnest, but that doesn't support randr. The attached patch mocks up a global monitor to use if init fails. It works at the first glance, but the patch is not very clean. Please comment. Ciao Dominik ^_^ ^_^ -- Dominik Vogt From

Re: [RFC] New parser framework for testing

2021-11-18 Thread Dominik Vogt
On Thu, Nov 18, 2021 at 03:31:46PM +, Thomas Adam wrote: > On Thu, Nov 18, 2021 at 02:19:11PM +0100, Dominik Vogt wrote: > > Most of the tests were meant to catch parsing bugs, leaks and > > crashes. A mor organised approach in the future would be good. > > Maybe it w

Re: [RFC] New parser framework for testing

2021-11-18 Thread Dominik Vogt
We need to put the results and suggestions of this discusstion in a file. > On Thu, Nov 18, 2021 at 12:31:09AM +0100, Dominik Vogt wrote: > > Anyway, we need > > infrastructure for automated testing. > > We used to have something like that but it fell into bitrot and I r

Re: [RFC] New parser framework for testing

2021-11-17 Thread Dominik Vogt
On Wed, Nov 17, 2021 at 10:40:56PM +, Thomas Adam wrote: > On Wed, Nov 17, 2021 at 08:40:09PM +0100, Dominik Vogt wrote: > > 'k, the patched code didn't immediately crash, so here it is (two > > patches). Please test. > > I've applied those two patches on a branch called

[RFC] New parser framework for testing

2021-11-17 Thread Dominik Vogt
nctions.c may as well. * Same in CMD_... functions and various parts of fvwm that call execute_function to do their work. * Debug code needt to be removed later. Ciao Dominik ^_^ ^_^ -- Dominik Vogt From eddb78f108c0284fd7c670dd4d08811de59d2820 Mon Sep 17 00:00:00 2001 From: Dominik Vogt Date

Re: [PATCH] (6) Man page changes -- second attempt

2021-11-17 Thread Dominik Vogt
On Wed, Nov 17, 2021 at 04:40:55PM +, Thomas Adam wrote: > On Wed, Nov 17, 2021 at 02:35:32PM +0100, Dominik Vogt wrote: > > On Tue, Nov 16, 2021 at 01:36:53AM +0100, Dominik Vogt wrote: > > > This is the full set of patches for splitting the man page, to be >

Re: parser branch

2021-11-17 Thread Dominik Vogt
On Wed, Nov 17, 2021 at 06:20:05PM +, Thomas Adam wrote: > On Wed, Nov 17, 2021 at 01:47:05PM +, Thomas Adam wrote: > > On Wed, Nov 17, 2021 at 02:38:19PM +0100, Dominik Vogt wrote: > > > I'd like to finish the parser work started in 2014. Is the old > > > branc

Re: [PATCH] (6) Man page changes -- second attempt

2021-11-17 Thread Dominik Vogt
On Tue, Nov 16, 2021 at 01:36:53AM +0100, Dominik Vogt wrote: > This is the full set of patches for splitting the man page, to be > applied to master. Second attempt. The style docs are not moved aound in the man page. The .section files have been renamed to .ad because asciidoc only eva

parser branch

2021-11-17 Thread Dominik Vogt
I'd like to finish the parser work started in 2014. Is the old branch still available somewhere? Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: [PATCH] (5) Man page changes

2021-11-17 Thread Dominik Vogt
On Wed, Nov 17, 2021 at 05:59:49AM +, Thomas Adam wrote: > On Tue, Nov 16, 2021 at 01:36:53AM +0100, Dominik Vogt wrote: > > This is the full set of patches for splitting the man page, to be > > applied to master. > > > > 1, 2 and 4 are unrelated cleanups. >

Re: [PATCH] (2) fvwm3styles.1.

2021-11-16 Thread Dominik Vogt
On Tue, Nov 16, 2021 at 08:28:12AM +, Thomas Adam wrote: > On Tue, Nov 16, 2021 at 01:18:24AM +0100, Dominik Vogt wrote: > > Two more patches for the man page branch, this time taking care of > > the style commands. > > > > 0001: General cleanup. > > 0002: Spl

Re: [PATCH] (2) Split off menu documentation to fvwm3menus.1.

2021-11-15 Thread Dominik Vogt
man page restructuring done. In any case, it's a good if another person looks at patches, not just me. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: [PATCH] (2) Split off menu documentation to fvwm3menus.1.

2021-11-15 Thread Dominik Vogt
On Tue, Nov 16, 2021 at 12:26:45AM +, Thomas Adam wrote: > On Tue, Nov 16, 2021 at 01:13:24AM +0100, Dominik Vogt wrote: > > On Tue, Nov 16, 2021 at 12:09:41AM +, Thomas Adam wrote: > > > On Mon, Nov 15, 2021 at 11:57:54PM +0100, Dominik Vogt wrote: > > > >

Re: [PATCH] (2) fvwm3styles.1.

2021-11-15 Thread Dominik Vogt
On Tue, Nov 16, 2021 at 01:18:24AM +0100, Dominik Vogt wrote: > Off-topic: Can we remove the "globalopts" command description? And while we're at it, remove its implementation as well? At the moment, GlobalOpts: (1) Emits a deprecation warning ans prints the command that has t

Re: [PATCH] (2) Split off menu documentation to fvwm3menus.1.

2021-11-15 Thread Dominik Vogt
On Tue, Nov 16, 2021 at 12:09:41AM +, Thomas Adam wrote: > On Mon, Nov 15, 2021 at 11:57:54PM +0100, Dominik Vogt wrote: > > On Mon, Nov 15, 2021 at 11:38:36PM +0100, Dominik Vogt wrote: > > > 0001: Some man page cleanup. > > > 0002: New man page fvwm3menus.1 > &

Re: [PATCH] (2) Split off menu documentation to fvwm3menus.1.

2021-11-15 Thread Dominik Vogt
On Mon, Nov 15, 2021 at 11:38:36PM +0100, Dominik Vogt wrote: > 0001: Some man page cleanup. > 0002: New man page fvwm3menus.1 0003: Fix list formatting (attached). Ciao Dominik ^_^ ^_^ -- Dominik Vogt From c23033b58a26b53da0a743c26d8f017719a1d5ac Mon Sep 17 00:00:00 2001 From: Domini

[PATCH] (2) Split off menu documentation to fvwm3menus.1.

2021-11-15 Thread Dominik Vogt
ext goes back to the indentation of the section heading, or ig "+" is used it's indented like the list text. The workaround is to start a new list with smaller indentation with --snip-- .:: --snip-- But that creates an additional "." heading. See line 2904. Ciao Dominik ^_^

Re: [RFC] Splitting the man page

2021-11-15 Thread Dominik Vogt
On Mon, Nov 15, 2021 at 08:53:48PM +, Thomas Adam wrote: > On Mon, Nov 15, 2021 at 09:00:43PM +0100, Dominik Vogt wrote: > > Now, about the contents of the new man pages: Splitting has not > > bought us that much yet. 75% of the contents are now in the > > commands man

[PATCH] Fix resize calculations.

2021-11-15 Thread Dominik Vogt
The earlier patch broke resize calculations by making windows too big. This patch fixes this. Ciao Dominik ^_^ ^_^ -- Dominik Vogt From f95313370fd977f95a02148cb0ab75d4230e86b7 Mon Sep 17 00:00:00 2001 From: Dominik Vogt Date: Mon, 15 Nov 2021 21:35:53 +0100 Subject: [PATCH] Fix resize

Re: [RFC] Splitting the man page

2021-11-15 Thread Dominik Vogt
On Mon, Nov 15, 2021 at 06:42:20PM +, Thomas Adam wrote: > On Mon, Nov 15, 2021 at 07:04:57PM +0100, Dominik Vogt wrote: > > Guessed so. I believe automake + autoconf should support that > > automatically in the generated rules, but it needs to be tested. > > Anybo

[RFC] Splitting the man page

2021-11-15 Thread Dominik Vogt
install" and "make uninstall" work fine, but I haven't tried to build and test a distro from that. Comments? Ciao Dominik ^_^ ^_^ -- Dominik Vogt From 3994b8a87ac7d2637215dd514d21634e490f0a29 Mon Sep 17 00:00:00 2001 From: Dominik Vogt Date: Mon, 15 Nov 2021 16:52:38 +

Re: [PATCH] (7) Miscellaneous cleanup

2021-11-15 Thread Dominik Vogt
On Mon, Nov 15, 2021 at 11:45:58AM +, Thomas Adam wrote: > On Mon, Nov 15, 2021 at 12:11:51PM +0100, Dominik Vogt wrote: > > Thanks. Will apply. With respect this this patch: > > > 0007: Remove the "MWM COMPATIBILITY" section. Nobody cares anymore. > > P

  1   2   3   4   5   6   7   8   9   10   >