Commit 3f61e78 breaks fvwm3 -v

2021-11-24 Thread Jaimos Skriletz
Hello, On my system the following commit makes it so fvwm3 -v fails to start on my system. But fvwm3 works just fine. I tracked the issue to this commit, as this is the first commit in which fvwm3 -v no longer works when running startx using a ~/.xsession file to launch fvwm3.

memleak in FScreenParseGeometryWithScreen

2021-11-24 Thread Dominik Vogt
From FScreen.c:FScreenParseGeometryWithScreen(): 943 copy = fxstrdup(parsestring); 944 copy = strsep(, "@"); 945 946 *screen_return = fxstrdup(parsestring); 947 geom_str = strsep(, "@"); 948 copy = geom_str; I can't fix this because I don't understand what the code does.

Re: Commit 3f61e78 breaks fvwm3 -v

2021-11-24 Thread Dominik Vogt
On Wed, Nov 24, 2021 at 03:49:19AM -0700, Jaimos Skriletz wrote: > Hello, > > On my system the following commit makes it so fvwm3 -v fails to start > on my system. But fvwm3 works just fine. I tracked the issue to this > commit, as this is the first commit in which fvwm3 -v no longer works > when

Flocale leak

2021-11-24 Thread Dominik Vogt
I can't figure out when this memory is leaked: ==8482== 21 bytes in 1 blocks are definitely lost in loss record 155 of 536 ==8482==at 0x483877F: malloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so) ==8482==by 0x5FE76A7: __vasprintf_internal (vasprintf.c:71)

Re: Commit 3f61e78 breaks fvwm3 -v

2021-11-24 Thread Jaimos Skriletz
On Wed, Nov 24, 2021 at 5:41 AM Dominik Vogt wrote: > > Fixed on master. > Thanks. No longer crashes here. jaimos

UPDATE_FVWM_SCREEN macro?

2021-11-24 Thread Dominik Vogt
Does anybody know why this is a macro and not a function? (screen.h) #define UPDATE_FVWM_SCREEN(fw) \ do { \ rectangle g;