Re: FvwmPager vanishes when moving windows
On Tue, Feb 5, 2013 at 7:36 AM, Omari Norman wrote: > Which works just fine, but the manpage says I can do something that > doesn't work. This patch makes the manpage conform to current > behavior. Thanks! --Omari Bad patch, sorry! My webmail will mangle it. Here as an attachment (don't know if the list will let it through.) fvwm-pager-manpage.patch Description: Binary data
Re: FvwmPager vanishes when moving windows
On Tue, Feb 5, 2013 at 4:35 AM, Thomas Adam wrote: >> I also notice that for me at least the pager does not seem to behave >> as documented in the man page, which says that if I omit both desk >> numbers, the current desk is used instead. So I would think this means >> that if I do >> >> GotoDesk 0 1 >> Module FvwmPager > > FvwmPager * Which works just fine, but the manpage says I can do something that doesn't work. This patch makes the manpage conform to current behavior. Thanks! --Omari diff -aur fvwm-2.6.5-orig/modules/FvwmPager/FvwmPager.1.in fvwm-2.6.5/modules/FvwmPager/FvwmPager.1.in --- fvwm-2.6.5-orig/modules/FvwmPager/FvwmPager.1.in2012-02-20 07:27:34.0 -0500 +++ fvwm-2.6.5/modules/FvwmPager/FvwmPager.1.in 2013-02-05 07:27:38.490354119 -0500 @@ -5,17 +5,18 @@ .SH NAME FvwmPager \- the Fvwm Pager module .SH SYNOPSIS -\fBFvwmPager\fP [ \fI-transient\fP ] [ \fIname\fP ] [ \fIfirst desk\fP [ \fIlast desk\fP ] ] +\fBFvwmPager\fP [ \fI-transient\fP ] [ \fIname\fP ] * + +\fBFvwmPager\fP [ \fI-transient\fP ] [ \fIname\fP ] \fIfirst_desk\fP [ \fIlast_desk\fP ] + FvwmPager is spawned by fvwm, so no command line invocation will work. -All desks with desk numbers between \fIfirst desk\fP and \fIlast -desk\fP are displayed. If \fIlast desk\fP is omitted only the -\fIfirst desk\fP is shown. If both desk numbers are omitted, the -current desk is used instead. If you use an asterisk '*' in place -of \fIfirst desk\fP the pager will always show the current -desktop, even when you switch desks. +An asterisk '*' will always show the current desktop, even when you +switch desks. Alternatively, all desks with desk numbers between +\fIfirst desk\fP and \fIlast desk\fP are displayed. If \fIlast desk\fP +is omitted only the \fIfirst desk\fP is shown. -Example lines to put in your .fvwm2rc: +Example lines to put in your \fI$HOME/.fvwm/config\fP: .nf .sp
Re: FvwmPager vanishes when moving windows
On 5 February 2013 01:52, Omari Norman wrote: > On Sun, Feb 3, 2013 at 9:24 AM, Thomas Adam wrote: >>> *CrashyConfig: Balloons >>> >>> AddToFunc InitFunction >>> + I GotoDesk 0 1 >>> + I Module FvwmPager 1 1 >>> + I Module FvwmPager CrashyConfig 1 1 >>> + I Exec exec xterm >> >> Does this fix it? >> + >> + if (i < 0) >> + return; >> + > > That does fix it, thanks! Fixed in CVS. > I also notice that for me at least the pager does not seem to behave > as documented in the man page, which says that if I omit both desk > numbers, the current desk is used instead. So I would think this means > that if I do > > GotoDesk 0 1 > Module FvwmPager FvwmPager * -- Thomas Adam
Re: FvwmPager vanishes when moving windows
On Sun, Feb 3, 2013 at 9:24 AM, Thomas Adam wrote: >> *CrashyConfig: Balloons >> >> AddToFunc InitFunction >> + I GotoDesk 0 1 >> + I Module FvwmPager 1 1 >> + I Module FvwmPager CrashyConfig 1 1 >> + I Exec exec xterm > > Does this fix it? > + > + if (i < 0) > + return; > + That does fix it, thanks! I also notice that for me at least the pager does not seem to behave as documented in the man page, which says that if I omit both desk numbers, the current desk is used instead. So I would think this means that if I do GotoDesk 0 1 Module FvwmPager then I would get an FvwmPager showing Desk 1, but instead I get a pager that says "Desk 1" in the title bar while actually showing me "Desk 0" in the pager (which is labeled appropriately in the pager.) Is that what's expected? Thanks. --Omari
Re: FvwmPager vanishes when moving windows
On Sun, Feb 03, 2013 at 01:12:37AM -0500, Omari Norman wrote:
> *CrashyConfig: Balloons
>
> AddToFunc InitFunction
> + I GotoDesk 0 1
> + I Module FvwmPager 1 1
> + I Module FvwmPager CrashyConfig 1 1
> + I Exec exec xterm
Does this fix it?
diff --git a/modules/FvwmPager/x_pager.c b/modules/FvwmPager/x_pager.c
index a0c3a6f..a45a959 100644
--- a/modules/FvwmPager/x_pager.c
+++ b/modules/FvwmPager/x_pager.c
@@ -3202,6 +3202,10 @@ void MapBalloonWindow(PagerWindow *t, Bool is_icon_view)
{
i = t->desk - desk1;
}
+
+ if (i < 0)
+ return;
+
Scr.balloon_desk = i;
/* get the label for this balloon */
if (Scr.balloon_label)
-- Thomas Adam
FvwmPager vanishes when moving windows
Hi, I have found that FvwmPager crashes and the window vanishes when 1) the pager is showing a desk other than Desk 0; 2) the configuration has the pager showing balloons; and 3) you then use button 2 on the mouse to move a window within the pager. For instance, try moving a window within the pager using mouse button 2 within both of these pagers. On my machine one pager (the one without the balloons) will vanish after doing the move; the other pager without the balloons will not vanish. --- *CrashyConfig: Balloons AddToFunc InitFunction + I GotoDesk 0 1 + I Module FvwmPager 1 1 + I Module FvwmPager CrashyConfig 1 1 + I Exec exec xterm --- Thanks for all your work on fvwm. Let me know if I can provide any other info or if this can't be replicated. This is fvwm 2.6.5 on Arch Linux. --Omari
