Re: FVWM Patch for Interaction problem with Java 7

[Schaaf, Jonathan P (GE Healthcare)]

 It's not enough to just comment this out for Java's case.  I might
consider a BugOpts though.
The patch has been updated to be a BugOpts.  See attached.

 I suspect the original comment was more for Tk's benefit -- can you
confirm that's still the case?
I assume that Tk refers to the widget set.  I wouldn't even know where
to start looking into that.  If you can give me a pointer I can explore
the topic a bit, but without some background it's hard to understand how
it relates.




java_fix.patch
Description: java_fix.patch

Re: FVWM Patch for Interaction problem with Java 7

[Thomas Adam]

On Mon, Apr 16, 2012 at 03:37:48PM -0400, Schaaf, Jonathan P (GE Healthcare) 
wrote:
 diff -urNp fvwm-2.6.4/doc/commands/BugOpts.xml 
 fvwm-2.6.4-modified/doc/commands/BugOpts.xml
 --- fvwm-2.6.4/doc/commands/BugOpts.xml   2009-12-31 11:35:47.0 
 -0600
 +++ fvwm-2.6.4-modified/doc/commands/BugOpts.xml  2012-04-16 
 14:19:41.543549878 -0500
 @@ -139,4 +139,12 @@ utf-8 fails due to characters which have
  the target charecter set. Some clients however neglect to set non utf-8
  properties correctly in which case this option may help./para
  
 +paraThe fvwmopt cmd=BugOpts opt=Java7FocusWorkaround/ option

I don't like the name, and thinking about it some more, I don't think a
bugopt is the right thing to do here either -- FPLenient should be implied
for this to work, so really I think:

 + if (mra-w_with_focus != None  !Scr.bo.do_java_focus_behavior)

diff --git a/fvwm/frame.c b/fvwm/frame.c
index 55922ce..e4aafab 100644
--- a/fvwm/frame.c
+++ b/fvwm/frame.c
@@ -1938,7 +1938,7 @@ void frame_free_move_resize_args(
}
update_absolute_geometry(fw);
frame_reparent_hide_windows(Scr.NoFocusWin);
-   if (mra-w_with_focus != None)
+   if (mra-w_with_focus != None  FP_IS_LENIENT(FW_FOCUS_POLICY(fw)))
{
/* domivogt (28-Dec-1999): For some reason the XMoveResize() on
 * the frame window removes the input focus from the client

What do you think?

-- Thomas Adam

-- 
Deep in my heart I wish I was wrong.  But deep in my heart I know I am
not. -- Morrissey (Girl Least Likely To -- off of Viva Hate.)