Re: Patch: HasTitle and HasBorders
On 18 Jan 2006 18:53:58 +, Thomas Adam wrote: I'd been meaning to send these in for a while, but University work always seems to get in the way. :) I've created two patches[1] --- very minor ones that add two new conditionals: HasTitle -- Checks to see whether a window has a titlebar or not. HasBorders -- Checks to see whether a window has a border or not. I am all for adding these conditions, but implementation is incorect. HasBorders can't work, since you do not use any window info for it. Hint: you may use has_no_borders window flag for this. Do you want to submit a correct patch (with all documentation too)? Regards, Mikhael.
Re: Patch: HasTitle and HasBorders
On Thu, Jan 19, 2006 at 12:57:18AM +, Mikhael Goikhman wrote: I am all for adding these conditions, but implementation is incorect . HasBorders can't work, since you do not use any window info for it . Hint: you may use has_no_borders window flag for this. Ah. But I did add a flag to fvwm.h for this: has_borders. I would have used has_no_borders, and I probably should. I'll change it, if you like? Do you want to submit a correct patch (with all documentation too)? OK. I'll do this in the morning, after I have slept. Thanks. -- Thomas Adam -- I'm brutal, honest, and afraid of you.
Re: Patch: HasTitle and HasBorders
On 19 Jan 2006 01:16:28 +, Thomas Adam wrote: On Thu, Jan 19, 2006 at 12:57:18AM +, Mikhael Goikhman wrote: I am all for adding these conditions, but implementation is incorect . HasBorders can't work, since you do not use any window info for it . Hint: you may use has_no_borders window flag for this. Ah. But I did add a flag to fvwm.h for this: has_borders. I would have used has_no_borders, and I probably should. I'll change it, if you like? You added a flag that noone sets (it is always zero). Another side effect after applying your patch is Move becomes Outline instead of Opaque after Restart --dont-preserve-state. Please test the patches thoroughly. Regards, Mikhael.
Re: Patch: HasTitle and HasBorders
On 19 Jan 2006 01:16:28 +, Thomas Adam wrote: OK. I'll do this in the morning, after I have slept. We are not really in hurry. In fact, I would feel more comfortably before applying any patch if its author tells that he runs fvwm with this patch applied for several days without problems and that he verified all new (and some old) functionality in variety of ways. Thanks for contributing. Regards, Mikhael.
