[RFC master] Add kvm machine version to hvparams

2013-01-07 Thread Dimitris Aragiorgis
Hello team, recently during a KVM upgrade we came across with the following scenario: A running drbd instance that was created with KVM 1.1 had to be migrated to a node with KVM 1.2 . Migration failed silently (info migrate monitor command returned successfully but -due to a kvm bug I suppose-

Re: [RFC master] Add kvm machine version to hvparams

2013-01-07 Thread Guido Trotter
Hi dimara, I agree about recording this and using the option: but are you sure this should be in hvparams? hvparams are meant for user-configurable options: this sounds more something like we should record under prefix/lib/ganeti/kvm-hypervisors/instance/... and use automatically. Any reason why

[RFC master] Re: Add kvm machine version to hvparams

2013-01-07 Thread Nicolas Sebrecht
The 07/01/13, Dimitris Aragiorgis wrote: Hello team, recently during a KVM upgrade we came across with the following scenario: A running drbd instance that was created with KVM 1.1 had to be migrated to a node with KVM 1.2 . Migration failed silently (info migrate monitor command returned

[RFC master] Re: Add kvm machine version to hvparams

2013-01-07 Thread Nicolas Sebrecht
The 07/01/13, Nicolas Sebrecht wrote: The 07/01/13, Dimitris Aragiorgis wrote: Hello team, recently during a KVM upgrade we came across with the following scenario: A running drbd instance that was created with KVM 1.1 had to be migrated to a node with KVM 1.2 . Migration failed

Re: [RFC master] Re: Add kvm machine version to hvparams

2013-01-07 Thread Vangelis Koukis
On Mon, Jan 07, 2013 at 01:57:12pm +0100, Nicolas Sebrecht wrote: The 07/01/13, Nicolas Sebrecht wrote: The 07/01/13, Dimitris Aragiorgis wrote: Hello team, recently during a KVM upgrade we came across with the following scenario: A running drbd instance that was created with

Re: [RFC master] Add kvm machine version to hvparams

2013-01-07 Thread Dimitris Aragiorgis
Hi Guido, * Guido Trotter ultrot...@google.com [2013-01-07 13:28:06 +0100]: Hi dimara, I agree about recording this and using the option: but are you sure this should be in hvparams? hvparams are meant for user-configurable options: this sounds more something like we should record under

Re: [RFC master] Add kvm machine version to hvparams

2013-01-07 Thread Guido Trotter
On Mon, Jan 7, 2013 at 3:09 PM, Dimitris Aragiorgis dim...@grnet.gr wrote: Hi Guido, * Guido Trotter ultrot...@google.com [2013-01-07 13:28:06 +0100]: Hi dimara, I agree about recording this and using the option: but are you sure this should be in hvparams? hvparams are meant for

[PATCH master] Makefile.am: Add missing space

2013-01-07 Thread Michael Hanselmann
Commit acaf3ca missed this space before a backslash. --- Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index ea69563..45260a1 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1274,7 +1274,7 @@ src/Ganeti/Version.hs:

Re: [PATCH master] Makefile.am: Add missing space

2013-01-07 Thread Guido Trotter
On Mon, Jan 7, 2013 at 3:14 PM, Michael Hanselmann han...@google.com wrote: Commit acaf3ca missed this space before a backslash. LGTM Thanks, Guido --- Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index ea69563..45260a1

[PATCH master] Add use_locking parameter to network query opcode

2013-01-07 Thread Michael Hanselmann
This was extracted from a patch by Dimitris Aragiorgis with the subject “Add locking to _NetworkQuery”. The rest of the patch did no longer apply and will require more work. --- lib/cmdlib.py |2 +- lib/opcodes.py |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git

Re: [PATCH master] Add use_locking parameter to network query opcode

2013-01-07 Thread Iustin Pop
On Mon, Jan 07, 2013 at 04:05:42PM +0100, Michael Hanselmann wrote: This was extracted from a patch by Dimitris Aragiorgis with the subject “Add locking to _NetworkQuery”. The rest of the patch did no longer apply and will require more work. --- lib/cmdlib.py |2 +- lib/opcodes.py |

Re: [RFC master] Re: Add kvm machine version to hvparams

2013-01-07 Thread Dimitris Aragiorgis
* Guido Trotter ultrot...@google.com [2013-01-07 15:09:37 +0100]: On Mon, Jan 7, 2013 at 2:21 PM, Vangelis Koukis vkou...@grnet.gr wrote: Hi Vangelis, On Mon, Jan 07, 2013 at 01:57:12pm +0100, Nicolas Sebrecht wrote: The 07/01/13, Nicolas Sebrecht wrote: The 07/01/13, Dimitris

Re: [PATCH master] Add use_locking parameter to network query opcode

2013-01-07 Thread Michael Hanselmann
2013/1/7 Iustin Pop iu...@k1024.org: This will likely require changes in the haskell code too, fyi (and unittests will tell you that). Interdiff: diff --git a/src/Ganeti/OpCodes.hs b/src/Ganeti/OpCodes.hs index 8285e93..ec9a34f 100644 --- a/src/Ganeti/OpCodes.hs +++ b/src/Ganeti/OpCodes.hs @@

Re: [PATCH master] Add use_locking parameter to network query opcode

2013-01-07 Thread Guido Trotter
On Mon, Jan 7, 2013 at 5:17 PM, Michael Hanselmann han...@google.com wrote: 2013/1/7 Iustin Pop iu...@k1024.org: This will likely require changes in the haskell code too, fyi (and unittests will tell you that). Interdiff: LGTM Thanks, Guido

Re: [PATCH master] Add locking to _NetworkQuery

2013-01-07 Thread Michael Hanselmann
2012/12/21 Dimitris Aragiorgis dim...@grnet.gr: Thanks a lot for clarifying. I am ok with that. But to be honest I am a bit confused with what is deprecated or not based on Iustin's comments. Commit 8d45912 now added the “use_locking” parameter to OpNetworkQuery. Could you please rebase your

[PATCH master] Add small webserver for development

2013-01-07 Thread Michael Hanselmann
When working on documentation it can be helpful to use a browser. In some environments it's not possible to access the files directly from a graphical browser. This trivial webserver exports all files in the current directory and unlike alternatives such as thttpd, doesn't check for world-readable

[PATCH master] man pages: Lowercase name for syntax highlighting

2013-01-07 Thread Michael Hanselmann
When the man pages' reST is built using Sphinx, “bash” must be used instead of “Bash”. Pandoc works with both. Signed-off-by: Michael Hanselmann han...@google.com --- man/ganeti-listrunner.rst |4 ++-- man/ganeti-os-interface.rst |4 ++-- man/ganeti-watcher.rst |2 +-

Re: [PATCH master] Add small webserver for development

2013-01-07 Thread Guido Trotter
LGTM, Thanks, Guido On 7 Jan 2013 18:14, Michael Hanselmann han...@google.com wrote: When working on documentation it can be helpful to use a browser. In some environments it's not possible to access the files directly from a graphical browser. This trivial webserver exports all files in the

Re: [PATCH master] man pages: Lowercase name for syntax highlighting

2013-01-07 Thread Guido Trotter
LGTM++! Guido On 7 Jan 2013 18:14, Michael Hanselmann han...@google.com wrote: When the man pages' reST is built using Sphinx, “bash” must be used instead of “Bash”. Pandoc works with both. Signed-off-by: Michael Hanselmann han...@google.com --- man/ganeti-listrunner.rst |4 ++--

Re: Issue 335 in ganeti: Command to reboot all nodes within the cluster

2013-01-07 Thread ganeti
Comment #4 on issue 335 by schrie...@gmail.com: Command to reboot all nodes within the cluster http://code.google.com/p/ganeti/issues/detail?id=335 We have an additional uses that could benefit from hroller (or a similar tool): 1. OS re-installs 2. Firmware / bios upgrades We could