Re: new snf-image release, now with support for Xen

2013-03-20 Thread Vangelis Koukis
On Fri, Mar 15, 2013 at 12:13:32pm +0100, Guido Trotter wrote: On Thu, Mar 14, 2013 at 6:47 PM, Vangelis Koukis vkou...@grnet.gr wrote: Hello everybody, we are happy to announce that snf-image v0.8.1 has been released. Last time we did a release announcement it was for v0.6, so there

[PATCH master] Fix typo 'VolumeN' in bdev.py

2013-03-20 Thread Helga Velroyen
Signed-off-by: Helga Velroyen hel...@google.com --- lib/bdev.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bdev.py b/lib/bdev.py index 3c453d0..649d92e 100644 --- a/lib/bdev.py +++ b/lib/bdev.py @@ -642,7 +642,7 @@ class LogicalVolume(BlockDev): @staticmethod

Re: [PATCH master] Fix typo 'VolumeN' in bdev.py

2013-03-20 Thread Iustin Pop
On Wed, Mar 20, 2013 at 11:23:35AM +0100, Helga Velroyen wrote: Signed-off-by: Helga Velroyen hel...@google.com --- lib/bdev.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bdev.py b/lib/bdev.py index 3c453d0..649d92e 100644 --- a/lib/bdev.py +++ b/lib/bdev.py

Issue 398 in ganeti: Automatically snapshot lock states for later analysis

2013-03-20 Thread ganeti
Status: New Owner: New issue 398 by le...@google.com: Automatically snapshot lock states for later analysis http://code.google.com/p/ganeti/issues/detail?id=398 There are cases when it's beneficial to have the output from 'gnt-debug locks' for analysing a situation / debugging. It

[PATCH master] Typo 'repot' in Server.hs

2013-03-20 Thread Helga Velroyen
Signed-off-by: Helga Velroyen hel...@google.com --- src/Ganeti/Query/Server.hs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Ganeti/Query/Server.hs b/src/Ganeti/Query/Server.hs index 9176a1a..df0e11c 100644 --- a/src/Ganeti/Query/Server.hs +++

Re: [PATCH master] Typo 'repot' in Server.hs

2013-03-20 Thread Iustin Pop
On Wed, Mar 20, 2013 at 11:43:58AM +0100, Helga Velroyen wrote: Signed-off-by: Helga Velroyen hel...@google.com LGTM…

[PATCH devel-2.7] Update FIXME string in RAPI

2013-03-20 Thread Michele Tartara
We are not ready for this change yet. Let's push it to 2.8. Signed-off-by: Michele Tartara mtart...@google.com --- lib/rapi/rlib2.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rapi/rlib2.py b/lib/rapi/rlib2.py index 3a28a84..9314b9a 100644 --- a/lib/rapi/rlib2.py +++

Re: [PATCH devel-2.7] Update FIXME string in RAPI

2013-03-20 Thread Guido Trotter
On Wed, Mar 20, 2013 at 12:20 PM, Michele Tartara mtart...@google.com wrote: We are not ready for this change yet. Let's push it to 2.8. Signed-off-by: Michele Tartara mtart...@google.com LGTM Thanks, Guido

[PATCH master 7/8] Upgrade configuration wrt enabled storage types

2013-03-20 Thread Helga Velroyen
This extends the 'cfgupgrade' script to add the new cluster configuration field 'enabled_storage_types' to the configuration. Note: This change enables updating from 2.7 to 2.7 (is that the correct way to do it?). The unit tests were extended accordingly. Signed-off-by: Helga Velroyen

[PATCH master 3/8] gnt-cluster info: show enabled storage types

2013-03-20 Thread Helga Velroyen
This extends the 'gnt-cluster info' command to list the storage types that are enabled on the cluster. Signed-off-by: Helga Velroyen hel...@google.com --- lib/client/gnt_cluster.py | 2 ++ src/Ganeti/Query/Server.hs | 10 ++ 2 files changed, 8 insertions(+), 4 deletions(-) diff --git

[PATCH master 5/8] gnt-cluster init: add enabled_storage_types parameter

2013-03-20 Thread Helga Velroyen
This patch extends the 'gnt-cluster init' command to set the list of enabled storage types on cluster creation. Signed-off-by: Helga Velroyen hel...@google.com --- lib/bootstrap.py | 16 +++- lib/client/gnt_cluster.py | 10 +- 2 files changed, 24 insertions(+), 2

[PATCH master 2/8] Add 'enabled_storage_types' to the cluster config

2013-03-20 Thread Helga Velroyen
This patch adds the cluster's new field 'enabled_storage_types' to the configuration objects in python and haskell. Signed-off-by: Helga Velroyen hel...@google.com --- lib/objects.py| 1 + src/Ganeti/Objects.hs | 1 + src/Ganeti/Types.hs | 5 + 3 files changed, 7 insertions(+)

[PATCH master 6/8] QA: Extend cluster QA wrt enabled storage types

2013-03-20 Thread Helga Velroyen
This extends the QA scripts to test the changes in 'gnt-cluster init', 'gnt-cluster info', and 'gnt-cluster modify' with respect to enabled storage types. Signed-off-by: Helga Velroyen hel...@google.com --- qa/ganeti-qa.py | 1 + qa/qa-sample.json | 1 + qa/qa_cluster.py | 29

[PATCH master 8/8] Use 'storage type' consistently in design doc

2013-03-20 Thread Helga Velroyen
To minimize the confusion between whether or not a storage type is the same as a storage method, I updated the design doc to use 'storage type' instead of 'storage method' consistently. Signed-off-by: Helga Velroyen hel...@google.com --- doc/design-storagespace.rst | 36

[PATCH master 4/8] gnt-cluster modify: dis/enabling storage types

2013-03-20 Thread Helga Velroyen
This patch extends the 'gnt-cluster modify' command to manipulate the list of enabled storage types. Note that this currenlty does no validation with respect to whether or not there are instances currently using a storage type that is being removed from the list. Signed-off-by: Helga Velroyen

[PATCH master 1/8] Add constants for storage types to constants.py

2013-03-20 Thread Helga Velroyen
This patch adds the currently known and used storage methods to the constants.py file. Note that storage types are different from disk templates. For example both disk templates, drbd and plain, use lvm storage types. The rapi documentation asserts that valid storage types are limited to lvm and

Re: [PATCH master 1/8] Add constants for storage types to constants.py

2013-03-20 Thread Guido Trotter
On Wed, Mar 20, 2013 at 1:43 PM, Helga Velroyen hel...@google.com wrote: This patch adds the currently known and used storage methods to the constants.py file. Note that storage types are different from disk templates. For example both disk templates, drbd and plain, use lvm storage types.

Re: [PATCH master 2/8] Add 'enabled_storage_types' to the cluster config

2013-03-20 Thread Guido Trotter
On Wed, Mar 20, 2013 at 1:43 PM, Helga Velroyen hel...@google.com wrote: This patch adds the cluster's new field 'enabled_storage_types' to the configuration objects in python and haskell. Signed-off-by: Helga Velroyen hel...@google.com LGTM Thanks, Guido

Re: [PATCH master 3/8] gnt-cluster info: show enabled storage types

2013-03-20 Thread Guido Trotter
On Wed, Mar 20, 2013 at 1:43 PM, Helga Velroyen hel...@google.com wrote: This extends the 'gnt-cluster info' command to list the storage types that are enabled on the cluster. Add Also fix indentation problem Thanks, Then LGTM Guido Signed-off-by: Helga Velroyen hel...@google.com ---

Re: [PATCH master 5/8] gnt-cluster init: add enabled_storage_types parameter

2013-03-20 Thread Guido Trotter
On Wed, Mar 20, 2013 at 1:43 PM, Helga Velroyen hel...@google.com wrote: This patch extends the 'gnt-cluster init' command to set the list of enabled storage types on cluster creation. Signed-off-by: Helga Velroyen hel...@google.com LGTM Thanks, Guido

Re: [PATCH master 5/8] gnt-cluster init: add enabled_storage_types parameter

2013-03-20 Thread Guido Trotter
On Wed, Mar 20, 2013 at 1:56 PM, Guido Trotter ultrot...@google.com wrote: On Wed, Mar 20, 2013 at 1:43 PM, Helga Velroyen hel...@google.com wrote: This patch extends the 'gnt-cluster init' command to set the list of enabled storage types on cluster creation. Signed-off-by: Helga Velroyen

Re: [PATCH master 4/8] gnt-cluster modify: dis/enabling storage types

2013-03-20 Thread Guido Trotter
On Wed, Mar 20, 2013 at 1:43 PM, Helga Velroyen hel...@google.com wrote: This patch extends the 'gnt-cluster modify' command to manipulate the list of enabled storage types. Note that this currenlty does no validation with respect to whether or not there are instances currently using a storage

Re: [PATCH master 6/8] QA: Extend cluster QA wrt enabled storage types

2013-03-20 Thread Guido Trotter
On Wed, Mar 20, 2013 at 1:43 PM, Helga Velroyen hel...@google.com wrote: This extends the QA scripts to test the changes in 'gnt-cluster init', 'gnt-cluster info', and 'gnt-cluster modify' with respect to enabled storage types. Signed-off-by: Helga Velroyen hel...@google.com ---

Re: [PATCH master 7/8] Upgrade configuration wrt enabled storage types

2013-03-20 Thread Guido Trotter
On Wed, Mar 20, 2013 at 1:43 PM, Helga Velroyen hel...@google.com wrote: This extends the 'cfgupgrade' script to add the new cluster configuration field 'enabled_storage_types' to the configuration. Note: This change enables updating from 2.7 to 2.7 (is that the correct way to do it?). The

Re: [PATCH master 8/8] Use 'storage type' consistently in design doc

2013-03-20 Thread Guido Trotter
On Wed, Mar 20, 2013 at 1:43 PM, Helga Velroyen hel...@google.com wrote: To minimize the confusion between whether or not a storage type is the same as a storage method, I updated the design doc to use 'storage type' instead of 'storage method' consistently. Signed-off-by: Helga Velroyen

Re: [PATCH master 3/8] gnt-cluster info: show enabled storage types

2013-03-20 Thread Helga Velroyen
Hi! thanks for the review. On Wed, Mar 20, 2013 at 1:55 PM, Guido Trotter ultrot...@google.com wrote: On Wed, Mar 20, 2013 at 1:43 PM, Helga Velroyen hel...@google.com wrote: This extends the 'gnt-cluster info' command to list the storage types that are enabled on the cluster. Add

Re: [PATCH master 6/8] QA: Extend cluster QA wrt enabled storage types

2013-03-20 Thread Iustin Pop
On Wed, Mar 20, 2013 at 02:05:30PM +0100, Guido Trotter wrote: On Wed, Mar 20, 2013 at 1:43 PM, Helga Velroyen hel...@google.com wrote: This extends the QA scripts to test the changes in 'gnt-cluster init', 'gnt-cluster info', and 'gnt-cluster modify' with respect to enabled storage types.

Re: [PATCH master 4/8] gnt-cluster modify: dis/enabling storage types

2013-03-20 Thread Helga Velroyen
Hi! On Wed, Mar 20, 2013 at 2:00 PM, Guido Trotter ultrot...@google.com wrote: On Wed, Mar 20, 2013 at 1:43 PM, Helga Velroyen hel...@google.com wrote: This patch extends the 'gnt-cluster modify' command to manipulate the list of enabled storage types. Note that this currenlty does no

Re: [PATCH master 5/8] gnt-cluster init: add enabled_storage_types parameter

2013-03-20 Thread Helga Velroyen
Hi! On Wed, Mar 20, 2013 at 1:58 PM, Guido Trotter ultrot...@google.com wrote: On Wed, Mar 20, 2013 at 1:56 PM, Guido Trotter ultrot...@google.com wrote: On Wed, Mar 20, 2013 at 1:43 PM, Helga Velroyen hel...@google.com wrote: This patch extends the 'gnt-cluster init' command to set the

Re: [PATCH master 6/8] QA: Extend cluster QA wrt enabled storage types

2013-03-20 Thread Iustin Pop
On Wed, Mar 20, 2013 at 02:26:03PM +0100, Helga Velroyen wrote: Hi! + AssertCommand([gnt-cluster, modify, + --enabled-storage-types=pinkbunny], I'm sure someone once will come up with a storage type named this way. :) LOL :) Anyway, usually we use

Re: [PATCH master 1/8] Add constants for storage types to constants.py

2013-03-20 Thread Helga Velroyen
Hi! +# for pv/vg-unspecific operations, we use lvm-vg as 'default' for lvm Not really. :) It's always either a pv or a vg operation. Usually though we refer to vgs. I would drop this comment altogether. Ok, will do. Cheers, Helga

[PATCH master 7/8] Upgrade configuration wrt enabled storage types

2013-03-20 Thread Helga Velroyen
This implements an online update of the configuration for when a configuration is loaded that does not yet contain the 'enabled_storage_types' attribute. Signed-off-by: Helga Velroyen hel...@google.com --- lib/objects.py | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/objects.py

[PATCH/resend master 00/14] Add UUIDs and names to Disks and NICs

2013-03-20 Thread Christos Stavrakakis
Hello team, I am resending the patch-set for adding UUIDs and names to devices, with Guido's comments incorporated. I actually preserved the legacy interface of the modify command, since it probably belongs to a separate patch and makes this patch series cleaner. I can send this as a different

[PATCH/resend master 05/14] Support UUIDs and names when refering to a device

2013-03-20 Thread Christos Stavrakakis
Modify _ApplyContainerMods function to lookup NICs/Disks not only by their index inside the container, but also by their UUID or name. Abstract the lookup code in new GetItemFromContainer function. Make type of identifier in opcode._TestInstSetParamsModList to be TInt or TString. Modify

[PATCH/resend master 03/14] Add IDISK_NAME and INIC_NAME constants

2013-03-20 Thread Christos Stavrakakis
Declare IDISK_NAME and INIC_NAME constants and add them to the IDISK_PARAMS_TYPE and INIC_PARAMS_TYPE. Signed-off-by: Christos Stavrakakis cst...@grnet.gr Signed-off-by: Dimitris Aragiorgis dim...@grnet.gr --- lib/cmdlib.py|1 + lib/constants.py |4 2 files changed, 5

[PATCH/resend master 07/14] Check that device names are unique and valid

2013-03-20 Thread Christos Stavrakakis
Extend the CheckArguments phase of LUInstanceCreate and CheckPrereq phase of LUInstanceSetParams to also check if the name parameters of disks and NICs are unique and valid. Signed-off-by: Christos Stavrakakis cst...@grnet.gr Signed-off-by: Dimitris Aragiorgis dim...@grnet.gr --- lib/cmdlib.py

[PATCH/resend master 09/14] Display UUIDs and names in gnt-instance info

2013-03-20 Thread Christos Stavrakakis
Modify gnt-instance client to display the UUID and name fields of instances disks and NICs. Signed-off-by: Christos Stavrakakis cst...@grnet.gr Signed-off-by: Dimitris Aragiorgis dim...@grnet.gr --- lib/client/gnt_instance.py | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-)

[PATCH/resend master 12/14] Add name to INicParams and IDiskParams

2013-03-20 Thread Christos Stavrakakis
This commits adds name to NIC and Disk modification definition. Signed-off-by: Chris Stavrakakis cst...@grnet.gr --- src/Ganeti/OpParams.hs |2 ++ test/hs/Test/Ganeti/OpCodes.hs |4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Ganeti/OpParams.hs

[PATCH/resend master 04/14] Support UUIDs and names when handling NICs/Disks

2013-03-20 Thread Christos Stavrakakis
Handle UUID and name fields when creating/managing NICs and Disks. Also, export NICs and Disks names to instance hooks environment. Signed-off-by: Christos Stavrakakis cst...@grnet.gr Signed-off-by: Dimitris Aragiorgis dim...@grnet.gr --- lib/cmdlib.py | 56

[PATCH/resend master 10/14] Add Disks and NICs to _AllUUIDObjects

2013-03-20 Thread Christos Stavrakakis
Since disks and NICs have UUIDs, they must be considered to _AllUUIDObjects. Signed-off-by: Christos Stavrakakis cst...@grnet.gr Signed-off-by: Dimitris Aragiorgis dim...@grnet.gr --- lib/config.py | 20 1 file changed, 20 insertions(+) diff --git a/lib/config.py

[PATCH/resend master 06/14] Implement renaming Disks and NICs

2013-03-20 Thread Christos Stavrakakis
Implement renaming Disks and NICs in LUInstanceSetParams. Remove code that checked that changing disk mode was the only disk modification supported. Signed-off-by: Christos Stavrakakis cst...@grnet.gr Signed-off-by: Dimitris Aragiorgis dim...@grnet.gr --- lib/cmdlib.py | 29

[PATCH/resend master 13/14] Update QA tests to check disk and NIC names

2013-03-20 Thread Christos Stavrakakis
Modify existing tests to use the name option for instance's disks. The configuration options 'disk' and 'disk-growth' are merged into 'disks' option, which is a list of dictionaries with 'size','growth' and 'name' items. Also, add 'instance-device-names' QA test, which tests addition, renaming

[PATCH/resend master 14/14] Update manpages wrt new device refering

2013-03-20 Thread Christos Stavrakakis
This patch updates gnt-instance man page to include refering to devices by their name and UUID. Signed-off-by: Christos Stavrakakis cst...@grnet.gr --- man/gnt-instance.rst | 96 -- 1 file changed, 61 insertions(+), 35 deletions(-) diff --git

Re: [PATCH master 6/8] QA: Extend cluster QA wrt enabled storage types

2013-03-20 Thread Guido Trotter
On Wed, Mar 20, 2013 at 2:45 PM, Iustin Pop ius...@google.com wrote: On Wed, Mar 20, 2013 at 02:26:03PM +0100, Helga Velroyen wrote: Hi! + AssertCommand([gnt-cluster, modify, + --enabled-storage-types=pinkbunny], I'm sure someone once will come up with a storage

Re: [PATCH master 7/8] Upgrade configuration wrt enabled storage types

2013-03-20 Thread Guido Trotter
On Wed, Mar 20, 2013 at 3:15 PM, Helga Velroyen hel...@google.com wrote: This implements an online update of the configuration for when a configuration is loaded that does not yet contain the 'enabled_storage_types' attribute. Signed-off-by: Helga Velroyen hel...@google.com ---

Re: [PATCH master 4/8] gnt-cluster modify: dis/enabling storage types

2013-03-20 Thread Guido Trotter
On Wed, Mar 20, 2013 at 2:21 PM, Helga Velroyen hel...@google.com wrote: Hi! On Wed, Mar 20, 2013 at 2:00 PM, Guido Trotter ultrot...@google.com wrote: On Wed, Mar 20, 2013 at 1:43 PM, Helga Velroyen hel...@google.com wrote: This patch extends the 'gnt-cluster modify' command to manipulate

Re: [PATCH master 5/8] gnt-cluster init: add enabled_storage_types parameter

2013-03-20 Thread Helga Velroyen
Hi! On Wed, Mar 20, 2013 at 4:12 PM, Guido Trotter ultrot...@google.com wrote: On Wed, Mar 20, 2013 at 2:23 PM, Helga Velroyen hel...@google.com wrote: Hi! On Wed, Mar 20, 2013 at 1:58 PM, Guido Trotter ultrot...@google.com wrote: On Wed, Mar 20, 2013 at 1:56 PM, Guido Trotter