Thanks for the review!
On Wed, Aug 20, 2014 at 04:59:11PM +0200, Michele Tartara wrote:
Il 19/ago/2014 10:37 'Aaron Karper' via ganeti-devel
ganeti-devel@googlegroups.com ha scritto:
In order to modify the data collectors displayed, there are the options
LGTM barring nitpicks.
On Mon, Aug 18, 2014 at 3:38 AM, Yuto KAWAMURA(kawamuray)
kawamuray.dad...@gmail.com wrote:
This patch adds the new hvparam lxc_drop_capabilities to the LXC
hypervisor.
This parameter specifies the list of capabilities should be dropped for
which should be
the LXC
On Wed, Aug 20, 2014 at 05:05:26PM +0200, Michele Tartara wrote:
Il 20/ago/2014 16:52 Aaron Karper akar...@google.com ha scritto:
On Wed, Aug 20, 2014 at 04:33:47PM +0200, Michele Tartara wrote:
Il 20/ago/2014 13:14 Aaron Karper akar...@google.com ha scritto:
Hi Michele, thanks
LGTM barring the nitpicks, thanks!
On Mon, Aug 18, 2014 at 3:38 AM, Yuto KAWAMURA(kawamuray)
kawamuray.dad...@gmail.com wrote:
This patch implements RebootInstance function of the LXCHypervisor.
the RebootInstance functionality
Reboot of the LXC container can be done by using lxc-stop
LGTM barring nitpicks, thanks!
On Mon, Aug 18, 2014 at 3:38 AM, Yuto KAWAMURA(kawamuray)
kawamuray.dad...@gmail.com wrote:
Add the _SetCgroupInstanceValue function which can be used to set the
value to the instance cgroup parameter.
s/to the/of an/
Signed-off-by: Yuto
commit 5b4b996b348e740e10a17e0557a28f9e12391885
Merge: 8f6bb1c fa5f77e
Author: Klaus Aehlig aeh...@google.com
Date: Thu Aug 21 15:52:39 2014 +0200
Merge branch 'stable-2.12' into master
* stable-2.12
Fix alterContainerL
Suffix bump for 2.12.0~rc1
Prepare NEWS
LGTM, thanks
On Thu, Aug 21, 2014 at 4:08 PM, 'Klaus Aehlig' via ganeti-devel
ganeti-devel@googlegroups.com wrote:
commit 5b4b996b348e740e10a17e0557a28f9e12391885
Merge: 8f6bb1c fa5f77e
Author: Klaus Aehlig aeh...@google.com
Date: Thu Aug 21 15:52:39 2014 +0200
Merge branch
Hello Ganeti team,
While running gnt-cluster verify, Ganeti complains about orphan LVs
in VGs it should know nothing about, i.e. LVs in VGs other than the
VG specified in the Ganeti conf.
For example:
master# gnt-cluster verify
...
Thu Aug 21 17:25:19 2014 * Verifying orphan volumes
Thu Aug 21
Hello Vangelis,
thanks for your report. As far as I can see, your
analysis is correct. Can you please...
This one-line patch against stable-2.10 fixes the problem:
$ git diff
diff --git a/lib/backend.py b/lib/backend.py
index e638e1c..3c7469c 100644
--- a/lib/backend.py
+++
Status: Accepted
Owner: aeh...@google.com
Labels: Milestone-Release2.13 Type-Documentation Priority-Low
New issue 921 by aeh...@google.com: ganeti man page referrs to design
documents
http://code.google.com/p/ganeti/issues/detail?id=921
...more precisely to design-oob.rst and
This option control the number of jobs in non-finalized non-queued
state and was added some time ago. Document it in the man page as
well.
Signed-off-by: Klaus Aehlig aeh...@google.com
---
man/gnt-cluster.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/man/gnt-cluster.rst
LGTM, thanks
On Thu, Aug 21, 2014 at 5:25 PM, 'Klaus Aehlig' via ganeti-devel
ganeti-devel@googlegroups.com wrote:
This option control the number of jobs in non-finalized non-queued
state and was added some time ago. Document it in the man page as
well.
Signed-off-by: Klaus Aehlig
commit a15e2c91e0faaa8d88936f55db2df70015b72203
Merge: fa5f77e 29b2746
Author: Klaus Aehlig aeh...@google.com
Date: Thu Aug 21 17:40:33 2014 +0200
Merge branch 'stable-2.11' into stable-2.12
* stable-2.11
Document --max-running-jobs option of gnt-cluster modify
LGTM
On Thu, Aug 21, 2014 at 5:44 PM, 'Klaus Aehlig' via ganeti-devel
ganeti-devel@googlegroups.com wrote:
commit a15e2c91e0faaa8d88936f55db2df70015b72203
Merge: fa5f77e 29b2746
Author: Klaus Aehlig aeh...@google.com
Date: Thu Aug 21 17:40:33 2014 +0200
Merge branch 'stable-2.11'
The --max-tracked-jobs option allows to set the limit of
job files watched via inotify; if the limit is exceeded,
luxid will back off to periodic polling. The option was
added some time ago. Document it in the man page as well.
Signed-off-by: Klaus Aehlig aeh...@google.com
---
LGTM, thanks
On Thu, Aug 21, 2014 at 5:56 PM, 'Klaus Aehlig' via ganeti-devel
ganeti-devel@googlegroups.com wrote:
The --max-tracked-jobs option allows to set the limit of
job files watched via inotify; if the limit is exceeded,
luxid will back off to periodic polling. The option was
added
All the code listed here works well and this would be an LGTM, but there is
the question of whether we should keep the memory cgroup optional / how to
behave if it is disabled.
What I find rather curious here is that ballooning / setting the runtime
memory returned quietly rather than raising an
During cluster verification, Ganeti would complain about
orphan LVs in VGs other than the one specified in its configuration.
This commit fixes the backend layer for nodegroup verification
to only report LVs in the VG passed by the master node as part
of the node verification parameters.
LGTM with nitpicks
On Mon, Aug 18, 2014 at 3:38 AM, Yuto KAWAMURA(kawamuray)
kawamuray.dad...@gmail.com wrote:
Once I try to modify a hvparam of the LXC hypervisor, I got this error:
s/try/tried/
ValueError: max() arg is an empty sequence
This is because the current default value
Only nitpicks here, LGTM!
Commit message: drop the as a and replace with an
On Mon, Aug 18, 2014 at 3:38 AM, Yuto KAWAMURA(kawamuray)
kawamuray.dad...@gmail.com wrote:
This patch adds new hvparam lxc_devices to the LXC hypervisor.
adds a new
This parameter specifies the access control
LGTM barring the nitpick, thanks!
On Mon, Aug 18, 2014 at 3:38 AM, Yuto KAWAMURA(kawamuray)
kawamuray.dad...@gmail.com wrote:
Read the cputime(usage) of the LXC instance from the cpuacct.usage
cgroup parameter and include it as the time field of the return value
of the GetInstanceInfo.
On Mon, Aug 18, 2014 at 3:38 AM, Yuto KAWAMURA(kawamuray)
kawamuray.dad...@gmail.com wrote:
Add the new hvparam lxc_extra_config which is used to specify
additional LXC container config parameters which are not supported by
the Ganeti LXC hypervisor natively.
Signed-off-by: Yuto
LGTM, thanks!
On Mon, Aug 18, 2014 at 3:38 AM, Yuto KAWAMURA(kawamuray)
kawamuray.dad...@gmail.com wrote:
Remove the unused _GetMountSubdirs function from LXCHypervisor class.
Signed-off-by: Yuto KAWAMURA(kawamuray) kawamuray.dad...@gmail.com
---
lib/hypervisor/hv_lxc.py | 14
As with patch 5, whether we need any changes here depends on whether the
memory cgroup remains optional.
If the cgroup is optional, this patch should probably not be applied. If it
is not, then other parts of the code need to be changed.
On Mon, Aug 18, 2014 at 3:38 AM, Yuto KAWAMURA(kawamuray)
LGTM barring nitpicks
On Mon, Aug 18, 2014 at 3:38 AM, Yuto KAWAMURA(kawamuray)
kawamuray.dad...@gmail.com wrote:
Currently both of these functions are checking if the value is
s/are checking/check/
s/is/satisfies/
bool(value) == False.
By this approach, numerical 0 would not be allowed
25 matches
Mail list logo
