[Off-topic] Python pattern matching proposal accepted!

Basically: https://lwn.net/Articles/845480/. Examples/tutorial in https://www.python.org/dev/peps/pep-0636/. Don't know in which Python version will land, but it looks to improve code safety quite a bit (in some cases). Then it needs to land in Debian Stable, etc. etc. :) iustin -- You

Re: Forward-porting vs back-porting fixes

On 2020-12-30 11:50:10, Apollon Oikonomopoulos wrote: > Hi all, > > Now that we've officially released 3.0, it's time to look a bit at > stable release management. What I'd like to discuss in particular is the > possibility of switching from a forward-porting workflow for stable > updates to a

Re: resurrecting 3.0 release

On 2020-12-01 18:30:45, Apollon Oikonomopoulos wrote: > Hi Sascha, > > Apologies for not responding earlier, end-November is always terribly > busy. Same here. Especially as Debian freeze approaches… > Sascha Lucas writes: > > > Hi, > > > > after some weeks of silence I like to ask if someone

Registered for github security scan beta

Just FYI, as I enabled one of my own repositories for the security scan beta, I realised I can enable ganeti too, so I went ahead and did that for the entire org. It's s closed beta, so we're in the queue only, not yet enabled, we'll see how it goes. iustin -- You received this message because

Re: GHC versions for 3.0?

uld keep 8.0 compatibility. It's doable, but not pleasant :) I'll reply on bug too. iustin > Am Mi., 8. Juli 2020 um 10:19 Uhr schrieb Iustin Pop : > > > > On 2020-07-08 08:22:22, Rudolph Bott wrote: > > > Hi Iustin, > > > > > > I can not add anythi

Re: GHC versions for 3.0?

/1492 Ouch, I missed those. I have Ganeti now working with GHC 8.8, but cleaning up the patches depends on what the minimum version will be. Thanks, I'll reply on those bugs. iustin > On Tue, Jul 7, 2020 at 11:20 PM Iustin Pop wrote: > > > Hi all, > > > > I made the m

GHC versions for 3.0?

Hi all, I made the mistake of attempting to build ganeti 3.0 beta on a sid box, with GHC 8.8, which causes no end of fun… To solve the fun and make this actually built, would be good to settle which versions of GHC we support (if we didn't already and I missed the email or simply forgot). IMO,

Haskell environment for 2.16.1

Hi Apollon, I just realised that all the fixes from the Debian packaging are on master. This means two thing for the stable-2.16 branch: - building in a recent environment is tricky - the travis-ci builds for it are still failing Any reason why not to update stable-2.16 to be fully buildable?

Re: Continuing development

On 2019-02-12 17:02:35, Apollon Oikonomopoulos wrote: > Immediate steps > --- > > In light of the above, I propose the following: > > - Dismiss all unreleased work and archive the current master and >stable-2.17 branches under attic/ (I've already pushed a ref for >

Re: Continuing development

On 2019-02-13 00:56:49, Apollon Oikonomopoulos wrote: > On 18:38 Tue 12 Feb , Iustin Pop wrote: > > On 2019-02-12 17:02:35, Apollon Oikonomopoulos wrote: > > > Hi everyone, > > > > One specific question below: > > > > > - git push --force origin

Re: Continuing development

On 2019-02-12 17:02:35, Apollon Oikonomopoulos wrote: > Hi everyone, One specific question below: > - git push --force origin v2.16.0:master and continue development from >there. I don't expect the force-push to be an issue, and it's much >cleaner than a `git merge -s ours' or messing

Re: Continuing development

And now correcting the -devel mailing list address. On 2019-02-12 18:26:04, Iustin Pop wrote: > On 2019-02-12 17:02:35, Apollon Oikonomopoulos wrote: > > Hi everyone, > > Hi Apollon, > > > With 2.16.0 released last fall, I think it's time to discuss how we can > >

Re: Status of migrated issues?

On 2018-02-04 14:18:51, Ganeti Development List wrote: > As an FYI all, I have closed all Github issues that had the label > Status:Fixed. Awesome, thanks Morg! iustin

Re: Status of migrated issues?

ould trust the code.google.com "fixed" tag; - there are a lot of very old issues that are for sure fixed, and verifying all of them is time better spent on fixing new issues If some issue is still open, and if users still hit it, let's crowdsource the effort of reopening (against current v

Re: Status of migrated issues?

On 2018-01-14 02:15:41, Iustin Pop wrote: > Hi all, > > I did a quick look at the GitHub issue tracker today, and it seems that > the migrator did not close the migrated issues that were closed. > > More specifically, a search of: > > is:issue is:open label:St

Status of migrated issues?

Hi all, I did a quick look at the GitHub issue tracker today, and it seems that the migrator did not close the migrated issues that were closed. More specifically, a search of: is:issue is:open label:Status:Fixed Shows 98 such open issues. If I'm not mistaken, "Status:Fixed" is a

Re: [RFH] Building with GHC 8 and snap-server 1.0

On 2016-12-10 21:42:12, Apollon Oikonomopoulos wrote: > Hi all, > > I'm trying to sort out the situation with Ganeti 2.15.2 in Debian > unstable. Right now we have GHC 8 and snap-server 1.0 which cause > Ganeti's build to fail and Ganeti is due to be removed from testing. I have > (probably)

Re: [PATCH stable-2.15 01/17] Cleanup: Use new-style classes everywhere

On 2016-12-06 21:51:49, Ganeti Development List wrote: > On Tue, Dec 06, 2016 at 09:34:39PM +0100, Iustin Pop wrote: > > On 2016-12-06 17:29:56, Ganeti Development List wrote: > > > This quells pylint's old-style-class warning. For all classes changed by > > > this comm

Re: [PATCH stable-2.15 17/17] Disable pylint too-many-nested-blocks in _RunCmdPipe

On 2016-12-06 17:30:26, Ganeti Development List wrote: > There doesn't appear to be any easy way of reducing the complexity > of this function without moving it elsewhere or completely reorganising > the function, so disable this warning for the time being. LGTM.

Re: [PATCH stable-2.15 16/17] Reduce nesting in import-export ProcessChildIO

On 2016-12-06 17:30:24, Ganeti Development List wrote: > This avoids some pylint too-many-nested-blocks warnings. Do this by > flattening some 'arrow antipattern code' inside the polling loop to use > guards instead. Was not sure what arrow antipattern is, but after squinting at the diff I'll

Re: [PATCH stable-2.15 15/17] Reduce nesting in LUOobCommand.Exec

On 2016-12-06 17:30:22, Ganeti Development List wrote: > This avoids a pylint too-many-nested-blocks warning. > > NB it's hard to see from the diff because of all the whitespace, but > this just turns the if result.fail_msg check into a guard that continues > the next iteration of the loop, and

Re: [PATCH stable-2.15 14/17] Reduce nesting in LUInstanceCreate.RunOsScripts

On 2016-12-06 17:30:20, Ganeti Development List wrote: > This avoids a pylint too-many-nested-blocks warning. > > NB it's hard to see from the diff because of all the whitespace, but > this just replaces the top "if iobj.disk and not self.adopt_disks" with > a pair of guards that return early,

Re: [PATCH stable-2.15 13/17] Reduce nesting in RemoveNodeSshKeyBulk key calculation

On 2016-12-06 17:30:18, Ganeti Development List wrote: > This avoids a pylint too-many-nested-blocks warning. This removes the > 6th level of nesting in the function, but may also be marginally faster > by turning the calculation into the set difference operation it really > is. > > No functional

Re: [PATCH stable-2.15 12/17] Reduce nesting in RemoveNodeSshKeyBulk ssh logic

On 2016-12-06 17:30:17, Ganeti Development List wrote: > This avoids a pylint too-many-nested-blocks warning. It also removes > some copy & paste code, showing that the master candidate and ordinary > node case are the same apart from the logging. As common with cleanup, one has to wonder how

Re: [PATCH stable-2.15 11/17] Reduce nesting in gnt-cluster VerifyDisks missing disk loop

On 2016-12-06 17:30:15, Ganeti Development List wrote: > To avoid pylint's too-many-nested-blocks warning. Also improves readability a bit, LGTM.

Re: [PATCH stable-2.15 10/17] Reduce nesting in _CheckVLANArguments

On 2016-12-06 17:30:13, Ganeti Development List wrote: > This avoids a pylint too-many-nested-blocks warning. It also has the > happy side effect of removing some duplicated code. > > No functional change. Nice cleanup, LGTM.

Re: [PATCH stable-2.15 09/17] Reduce nesting in StartDaemon

On 2016-12-06 17:30:11, Ganeti Development List wrote: > This avoids a pylint too-many-nested-blocks warning. > > The extra try: finally: os._exit(1) is unnecessary as _StartDaemonChild > already catches all its exceptions and if it ever finishes, calls > os._exit(1) anyways. LGTM, although this

Re: [PATCH stable-2.15 08/17] Disable pylint bad-continuation warning

On 2016-12-06 17:30:09, Ganeti Development List wrote: > pylint is much more strict than pep8, and it would be too invasive > (and arguably pointless) to update these right now. LGTM.

Re: [PATCH stable-2.15 07/17] Disable pylint superfluous-parens warning

On 2016-12-06 17:30:08, Ganeti Development List wrote: > There are too many cases where we deliberately wrap expressions in > parens, either to indicate comparisons, or to allow multiline > expressions without line continuation chars, or to clarify confusing > precedence. > > While here, clean up

Re: [PATCH stable-2.15 03/17] Disable incorrect pylint assigning-non-slot warning

On 2016-12-06 17:30:00, Ganeti Development List wrote: > This occurs pretty heavily in lib/objects.py, where pylint isn't > correctly detecting the __slots__ assignment. This appears to be > a known issue: https://github.com/PyCQA/pylint/issues/379 LGTM.

Re: [PATCH stable-2.15 06/17] Disable pylint redefined-variable-type warning

On 2016-12-06 17:30:06, Ganeti Development List wrote: > There are a large number of cases where Ganeti assigns multiple types > (eg set/list, float/int) to the same variable at different times, and > although these would make a type checking tool very unhappy, they are > benign here (and besides,

Re: [PATCH stable-2.15 05/17] Disable pylint too-many-branches warnings

On 2016-12-06 17:30:04, Ganeti Development List wrote: > This is useful, but in some cases is a little too conservative. A fn > can have a lot of branches, but very little nesting, and can still be > easy to understand. This occurs in, eg, XenPvmHypervisor._GetConfig. LGTM.

Re: [PATCH stable-2.15 04/17] Disable pylint broad-except warnings

On 2016-12-06 17:30:02, Ganeti Development List wrote: > These are all deliberate top-level catch-any-unhandled-exception cases, > used for logging and error handling so just get pylint to ignore them. LGTM.

Re: [PATCH stable-2.15 02/17] Quell pylint unbalanced-tuple-unpacking warning

On 2016-12-06 17:29:58, Ganeti Development List wrote: > Both of these functions return a list, not a tuple, and by manually > tracing the code, we can see they always return non-empty lists. > > Change the callers to get the first element of the list rather than > using destructuring. Someday

Re: [PATCH stable-2.15 01/17] Cleanup: Use new-style classes everywhere

On 2016-12-06 17:29:56, Ganeti Development List wrote: > This quells pylint's old-style-class warning. For all classes changed by > this commit, none of the differences between new-style and old classes > matter: we don't subclass any of these classes, or use super()/type(). I don't know anymore

Re: [PATCH stable-2.15 13/37] Fix pylint >1.4 pycurl no-member warnings

On 5 December 2016 at 14:56, 'Brian Foley' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > On Mon, Dec 05, 2016 at 01:43:57PM +, Federico Pareschi wrote: > > to avoid arbitrary code injection. > > > >Is this safe? Should we be looking more into this or is it something > >

Re: [PATCH stable-2.15 00/37] Cleanup for pylint 1.6.4

On 5 December 2016 at 13:04, 'Brian Foley' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > On Mon, Dec 05, 2016 at 12:01:14PM +0100, Iustin Pop wrote: > >Quick question: is there a reason to keep that compat, as opposed to > >switching the "bles

Re: [PATCH stable-2.15] Fix coexistence of location tags and non-DRBD instances

On 4 December 2016 at 18:44, Brian Foley <bpfo...@google.com> wrote: > On Fri, Dec 02, 2016 at 11:03:55PM +0100, Iustin Pop wrote: > > From: Iustin Pop <ius...@google.com> > > > > This addresses issue 1185, “hbal: IntMap.!: key -1 is not an element of > > t

Re: [PATCH stable-2.15 00/37] Cleanup for pylint 1.6.4

On 5 December 2016 at 11:35, 'Brian Foley' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > Ganeti's python code passes the pylint checks in the version of pylint > included with Debian Jessie. Unfortunately this is a really old pylint > (0.26 from 2012) and the latest stable pylint

Re: [PATCH stable-2.15] Fix invalid variable error for file-based disks

On 2016-12-04 17:54:41, Ganeti Development List wrote: > On Fri, Dec 02, 2016 at 08:28:13PM +0100, Iustin Pop wrote: > > On 2016-12-02 18:03:33, Ganeti Development List wrote: > > > Introduced by 94e252a33. Found by pylint's undefined-loop-variable > > > warning. >

[PATCH stable-2.15] Fix coexistence of location tags and non-DRBD instances

From: Iustin Pop <ius...@google.com> This addresses issue 1185, “hbal: IntMap.!: key -1 is not an element of the map”. The issue is that the location tags code presumed all instances have a primary and a secondary (i.e., they are DRBD). The fix is to set the location score for non-DRBD ins

Re: [PATCH stable-2.15] Fix invalid variable error for file-based disks

On 2016-12-02 18:03:33, Ganeti Development List wrote: > Introduced by 94e252a33. Found by pylint's undefined-loop-variable > warning. > > Signed-off-by: Brian Foley > --- > lib/cmdlib/instance_storage.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH stable-2.15] Fix for incorrect parsing of DRBD versions

On Thu, Dec 01, 2016 at 04:09:56AM -0800, Ganeti Development List wrote: > > On Thursday, December 1, 2016 at 11:53:43 AM UTC, Iustin Pop wrote: > > > > On Thu, Dec 01, 2016 at 11:38:35AM +, Ganeti Development List wrote: > > > Following issue #1194, this patch

Re: [PATCH stable-2.15] Fix for incorrect parsing of DRBD versions

On Thu, Dec 01, 2016 at 11:38:35AM +, Ganeti Development List wrote: > Following issue #1194, this patch allows Ganeti to correctly > parse drbd versions that also include a dash in their k-fix > version component. This means 8.4.8-1 and 8.4.8.1 will be treated the same. Is this the correct

Re: [PATCH master] Fix for instance reinstall not updating config

On 2016-11-28 14:10:39, Ganeti Development List wrote: > From the modified log line it looks like it was intentional, but as we > discussed I don't see a good reason for this. Reinstalling OS image without > changing the configuration creates an inconsistency between the state of > the world and

Re: pylint of master, on Gentoo

On 2016-10-01 23:18:59, Ganeti Development List wrote: > On Sat, Oct 01, 2016 at 11:40:47PM +0200, Iustin Pop wrote: > > On 2016-10-01 19:55:30, Robin H. Johnson wrote: > > > If you're running pylint on jessie as you say, then it's a really old > > > pylint, > >

Re: pylint of master, on Gentoo

On 2016-10-01 19:55:30, Robin H. Johnson wrote: > If you're running pylint on jessie as you say, then it's a really old pylint, > so I suspect much of this may just be newer checks then. I did think > jessie-backports had a relatively modern pylint however. Some historical context: this is not

Re: [PATCH stable-2.15] Update NEWS file for 2.15.3

On 2016-10-01 08:56:02, Ganeti Development List wrote: > (Will update with actual release date on release) A few wording improvements below, but otherwise LGTM. Feel free to apply or discard any/all of them, they are just suggestions. > +Version 2.15.3 > +-- > +*(Released %a, %d %b

Re: RFC: Releasing Ganeti 2.15.3

On 30 September 2016 at 12:30, 'Brian Foley' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > On Fri, Sep 30, 2016 at 11:47:24AM +0200, Iustin Pop wrote: > >On 29 September 2016 at 19:21, 'Brian Foley' via ganeti-devel > ><[1]ganeti-devel@googlegroups.com

Re: RFC: Releasing Ganeti 2.15.3

On 29 September 2016 at 19:21, 'Brian Foley' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > Hi all, > > since December 2015 quite a large number of commits have been made to the > stable-2.15 branch (87 to be exact). These cover the gamut from performance > improvements, to

Re: [PATCH stable-2.16] Add missing cluster modify --modify-etc-hosts to man

On 2016-08-16 18:35:32, Ganeti Development List wrote: > Tweak formatting while here. LGTM, thanks. iustin

Re: [PATCH stable-2.16] Fix some typos/poor phrasing in gnt-node man page

On 2016-08-16 16:17:06, Ganeti Development List wrote: > No change in meaning/options. LGTM, thanks.

Re: [PATCH stable-2.16] Fix typos in gnt-cluster man page

On Fri, Aug 12, 2016 at 03:03:18PM +0100, Ganeti Development List wrote: > Luckily, nothing that changes the meaning anywhere. > > Signed-off-by: Brian Foley LGTM, thanks.

Re: [PATCH stable-2.16] Hide errors for expected inotify failures in unittest

On 12 August 2016 at 15:38, Brian Foley <bpfo...@google.com> wrote: > On Fri, Aug 12, 2016 at 03:13:53PM +0200, Iustin Pop wrote: > >On 12 August 2016 at 15:04, 'Brian Foley' via ganeti-devel > ><[1]ganeti-devel@googlegroups.com> wrote: > > >

Re: [PATCH stable-2.16] Hide errors for expected inotify failures in unittest

On 12 August 2016 at 15:04, 'Brian Foley' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > This makes it a little easier to eyeball the output of make py-tests. > Ooh, nice, this is a very old bug, thanks! +logger = logging.getLogger('pyinotify') > +logger.propagate = False >

Re: [PATCH stable-2.16] Make 'make pep8' happy

On 2016-07-08 17:26:39, Ganeti Development List wrote: > Signed-off-by: Brian Foley > --- > lib/cmdlib/cluster/verify.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/cmdlib/cluster/verify.py b/lib/cmdlib/cluster/verify.py > index

Re: [PATCH stable-2.16] Fix some trivial pep8/pylint errors

On 7 July 2016 at 13:05, 'Brian Foley' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > Whitespace and an unused variable. > LGTM ,thanks. iustin

Re: [PATCH stable-2.16 2/2] Make executeRpcCall only compute rpcCallData once

On 5 July 2016 at 11:44, 'Brian Foley' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > On Mon, Jul 04, 2016 at 08:32:12PM +0200, Iustin Pop wrote: > > On 2016-07-04 16:57:24, Ganeti Development List wrote: > > > This is important for distMCsAsyncTask, beca

Re: [PATCH stable-2.16 2/2] Make executeRpcCall only compute rpcCallData once

On 2016-07-04 16:57:24, Ganeti Development List wrote: > This is important for distMCsAsyncTask, because currently every time > config.data is updated, wconfd generates a separate copy of the Base64 > encoded, zlib compressed config.data payload string for the > /upload_file_single call sent to

Re: [PATCH stable-2.16 1/2] Remove storage unit selection from rpcCallData

On 2016-07-04 16:57:23, Ganeti Development List wrote: > This means the one case where rpcCallData needed to use a Node can be > removed, simplifying the rpcCallData interface and making the payload > computation independent of the node its sent to. > > Signed-off-by: Brian Foley

Re: [PATCH master 2/6] Add bandwidth tags and bandwidth map fields into Node

On 28 June 2016 at 16:16, Даниил Лещёв wrote: > > I have to main concerns here. >> >> 1. I still believe it's wrong to model this on a per-node basis, and that >> it should be rather two things: bandwidth available inside a node group >> (between any two arbitrary nodes), and

Re: [PATCH master 2/6] Add bandwidth tags and bandwidth map fields into Node

On 28 June 2016 at 11:28, Даниил Лещёв wrote: > > > The bandwidths map store data about network speed >> > between current node and given Node by it's bandwidth tags. >> >> Filling this up will take some space in a large cluster. Is it really >> necessary to store this by nodes

Re: [PATCH master 2/6] Add bandwidth tags and bandwidth map fields into Node

On 2016-06-23 17:45:34, mele...@gmail.com wrote: > From: Daniil Leshchev > > The bandwidths map store data about network speed > between current node and given Node by it's bandwidth tags. Filling this up will take some space in a large cluster. Is it really necessary to

Re: [PATCH master 0/6] New balancing options implementation

that Ganeti would automatically adjust the concurrency of such jobs per node, without needing external control. That is however far-fetched, so I'm not proposing any change to the code per se; I was asking to see what others think of this. regards, iustin On Fri, Jun 24, 2016 at 3:17 PM Iustin Pop

Re: [PATCH master 0/6] New balancing options implementation

On 23 June 2016 at 18:32, Даниил Лещёв wrote: > >> I would slightly prefer if we discuss it over plain email (without >> patches), to see what you think about how complex the network model needs >> to be, and whether a static "time X" vs. semi-dynamic (based on the >> instance

Re: [PATCH master 0/6] New balancing options implementation

On 23 June 2016 at 17:42, Даниил Лещёв wrote: > Hi, Iustin > > >> Oh, no worries, I just wanted to know if Daniil acknowledged the comments >> or not. >> >> Anyway, comments are welcome here and the discussion is still open:) >>> >> >> > The only reason why I didn't reply to

Re: [PATCH master 0/6] New balancing options implementation

, I just wanted to know if Daniil acknowledged the comments or not. Anyway, comments are welcome here and the discussion is still open:) > Sounds good. And thanks Daniil for the commits. > Of course, looking forward to see this implemented! thanks! iustin On Thu, Jun 23, 2016 at 5:49 PM '

Re: [PATCH master 0/6] New balancing options implementation

On 23 June 2016 at 16:45, wrote: > From: Daniil Leshchev > > The patchset introduces new command line options > (--long-solution-threshold" and --avoid-long-solutions"). > That gives an ability for HBal to avoid balancing solutions, > that take significant

Re: [PATCH stable-2.15 1/2] KVM: handle gracefully too old psutil versions

On 21 June 2016 at 16:28, Brian Foley <bpfo...@google.com> wrote: > On Sat, Jun 18, 2016 at 04:53:25AM +0200, Iustin Pop wrote: > > On 2016-06-15 10:23:57, Brian Foley wrote: > > > Additionally, 0.5.0 had a psutil.Process.{get,set}_cpu_affinity() API, > > > which

Re: [PATCH stable-2.15] KVM: handle gracefully too old/too new psutil versions

On 21 June 2016 at 16:29, Brian Foley <bpfo...@google.com> wrote: > On Sat, Jun 18, 2016 at 04:54:51AM +0200, Iustin Pop wrote: > > From: Iustin Pop <ius...@google.com> > > > > My previous pylint cleanups were done without psutil installed; as soon

Re: [PATCH master] Add proposal of a new data collector and new command-line options

On 2016-06-12 21:22:41, mele...@gmail.com wrote: > From: Daniil Leshchev > > Introduce new command-line options for configuring > balancing process. > > Introduce the data collector for gathering information > about network speed. This information can be used in order > to

Re: [PATCH stable-2.16] Special case WaitForJobChange to reduce heap use

On 2016-06-15 17:25:18, Ganeti Development List wrote: > As we talked offline, I like the fact that we are not going through the > generic handleCall if we do not need the config regardless of the > optimisation (which is awesome and is the main motivation for this patch). > I'm wondering if we

[PATCH stable-2.15] KVM: handle gracefully too old/too new psutil versions

From: Iustin Pop <ius...@google.com> My previous pylint cleanups were done without psutil installed; as soon I installed it, pylint showed that the wheezy's version of psutil is too old (0.5.1), not having the cpu_count() function which was introduced in 2.0.0. Furthermore, thanks to

Re: [PATCH stable-2.15 1/2] KVM: handle gracefully too old psutil versions

On 2016-06-15 10:23:57, Brian Foley wrote: > On Wed, Jun 15, 2016 at 07:18:38AM +0200, Iustin Pop wrote: > > From: Iustin Pop <ius...@google.com> > > > > My previous pylint cleanups were done without psutil installed; as soon > > I installed it, pylint showed th

Re: [PATCH stable-2.17] Prevent watcher from holding lock on verify group

fix to solve some blocker issues that show up > as a consequence of it. > Ack, thanks for the info! iustin > On 17 June 2016 at 17:57, Iustin Pop <ius...@google.com> wrote: > >> 2016-06-17 9:46 GMT-07:00 Federico Pareschi <m...@google.com>: >> >>> Whe

Re: [PATCH stable-2.17] Prevent watcher from holding lock on verify group

ently, can we end up with multiple (redundant) verify-group jobs? Sorry if I misunderstand the situation. iustin On 17 June 2016 at 17:18, Iustin Pop <ius...@google.com> wrote: > >> 2016-06-17 8:31 GMT-07:00 'Federico Morg Pareschi' via ganeti-devel < >> ganeti-devel@g

Re: [PATCH stable-2.17] Prevent watcher from holding lock on verify group

2016-06-17 8:31 GMT-07:00 'Federico Morg Pareschi' via ganeti-devel < ganeti-devel@googlegroups.com>: > The ganeti-watcher holds the group file lock for too long, until after > the execution of a group-verify-disk job. This locks for a long time if > there are other jobs already running and

[PATCH stable-2.15 2/2] Cleanup more pylint/pep8/apidoc errors

From: Iustin Pop <ius...@google.com> Hopefully this makes stable-2.15 clean and able to pass a buildbot run. The changes should all be self-explanatory, except test/mocks.py one: there were more unused arguments, so I added a silence for that at class level, and removed the '_' on _ec_id

[PATCH stable-2.15 1/2] KVM: handle gracefully too old psutil versions

From: Iustin Pop <ius...@google.com> My previous pylint cleanups were done without psutil installed; as soon I installed it, pylint showed that the wheezy's version of psutil is too old (0.5.1), not having the cpu_count() function which was introduced in 2.0.0. This change adds a simp

[PATCH stable-2.15 0/2] A couple of more 2.15 fixes

From: Iustin Pop <ius...@google.com> The first one shows why pylint, as annoying as it is sometimes, is useful: as far as I see, we don't have any other version check for psutil, so this was indeed broken. The second patch is rather trivial. Hopefully these two will for real make 2.15 d

Re: [PATCH stable-2.15 0/2] Make stable-2.15 distcheck-compliant

On 2016-06-14 12:22:21, Brian Foley wrote: > On Tue, Jun 14, 2016 at 06:04:00AM +0200, Iustin Pop wrote: > > From: Iustin Pop <ius...@google.com> > > > > This two patches (well, only the first, the second is cleanup) make > > stable-2.15 > > pass "mak

Re: [PATCH master 2/2] Fix running unittests without python-psutil

On 2016-06-14 13:36:38, Brian Foley wrote: > On Tue, Jun 14, 2016 at 06:10:28AM +0200, Iustin Pop wrote: > > From: Iustin Pop <ius...@google.com> > > > > Python 2.7 has a very nice extension to the unittest module to support > > test skipping, but until we officia

[PATCH master 0/2] Make master distcheck-compliant

From: Iustin Pop <ius...@google.com> And this is the last couple of patches. Merge 2.16 to 2.17 to master before. Iustin Pop (2): Fix remaining pylint/check-local issues Fix running unittests without python-psutil lib/hypervisor/hv_kvm/__init__.py| 2 +- test/py/

[PATCH master 1/2] Fix remaining pylint/check-local issues

From: Iustin Pop <ius...@google.com> Two trivial things—indentation and line length. Signed-off-by: Iustin Pop <ius...@google.com> --- lib/hypervisor/hv_kvm/__init__.py | 2 +- test/py/cmdlib/test_unittest.py | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) mode c

[PATCH master 2/2] Fix running unittests without python-psutil

From: Iustin Pop <ius...@google.com> Python 2.7 has a very nice extension to the unittest module to support test skipping, but until we officially stop supporting it we pretend these pass. Signed-off-by: Iustin Pop <ius...@google.com> --- test/py/ganeti.hypervisor.hv_kvm_uni

[PATCH stable-2.16 1/2] Fix line-too long errors

From: Iustin Pop <ius...@google.com> These are all trivial changes. Signed-off-by: Iustin Pop <ius...@google.com> --- lib/http/server.py | 9 ++--- src/Ganeti/Config.hs | 3 ++- test/py/ganeti.storage.bdev_unittest.py| 6 +++

[PATCH stable-2.16 0/2] Make stable-2.16 distcheck-compliant

From: Iustin Pop <ius...@google.com> This is now for the 2.16 stable branch. Before committing these, merge with 2.15 after my two previous patches, with the conflicts solved as follows: - lib/cluster/verify.py: keep our version (the one with enable/disable), dropping the C0xx m

[PATCH stable-2.16 2/2] Fix lint or silence errors

From: Iustin Pop <ius...@google.com> Some of the them are fixed (e.g. unused variable), others are simply silenced especially when there's no context of why the code was committed as such (and I don't want to change things which are non-obvious). Signed-off-by: Iustin Pop <ius...@g

[PATCH stable-2.15 2/2] Fix small typo in opcode tests

From: Iustin Pop <ius...@google.com> Signed-off-by: Iustin Pop <ius...@google.com> --- test/hs/Test/Ganeti/OpCodes.hs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/hs/Test/Ganeti/OpCodes.hs b/test/hs/Test/Ganeti/OpCodes.hs index 229696f..d677b4c 100644 -

[PATCH stable-2.15 1/2] Fix line-too long errors

From: Iustin Pop <ius...@google.com> This does mostly trivial line-too-long fixes. The only non-trivial is the rewriting of the checkNonOptDef function, although I think this is worth anyway as the new version is (IMHO) more readable. Signed-off-by: Iustin Pop <ius...@google.com> ---

[PATCH stable-2.15 0/2] Make stable-2.15 distcheck-compliant

From: Iustin Pop <ius...@google.com> This two patches (well, only the first, the second is cleanup) make stable-2.15 pass "make distcheck" on wheezy again. Iustin Pop (2): Fix line-too long errors Fix small typo in opcode tests lib/cmdlib/cluster/verify.py | 4 +++- s

Re: [MERGE] stable-2.17 to master

2016-06-10 16:25 GMT+02:00 'Brian Foley' via ganeti-devel < ganeti-devel@googlegroups.com>: > commit 7eb49311e18865db76c4e8da5eb4b2e166db2d55 > Merge: a32eb3c 17a1c27 > Author: Brian Foley > Date: Fri Jun 10 15:20:33 2016 +0100 > > Merge branch 'stable-2.17' > > *

Re: [MERGE] stable-2.16 to stable-2.17

2016-06-10 15:40 GMT+02:00 'Brian Foley' via ganeti-devel < ganeti-devel@googlegroups.com>: > commit b462d8c77bff0789e8a951288dea34226ab8b6d7 > Merge: 20c24a8 90281b4 > Author: Brian Foley > Date: Fri Jun 10 14:35:13 2016 +0100 > > Merge branch 'stable-2.16' into

Re: [MERGE] stable-2.15 to stable 2.16

2016-06-10 15:28 GMT+02:00 'Brian Foley' via ganeti-devel < ganeti-devel@googlegroups.com>: > commit 5785f214a9e728465a4bfc1aef7ded306225cfa2 > Merge: 40cd52f 2429235 > Author: Brian Foley > Date: Fri Jun 10 14:23:10 2016 +0100 > > Merge branch 'stable-2.15' into

[PATCH stable-2.15] Fixup compatibility with GHC 7.4/base 4.5

It looks like commit c429dd26 introduced the use of atomicModifyIORef', which is only present in base 4.6 (GHC 7.6). Let's fix that by importing the actual implementation of said function from base 4.6 in case we're running with earlier versions. Signed-off-by: Iustin Pop <ius...@google.

Re: [PATCH master] Fixup compatibility with GHC 7.4/base 4.5

On Fri, Jun 10, 2016 at 12:07:45PM +0100, Brian Foley wrote: > On Fri, Jun 10, 2016 at 12:33:23PM +0200, 'Iustin Pop' via ganeti-devel wrote: > > On Fri, Jun 10, 2016 at 12:30:03PM +0200, Iustin Pop wrote: > > > It looks like commit c429dd26 introduced the use of atomicModifyIO

Re: [PATCH master] Fixup compatibility with GHC 7.4/base 4.5

On Fri, Jun 10, 2016 at 12:30:03PM +0200, Iustin Pop wrote: > It looks like commit c429dd26 introduced the use of atomicModifyIORef', which > is only present in base 4.6 (GHC 7.6). Let's temporarily fix that by adding a > small compat layer (which undoes the optimisations of using stri

Re: [PATCH master 4/8] Split getInstance into *ByUuid and *ByPartialName

On Fri, Jun 10, 2016 at 11:28:16AM +0100, Brian Foley wrote: > On Thu, Jun 09, 2016 at 11:13:54PM +0200, Iustin Pop wrote: > > From: Iustin Pop <ius...@google.com> > > > > This function (and getNode, next patch) were two pain points when I tried to > > convert UUI

[PATCH master] Fixup compatibility with GHC 7.4/base 4.5

for 7.4. Signed-off-by: Iustin Pop <ius...@google.com> --- src/Ganeti/Compat.hs | 10 ++ src/Ganeti/JQScheduler.hs | 5 +++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/src/Ganeti/Compat.hs b/src/Ganeti/Compat.hs index e5276d1..3ee3293 100644 --- a/src/

Re: [PATCH master 3/3] Fix KVM pinning tests to not depend on the local machine

2016-06-10 10:58 GMT+02:00 Viktor Bachraty <vbachr...@google.com>: > > On Thu, Jun 9, 2016 at 11:33 PM, Iustin Pop <ius...@k1024.org> wrote: > >> From: Iustin Pop <ius...@google.com> >> >> Commit 8b2ec2f added unittests for KVM pinning, but it in

  1   2   3   4   5   6   7   8   9   10   >