Re: [PATCH master 5/7] Move _FakeCurl from tests/ganeti.rapi.client to ganeti.rapi.testutils

2012-04-04 Thread René Nussbaumer
On Fri, Mar 30, 2012 at 16:54, Michael Hanselmann han...@google.com wrote: From: René Nussbaumer r...@google.com This is preparation for the mock system, where we need the same cURL mock. Signed-off-by: René Nussbaumer r...@google.com Signed-off-by: Michael Hanselmann han...@google.com ---

Re: [PATCH master 6/7] rapi.testutils.FakeCurl: Add header support

2012-04-04 Thread René Nussbaumer
On Fri, Mar 30, 2012 at 16:54, Michael Hanselmann han...@google.com wrote: With this patch headers are constructed from the PycURL options and passed to the mock implementation. ---  lib/rapi/testutils.py               |   27 ++-  test/ganeti.rapi.client_unittest.py |  

Re: [PATCH master 7/7] Add more RAPI test utilities

2012-04-04 Thread René Nussbaumer
On Fri, Mar 30, 2012 at 16:54, Michael Hanselmann han...@google.com wrote: This patch adds a mock RAPI client to test input values to methods. All methods either raise an exception if there was a problem or return None. Third-party code can use this to test their input values to the RAPI

Re: [PATCH master 3/9] Introduce new module for IP pool management

2012-04-04 Thread Vangelis Koukis
On Mon, Apr 02, 2012 at 03:20:59pm +0200, Iustin Pop wrote: I see a few ways… Would it make sense to submit this to the author of bitarray? Yes. Any comments are more than welcome. So. First, the author of bitarray should be the one commenting on the code, especially the C

Re: [PATCH master 3/9] Introduce new module for IP pool management

2012-04-04 Thread Vangelis Koukis
[resending with proper Cc:, sorry for spamming you] On Mon, Apr 02, 2012 at 03:20:59pm +0200, Iustin Pop wrote: I see a few ways… Would it make sense to submit this to the author of bitarray? Yes. Any comments are more than welcome. So. First, the author of bitarray should be the one

Re: [PATCH master 3/9] Introduce new module for IP pool management

2012-04-04 Thread Iustin Pop
On Wed, Apr 04, 2012 at 06:06:49PM +0300, Vangelis Koukis wrote: [resending with proper Cc:, sorry for spamming you] (heh, no worry!) On Mon, Apr 02, 2012 at 03:20:59pm +0200, Iustin Pop wrote: I see a few ways… Would it make sense to submit this to the author of bitarray? Yes.

[PATCH master 5/5] Update the shared storage design document

2012-04-04 Thread Constantinos Venetsanopoulos
Update the shared storage design document to reflect the current changes, after the implementation of the ExtStorage interface. Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- doc/design-shared-storage.rst | 204 ++-- 1 files changed, 112

[PATCH master 0/5] Introduce the External Storage Interface

2012-04-04 Thread Constantinos Venetsanopoulos
Hello team, Until now, Ganeti can handle shared storage in two ways: - with the `drbd' disk template (internally) - with the `blockdev' and `sharedfile' template (externally) As stated in the shared-storage design doc, the blockdev and sharedfile template cannot handle operations on the

[PATCH master 4/5] Add external storage interface related man pages

2012-04-04 Thread Constantinos Venetsanopoulos
* ganeti-extstorage-interface man page * gnt-storage man page Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- .gitignore |1 + Makefile.am |2 + man/footer.rst | 11 +-

[PATCH master 1/5] Implement the External Storage Interface

2012-04-04 Thread Constantinos Venetsanopoulos
With this commit we introduce the External Storage Interface to Ganeti, abbreviated: ExtStorage Interface. The ExtStorage Interface provides Ganeti with the ability to interact with externally connected shared storage pools, visible by all VM-capable nodes. This means that Ganeti is able to

[PATCH master 2/5] Multiple ExtStorage Providers and ext-params

2012-04-04 Thread Constantinos Venetsanopoulos
Add support for passing parameters to the ext template (ext-params). Take advantage of disk-params, that don't seem to make much sense in this template (ExtStorage Providers are not predefined and we don't know their needs) and use them to pass the ext-params dynamically to the template.

[PATCH master 3/5] Add the gnt-storage client

2012-04-04 Thread Constantinos Venetsanopoulos
Add a new client called 'gnt-storage'. The client interacts with the ExtStorage interface, similarly to the way gnt-os interacts with the OS interface. For now, only two commands are supported: 'info' and 'diagnose'. 'diagnose' calculates the node status of each provider on each node, similarly

Re: [PATCH master 0/5] Introduce the External Storage Interface

2012-04-04 Thread Iustin Pop
On Wed, Apr 04, 2012 at 07:28:25PM +0300, Constantinos Venetsanopoulos wrote: Hello team, Until now, Ganeti can handle shared storage in two ways: - with the `drbd' disk template (internally) - with the `blockdev' and `sharedfile' template (externally) As stated in the shared-storage

Re: [PATCH master 0/5] Introduce the External Storage Interface

2012-04-04 Thread Constantinos Venetsanopoulos
On 04/04/2012 07:39 PM, Iustin Pop wrote: On Wed, Apr 04, 2012 at 07:28:25PM +0300, Constantinos Venetsanopoulos wrote: Hello team, Until now, Ganeti can handle shared storage in two ways: - with the `drbd' disk template (internally) - with the `blockdev' and `sharedfile' template

Re: [PATCH stable-2.5] Further fixes concerning drbd port release

2012-04-04 Thread Iustin Pop
On Mon, Apr 02, 2012 at 09:27:35PM +0300, Dimitris Aragiorgis wrote: Commit 3b3b1bc does not entirely fix the bug introduced in commit f396ad8. It fixes consistency of config data in permanent storage, but does not ensure consistency in data held in runtime memory of masterd. The bug of

Re: Issue 190 in ganeti: gnt-cluster verify fails on missing drbd module even if the cluster does not use drbd

2012-04-04 Thread ganeti
Comment #1 on issue 190 by zo...@gentoo.org: gnt-cluster verify fails on missing drbd module even if the cluster does not use drbd http://code.google.com/p/ganeti/issues/detail?id=190 Have the same problem Wed Apr 4 20:52:59 2012 - ERROR: node node1amd.xxx.xx: cannot parse drbd status