plugin_is_GPL_compatible mangling

2010-06-08 Thread Joern Rennecke
I'm currently working on an update of the patch for PR42843, and I wonder what best to do about the symbol plugin_is_GPL_compatible. Although gcc doesn't currently mangle global variables, a future version of gcc - or any other build compiler - might add mangling. If I add: #ifdef __cplusplus

Re: plugin_is_GPL_compatible mangling

2010-06-08 Thread Basile Starynkevitch
On Tue, Jun 08, 2010 at 09:48:15AM -0400, Joern Rennecke wrote: I'm currently working on an update of the patch for PR42843, and I wonder what best to do about the symbol plugin_is_GPL_compatible. extern int plugin_is_GPL_compatible; However, it would mean that plugin_is_GPL_compatible

Re: plugin_is_GPL_compatible mangling

2010-06-08 Thread Mark Mitchell
Joern Rennecke wrote: #ifdef __cplusplus extern C { #endif extern int plugin_is_GPL_compatible; #ifdef __cplusplus } #endif I think that's a good idea; I don't think that at this point we've made any plugin compatibility guarantees. (In the future, I think we should -- but only when we