[Bug demangler/80513] demangler walks past trailing nul in mangled name in a bunch of cases

2017-04-27 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80513 --- Comment #6 from Jonathan Wakely --- Author: redi Date: Thu Apr 27 09:44:28 2017 New Revision: 247300 URL: https://gcc.gnu.org/viewcvs?rev=247300=gcc=rev Log: PR demangler/80513 check for overflows and invalid characters in thunks

[Bug demangler/80513] demangler walks past trailing nul in mangled name in a bunch of cases

2017-04-27 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80513 Jonathan Wakely changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

[Bug demangler/80513] demangler walks past trailing nul in mangled name in a bunch of cases

2017-04-26 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80513 Jonathan Wakely changed: What|Removed |Added Status|NEW |ASSIGNED

[Bug demangler/80513] demangler walks past trailing nul in mangled name in a bunch of cases

2017-04-26 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80513 --- Comment #4 from Jonathan Wakely --- (In reply to Richard Smith from comment #1) > While we're here, this check for overflow in consume_count is nonsense, and > any decent optimising compiler is going to optimise away the overflow check: > >

[Bug demangler/80513] demangler walks past trailing nul in mangled name in a bunch of cases

2017-04-26 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80513 --- Comment #3 from Jonathan Wakely --- Oops, no, that's not the right character to check!

[Bug demangler/80513] demangler walks past trailing nul in mangled name in a bunch of cases

2017-04-26 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80513 --- Comment #2 from Jonathan Wakely --- For the first problem this should be sufficient: --- a/libiberty/cplus-dem.c +++ b/libiberty/cplus-dem.c @@ -3173,6 +3173,8 @@ gnu_special (struct work_stuff *work, const char **mangled, string *declp)

[Bug demangler/80513] demangler walks past trailing nul in mangled name in a bunch of cases

2017-04-25 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80513 Jonathan Wakely changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed|

[Bug demangler/80513] demangler walks past trailing nul in mangled name in a bunch of cases

2017-04-25 Thread richard-gccbugzilla at metafoo dot co.uk
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80513 --- Comment #1 from Richard Smith --- While we're here, this check for overflow in consume_count is nonsense, and any decent optimising compiler is going to optimise away the overflow check: