http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
--- Comment #39 from Dmitry Vyukov dvyukov at google dot com 2013-02-01
20:00:22 UTC ---
Sorry, I was busy previous weeks. Thanks for fixing this.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
--- Comment #37 from Jakub Jelinek jakub at gcc dot gnu.org 2013-01-31
14:29:27 UTC ---
As discussed elsewhere, __atomic_load_n actually should work on all targets, if
the backend doesn't have special support for that, it is emitted as
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
--- Comment #38 from Jakub Jelinek jakub at gcc dot gnu.org 2013-01-31
16:57:15 UTC ---
Author: jakub
Date: Thu Jan 31 16:57:09 2013
New Revision: 195618
URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=195618
Log:
PR
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
Alan Modra amodra at gmail dot com changed:
What|Removed |Added
CC||amodra at
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
--- Comment #34 from Joost VandeVondele Joost.VandeVondele at mat dot ethz.ch
2013-01-10 11:26:23 UTC ---
(In reply to comment #33)
Can you sent it to review? You can also mention that it fixes issue 40362.
I had a closer look at
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
--- Comment #35 from Jakub Jelinek jakub at gcc dot gnu.org 2013-01-10
11:37:08 UTC ---
For config/posix it is not that easy, because you can't assume that atomics are
available. You'd need to guard it with #ifdef HAVE_SYNC_BUILTINS and do
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
--- Comment #33 from Dmitry Vyukov dvyukov at google dot com 2013-01-08
09:17:31 UTC ---
(In reply to comment #32)
(In reply to comment #30)
The formatting in the patch is wrong (multiple issues).
I've tried to fix them in the
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
--- Comment #32 from Joost VandeVondele Joost.VandeVondele at mat dot ethz.ch
2013-01-07 21:35:25 UTC ---
(In reply to comment #30)
The formatting in the patch is wrong (multiple issues).
I've tried to fix them in the version below.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
--- Comment #29 from Dmitry Vyukov dvyukov at google dot com 2013-01-02
09:09:11 UTC ---
(In reply to comment #28)
(In reply to comment #26)
For config/linux/ptrlock the changes are:
[...]
Following your suggestions, I applied
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
--- Comment #30 from Jakub Jelinek jakub at gcc dot gnu.org 2013-01-02
09:43:29 UTC ---
The formatting in the patch is wrong (multiple issues).
I don't see a point in the __atomic_load_n (addr, MEMMODEL_RELAXED), for
aligned ints or
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
--- Comment #31 from Dmitry Vyukov dvyukov at google dot com 2013-01-02
10:28:00 UTC ---
(In reply to comment #30)
The formatting in the patch is wrong (multiple issues).
I don't see a point in the __atomic_load_n (addr,
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
--- Comment #28 from Joost VandeVondele Joost.VandeVondele at mat dot ethz.ch
2013-01-01 17:13:39 UTC ---
(In reply to comment #26)
For config/linux/ptrlock the changes are:
[...]
Following your suggestions, I applied the following
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
--- Comment #22 from Joost VandeVondele Joost.VandeVondele at mat dot ethz.ch
2012-12-30 09:03:15 UTC ---
(In reply to comment #18)
The obvious solution to this seems to be that also the OMP runtime (libgomp)
must be compiled with
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
--- Comment #23 from Dmitry Vyukov dvyukov at google dot com 2012-12-30
09:57:44 UTC ---
(In reply to comment #22)
I did do some more testing, and the combination '-fsanitize=thread -fopenmp'
was really very useful. Apart from the
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
--- Comment #24 from Dmitry Vyukov dvyukov at google dot com 2012-12-30
10:11:27 UTC ---
For testing you can comment out first 2 lines of gomp_ptrlock_get(). That
should fix the race in libgomp. It's not a good fix form performance pov, but
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
--- Comment #25 from Joost VandeVondele Joost.VandeVondele at mat dot ethz.ch
2012-12-30 14:52:51 UTC ---
(In reply to comment #24)
For testing you can comment out first 2 lines of gomp_ptrlock_get(). That
should fix the race in libgomp.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
--- Comment #26 from Dmitry Vyukov dvyukov at google dot com 2012-12-30
17:07:01 UTC ---
(In reply to comment #25)
(In reply to comment #24)
For testing you can comment out first 2 lines of gomp_ptrlock_get(). That
should fix the
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
--- Comment #27 from Joost VandeVondele Joost.VandeVondele at mat dot ethz.ch
2012-12-30 19:57:24 UTC ---
(In reply to comment #24)
For testing you can comment out first 2 lines of gomp_ptrlock_get(). That
should fix the race in libgomp.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
--- Comment #18 from Dmitry Vyukov dvyukov at google dot com 2012-12-29
09:32:53 UTC ---
On Tue, Dec 25, 2012 at 11:30 PM, Joost.VandeVondele at mat dot
ethz.ch gcc-bugzi...@gcc.gnu.org wrote:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
--- Comment #19 from Dmitry Vyukov dvyukov at google dot com 2012-12-29
09:38:13 UTC ---
On Wed, Dec 26, 2012 at 12:23 AM, Joost.VandeVondele at mat dot
ethz.ch gcc-bugzi...@gcc.gnu.org wrote:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
--- Comment #20 from Dmitry Vyukov dvyukov at google dot com 2012-12-29
10:13:00 UTC ---
(In reply to comment #19)
On Wed, Dec 26, 2012 at 12:23 AM, Joost.VandeVondele at mat dot
ethz.ch gcc-bugzi...@gcc.gnu.org wrote:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
--- Comment #21 from Dmitry Vyukov dvyukov at google dot com 2012-12-29
10:21:06 UTC ---
It is a known issue http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40362#c7
and Jakub said it's safe. I am not that sure.
On Sat, Dec 29, 2012 at 2:13
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
--- Comment #17 from Joost VandeVondele Joost.VandeVondele at mat dot ethz.ch
2012-12-26 19:34:29 UTC ---
Another testcase that yields warnings with a sanitized libgomp:
!$omp parallel default(none) private(i,j,k)
!$omp do collapse(3)
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
--- Comment #15 from Joost VandeVondele Joost.VandeVondele at mat dot ethz.ch
2012-12-25 19:30:15 UTC ---
(In reply to comment #13)
(In reply to comment #12)
That's great that gcc tsan works for Fortran/OpenMP out of the box!
I'm
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
--- Comment #16 from Joost VandeVondele Joost.VandeVondele at mat dot ethz.ch
2012-12-25 20:23:07 UTC ---
many things appear to work fine, but seemingly parallel do loops with a dynamic
schedule generate warnings in libgomp. I also seem to
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55561
Joost VandeVondele Joost.VandeVondele at mat dot ethz.ch changed:
What|Removed |Added
Summary|TSAN crashes for
26 matches
Mail list logo
