[Bug c++/80518] -Wsuggest-override does not warn about missing override on destructor

2019-10-07 Thread egallager at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80518 --- Comment #8 from Eric Gallager --- (In reply to Jonathan Wakely from comment #7) > The guideline might be changing: > https://github.com/isocpp/CppCoreGuidelines/pull/1448 > If that pull request is merged we might want to change

[Bug c++/80518] -Wsuggest-override does not warn about missing override on destructor

2019-07-08 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80518 --- Comment #7 from Jonathan Wakely --- The guideline might be changing: https://github.com/isocpp/CppCoreGuidelines/pull/1448 If that pull request is merged we might want to change -Wsuggest-override too, without needing a separate option.

[Bug c++/80518] -Wsuggest-override does not warn about missing override on destructor

2019-07-07 Thread egallager at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80518 --- Comment #6 from Eric Gallager --- (In reply to Arnaud Desitter from comment #2) > Interesting. Shame that there is no rationale. > > I suppose that "-Wsuggest-override=2" could warn about "override" missing > for destructor. I'd just like

[Bug c++/80518] -Wsuggest-override does not warn about missing override on destructor

2018-10-08 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80518 --- Comment #5 from Jonathan Wakely --- https://github.com/isocpp/CppCoreGuidelines/issues/721

[Bug c++/80518] -Wsuggest-override does not warn about missing override on destructor

2018-10-08 Thread egallager at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80518 Eric Gallager changed: What|Removed |Added CC||redi at gcc dot gnu.org --- Comment #4

[Bug c++/80518] -Wsuggest-override does not warn about missing override on destructor

2017-08-22 Thread egallager at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80518 Eric Gallager changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed|

[Bug c++/80518] -Wsuggest-override does not warn about missing override on destructor

2017-04-25 Thread arnaud02 at users dot sourceforge.net
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80518 --- Comment #2 from Arnaud Desitter --- Interesting. Shame that there is no rationale. I suppose that "-Wsuggest-override=2" could warn about "override" missing for destructor.

[Bug c++/80518] -Wsuggest-override does not warn about missing override on destructor

2017-04-25 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80518 Jonathan Wakely changed: What|Removed |Added Keywords||diagnostic --- Comment #1 from