FDO usability -- sanity check indirect call target

2011-04-08 Thread Xinliang David Li
Hi, due to race conditions, it is common that the value profile information for an indirect call site is 'corrupted' -- resulting in false target function to be recorded. The value profile transformation won't cause runtime problem as the path will never be executed, however it may cause compile

Re: Simple enhancement to -dA dump

2011-04-08 Thread Xinliang David Li
Ping? On Sun, Apr 3, 2011 at 5:54 PM, Xinliang David Li davi...@google.com wrote: For an assembly dump, it is very useful to examine the control flow graph with frequency and profile count information. This requires dumping the .s file with more control flow annotations. This patch does just

C++ PATCHes for c++/48481 (overload resolution memory hog)

2011-04-08 Thread Jason Merrill
48481 involves a huge function involving calls to functions taking class arguments. Detailed memory statistics pointed to three primary sources of garbage: 1) BASELINKs from lookup of constructors for considering a user-defined conversion sequence. We can just avoid creating these in the

Re: [PATCH, ARM] PR47855 Compute attr length for some thumb2 insns

2011-04-08 Thread Carrot Wei
Hi This patch moves the length computation of push_multi into a C function to avoid the usage of GNU extension. Tested on qemu without regression. OK to install? thanks Carrot ChangeLog: 2011-04-08 Wei Guozhi car...@google.com PR target/47855 * config/arm/arm-protos.h

[patch, ARM] PR48250, rehaul arm_legitimize_reload_address()

2011-04-08 Thread Chung-Lin Tang
Hi Richard, here's a new patch, with some quite significant changes to arm_legitimize_reload_address(). This time fully utilizing the sign-magnitude offset macro you gave in the last thread, and adapting your description into embedded comments. The reload_outdf pattern caused some regressions in

Re: FDO usability patch -- correct insane profile data

2011-04-08 Thread Richard Guenther
On Fri, Apr 8, 2011 at 1:39 AM, Xinliang David Li davi...@google.com wrote: Hi please review the attached patch. Ok when bootstrap and test finish? Ok. Thanks, Richard. Thanks, David 2011-04-07  Xinliang David Li  davi...@google.com        * ipa-cp.c (ipcp_update_profiling): Correct

Re: FDO usability -- sanity check indirect call target

2011-04-08 Thread Richard Guenther
On Fri, Apr 8, 2011 at 8:06 AM, Xinliang David Li davi...@google.com wrote: Hi, due to race conditions, it is common that the value profile information for an indirect call site is 'corrupted' -- resulting in false target function to be recorded. The value profile transformation won't cause

Re: [Ping #2][Patch, testsuite]: Don't xfail sibcalls on AVR

2011-04-08 Thread Georg-Johann Lay
Gerald Pfeifer schrieb: On Wed, 6 Apr 2011, Georg-Johann Lay wrote: I signed a fsf copyright assignment. AFAIK there is no automatism that grants write access when copyright assignment is approved. Yes, this is correct. I would have to be maintainer or something like that. Nope. All

[PATCH] Abstract call stmt function type

2011-04-08 Thread Richard Guenther
This prepares a patch that makes the type of the called function explicit in gimple calls rather than taking this information from the called function pointer. It introduces a gimple_call_fntype accessor that the replaces TREE_TYPE (TREE_TYPE (gimple_call_fn ( pattern used everywhere (which

Re: [PATCH] Fix PR48467

2011-04-08 Thread Diego Novillo
On Wed, Apr 6, 2011 at 11:47, Richard Guenther rguent...@suse.de wrote: 2011-04-06  Richard Guenther  rguent...@suse.de        PR lto/48467        * toplev.c (lang_dependent_init): Do not open asm_out_file        in WPA mode, nor perform debug machinery initialization.        (finalize): Do

New German PO file for 'gcc' (version 4.6.0)

2011-04-08 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the German team of translators. The file is available at: http://translationproject.org/latest/gcc/de.po (This file, 'gcc-4.6.0.de.po', has just

Re: [gc-improv] Permanent vs function RTL obstack fix

2011-04-08 Thread Laurynas Biveinis
2011/4/8 Steven Bosscher stevenb@gmail.com:        * stmt.c (label_rtx): Allocate RTX in permanent RTL memory. That looks strange, labels should be function specific, except non-local labels. Maybe you can get away with allocating DECL_NONLOCAL labels on the permanent rtl obstack? That's

[PATCH, committed] Fix PR 48272

2011-04-08 Thread Andrey Belevantsev
Hello, This is the case when sched-pressure support is not ready for new insns appearing during scheduling. (Found with the crazy set of options on ia64, where register pressure is not much of an issue.) Anyways, the fix is simply initializing the proper data structures at the point where

Re: [pph] Macro Validation (issue4379044)

2011-04-08 Thread Diego Novillo
On Thu, Apr 7, 2011 at 13:54, Lawrence Crowl cr...@google.com wrote: *** pth_save_token_cache (cp_token_cache *ca *** 448,453 --- 448,454    pph_output_uint (f, num);    for (i = 0, tok = cache-first; i num; tok++, i++)      pth_save_token (tok, f); +  } Extra

Re: Fix PR48389: ICE in make_edges

2011-04-08 Thread Michael Matz
Hi, On Fri, 8 Apr 2011, Jakub Jelinek wrote: On Fri, Apr 08, 2011 at 03:33:49PM +0200, Michael Matz wrote: --- testsuite/gcc.target/i386/pr48389.c (revision 0) +++ testsuite/gcc.target/i386/pr48389.c (revision 0) @@ -0,0 +1,12 @@ +/* PR middle-end/48389 */ +/* { dg-do compile

Re: [patch libjava]: Do some fixes for windows native targets

2011-04-08 Thread Kai Tietz
2011/4/8 Tom Tromey tro...@redhat.com: Kai == Kai Tietz ktiet...@googlemail.com writes: Kai I added to headers.txt the changes and regenerate headers.  Btw it is Kai a bit tricky to enable for libjava the maintainer-mode and then have a Kai successful configure for it ... [...] Kai Sorry,

Re: [gc-improv] Permanent vs function RTL obstack fix

2011-04-08 Thread Richard Guenther
On Fri, Apr 8, 2011 at 4:36 PM, Jeff Law l...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/08/11 07:21, Laurynas Biveinis wrote: 2011/4/8 Steven Bosscher stevenb@gmail.com:        * stmt.c (label_rtx): Allocate RTX in permanent RTL memory. That looks strange,

Re: [gc-improv] Permanent vs function RTL obstack fix

2011-04-08 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/08/11 08:39, Richard Guenther wrote: On Fri, Apr 8, 2011 at 4:36 PM, Jeff Law l...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/08/11 07:21, Laurynas Biveinis wrote: 2011/4/8 Steven Bosscher stevenb@gmail.com:

[testsuite] fix to gcc.target/arm/sync-1.c

2011-04-08 Thread Janis Johnson
Test gcc.target/arm/sync-1.c specifies -march=armv7-a and fails execution for multilibs whose hardware or simulator doesn't support that architecture. The test uses __sync_fetch_and_add, which GCC doesn't support for all arm targets. Using the -march option allows it to compile if the multilib

Re: patch to fix PR 48435

2011-04-08 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/07/11 13:41, Vladimir Makarov wrote: The following patch should solve problem http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48435. It might solve other latest IRA problems too including performance related ones. The patch is for targets

Re: [PATCH] use use_reg in several backends

2011-04-08 Thread Richard Henderson
On 04/05/2011 10:55 AM, Nathan Froyd wrote: * config/alpha/alpha.c (alpha_emit_xfloating_libcall): Call use_reg. * config/xtensa/xtensa.c (xtensa_call_tls_desc): Likewise. * config/sparc/sparc.c (sparc_legitimize_tls_address): Likewise. Ok. r~

[PATCH][RFC] Make called function type explicit, make function pointer type conversions useless

2011-04-08 Thread Richard Guenther
This is the real fix for PR46076 that I wanted to persue. Make function pointer type conversions useless as to more aggressively be able to turn indirect into direct calls. This requires that we preserve the original type signature of the called function as presented by the frontend. The patch

Re: Simple enhancement to -dA dump

2011-04-08 Thread Xinliang David Li
On Fri, Apr 8, 2011 at 5:04 AM, Diego Novillo dnovi...@google.com wrote: On 04/03/2011 08:54 PM, Xinliang David Li wrote: + +      fprintf (file, # BLOCK %d, bb-index); +      if (bb-frequency) +        fprintf (file, freq:%d, bb-frequency); +      if (bb-count) +        fprintf (file,

Re: Simple enhancement to -dA dump

2011-04-08 Thread Diego Novillo
On Fri, Apr 8, 2011 at 12:20, Xinliang David Li davi...@google.com wrote:   /* Output the insns.  */   for (insn = first; insn;)     { @@ -1721,8 +1788,19 @@ final (rtx first, FILE *file, int optimi        insn_current_address = INSN_ADDRESSES (INSN_UID (insn));  #endif /* HAVE_ATTR_length

[committed] Fix secondary reload support for PA shift amount register

2011-04-08 Thread John David Anglin
Recent changes to the ira code exposed problems in handling secondary reloads for copies between the shift amount register and floating point registers. This requires an intermediate general register. I also saw a case where reload tried to stuff a SFmode value into the shift amount register

Re: patch to fix PR 48435

2011-04-08 Thread Graham Stott
Vladimir, The wrong PR 4435 was in referrenced the commit --- On Fri, 8/4/11, Jeff Law l...@redhat.com wrote: From: Jeff Law l...@redhat.com Subject: Re: patch to fix PR 48435 To: Vladimir Makarov vmaka...@redhat.com Cc: gcc-patches gcc-patches@gcc.gnu.org Date: Friday, 8 April, 2011,

Re: patch to fix PR 48435

2011-04-08 Thread Vladimir Makarov
On 04/08/2011 01:28 PM, Graham Stott wrote: Vladimir, The wrong PR 4435 was in referrenced the commit Thanks, Graham. I've just fixed it. I should change my keyboard. This is not the first time when some symbols are missed.

Re: [PATCH PING] c++-specific bits of tree-slimming patches

2011-04-08 Thread Jason Merrill
On 03/24/2011 09:15 AM, Nathan Froyd wrote: The C++-specific bits of these patches: [PATCH 02/18] enforce TREE_CHAIN and TREE_TYPE accesses http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00557.html OK. [PATCH 07/18] generalize build_case_label to the rest of the compiler

Re: [PATCH] Fix LTO bootstrap on i686-linux (problem with two Ldebug_info0 labels; PR bootstrap/48148)

2011-04-08 Thread Jason Merrill
On 04/05/2011 10:19 AM, Jakub Jelinek wrote: i686-linux LTO bootstrap currently fails, because in one partition we emit .Ldebug_info0 label twice. The problem is that resolve_addr for call_site support attempts to force_decl_die external function decls, and at least with LTO that in turn can

Ping Re: Target header etc. cleanup patch

2011-04-08 Thread Joseph S. Myers
Ping. This patch http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00130.html is pending review. The updated version http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00199.html (with one bit that had been committed separately removed) applies cleanly to current trunk. -- Joseph S. Myers

Re: Ping Re: Target header etc. cleanup patch

2011-04-08 Thread Mike Stump
On Apr 8, 2011, at 11:46 AM, Joseph S. Myers wrote: Ping. This patch http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00130.html is pending 011-04-02 Joseph Myers joseph:codesourcery.com This is wrong, it should use @ instead of :. :-) I glanced at the rest (in part to see if there were

Re: [pph] Macro Validation (issue4379044)

2011-04-08 Thread Tom Tromey
Lawrence == Lawrence Crowl cr...@google.com writes: Diego Hm, and 5 bits are still enough for directive_index? Lawrence Yes there are enough. I added a comment at the table definition Lawrence to ensure that future changes keep it so. I suggest a static assertion of some kind. Or in lieu of

[Ada] Fix ICE on array type with aggregate component as bound

2011-04-08 Thread Eric Botcazou
The compiler aborts on the declaration of an array type whose upper bound is a component of an aggregate whose nominal subtype is a discriminated record type which contains a component whose nominal subtype is a volatile discriminated record type with a variant part and a size clause. Tested on

Re: [patch i386]: Cleanup calling convention handling in i386.c and fix PR target/9601 and PR target/11772

2011-04-08 Thread Richard Henderson
+ /* Special case regparm/sseregparm, which are either cdecl or stdcall. */ + if ((ret (IX86_CALLCVT_REGPARM | IX86_CALLCVT_SSEREGPARM)) != 0) +return (ret | ((TARGET_RTD !stdarg_p (type)) ? IX86_CALLCVT_STDCALL + :

Re: [PATCH] Fix LTO bootstrap on i686-linux (problem with two Ldebug_info0 labels; PR bootstrap/48148)

2011-04-08 Thread Richard Guenther
On Fri, 8 Apr 2011, Jakub Jelinek wrote: On Fri, Apr 08, 2011 at 01:58:14PM -0400, Jason Merrill wrote: On 04/05/2011 10:19 AM, Jakub Jelinek wrote: i686-linux LTO bootstrap currently fails, because in one partition we emit .Ldebug_info0 label twice. The problem is that resolve_addr for

Re: FDO usability -- sanity check indirect call target

2011-04-08 Thread Xinliang David Li
Please review this patch. Regression test is ok. I will do more application testing to make sure the check is not too strict (filtering out legal ic targets). Thanks, David 2011-04-07 Xinliang David Li davi...@google.com * value-profile.c (function_decl_num_args): New function.

Re: [patch, fortran] More control over front end optimization

2011-04-08 Thread Thomas Koenig
Hello Mikael and Daniel, thanks for the reviews. Here is what I committed as rev. 172215. I tried to be a little bit more specific in the doc, but couldn't think of a better name for the options without trying to win a prize for Gcc's longest option name. Thomas 2011-04-08 Thomas

Fix PR48484

2011-04-08 Thread Xinliang David Li
Hi, this patch fixes the test failure. OK after bootstrap and regression test? Thanks, David 2011-04-08 Xinliang David Li davi...@google.com PR tree-optimization/PR48484 * tree-ssa-uninit.c (convert_control_dep_chain_into_preds): Set has_valid_pred lazily 2011-04-08

Re: [testsuite] fix to gcc.target/arm/pr43698.c

2011-04-08 Thread Mike Stump
On Apr 8, 2011, at 8:07 AM, Janis Johnson wrote: Test gcc.target/arm/pr43698.c specifies -march=armv7-a and fails execution for multilibs whose hardware or simulator doesn't support that architecture. Ideally, I'd like target people to weigh in on target changes, ssa people to weigh in on ssa