FDO usage: -Wcoverage-mismatch should not ignore -Wno-error

2011-04-19 Thread Xinliang David Li
-Wcoverage-mismatch is enabled by default, and the warning is promoted to error by default. However in the current implementation -Wno-error can not demote the error back to warning. The patch was ported from one contributed by Neil. OK for trunk after regression testing? 2011-04-18 Neil

Re: [Patch, fortran] Use xcalloc instead of gfc_getmem

2011-04-19 Thread Janne Blomqvist
On Mon, Apr 18, 2011 at 23:50, Steve Kargl s...@troutmask.apl.washington.edu wrote: On Mon, Apr 18, 2011 at 11:41:33PM +0300, Janne Blomqvist wrote: Hi, the attached patch replaces gfc_getmem with calls to xcalloc (from libiberty). Apart from reducing duplicated code, calloc is better than

Re: [Patch, fortran] Use xcalloc instead of gfc_getmem

2011-04-19 Thread Jakub Jelinek
On Tue, Apr 19, 2011 at 10:41:33AM +0300, Janne Blomqvist wrote: On Mon, Apr 18, 2011 at 23:50, Steve Kargl s...@troutmask.apl.washington.edu wrote: On Mon, Apr 18, 2011 at 11:41:33PM +0300, Janne Blomqvist wrote: Hi, the attached patch replaces gfc_getmem with calls to xcalloc (from

Re: FDO usage: -Wcoverage-mismatch should not ignore -Wno-error

2011-04-19 Thread Richard Guenther
On Tue, Apr 19, 2011 at 9:13 AM, Xinliang David Li davi...@google.com wrote: -Wcoverage-mismatch is enabled by default, and the warning is promoted to error by default. However in the current implementation -Wno-error can not demote the error back to warning. The patch was ported from one

[vms] committed: add wrappers for ld and ar

2011-04-19 Thread Tristan Gingold
Hi, as the native vms linker ('link') doesn't follow at all the unix convention, we need to convert and massage the command line before invoking the native linker. The easiest and least intrusive way is the use of a wrapper. It deals with command line length limitation, filename, extension,

Re: [Patch,AVR]: PR18145: do_copy_data do_clear_bss only if needed

2011-04-19 Thread Georg-Johann Lay
Anatoly Sokolov schrieb: Hi. +/* To track if code will use .bss and/or .data */ +static int avr_need_clear_bss_p = 0; +static int avr_need_copy_data_p = 0; Change type avr_need_clear_bss_p and avr_need_copy_data_p vars to bool. [ASM_OUTPUT_COMMON] Use ASM_OUTPUT_ALIGNED_DECL_COMMON

[PATCH] Fix PR46188

2011-04-19 Thread Richard Guenther
This fixes PR46188 on the 4.5 branch by backporting rev. 159907. Instead of carrying over the checking bits I simply removed them on the branch (they had one trivial fallout originally, PR44295). Bootstrapped and tested on x86_64-unknown-linux-gnu, {,-m32} for all languages including Ada and

Re: [Patch,AVR]: FIX ICE in optabs due to bad rotate expander.

2011-04-19 Thread Georg-Johann Lay
Denis Chertykov schrieb: 2011/4/18 Georg-Johann Lay a...@gjlay.de: Denis Chertykov schrieb: 2011/4/17 Denis Chertykov cherty...@gmail.com: 2011/4/15 Georg-Johann Lay a...@gjlay.de: Finally, I exposed alternative #3 of the insns to the register allocator, because it is not possible to

Re: PR target/46329: Reject Neon structure constants

2011-04-19 Thread Richard Earnshaw
On Mon, 2011-04-18 at 11:12 +0100, Richard Sandiford wrote: Richard Earnshaw rearn...@arm.com writes: I'm uncomfortable about this. Generally the ARM port doesn't work well with the target-independent constant pool and it's better to assert that this is empty when it comes to final

Re: Fix PR47976

2011-04-19 Thread Richard Guenther
On Tue, Apr 12, 2011 at 6:18 PM, Jeff Law l...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/07/11 04:47, Bernd Schmidt wrote: PR47976 is a followup to PR47166; the patch there caused this problem. The problem occurs in reload. There are two autoinc addresses which

[google] remove redundant push {lr} for -mthumb (issue4441050)

2011-04-19 Thread Guozhi Wei
Reload pass tries to determine the stack frame, so it needs to check the push/pop lr optimization opportunity. One of the criteria is if there is any far jump inside the function. Unfortunately at this time gcc can't decide each instruction's length and basic block layout, so it can't know the

Re: [Patch,AVR]: FIX ICE in optabs due to bad rotate expander.

2011-04-19 Thread Denis Chertykov
2011/4/19 Georg-Johann Lay a...@gjlay.de: How can add, sub etc. be split? This would need an explicit representation of carry. Yes. Look at http://gcc.gnu.org/ml/gcc/2005-03/msg00871.html Denis.

Re: [google] remove redundant push {lr} for -mthumb (issue4441050)

2011-04-19 Thread Richard Guenther
On Tue, Apr 19, 2011 at 11:41 AM, Guozhi Wei car...@google.com wrote: Reload pass tries to determine the stack frame, so it needs to check the push/pop lr optimization opportunity. One of the criteria is if there is any far jump inside the function. Unfortunately at this time gcc can't decide

Re: [google] remove redundant push {lr} for -mthumb (issue4441050)

2011-04-19 Thread Carrot Wei
On Tue, Apr 19, 2011 at 5:57 PM, Richard Guenther richard.guent...@gmail.com wrote: On Tue, Apr 19, 2011 at 11:41 AM, Guozhi Wei car...@google.com wrote: Reload pass tries to determine the stack frame, so it needs to check the push/pop lr optimization opportunity. One of the criteria is if

Re: [Patch,AVR]: FIX ICE in optabs due to bad rotate expander.

2011-04-19 Thread Georg-Johann Lay
Denis Chertykov schrieb: 2011/4/19 Georg-Johann Lay a...@gjlay.de: How can add, sub etc. be split? This would need an explicit representation of carry. Yes. Look at http://gcc.gnu.org/ml/gcc/2005-03/msg00871.html Just skimmed the conversation. I thought about making AVR ISA's effects on

Re: [patch] Fix PR lto/48148

2011-04-19 Thread Jakub Jelinek
On Mon, Apr 18, 2011 at 11:45:03PM +0200, Eric Botcazou wrote: 2011-04-18 Eric Botcazou ebotca...@adacore.com PR lto/48148 * gimple.c (gimple_types_compatible_p_1) ENUMERAL_TYPE: Do not merge the types if they have different enumeration identifiers. While I think it is a

Re: [patch] Fix PR lto/48148

2011-04-19 Thread Richard Guenther
On Tue, Apr 19, 2011 at 12:21 PM, Jakub Jelinek ja...@redhat.com wrote: On Mon, Apr 18, 2011 at 11:45:03PM +0200, Eric Botcazou wrote: 2011-04-18  Eric Botcazou  ebotca...@adacore.com       PR lto/48148       * gimple.c (gimple_types_compatible_p_1) ENUMERAL_TYPE: Do not       merge the

[Patch, Fortran] PR 48588 - (4.6/4.7 regression) Resolve whole TU before generating code

2011-04-19 Thread Tobias Burnus
Currently, gfortran ships (trans*.c) MODULEs directly while it waits until the end for subroutines, functions and PROGRAM. The latter are then first all resolved and afterwards the middle-end code is generated. In the PR this shows an issue: The a module procedure calls an external subroutine

Re: [PATCH] Fix incorrect devirtualization (PR middle-end/48661)

2011-04-19 Thread Jan Hubicka
On Tue, 19 Apr 2011, Jan Hubicka wrote: Huh. No, I don't think we want to do any inlining as part of folding. At least not if it is a correctness issue (is it?). Why does the inliner not simply inline the thunk function body? Because thunk functions have no bodies in

[PATCH][LTO] Fix PR48207, ICE in lhd_set_decl_assembler_name

2011-04-19 Thread Richard Guenther
This avoids ICEing in the default decl-assembler-name hook during compile-time. We are not yet prepared for a world where all important mangling is done before/during free-lang-data, and the default langhook implementation surely isn't the one that would assert so. The following patch simply

Re: [PATCH] Fix incorrect devirtualization (PR middle-end/48661)

2011-04-19 Thread Richard Guenther
On Tue, 19 Apr 2011, Jan Hubicka wrote: On Tue, 19 Apr 2011, Jan Hubicka wrote: Huh. No, I don't think we want to do any inlining as part of folding. At least not if it is a correctness issue (is it?). Why does the inliner not simply inline the thunk function body?

[patch] Add missing test for DECL_NO_INLINE_WARNING_P

2011-04-19 Thread Eric Botcazou
Hi, tree_inlinable_function_p issues the -Winline warning only if /* We only warn for functions declared `inline' by the user. */ do_warning = (warn_inline DECL_DECLARED_INLINE_P (fn) !DECL_NO_INLINE_WARNING_P (fn) !DECL_IN_SYSTEM_HEADER

[testsuite]: Skip some tests for avr

2011-04-19 Thread Georg-Johann Lay
This patchlet skips some tests for avr because int is just 16 bits there. Johann testsuite/ 2011-04-19 Georg-Johann Lay a...@gjlay.de * gcc.c-torture/compile/pr43191.c: Skip avr due to 16-bit int. * gcc.dg/torture/pr43165.c: Ditto. * gcc.dg/torture/pr47228.c: Ditto.

Re: [Patch,AVR]: FIX ICE in optabs due to bad rotate expander.

2011-04-19 Thread Richard Earnshaw
On Tue, 2011-04-19 at 15:17 +0400, Denis Chertykov wrote: 2011/4/19 Georg-Johann Lay a...@gjlay.de: Denis Chertykov schrieb: 2011/4/19 Georg-Johann Lay a...@gjlay.de: How can add, sub etc. be split? This would need an explicit representation of carry. Yes. Look at

Re: [google] remove redundant push {lr} for -mthumb (issue4441050)

2011-04-19 Thread Richard Earnshaw
On Tue, 2011-04-19 at 17:41 +0800, Guozhi Wei wrote: Reload pass tries to determine the stack frame, so it needs to check the push/pop lr optimization opportunity. One of the criteria is if there is any far jump inside the function. Unfortunately at this time gcc can't decide each

Re: [PATCH][LTO] Fix PR48207, ICE in lhd_set_decl_assembler_name

2011-04-19 Thread Diego Novillo
On Tue, Apr 19, 2011 at 06:51, Richard Guenther rguent...@suse.de wrote: 2011-04-19  Richard Guenther  rguent...@suse.de        PR lto/48207        * tree.c (free_lang_data): Do not reset the decl-assembler-name        langhook.        * g++.dg/lto/pr48207_0.C: New testcase. OK, if it's

[PATCH] Don't use ./tmp0 for site.exp generation

2011-04-19 Thread Richard Guenther
This patch sits in all my development trees because delta uses tmp? named directories for storing intermediate files. This causes a make check to fail. Maybe there is an even better way to create a truly temporary file name (that is even portable), but the following patch simply avoids using

Re: [PATCH] Don't use ./tmp0 for site.exp generation

2011-04-19 Thread Rainer Orth
Richard Guenther rguent...@suse.de writes: This patch sits in all my development trees because delta uses tmp? named directories for storing intermediate files. This causes a make check to fail. Maybe there is an even better way to create a truly temporary file name (that is even

Re: [PATCH] Fix incorrect devirtualization (PR middle-end/48661)

2011-04-19 Thread Richard Guenther
On Tue, 19 Apr 2011, Jan Hubicka wrote: I thought the idea was to use __builtin_va_arg_pack and friends. Of course the inliner would still need to know how to inline such a va-arg forwarder, and we would need a way to expand them (well, or just go the existing special casing). We might

Fix hot/cold code in ipa-cp

2011-04-19 Thread Jan Hubicka
Hi, while removing use of optimize_function_for_size_p from the ipa-inliner (since we already check cgraph_maybe_hot_edge_p that include the test), I noticed that optimize_function_for_size_p (DECL_STRUCT_FUNCTION (node-decl)) won't give the expected results on WPA when DECL_STRUCT_FUNCTION is

Re: [PATCH][ARM] New testcases for NEON

2011-04-19 Thread Richard Earnshaw
On Wed, 2011-04-13 at 16:59 +0100, Andrew Stubbs wrote: Hi, This old patch has been carried in the CodeSourcery toolchain for some time now. It just adds a few new testcases for vectorization. OK? Andrew OK. 2008-12-03 Daniel Jacobowitz d...@codesourcery.com gcc/testsuite/

Re: Make vectoriser use operand_equal_p to compare base addresses

2011-04-19 Thread Richard Guenther
On Tue, Apr 19, 2011 at 4:59 PM, Richard Sandiford richard.sandif...@linaro.org wrote: In the attached testcase, we treat:    sum += x[i][0] * x[i][0] + x[i][1] * x[i][1]; as being two independent strided loads: x[i][0] and x[i][1]. On targets with appropriate support, we therefore use two

Re: [Patch, Fortran] PR 48588 - (4.6/4.7 regression) Resolve whole TU before generating code

2011-04-19 Thread Mikael Morin
On Tuesday 19 April 2011 12:36:11 Tobias Burnus wrote: Build and regtested on x86-64-linux. OK for the trunk - and after some grace period - for the 4.6 branch? Yes. Do you think we could have a case where we have to delay module namespace resolving as well (which we can't as we have to

Re: [google] Install cpu_defines.h (issue4440044)

2011-04-19 Thread Diego Novillo
On Tue, Apr 19, 2011 at 12:04, Benjamin Kosnik b...@redhat.com wrote: This patch adds cpu_defines.h to the set of files to be installed. Doug, could you describe why we need to do this?  Will you be submitting this patch for trunk? It's already in trunk, see D'oh. Thanks. Clearly, I was

Re: [PATCH] Disallow i?86/x86_64 movstrictmode for subregs of non-MODE_INT regs (PR target/48678)

2011-04-19 Thread Uros Bizjak
On Tue, Apr 19, 2011 at 4:59 PM, Jakub Jelinek ja...@redhat.com wrote: Since MEM_REF has been added, we can unlike in 4.5 and earlier, arbitrary VCEs on the LHS.  Reload isn't able to reload (strict_low_part (subreg:HI (reg:V2DI ...))) on the LHS, while it probably should be taught to do

[gomp3.1] Allow pointers and cray pointers in firstprivate/lastprivate, handle not allocated allocatable in firstprivate

2011-04-19 Thread Jakub Jelinek
Hi! This patch includes assorted OpenMP 3.1 changes for Fortran. Haven't changed COPYIN with not allocated allocatables yet, waiting for explanation on OpenMP forum there. 2011-04-19 Jakub Jelinek ja...@redhat.com PR fortran/46752 * trans-openmp.c (gfc_omp_clause_copy_ctor):

Re: Improve stack layout heuristic.

2011-04-19 Thread Easwaran Raman
On Tue, Apr 19, 2011 at 5:08 AM, Michael Matz m...@suse.de wrote: Hi, On Mon, 18 Apr 2011, Easwaran Raman wrote: @@ -596,7 +581,7 @@    if (vb-conflicts)      {        EXECUTE_IF_SET_IN_BITMAP (vb-conflicts, 0, u, bi) -     add_stack_var_conflict (a,

Re: [build, doc] Remove --enable-threads=solaris support

2011-04-19 Thread Rainer Orth
Hi Ralf, Can't gcc/gthr-tpf.h go, too? What about gcc/gthr-nks.h? they are both used: config.gcc (s390x-ibm-tpf*) has thread_file='tpf', and i[3456x]86-*-netware* uses thread_file='nks'. I checked for references to the existing gthr-*.h files for the cleanup patch. Thanks. Rainer --

Re: [google] Install cpu_defines.h (issue4440044)

2011-04-19 Thread 關振德
This is used for a freestanding C++ library (i.e., we build libsupc++.a only). This is in trunk but for some reason it is not in the 4.6 release. -Doug On Sat, Apr 16, 2011 at 1:27 PM, Diego Novillo dnovi...@google.com wrote: I am committing this patch from Doug Kwan on google/main. This

Re: [testsuite]: Skip some tests for avr

2011-04-19 Thread Georg-Johann Lay
Hans-Peter Nilsson schrieb: On Tue, 19 Apr 2011, Georg-Johann Lay wrote: This patchlet skips some tests for avr because int is just 16 bits there. 2011-04-19 Georg-Johann Lay a...@gjlay.de * gcc.c-torture/compile/pr43191.c: Skip avr due to 16-bit int. *

Re: [google] Install cpu_defines.h (issue4440044)

2011-04-19 Thread Paolo Carlini
On 04/19/2011 07:26 PM, Doug Kwan (關振德) wrote: This is used for a freestanding C++ library (i.e., we build libsupc++.a only). This is in trunk but for some reason it is not in the 4.6 release. Why do you think so? For sure upon approval you committed it to the branch too, on March, 15th.

Re: [build, lto] Only accept -fuse-linker-plugin if linker supports -plugin (PR lto/46944)

2011-04-19 Thread Rainer Orth
Hi Ralf, I haven't found if there are provisions for in-tree gold, though, and still cannot test that. I'm not quite sure I understand this statement. I built a combined tree with gold enabled a while ago (must've been several months now). I might be misunderstanding this. I suppose I've

Re: [build, lto] Only accept -fuse-linker-plugin if linker supports -plugin (PR lto/46944)

2011-04-19 Thread Rainer Orth
Paolo Bonzini bonz...@gnu.org writes: On 04/04/2011 06:15 PM, Rainer Orth wrote: I haven't found if there are provisions for in-tree gold, though, and still cannot test that. In-tree gold definitely works (or should). My problem is simply that gold doesn't work on Solaris at all, either

Re: [Patch, fortran] Use xcalloc instead of gfc_getmem

2011-04-19 Thread Janne Blomqvist
On Tue, Apr 19, 2011 at 10:46, Jakub Jelinek ja...@redhat.com wrote: On Tue, Apr 19, 2011 at 10:41:33AM +0300, Janne Blomqvist wrote: On Mon, Apr 18, 2011 at 23:50, Steve Kargl s...@troutmask.apl.washington.edu wrote: On Mon, Apr 18, 2011 at 11:41:33PM +0300, Janne Blomqvist wrote: Hi,

Re: [Patch,AVR]: PR18145: do_copy_data do_clear_bss only if needed

2011-04-19 Thread Anatoly Sokolov
Hi. This patch now uses the same procedure like elfos.h ... +#define ASM_OUTPUT_ALIGNED_DECL_COMMON(STREAM, DECL, NAME, SIZE, ALIGN) \ + avr_asm_output_aligned_common (STREAM, NAME, SIZE, ALIGN, false) .. +#define ASM_OUTPUT_ALIGNED_DECL_LOCAL(STREAM, DECL, NAME, SIZE, ALIGN) \ +

Re: [Patch, fortran] Use xcalloc instead of gfc_getmem

2011-04-19 Thread Jakub Jelinek
On Tue, Apr 19, 2011 at 08:46:17PM +0300, Janne Blomqvist wrote: Oh, those macros are nice. I updated the patch to use them instead, except for one case where the usage didn't fit the XCNEW(VEC) API and I used xcalloc directly instead. Here's what I committed: For that remaining case there is

Re: [build] Support multilib testing in libgo

2011-04-19 Thread Rainer Orth
Hi Ralf, * Rainer Orth wrote on Mon, Apr 04, 2011 at 08:19:19PM CEST: To avoid this mess, I'm instead setting LD_LIBRARY_PATH in CHECK. While this isn't exactly portable (some platforms, especially Darwin and HP-UX, use different variables), it's at least more widespread than -R. Toplevel

Re: [Patch, fortran] Use xcalloc instead of gfc_getmem

2011-04-19 Thread Janne Blomqvist
On Tue, Apr 19, 2011 at 20:53, Jakub Jelinek ja...@redhat.com wrote: On Tue, Apr 19, 2011 at 08:46:17PM +0300, Janne Blomqvist wrote: Oh, those macros are nice. I updated the patch to use them instead, except for one case where the usage didn't fit the XCNEW(VEC) API and I used xcalloc

[patch, fortran] PR 48405 - Front end expressions in DO loops

2011-04-19 Thread Thomas Koenig
Hello world, this patch fixes the enhancement PR, plus probably a few regressions. The basic problem was that the code walker got confused when *c, the pointer to the current gfc_code statement, was changed by inserting additional code. Currently regression-testing. OK for trunk if the

Re: [Patch,AVR]: PR18145: do_copy_data do_clear_bss only if needed

2011-04-19 Thread Anatoly Sokolov
Please use ASM_OUTPUT_ALIGNED_DECL_COMMON and ASM_OUTPUT_ALIGNED_DECL_LOCAL macros here. Confused. These macros are used. Johann Sorry... Im look on function name not on macro definition. I agree with the patch. Please wait day or two if Denis would not object, commit patch.

Re: [google]Pass --save-temps to the assembler (issue4436049)

2011-04-19 Thread Diego Novillo
On Tue, Apr 19, 2011 at 15:02, Easwaran Raman era...@google.com wrote: This makes the gcc driver pass the --save-temps option to the assembler or assembler wrapper so that post-assembly tools like MAO can be integrated. Bootstraps on x86_64. Ok for google/main? 2011-04-19  Easwaran Raman  

Re: [Patch,AVR]: PR18145: do_copy_data do_clear_bss only if needed

2011-04-19 Thread Denis Chertykov
2011/4/19 Anatoly Sokolov ae...@post.ru: Please use ASM_OUTPUT_ALIGNED_DECL_COMMON and ASM_OUTPUT_ALIGNED_DECL_LOCAL macros here. Confused. These macros are used. Johann Sorry... Im look on function name not on macro definition. I agree with the patch. Please wait day or two if

Re: [Patch,AVR]: PR18145: do_copy_data do_clear_bss only if needed

2011-04-19 Thread Richard Henderson
On 04/18/2011 10:20 AM, Georg-Johann Lay wrote: +avr_asm_named_section (const char *name, unsigned int flags, tree decl) +{ + if (!avr_need_copy_data_p) +avr_need_copy_data_p = ((0 == strncmp (name, .data, 5) + || 0 == strncmp (name, .rodata, 7) +

Re: [google]Pass --save-temps to the assembler (issue4436049)

2011-04-19 Thread Easwaran Raman
On Tue, Apr 19, 2011 at 12:19 PM, Diego Novillo dnovi...@google.com wrote: On Tue, Apr 19, 2011 at 15:02, Easwaran Raman era...@google.com wrote: This makes the gcc driver pass the --save-temps option to the assembler or assembler wrapper so that post-assembly tools like MAO can be integrated.

RE: [Patch,AVR]: PR18145: do_copy_data do_clear_bss only if needed

2011-04-19 Thread Weddington, Eric
-Original Message- From: Richard Henderson [mailto:r...@redhat.com] Sent: Tuesday, April 19, 2011 1:31 PM To: Georg-Johann Lay Cc: gcc-patches@gcc.gnu.org; Weddington, Eric; Denis Chertykov; Anatoly Sokolov Subject: Re: [Patch,AVR]: PR18145: do_copy_data do_clear_bss only if

Re: FDO usability patch -- cfg and lineno checksum

2011-04-19 Thread Xinliang David Li
The attached is the revised patch with a warning suggested for cases when CFG matches, but source locations change. Ok for trunk? thanks, David On Sun, Apr 17, 2011 at 8:36 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi,  in current FDO implementation, the source file version used in

better wpa [1/n]: merge types during read-in

2011-04-19 Thread Michael Matz
Hi, I have a backlog of random improvements to the WPA phase of LTO compilations, all with the common goal of reducing peak memory usage. I was basically dumping all trees that the WPA phase read in, and then tried to think about which trees can be merged with already existing ones very

FDO usability: pid handling

2011-04-19 Thread Xinliang David Li
Hi, Insane value profile data may contain indirect call targets with wrong (corrupted) pids. r172276 solves the problem when the pid refers to a bogus target that is still 'alive'. This patch addresses the issue when the bogus target is already eliminated or pid is too large. OK after testing?

Re: [Patch,AVR]: PR18145: do_copy_data do_clear_bss only if needed

2011-04-19 Thread Georg-Johann Lay
Georg-Johann Lay schrieb: When I wrote this patch I looked at the default linker script to see what goes into .data resp .bss; the hard-coded section maned reflect .names that. For the linkonce stuff I found no explanation (grepping the

Re: [testsuite] Disable gcc.dg/guality and gfortran.dg/guality on Tru64 UNIX (PR testsuite/48251)

2011-04-19 Thread Steve Kargl
On Mon, Apr 18, 2011 at 05:54:28PM +0200, Rainer Orth wrote: As already done for the g++.dg/guality driver, I'm also disabling the remaining guality testsuites on Tru64 UNIX: the gcc.dg one doesn't even start: gdb: took too long to attach and the gfortran tests either fail or are

Re: [testsuite] Disable gcc.dg/guality and gfortran.dg/guality on Tru64 UNIX (PR testsuite/48251)

2011-04-19 Thread Steve Kargl
On Tue, Apr 19, 2011 at 02:06:13PM -0700, Steve Kargl wrote: On Mon, Apr 18, 2011 at 05:54:28PM +0200, Rainer Orth wrote: As already done for the g++.dg/guality driver, I'm also disabling the remaining guality testsuites on Tru64 UNIX: the gcc.dg one doesn't even start: gdb: took too

RE: [Patch,AVR]: PR18145: do_copy_data do_clear_bss only if needed

2011-04-19 Thread Weddington, Eric
-Original Message- From: Georg-Johann Lay [mailto:a...@gjlay.de] Sent: Tuesday, April 19, 2011 2:13 PM To: Weddington, Eric Cc: Richard Henderson; gcc-patches@gcc.gnu.org; Denis Chertykov; Anatoly Sokolov Subject: Re: [Patch,AVR]: PR18145: do_copy_data do_clear_bss only if

Go patch committed: Use backend interface for temporary variables

2011-04-19 Thread Ian Lance Taylor
This patch to the Go frontend uses the backend interface for temporary variables. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian 2011-04-19 Ian Lance Taylor i...@google.com * go-gcc.cc (Gcc_backend::temporary_variable): New function.

[patch testsuite committed] Skip gcc.dg/torture/pr37868.c on sh

2011-04-19 Thread Kaz Kojima
Hi, gcc.dg/torture/pr37868.c fails on SH because of unaligned accesses. The patch below skips the test as is done for sparc targets. It's tested with bootstrap and regtest on i686-pc-linux-gnu. Applied on trunk. Regards, kaz -- 2011-04-19 Kaz Kojima kkoj...@gcc.gnu.org PR

Re: [PATCH] make LABEL_DECL has its own rtx field for its associated CODE_LABEL

2011-04-19 Thread Nathan Froyd
On Tue, Apr 05, 2011 at 05:55:33PM +0200, Michael Matz wrote: I have a preference in having just one DECL_RTL field for conceptual reasons: Most DECLs are actually objects (there are some prominent exceptions, but those always would be better described with something like NAMED_ENTITY,

Re: FDO usability patch -- cfg and lineno checksum

2011-04-19 Thread Jan Hubicka
I can not review tree.c changes. I would probably suggest making crc_byte inline. +#if IN_LIBGCOV + +/* These functions are guarded by #if to avoid compile time warning. */ + +/* Return the number of words STRING would need including the length + field in the output stream itself.

Re: FDO usability: pid handling

2011-04-19 Thread Xinliang David Li
On Tue, Apr 19, 2011 at 2:38 PM, Jan Hubicka hubi...@ucw.cz wrote: Hi, Insane value profile data may contain indirect call targets with wrong (corrupted) pids.  r172276 solves the problem when the pid refers to a bogus target that is still 'alive'. This patch addresses the issue when the bogus

Go patch committed: Always use backend interface for statements

2011-04-19 Thread Ian Lance Taylor
All the statements have now been converted to use the backend interface. This patch changes the Statement class to use the backend interface, replacing the get_tree method with get_backend. This basically removes a bunch of calls to a temporary helper function to convert from Bstatement to tree.

Re: FDO usability: pid handling

2011-04-19 Thread Xinliang David Li
So between hashtab and VEC, which one do you prefer? Either one is fine with me. Thanks, David On Tue, Apr 19, 2011 at 3:39 PM, Jan Hubicka hubi...@ucw.cz wrote: Why is VEC any better in terms of density ? Are you suggesting using a hash table? It is not any better, but we usually use VEC

Re: better wpa [1/n]: merge types during read-in

2011-04-19 Thread Jan Hubicka
Hi, I have a backlog of random improvements to the WPA phase of LTO compilations, all with the common goal of reducing peak memory usage. I was basically dumping all trees that the WPA phase read in, and then tried to think about which trees can be merged with already existing ones very

Re: FDO usability: pid handling

2011-04-19 Thread Jan Hubicka
So between hashtab and VEC, which one do you prefer? Either one is fine with me. I would go with VEC. While the array will have holes, there are not many since the ids are originally assigned sequentially. Actually given that we do IPA pass now, I think you can just remove cgraph-pid field

Re: [PATCH] Fix incorrect devirtualization (PR middle-end/48661)

2011-04-19 Thread Jason Merrill
On 04/19/2011 12:07 AM, Jakub Jelinek wrote: On Mon, Apr 18, 2011 at 03:33:18PM -0700, Jason Merrill wrote: Well, it means that we do dynamic adjustment at runtime. If we're able to do devirtualization, we should be able to figure out the right offset as well, just not in 4.6. Sure, but

Go patch committed: statement.cc no longer includes gcc headers

2011-04-19 Thread Ian Lance Taylor
This patch to the Go frontend adjusts statement.cc so that it no longer includes any gcc headers. All operations are now done via the backend interface. There are four remaining files which includes gcc header files: export.cc, expressions.cc, gogo-tree.c, and types.cc. This patch bootstrapped

Re: FDO usability: pid handling

2011-04-19 Thread Jan Hubicka
On Tue, Apr 19, 2011 at 3:57 PM, Jan Hubicka hubi...@ucw.cz wrote: So between hashtab and VEC, which one do you prefer? Either one is fine with me. I would go with VEC.  While the array will have holes, there are not many since the ids are originally assigned sequentially.

Re: FDO usability: pid handling

2011-04-19 Thread Xinliang David Li
On Tue, Apr 19, 2011 at 4:30 PM, Jan Hubicka hubi...@ucw.cz wrote: On Tue, Apr 19, 2011 at 3:57 PM, Jan Hubicka hubi...@ucw.cz wrote: So between hashtab and VEC, which one do you prefer? Either one is fine with me. I would go with VEC.  While the array will have holes, there are not many

Re: FDO usability: pid handling

2011-04-19 Thread Jan Hubicka
Actually, among all the choices, funcdef_no is probably the most dense one -- it is for function decl with definition only. In LIPO, the Yes, funddef_no is densiest, but we don't really need great density here (in many other places we index arrays by cgraph_uid - it is intended for that

Re: FDO usability: pid handling

2011-04-19 Thread Xinliang David Li
On Tue, Apr 19, 2011 at 4:49 PM, Jan Hubicka hubi...@ucw.cz wrote: Actually, among all the choices, funcdef_no is probably the most dense one -- it is for function decl with definition only.  In LIPO, the Yes, funddef_no is densiest, but we don't really need great density here (in many other

C++ PATCH for c++/45267 (always_inline sorry in 4.5)

2011-04-19 Thread Jason Merrill
duplicate_decls was dropping DECL_DISREGARD_INLINE_LIMITS, but leaving the always_inline attribute in DECL_ATTRIBUTES, leading to confusion. This patch keeps them in sync. Tested x86_64-pc-linux-gnu, applying to trunk and 4.5 (not 4.6). commit 679e5e90918506d6792b8c0b19deff0f1a497298 Author:

Re: [google]Pass --save-temps to the assembler (issue4436049)

2011-04-19 Thread Easwaran Raman
On Tue, Apr 19, 2011 at 12:19 PM, Diego Novillo dnovi...@google.com wrote: On Tue, Apr 19, 2011 at 15:02, Easwaran Raman era...@google.com wrote: This makes the gcc driver pass the --save-temps option to the assembler or assembler wrapper so that post-assembly tools like MAO can be integrated.

Allow union variables to share stack slots wwith -fno-strict-aliasing (issue4444051)

2011-04-19 Thread Easwaran Raman
Hi, This patch allows variables whose type transitively contains a union to share stack slots if -fno-strict-aliasing is used. Bootstraps on x86_64 with no test regressions. Also tested by changing flag_strict_aliasing to 0 by default. Bootstraps and no test regressions when compared to

Fix FDO inliner ICE

2011-04-19 Thread Jan Hubicka
Hi, while cleaning up the way small functions inliner populate the heap I made simple thinko trying to compute summary information used for badness and the badness values themselves in one loop. Since only FDO badness computation depends on summaries this has passed my non-FDO testing.

[patch, committed] PR48602 Fix optimization issue

2011-04-19 Thread Jerry DeLisle
Committed the following after regression testing. i will update the test case when I get the chance. Jerry Author: jvdelisle Date: Wed Apr 20 04:18:25 2011 New Revision: 172753 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=172753 Log: 2011-04-19 Jerry DeLisle jvdeli...@gcc.gnu.org

Re: [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334)

2011-04-19 Thread Mike Stump
On Apr 19, 2011, at 11:12 AM, Rainer Orth wrote: I've had a closer look now and think it's possible (and desirable) to define HAVE_GAS_HIDDEN for Darwin, too. But, they don't have the same thing, therefore, either, you loose out on the meaning, or, you must have yet another test that means the

Re: [testsuite]: Skip some tests for avr

2011-04-19 Thread Mike Stump
On Apr 19, 2011, at 10:29 AM, Georg-Johann Lay wrote: Thanks for that hint. There are some more test cases that imply int = 32 bit Johann 2011-04-19 Georg-Johann Lay a...@gjlay.de * gcc.dg/pr42629.c: Add dg-require-effective-target int32plus *

Re: [patch testsuite committed] Skip gcc.dg/torture/pr37868.c on sh

2011-04-19 Thread Mike Stump
On Apr 19, 2011, at 2:59 PM, Kaz Kojima wrote: gcc.dg/torture/pr37868.c fails on SH because of unaligned accesses. The patch below skips the test as is done for sparc targets. I'd pre-approve hoisting these up into the lib/.exp files and checking a generic target requirement... :-) -/* {