Re: [PING] SLSR for conditional candidates

2013-05-03 Thread Richard Biener
On Thu, 2 May 2013, Bill Schmidt wrote: On Thu, 2013-05-02 at 13:29 +0200, Richard Biener wrote: On Mon, 29 Apr 2013, Bill Schmidt wrote: Half-hearted ping for http://gcc.gnu.org/ml/gcc-patches/2013-03/msg01291.html ... I promise this is the last major code dump for SLSR. ;)

Re: [PATCH, AArch64] Testcases for TST instruction

2013-05-03 Thread Marcus Shawcroft
OK /Marcus On 2 May 2013 15:56, Ian Bolton ian.bol...@arm.com wrote: I previously fixed a bug with the patterns that generate TST. I added these testcases to make our regression testing more solid. They've been running on our internal branch for about a month. OK to commit to trunk?

Re: [PATCH] Refactor coverage.c, outline the construction of gcov constructor

2013-05-03 Thread Richard Biener
On Thu, May 2, 2013 at 10:41 PM, Carrot Wei car...@google.com wrote: This patch outline the construction of gcov constructor from coverage_obj_init as a separate function build_init_ctor. It passed bootstrap and regression test on x86-64. OK for trunk and google 4.7 branch? Please pass

Re: [patch, mips] Allow users to avoid promoting prototypes.

2013-05-03 Thread Richard Biener
On Fri, May 3, 2013 at 12:26 AM, Richard Sandiford rdsandif...@googlemail.com wrote: Steve Ellcey sell...@imgtec.com writes: MIPS architectures set TARGET_PROMOTE_PROTOTYPES to true. I would like to have an option to set this to false in order to avoid extra masking when passing char or

Re: [RFA][PATCH] Fix tree-optimization/57144

2013-05-03 Thread Richard Biener
On Fri, May 3, 2013 at 6:30 AM, Jeff Law l...@redhat.com wrote: When we have x = (T) y; if (x CONST) true arm else false arm Assume CONST is larger than what can be represented in T. If we use fold_convert, any bits not not in T will be dropped. So if CONST is say 0x1

Re: [PATCH] Fix up make_compound_operation (PR rtl-optimization/57130)

2013-05-03 Thread Eric Botcazou
My understanding is that in_code == COMPARE (as opposed to in_code == SET) is mostly harmless, just tells make_extraction to no longer special case zero extraction at position 0, but there is one exception - AND with constant power of two CONST_INT. If we have make_compound_operation (

Re: [PATCH] Fix up make_compound_operation (PR rtl-optimization/57130)

2013-05-03 Thread Jakub Jelinek
On Fri, May 03, 2013 at 10:13:17AM +0200, Eric Botcazou wrote: My understanding is that in_code == COMPARE (as opposed to in_code == SET) is mostly harmless, just tells make_extraction to no longer special case zero extraction at position 0, but there is one exception - AND with constant

[C++ testcase, committed] PR 54318

2013-05-03 Thread Paolo Carlini
Hi, committed to mainline. Thanks, Paolo. /// 2013-05-03 Paolo Carlini paolo.carl...@oracle.com PR c++/54318 * g++.dg/cpp0x/pr54318.C: New. Index: g++.dg/cpp0x/pr54318.C === ---

Re: [PATCH] Fix up make_compound_operation (PR rtl-optimization/57130)

2013-05-03 Thread Eric Botcazou
Does it hurt to punt on nested SUBREG (it isn't really punting, just passing SET instead of COMPARE, which means avoiding the and with power of two and some make_extraction details), when usually the nested subregs should be already simplified and thus the reason I want it there is just to be

[PATCH] Fix PR57147, fix edge removal code

2013-05-03 Thread Richard Biener
The following fixes a bug in gimple_purge_dead_abnormal_call_edges which happily removes a EDGE_FALLTHRU|EDGE_ABNORMAL edge. The CFG builder via make_edge generally seems to merge edge flags and edges for edges between the same basic-blocks, so any abnormal call edges we insert may shadow the

Re: [AArch64] Support scalar form of FABD

2013-05-03 Thread Marcus Shawcroft
OK and committed. Thankyou. /Marcus On 2 May 2013 19:04, Vidya Praveen vidyaprav...@arm.com wrote: Hello, This attached patch adds support to the scalar form of FABD instruction along with the compile execute tests for the same. Regression tested on aarch64-none-elf with no issues. OK?

Re: [AArch64] Fix the description of simd_fabd

2013-05-03 Thread Marcus Shawcroft
OK and committed. Thankyou. /Marcus On 2 May 2013 19:21, Vidya Praveen vidyaprav...@arm.com wrote: Hello, This attached patch corrects the description for simd_fabd. OK? Regards VP gcc/ChangeLog 2013-05-02 Vidya Praveen vidyaprav...@arm.com *

[Patch, Fortran] PR57141 - fix using use-associated NULL() intrinsic

2013-05-03 Thread Tobias Burnus
The problem is that the procedure attributed is tried to be set to NULL() - but that's rejected because null() is use associated. I am not sure whether this is the cleanest patch, but I think it should be fine. Build and regtested on x86-64-gnu-linux. OK for the turnk? PENDING PATCHES: -

[PATCH] Speedup get_ref_base_and_extent (double-int)

2013-05-03 Thread Richard Biener
This speeds up get_ref_base_and_extent by not using the expensive alshift routine to convert from bytes to bits but a new lshift overload that works on the whole double-int and only handles positive shift counts (no extension necessary). The issue with shifts of course is that we allow negative

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Richard Biener
On Wed, Apr 24, 2013 at 5:29 PM, Richard Sandiford rdsandif...@googlemail.com wrote: Richard Biener richard.guent...@gmail.com writes: On Wed, Apr 24, 2013 at 4:35 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 04/24/2013 09:36 AM, Richard Biener wrote: On Wed, Apr 24, 2013 at 2:44

Committed: fix PR tree-optimization/57027

2013-05-03 Thread Joern Rennecke
Bootstrapped regtested on i686-pc-linux-gnu. Committed, as reviewed by Richard Biener: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57027 and also arguably obvious. 2013-05-03 Joern Rennecke joern.renne...@embecosm.com PR tree-optimization/57027 * tree-ssa-math-opts.c

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Richard Biener
On Wed, Apr 24, 2013 at 5:55 PM, Richard Sandiford rdsandif...@googlemail.com wrote: Richard Biener richard.guent...@gmail.com writes: On Wed, Apr 24, 2013 at 5:00 PM, Richard Sandiford rdsandif...@googlemail.com wrote: Richard Biener richard.guent...@gmail.com writes: On Wed, Apr 24, 2013 at

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Richard Biener
On Thu, Apr 25, 2013 at 1:18 AM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 04/24/2013 11:13 AM, Richard Biener wrote: On Wed, Apr 24, 2013 at 5:00 PM, Richard Sandiford rdsandif...@googlemail.com wrote: Richard Bienerrichard.guent...@gmail.com writes: On Wed, Apr 24, 2013 at 4:29

RFA: fix find_valid_class to accept classes w/out last hard reg

2013-05-03 Thread Joern Rennecke
In revision 91802, the tests in find_valid_class got garbled so that with n 0, it won't accept a class that does not include FIRST_PSEUDO_REGISTER - 1. The attached patch restores the status quo ante of allowing register classes that stop earlier. This fixes the compile/pr55921.c failures

Ping: RFA: replace MD_REDIRECT_BRANCH with TARGET_CAN_FOLLOW_JUMP

2013-05-03 Thread Joern Rennecke
This patch hasn't been reviewed yet: http://gcc.gnu.org/ml/gcc-patches/2013-04/msg01332.html

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Kenneth Zadeck
On 05/03/2013 07:34 AM, Richard Biener wrote: On Thu, Apr 25, 2013 at 1:18 AM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 04/24/2013 11:13 AM, Richard Biener wrote: On Wed, Apr 24, 2013 at 5:00 PM, Richard Sandiford rdsandif...@googlemail.com wrote: Richard

[PATCH, i386]: Merge *vec_concatv2si_sse2 with vec_concatv2si_sse and vec_concatv2di with *vec_concatv2di_rex64.

2013-05-03 Thread Uros Bizjak
Hello! 2013-05-03 Uros Bizjak ubiz...@gmail.com * config/i386/i386.md (isa): Add x64_sse4_noavx and x64_avx members. (enabled): Handle new members. * config/i386/sse.md (*vec_concatv2si): Merge from *vec_concatv2si_sse2 and vec_concatv2si_sse. (vec_concatv2di): Merge with

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Richard Biener
On Fri, May 3, 2013 at 1:49 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 05/03/2013 07:34 AM, Richard Biener wrote: On Thu, Apr 25, 2013 at 1:18 AM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 04/24/2013 11:13 AM, Richard Biener wrote: On Wed, Apr 24, 2013 at 5:00 PM,

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Kenneth Zadeck
On 05/03/2013 08:12 AM, Richard Biener wrote: On Fri, May 3, 2013 at 1:49 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 05/03/2013 07:34 AM, Richard Biener wrote: On Thu, Apr 25, 2013 at 1:18 AM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 04/24/2013 11:13 AM, Richard Biener

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Richard Sandiford
Richard Biener richard.guent...@gmail.com writes: See e.g. the hoops that cselib has to jump through: /* We need to pass down the mode of constants through the hash table functions. For that purpose, wrap them in a CONST of the appropriate mode. */ static rtx wrap_constant (enum

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Richard Biener
On Fri, May 3, 2013 at 2:31 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 05/03/2013 08:12 AM, Richard Biener wrote: On Fri, May 3, 2013 at 1:49 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 05/03/2013 07:34 AM, Richard Biener wrote: On Thu, Apr 25, 2013 at 1:18 AM, Kenneth

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Kenneth Zadeck
On 05/03/2013 07:19 AM, Richard Biener wrote: On Wed, Apr 24, 2013 at 5:29 PM, Richard Sandiford rdsandif...@googlemail.com wrote: Richard Biener richard.guent...@gmail.com writes: On Wed, Apr 24, 2013 at 4:35 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 04/24/2013 09:36 AM, Richard

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Richard Sandiford
Kenneth Zadeck zad...@naturalbridge.com writes: There are several problems with just dropping a mode into the already existing mode field of an rtx constant. 1) There may be places where the a back end is testing equality to see if constants of different modes are in fact the same value. 2)

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Richard Biener
On Fri, May 3, 2013 at 2:37 PM, Richard Sandiford rdsandif...@googlemail.com wrote: Richard Biener richard.guent...@gmail.com writes: See e.g. the hoops that cselib has to jump through: /* We need to pass down the mode of constants through the hash table functions. For that purpose, wrap

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Richard Biener
On Fri, May 3, 2013 at 2:45 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 05/03/2013 07:19 AM, Richard Biener wrote: On Wed, Apr 24, 2013 at 5:29 PM, Richard Sandiford rdsandif...@googlemail.com wrote: Richard Biener richard.guent...@gmail.com writes: On Wed, Apr 24, 2013 at 4:35

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Richard Biener
On Fri, May 3, 2013 at 2:48 PM, Richard Sandiford rdsandif...@googlemail.com wrote: Kenneth Zadeck zad...@naturalbridge.com writes: There are several problems with just dropping a mode into the already existing mode field of an rtx constant. 1) There may be places where the a back end is

Re: [PATCH] Fix PR57147, fix edge removal code

2013-05-03 Thread Richard Biener
On Fri, 3 May 2013, Richard Biener wrote: The following fixes a bug in gimple_purge_dead_abnormal_call_edges which happily removes a EDGE_FALLTHRU|EDGE_ABNORMAL edge. The CFG builder via make_edge generally seems to merge edge flags and edges for edges between the same basic-blocks, so any

[PATCH] Fix latent bug in RTL GCSE/PRE (PR57159)

2013-05-03 Thread Julian Brown
Hi, This is a patch which fixes a latent bug in RTL GCSE/PRE, described more fully in: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57159 I haven't been able to reproduce the problem on mainline (nor on a supported target). Maybe someone more familiar with the code in question than I am can tell

Re: [PATCH] Fold VEC_[LR]SHIFT_EXPR (PR tree-optimization/57051)

2013-05-03 Thread Jakub Jelinek
On Thu, Apr 25, 2013 at 11:47:02PM +0200, Jakub Jelinek wrote: This patch adds folding of constant arguments v and v, which helps to optimize the testcase from the PR back into constant store after vectorized loop is unrolled. As this fixes a regression on the 4.8 branch, I've backported it

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Richard Sandiford
Richard Biener richard.guent...@gmail.com writes: 5) All const_ints in the .md files would need to be given a mode (except for those places where const_int actually represents a C++ constant, such as in attributes). I realise your list wasn't supposed to be exhaustive, and neither's

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Richard Sandiford
Richard Biener richard.guent...@gmail.com writes: But storing the mode in the rtx is orthogonal to what Kenny is doing. The mode of each rtx constant is already available in the places that Kenny is changing, because we already do the work to keep track of the mode separately. Being able to

[PATCH, i386]: Fix PR 57106, -fcompare-debug failure with -O2 -fschedule-insns -funroll-all-loops

2013-05-03 Thread Uros Bizjak
Hello! Apparently, the wrong insn is used when adding insn dependencies. The last index gets updated to the found !NONDEBUG_INSN. Use first_arg that points to the right insn instead. 2013-05-03 Uros Bizjak ubiz...@gmail.com PR target/57106 * config/i386/i386.c

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Kenneth Zadeck
On 05/03/2013 08:40 AM, Richard Biener wrote: On Fri, May 3, 2013 at 2:31 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 05/03/2013 08:12 AM, Richard Biener wrote: On Fri, May 3, 2013 at 1:49 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 05/03/2013 07:34 AM, Richard Biener

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Kenneth Zadeck
On 05/03/2013 08:53 AM, Richard Biener wrote: On Fri, May 3, 2013 at 2:37 PM, Richard Sandiford rdsandif...@googlemail.com wrote: Richard Biener richard.guent...@gmail.com writes: See e.g. the hoops that cselib has to jump through: /* We need to pass down the mode of constants through the

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Kenneth Zadeck
On 05/03/2013 09:02 AM, Richard Biener wrote: On Fri, May 3, 2013 at 2:45 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 05/03/2013 07:19 AM, Richard Biener wrote: On Wed, Apr 24, 2013 at 5:29 PM, Richard Sandiford rdsandif...@googlemail.com wrote: Richard Biener

RFA: Allow simplification of SUBREGs involving the frame pointer during LRA

2013-05-03 Thread Nick Clifton
Hi Guys, I would like to apply the patch below to allow simplify_subreg_regno() to treat the frame pointer register in the same way as the stack pointer register when the LRA pass is running. I found that I needed this whilst trying to enable LRA for the RX and RL78 targets. (LRA is

Re: [RFA][PATCH] Fix tree-optimization/57144

2013-05-03 Thread Jeff Law
On 05/02/2013 11:56 PM, Jakub Jelinek wrote: On Thu, May 02, 2013 at 10:30:57PM -0600, Jeff Law wrote: --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/execute/pr57144.c @@ -0,0 +1,15 @@ +__attribute__ ((noinline)) +foo(int a) +{ + int z = a 0 ? a : -a; + long x = z; + if (x 0x1) +

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Kenneth Zadeck
Richi, I also think that it is a digression to have this discussion about rtl.The root problem is really that Mike, Richard, and myself do not believe that infinite precision math is the proper way to do math for the majority of the compiler. Most of the compiler, at both the rtl and

Re: RFA: Allow simplification of SUBREGs involving the frame pointer during LRA

2013-05-03 Thread Jeff Law
On 05/03/2013 09:01 AM, Nick Clifton wrote: Hi Guys, I would like to apply the patch below to allow simplify_subreg_regno() to treat the frame pointer register in the same way as the stack pointer register when the LRA pass is running. I found that I needed this whilst trying to

Re: [patch, mips] Allow users to avoid promoting prototypes.

2013-05-03 Thread Steve Ellcey
On Thu, 2013-05-02 at 23:26 +0100, Richard Sandiford wrote: 2013-05-02 Steve Ellcey sell...@imgtec.com * config/mips/mips.c (mips_promote_prototypes) :New. (TARGET_PROMOTE_PROTOTYPES): Change to use mips_promote_prototypes. * config/mips/mips.opt (mpromote-prototypes):

[PATCH] Fix PR bootstrap/57154 (issue9179043)

2013-05-03 Thread Teresa Johnson
This patch fixes PR bootstrap/57154. Bootstrapped on powerpc64-linux to ensure it fixes the bootstrap problem reported for that architecture, and also the test case attached to the bug report. Also bootstrapped and regtested on x86_64-unknown-linux-gnu. Ok for trunk? Thanks, Teresa 2013-05-03

[PATCH] Fix tree-optimization/57144

2013-05-03 Thread Jeff Law
Only change is in the new test which incorporates Jakub's comments. Installed onto the trunk. commit e30e5a25cb9b1888b48531d87573a833515a1e4b Author: Jeff Law l...@redhat.com Date: Thu May 2 22:19:37 2013 -0600 PR tree-optimization/57411 * tree-vrp.c

Re: [PATCH] Fix PR bootstrap/57154 (issue9179043)

2013-05-03 Thread David Edelsohn
Thanks for the patch. Bootstrap works on x86 and Anton's testcase works on x86. Is there any testcase for x86 that would demonstrate the failure or that could check the probabilities in a dump file and see the inconsistency? Thanks, David

Re: [PATCH] Fix PR bootstrap/57154 (issue9179043)

2013-05-03 Thread Jeff Law
On 05/03/2013 10:23 AM, Teresa Johnson wrote: This patch fixes PR bootstrap/57154. Bootstrapped on powerpc64-linux to ensure it fixes the bootstrap problem reported for that architecture, and also the test case attached to the bug report. Also bootstrapped and regtested on

Re: [PATCH] Fix tree-optimization/57144

2013-05-03 Thread H.J. Lu
On Fri, May 3, 2013 at 9:36 AM, Jeff Law l...@redhat.com wrote: Only change is in the new test which incorporates Jakub's comments. Installed onto the trunk. commit e30e5a25cb9b1888b48531d87573a833515a1e4b Author: Jeff Law l...@redhat.com Date: Thu May 2 22:19:37 2013 -0600 PR

Re: [PATCH] Fix tree-optimization/57144

2013-05-03 Thread Jeff Law
On 05/03/2013 10:44 AM, H.J. Lu wrote: On Fri, May 3, 2013 at 9:36 AM, Jeff Law l...@redhat.com wrote: Only change is in the new test which incorporates Jakub's comments. Installed onto the trunk. commit e30e5a25cb9b1888b48531d87573a833515a1e4b Author: Jeff Law l...@redhat.com Date: Thu

[PATCH] Fix array sizes created by Java FE (PR libgcj/57074)

2013-05-03 Thread Jakub Jelinek
Hi! As discovered by Alan Modra, the GCJ FE sometimes emits VAR_DECLs that have smaller DECL_SIZE (and TYPE_SIZE (TREE_TYPE ())) than the size of their initializers. I went through all build_constructor calls in the java FE and it seems only these two spots are problematic, they keep using

Re: [PATCH] Improve simplify_subreg

2013-05-03 Thread Jakub Jelinek
On Thu, May 02, 2013 at 06:53:31PM +0100, Richard Sandiford wrote: Jakub Jelinek ja...@redhat.com writes: When working on PR57130, I've wondered why we don't simplify it much earlier and end up with creating such weirdness. The following patch fixes that, by using nonzero_bits to see if

Re: [PATCH] Fix PR bootstrap/57154 (issue9179043)

2013-05-03 Thread Teresa Johnson
On Fri, May 3, 2013 at 9:37 AM, David Edelsohn dje@gmail.com wrote: Thanks for the patch. Bootstrap works on x86 and Anton's testcase works on x86. Is there any testcase for x86 that would demonstrate the failure or that could check the probabilities in a dump file and see the

Re: [PATCH] Fix PR bootstrap/57154 (issue9179043)

2013-05-03 Thread Jeff Law
On 05/03/2013 11:15 AM, Teresa Johnson wrote: On Fri, May 3, 2013 at 9:37 AM, David Edelsohn dje@gmail.com wrote: Thanks for the patch. Bootstrap works on x86 and Anton's testcase works on x86. Is there any testcase for x86 that would demonstrate the failure or that could check the

Re: [PATCH] Fix PR bootstrap/57154 (issue9179043)

2013-05-03 Thread David Edelsohn
On Fri, May 3, 2013 at 1:26 PM, Jeff Law l...@redhat.com wrote: On 05/03/2013 11:15 AM, Teresa Johnson wrote: On Fri, May 3, 2013 at 9:37 AM, David Edelsohn dje@gmail.com wrote: Thanks for the patch. Bootstrap works on x86 and Anton's testcase works on x86. Is there any testcase for

Re: [PATCH] Fix PR bootstrap/57154 (issue9179043)

2013-05-03 Thread Teresa Johnson
On Fri, May 3, 2013 at 10:28 AM, David Edelsohn dje@gmail.com wrote: On Fri, May 3, 2013 at 1:26 PM, Jeff Law l...@redhat.com wrote: On 05/03/2013 11:15 AM, Teresa Johnson wrote: On Fri, May 3, 2013 at 9:37 AM, David Edelsohn dje@gmail.com wrote: Thanks for the patch. Bootstrap

Re: [PATCH, i386]: Merge *vec_concatv2si_sse2 with vec_concatv2si_sse and vec_concatv2di with *vec_concatv2di_rex64.

2013-05-03 Thread Dominique Dhumieres
Uros, I think the '\\' should be removed from /* { dg-final { scan-assembler-times \\vec_concatv2di/3 1 } } */ TIA Dominique

Re: [PATCH] Refactor coverage.c, outline the construction of gcov constructor

2013-05-03 Thread Carrot Wei
On Fri, May 3, 2013 at 1:03 AM, Richard Biener richard.guent...@gmail.com wrote: On Thu, May 2, 2013 at 10:41 PM, Carrot Wei car...@google.com wrote: This patch outline the construction of gcov constructor from coverage_obj_init as a separate function build_init_ctor. It passed bootstrap

Re: [PATCH] Fix PR bootstrap/57154 (issue9179043)

2013-05-03 Thread Teresa Johnson
Here is the patch with the new test case. Tested using dejagnu with and without my fix for PR57154 to confirm that it exposes the failure and works with the patch. Ok for trunk? Thanks, Teresa 2013-05-03 Teresa Johnson tejohn...@google.com PR bootstrap/57154 * gcc.dg/pr57154.c: New test.

Re: [PATCH] Fix PR bootstrap/57154 (issue9179043)

2013-05-03 Thread Jeff Law
On 05/03/2013 12:35 PM, Teresa Johnson wrote: Here is the patch with the new test case. Tested using dejagnu with and without my fix for PR57154 to confirm that it exposes the failure and works with the patch. Ok for trunk? Thanks, Teresa 2013-05-03 Teresa Johnson tejohn...@google.com PR

Re: [PATCH] Refactor coverage.c, outline the construction of gcov constructor

2013-05-03 Thread Xinliang David Li
Please do what Richard suggested. gcov_info_type can be obtained from gcov_info_var decl. David On Fri, May 3, 2013 at 11:31 AM, Carrot Wei car...@google.com wrote: On Fri, May 3, 2013 at 1:03 AM, Richard Biener richard.guent...@gmail.com wrote: On Thu, May 2, 2013 at 10:41 PM, Carrot Wei

[Patch,Testsuite] Fix failure in gcc.dg/tree-ssa/forwprop-26.c

2013-05-03 Thread Greta Yorsh
This is a new test that fails on arm and probably other targets that have short enums by default: FAIL: gcc.dg/tree-ssa/forwprop-26.c (test for excess errors) Excess errors: /src/gcc/gcc/testsuite/gcc.dg/tree-ssa/forwprop-26.c:13:22: error: width of 'code' exceeds its type

Re: [PATCH, i386]: Merge *vec_concatv2si_sse2 with vec_concatv2si_sse and vec_concatv2di with *vec_concatv2di_rex64.

2013-05-03 Thread Uros Bizjak
On Fri, May 3, 2013 at 7:44 PM, Dominique Dhumieres domi...@lps.ens.fr wrote: I think the '\\' should be removed from /* { dg-final { scan-assembler-times \\vec_concatv2di/3 1 } } */ Oh, indeed. They were used to escape * and are useless now. For some reason, the regtest didn't failed for

Re: [PATCH, i386]: Merge *vec_concatv2si_sse2 with vec_concatv2si_sse and vec_concatv2di with *vec_concatv2di_rex64.

2013-05-03 Thread Dominique Dhumieres
Can you please commit the fixup patch, I am away from my keyboard today. Sorry, I don't have write access. Dominique

Re: [build, driver] RFC: Support compressed debug sections

2013-05-03 Thread Joseph S. Myers
On Tue, 30 Apr 2013, Rainer Orth wrote: * gcc.c (LINK_COMPRESS_DEBUG_SPEC, ASM_COMPRESS_DEBUG_SPEC): Define. (LINK_COMMAND_SPEC): Invoke LINK_COMPRESS_DEBUG_SPEC. (asm_options): Invoke ASM_COMPRESS_DEBUG_SPEC. Note that there are separate copies of LINK_COMMAND_SPEC

Re: [PATCH, i386]: Merge *vec_concatv2si_sse2 with vec_concatv2si_sse and vec_concatv2di with *vec_concatv2di_rex64.

2013-05-03 Thread H.J. Lu
On Fri, May 3, 2013 at 12:21 PM, Dominique Dhumieres domi...@lps.ens.fr wrote: Can you please commit the fixup patch, I am away from my keyboard today. Sorry, I don't have write access. Dominique I checked it in for you. Thanks. -- H.J.

C++/v3 PATCH to add/throw std::bad_array_new_length

2013-05-03 Thread Jason Merrill
Last year Florian fixed the compiler to detect overflow in array new size calculations and pass (size_t)-1 in that case. But C++11 specifies that in case of overflow the program throws std::bad_array_new_length (http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#624), so I've

Re: [Patch,Testsuite] Fix failure in gcc.dg/tree-ssa/forwprop-26.c

2013-05-03 Thread Jeff Law
On 05/03/2013 01:13 PM, Greta Yorsh wrote: This is a new test that fails on arm and probably other targets that have short enums by default: FAIL: gcc.dg/tree-ssa/forwprop-26.c (test for excess errors) Excess errors: /src/gcc/gcc/testsuite/gcc.dg/tree-ssa/forwprop-26.c:13:22: error: width of

Re: [RFA][PATCH] Fix tree-optimization/57124

2013-05-03 Thread Jeff Law
On 05/02/2013 01:55 AM, Richard Biener wrote: On Wed, May 1, 2013 at 10:26 PM, Jeff Law l...@redhat.com wrote: range_fits_type_p erroneously returns true in cases where the range has overflowed. So for example, we might have a range [0, +INF(OVF)] and conclude the range fits in an unsigned

Re: [patch, mips] Fix for PR target/56942

2013-05-03 Thread Steve Ellcey
On Tue, 2013-04-30 at 15:05 +0100, Richard Sandiford wrote: Richard Sandiford rdsandif...@googlemail.com writes: Steven Bosscher stevenb@gmail.com writes: I dont like this at all. At the very least, if we go this way, then all places where next_active_insn is used should be

Re: [PATCH] SLSR for conditional candidates

2013-05-03 Thread H.J. Lu
On Fri, Mar 29, 2013 at 2:15 PM, Bill Schmidt wschm...@linux.vnet.ibm.com wrote: This is a resubmission of a patch I sent to the list last August, re-based for the C++ changes since then. It implements the last big chunk of straight-line strength reduction (conditional candidates, for cases

Re: [PATCH] Fix PR bootstrap/57154 (issue9179043)

2013-05-03 Thread Teresa Johnson
Resending since it bounced as my mailer wasn't set to plain text. Teresa On Fri, May 3, 2013 at 12:48 PM, Teresa Johnson tejohn...@google.com wrote: Yes it will ICE on failure. What is the guideline on c.torture vs gcc.dg? Thanks, Teresa On May 3, 2013 11:47 AM, Jeff Law l...@redhat.com

[PATCH, rs6000] PR target/57150, do not use VSX instructions for long double caller saves

2013-05-03 Thread Michael Meissner
In debugging the glibc function __ieee754_scalbl when compiling for a power7 target, we discovered that the compiler was using VSX load and store instructions to save long double types that are passed in floating point registes. However, since long double types are passed as two scalar floating

Re: [PATCH, rs6000] PR target/57150, do not use VSX instructions for long double caller saves

2013-05-03 Thread David Edelsohn
On Fri, May 3, 2013 at 7:05 PM, Michael Meissner meiss...@linux.vnet.ibm.com wrote: In debugging the glibc function __ieee754_scalbl when compiling for a power7 target, we discovered that the compiler was using VSX load and store instructions to save long double types that are passed in

Re: [PATCH] Fix array sizes created by Java FE (PR libgcj/57074)

2013-05-03 Thread Alan Modra
On Fri, May 03, 2013 at 07:10:15PM +0200, Jakub Jelinek wrote: Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, but not tested on powerpc32 where it actually caused runtime issues, can somebody please try it there? Ok for trunk/4.8? /home/amodra/build/gcc-current/./gcc/gcj

Re: [PATCH] Fix array sizes created by Java FE (PR libgcj/57074)

2013-05-03 Thread Alan Modra
Here's a smaller case that shows the same problem /home/amodra/build/gcc-current/./gcc/jc1 /home/amodra/src/gcc-current/libjava/classpath/lib/gnu/java/awt/dnd/peer/gtk/GtkDragSourceContextPeer.class -fhash-synchronization -fuse-divide-subroutine -fuse-boehm-gc -fnon-call-exceptions -fPIC

[PATCH] Use indentation in gtype.state to show nested structure

2013-05-03 Thread David Malcolm
Whilst learning the internals of the GTY code I noticed that gtype.state's s-expressions are all aligned to the left-hand margin. The following patch to gengtype-state.c rewrites how they are written out to introduce indentation, showing the nesting structure of the s-expressions, which makes the

Re: [PATCH] SLSR for conditional candidates

2013-05-03 Thread Bill Schmidt
On Fri, 2013-05-03 at 13:58 -0700, H.J. Lu wrote: On Fri, Mar 29, 2013 at 2:15 PM, Bill Schmidt wschm...@linux.vnet.ibm.com wrote: This is a resubmission of a patch I sent to the list last August, re-based for the C++ changes since then. It implements the last big chunk of straight-line

Re: [PATCH] Refactor coverage.c, outline the construction of gcov constructor

2013-05-03 Thread Carrot Wei
commited as 198591. On Fri, May 3, 2013 at 11:51 AM, Xinliang David Li davi...@google.com wrote: Please do what Richard suggested. gcov_info_type can be obtained from gcov_info_var decl. David On Fri, May 3, 2013 at 11:31 AM, Carrot Wei car...@google.com wrote: On Fri, May 3, 2013 at 1:03

[PATCH, committed] Avoid bootstrap failure for i686-pc-linux-gnu due to SLSR

2013-05-03 Thread Bill Schmidt
This patch disables processing of conditional candidates in SLSR for the time being, until I can sort out the cause of a related bootstrap failure. Bootstrapped on powerpc64-unknown-linux-gnu with no regressions; bootstrapped on i686-pc-linux-gnu to verify bootstrap now works. Committed.

Re: [PATCH] Fix array sizes created by Java FE (PR libgcj/57074)

2013-05-03 Thread Alan Modra
I believe the real problem here is in place_block_symbol() and output_object_block(). If DECL_INITIAL is given for an array, then shouldn't we be taking the size from the initializer? This patch fixes that problem, and ensures that we get an assembler error if placement in the block changes.