Re: [PATCH 5/5] add libcc1

2014-10-28 Thread Jakub Jelinek
On Tue, Oct 28, 2014 at 01:05:00AM +0100, Dominique Dhumieres wrote: This patch has now been committed. It breaks bootstap on x86_64-apple-darwin14: ... make[3]: Entering directory `/opt/gcc/p_build/libcc1' make all-am make[4]: Entering directory `/opt/gcc/p_build/libcc1' make[4]: ***

Re: [PATCH 5/5] add libcc1

2014-10-28 Thread Uros Bizjak
This patch has now been committed. Also breaks bootstap on x86_64-linux-gnu, CentOS 5.11: gmake[4]: Entering directory `/home/uros/gcc-build/libcc1' /bin/sh ./libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I../../gcc-svn/trunk/libcc1 -I ../../gcc-svn/trunk/libcc1/../include -I

Re: genmatch infinite loop during bootstrap on AIX

2014-10-28 Thread Richard Biener
On Mon, 27 Oct 2014, David Edelsohn wrote: Richi, The bootstrap with an empty match.pd seems to be succeeding. I don't know if you have disabled optimizations in other passes that now are implemented in genmatch. Regular testing of AIX is important to discover bootstrap issues early and

Re: [PATCH 5/5] add libcc1

2014-10-28 Thread Phil Muldoon
On 28/10/14 08:13, Jakub Jelinek wrote: On Tue, Oct 28, 2014 at 01:05:00AM +0100, Dominique Dhumieres wrote: This patch has now been committed. It breaks bootstap on x86_64-apple-darwin14: ... make[3]: Entering directory `/opt/gcc/p_build/libcc1' make all-am make[4]: Entering directory

Re: [PATCH 5/5] add libcc1

2014-10-28 Thread Christophe Lyon
On 28 October 2014 09:43, Phil Muldoon pmuld...@redhat.com wrote: On 28/10/14 08:13, Jakub Jelinek wrote: On Tue, Oct 28, 2014 at 01:05:00AM +0100, Dominique Dhumieres wrote: This patch has now been committed. It breaks bootstap on x86_64-apple-darwin14: ... make[3]: Entering directory

[PATCH v5] Enable -fsanitize-recover for KASan

2014-10-28 Thread Yury Gribov
Hi all, On 10/23/2014 11:11 AM, Yury Gribov wrote: This patch enables -fsanitize-recover for KASan by default. This causes KASan to continue execution after error in case of inline instrumentation. This feature is needed because - reports during early bootstrap won't even be printed - needed to

Re: [PATCH 5/5] add libcc1

2014-10-28 Thread Phil Muldoon
On 28/10/14 08:36, Uros Bizjak wrote: This patch has now been committed. Also breaks bootstap on x86_64-linux-gnu, CentOS 5.11: gmake[4]: Entering directory `/home/uros/gcc-build/libcc1' /bin/sh ./libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I../../gcc-svn/trunk/libcc1 -I

RE: [AArch64] [BE] [2/2] Make large opaque integer modes endianness-safe.

2014-10-28 Thread David Sherwood
Hi, Sorry to bother you again, but if someone has time could they take a look at this change please? Thanks! David. -Original Message- From: David Sherwood [mailto:david.sherw...@arm.com] Sent: 13 October 2014 11:02 To: gcc-patches@gcc.gnu.org Subject: [AArch64] [BE] [2/2] Make large

RE: [AArch64] [BE] [1/2] Make large opaque integer modes endianness-safe.

2014-10-28 Thread David Sherwood
Hi, Sorry to bother you again. Could someone take a look at this change please if they have time? Thanks! David. -Original Message- From: David Sherwood [mailto:david.sherw...@arm.com] Sent: 10 October 2014 15:48 To: gcc-patches@gcc.gnu.org Subject: [AArch64] [BE] [1/2] Make large

Re: [PATCH 5/5] add libcc1

2014-10-28 Thread Jakub Jelinek
On Tue, Oct 28, 2014 at 08:43:35AM +, Phil Muldoon wrote: On 28/10/14 08:13, Jakub Jelinek wrote: On Tue, Oct 28, 2014 at 01:05:00AM +0100, Dominique Dhumieres wrote: This patch has now been committed. It breaks bootstap on x86_64-apple-darwin14: ... make[3]: Entering directory

Re: [PATCH 5/5] add libcc1

2014-10-28 Thread Uros Bizjak
On Tue, Oct 28, 2014 at 9:50 AM, Phil Muldoon pmuld...@redhat.com wrote: On 28/10/14 08:36, Uros Bizjak wrote: This patch has now been committed. Also breaks bootstap on x86_64-linux-gnu, CentOS 5.11: gmake[4]: Entering directory `/home/uros/gcc-build/libcc1' /bin/sh ./libtool --tag=CXX

Re: [PATCHv2] Don't expand string/memory builtins if ASan is enabled.

2014-10-28 Thread Maxim Ostapenko
The code which identifies interceptors seems to be duplicated in expand_builtin. What about factoring this out to some is_asan_intercepted() in asan.h? I agree. Fixed this. BTW, when you handle a builtin, but set *intercepted_p to false, is the point just that you don't instrument e.g.

Re: [PATCH v5] Enable -fsanitize-recover for KASan

2014-10-28 Thread Jakub Jelinek
On Tue, Oct 28, 2014 at 11:46:31AM +0300, Yury Gribov wrote: 2014-10-23 Yury Gribov y.gri...@samsung.com gcc/ * asan.c (report_error_func): Add noabort path. (check_func): Ditto. Formatting. (asan_expand_check_ifn): Handle noabort path. * common.opt

Re: [PATCHv2] Don't expand string/memory builtins if ASan is enabled.

2014-10-28 Thread Jakub Jelinek
On Tue, Oct 28, 2014 at 12:21:25PM +0400, Maxim Ostapenko wrote: 2014-10-28 Max Ostapenko m.ostape...@partner.samsung.com * asan.h (is_asan_intercepted): New function. I'd call it asan_intercepted_p instead. Can you please check if: void foo (char *p) { volatile int zero = 0;

Re: [PATCH 5/5] add libcc1

2014-10-28 Thread Jakub Jelinek
On Tue, Oct 28, 2014 at 09:36:45AM +0100, Uros Bizjak wrote: This patch has now been committed. Also breaks bootstap on x86_64-linux-gnu, CentOS 5.11: For -Werror, I'd think that should fix that, WARN_FLAGS should already contain -Werror during stage2/stage3 unless --disable-werror. Untested

Re: [patch] Flatten cgraph.h.

2014-10-28 Thread Richard Biener
On Mon, Oct 27, 2014 at 10:32 PM, Andrew MacLeod amacl...@redhat.com wrote: No so much preamble for this one since cgraph.h is already representative of only things in cgraph.c. So this is mostly shuffling of include files. One short 'interesting' patch, and a couple of longer boring

Re: [PATCH 5/5] add libcc1

2014-10-28 Thread Uros Bizjak
On Tue, Oct 28, 2014 at 10:35 AM, Jakub Jelinek ja...@redhat.com wrote: On Tue, Oct 28, 2014 at 09:36:45AM +0100, Uros Bizjak wrote: This patch has now been committed. Also breaks bootstap on x86_64-linux-gnu, CentOS 5.11: For -Werror, I'd think that should fix that, WARN_FLAGS should

[match-and-simplify] Merge from trunk

2014-10-28 Thread Richard Biener
Committed. Richard. 2014-10-28 Richard Biener rguent...@suse.de Merge from trunk r216632 through r216771. Brings back third merge piece.

Re: [PATCH v5] Enable -fsanitize-recover for KASan

2014-10-28 Thread Yury Gribov
On 10/28/2014 12:26 PM, Jakub Jelinek wrote: On Tue, Oct 28, 2014 at 11:46:31AM +0300, Yury Gribov wrote: 2014-10-23 Yury Gribov y.gri...@samsung.com gcc/ * asan.c (report_error_func): Add noabort path. (check_func): Ditto. Formatting. (asan_expand_check_ifn): Handle

Re: [match-and-simplify] error checking on user defined oper in for

2014-10-28 Thread Richard Biener
On Sat, Oct 25, 2014 at 8:16 PM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: Currently this is accepted: (for plus (mult div) ...) which is incorrect. This patch puts more error-checks on the user-defined operator in for-pattern. Nicely spotted issue. But I prefer to fix it

Re: [match-and-simplify] reject conditional convert and commutative ops in result operand

2014-10-28 Thread Richard Biener
On Mon, Oct 27, 2014 at 3:32 PM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: I suppose we should reject conditional convert and commutative ops in result operand ? since it would create 1-n mapping from match - result. Yeah. Same is true for parsing of :type syntax for the match

Re: [match-and-simplify] error checking on user defined oper in for

2014-10-28 Thread Prathamesh Kulkarni
On Tue, Oct 28, 2014 at 3:45 PM, Richard Biener richard.guent...@gmail.com wrote: On Sat, Oct 25, 2014 at 8:16 PM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: Currently this is accepted: (for plus (mult div) ...) which is incorrect. This patch puts more error-checks on the

Re: [match-and-simplify] error checking on user defined oper in for

2014-10-28 Thread Richard Biener
On Tue, Oct 28, 2014 at 11:27 AM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: On Tue, Oct 28, 2014 at 3:45 PM, Richard Biener richard.guent...@gmail.com wrote: On Sat, Oct 25, 2014 at 8:16 PM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: Currently this is accepted: (for

Re: [PATCH 5/5] add libcc1

2014-10-28 Thread Phil Muldoon
On 28/10/14 09:57, Uros Bizjak wrote: On Tue, Oct 28, 2014 at 10:35 AM, Jakub Jelinek ja...@redhat.com wrote: On Tue, Oct 28, 2014 at 09:36:45AM +0100, Uros Bizjak wrote: This patch has now been committed. Also breaks bootstap on x86_64-linux-gnu, CentOS 5.11: For -Werror, I'd think that

Re: [PATCH 5/5] add libcc1

2014-10-28 Thread Uros Bizjak
On Tue, Oct 28, 2014 at 11:35 AM, Phil Muldoon pmuld...@redhat.com wrote: This patch has now been committed. Also breaks bootstap on x86_64-linux-gnu, CentOS 5.11: For -Werror, I'd think that should fix that, WARN_FLAGS should already contain -Werror during stage2/stage3 unless

Re: [PATCH 5/5] add libcc1

2014-10-28 Thread Phil Muldoon
On 28/10/14 10:51, Uros Bizjak wrote: On Tue, Oct 28, 2014 at 11:35 AM, Phil Muldoon pmuld...@redhat.com wrote: This patch has now been committed. Also breaks bootstap on x86_64-linux-gnu, CentOS 5.11: For -Werror, I'd think that should fix that, WARN_FLAGS should already contain -Werror

[gomp4] Rationalise thread-local variables in libgomp OpenACC support

2014-10-28 Thread Julian Brown
Hi, This patch rationalises TLS support by moving all thread-local variables into a single structure. Because this meant interfering with how per-thread/per-device initialisation was done, I took the opportunity to tidy up a couple of other bits along the way. Highlights are: - TLS support is

[PATCH] Fix PR63665

2014-10-28 Thread Richard Biener
The following fixes folding of x + CST != CST with -fwrapv. Even with -fwrapv overflow is signalled by int_const_binop with TREE_OVERFLOW but of course we cannot do any undefined overflow optimizations when overflow wraps. bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard.

RE: [Patch] Add MIPS flag to avoid use of ldc1/sdc1/ldxc1/sdxc1

2014-10-28 Thread Matthew Fortune
Do you have an objection to allowing an option to disable these instructions (despite the reason for wanting to do so)? Yes this seems like a bad workaround for broken code. Well, we work around broken hardware all the time. What would you suggest that Steve do instead? We work

Re: [PATCH 5/5] add libcc1

2014-10-28 Thread Phil Muldoon
On 28/10/14 10:51, Uros Bizjak wrote: On Tue, Oct 28, 2014 at 11:35 AM, Phil Muldoon pmuld...@redhat.com wrote: This patch has now been committed. Also breaks bootstap on x86_64-linux-gnu, CentOS 5.11: For -Werror, I'd think that should fix that, WARN_FLAGS should already contain -Werror

[Ping] [PATCH] Add arm_cortex_m7_tune.

2014-10-28 Thread Hale Wang
Ping? https://gcc.gnu.org/ml/gcc-patches/2014-10/msg02025.html Thanks Hale Wang -Original Message- From: Hale Wang [mailto:hale.w...@arm.com] Sent: Tuesday, October 21, 2014 5:57 PM To: Hale Wang; gcc-patches@gcc.gnu.org Subject: RE: [PATCH] Add arm_cortex_m7_tune. Attach the

Re: FW: [AArch64] [BE] [1/2] Make large opaque integer modes endianness-safe.

2014-10-28 Thread Alan Lawrence
When you say a patch by Alan Hayward that's coming soon, I take it you mean this one? https://gcc.gnu.org/ml/gcc-patches/2014-10/msg00952.html Just so that we know it has now arrived :). --Alan David Sherwood wrote: Hi, I forgot to mention that this patch needs was tested in combination

[Ping] [PATCH] Small multiplier support in Cortex-M0/1/+

2014-10-28 Thread Hale Wang
Ping? https://gcc.gnu.org/ml/gcc-patches/2014-10/msg02027.html Thanks, Hale Wang -Original Message- From: Hale Wang [mailto:hale.w...@arm.com] Sent: Tuesday, October 21, 2014 6:02 PM To: 'gcc-patches@gcc.gnu.org' Subject: Small multiplier support in Cortex-M0/1/+ Hi, Some

[PING][PATCH, AARCH64] Add support for -mlong-calls option

2014-10-28 Thread Yangfei (Felix)
+ c_register_pragma (0, long_calls_off, aarch64_pr_long_calls_off); \ +} while (0) + #define FUNCTION_ARG_PADDING(MODE, TYPE) \ (aarch64_pad_arg_upward (MODE, TYPE) ? upward : downward) Hi, I added four testcases to ensure that this patch tested properly. Reg-tested

Re: [PATCH x86] Increase PARAM_MAX_COMPLETELY_PEELED_INSNS when branch is costly

2014-10-28 Thread Evgeny Stupachenko
make check for gcc passed On Mon, Oct 27, 2014 at 11:10 AM, Evgeny Stupachenko evstu...@gmail.com wrote: The results are the same for Silvermont. There are no significant changes on Haswell. So I agree with Richard, let's enable this x86 wide. Bootstrap/ passed. Make check in progress. Is

Re: [PATCH] Add zero-overhead looping for xtensa backend

2014-10-28 Thread Yangfei (Felix)
On Thu, Oct 23, 2014 at 11:51 PM, Yangfei (Felix) felix.y...@huawei.com wrote: Thanks for the explanation. I think I am clear about what you are thinking now. That's an interesting question. I am not sure about reason why GCC's reload cannot handle a doloop_end insn. I guess maybe the

Re: [PATCH 5/5] add libcc1

2014-10-28 Thread Jakub Jelinek
On Tue, Oct 28, 2014 at 11:47:31AM +, Phil Muldoon wrote: I think I have a solution. Though my automake fu is very weak. Does this patch work for you? I'm really not sure how to deal with the three possible versions of libiberty any other way. That is insufficient, a) you don't filter

Fix libcc1 bootstrap and linking issues

2014-10-28 Thread Phil Muldoon
Hi A few issues came to light this morning on some systems with bootstrapping and libiberty linking issues. We erroneously specified -Werror in stage one builds. This patch removes that flag. We also unconditionally linked with the PIC version of libiberty. This patch adds a conditional if

Re: [match-and-simplify] reject conditional convert and commutative ops in result operand

2014-10-28 Thread Prathamesh Kulkarni
On Tue, Oct 28, 2014 at 3:50 PM, Richard Biener richard.guent...@gmail.com wrote: On Mon, Oct 27, 2014 at 3:32 PM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: I suppose we should reject conditional convert and commutative ops in result operand ? since it would create 1-n mapping

[PATCH] Fix up sign extension in bswap

2014-10-28 Thread Jakub Jelinek
On Tue, Oct 21, 2014 at 10:28:40AM +0100, Thomas Preud'homme wrote: --- a/gcc/tree-ssa-math-opts.c +++ b/gcc/tree-ssa-math-opts.c @@ -1916,7 +1916,8 @@ find_bswap_or_nop_1 (gimple stmt, struct symbolic_number *n, int limit) if (!TYPE_UNSIGNED (n-type) type_size old_type_size

Re: [Patch] Add MIPS flag to avoid use of ldc1/sdc1/ldxc1/sdxc1

2014-10-28 Thread Ramana Radhakrishnan
On Tue, Oct 28, 2014 at 11:46 AM, Matthew Fortune matthew.fort...@imgtec.com wrote: Do you have an objection to allowing an option to disable these instructions (despite the reason for wanting to do so)? Yes this seems like a bad workaround for broken code. Well, we work around

[patch,avr,4.9] Fix PR63633 ICEs for expanders colliding hard-regs

2014-10-28 Thread Georg-Johann Lay
Middle-end might come up with hard registers as operands for expanders which clobber respective hard regs. This patch uses freshly created pseudos for respective expander operands and emits pseudo - hard move insn. Ok for 4.9.2? It's not yet for trunk because avr trunk backend is currently

Re: Fix libcc1 bootstrap and linking issues

2014-10-28 Thread Jakub Jelinek
On Tue, Oct 28, 2014 at 12:24:39PM +, Phil Muldoon wrote: 2014-10-28 Phil Muldoon pmuld...@redhat.com * configure.ac: Remove -Werror. * configure: Regenerate. * Makefile.am: Remove -Werror. Link correct libiberty. * Makefile.in: Regenerate. As for -Werror, doesn't your

(Withdrawn) Fix libcc1 bootstrap and linking issues

2014-10-28 Thread Phil Muldoon
On 28/10/14 12:24, Phil Muldoon wrote: Hi A few issues came to light this morning on some systems with bootstrapping and libiberty linking issues. We erroneously specified -Werror in stage one builds. This patch removes that flag. We also unconditionally linked with the PIC version of

Re: Fix libcc1 bootstrap and linking issues

2014-10-28 Thread Phil Muldoon
On 28/10/14 12:34, Jakub Jelinek wrote: On Tue, Oct 28, 2014 at 12:24:39PM +, Phil Muldoon wrote: 2014-10-28 Phil Muldoon pmuld...@redhat.com * configure.ac: Remove -Werror. * configure: Regenerate. * Makefile.am: Remove -Werror. Link correct libiberty. * Makefile.in:

Re: [PATCH] -fsanitize=vptr instrumentation (take 2)

2014-10-28 Thread Jakub Jelinek
On Mon, Oct 27, 2014 at 05:16:05PM +0100, Jakub Jelinek wrote: Here is an updated patch, ok if bootstrap/testing passes (so far just checked with make -j16 -k check RUNTESTFLAGS='--target_board=unix\{-m32,-m64\} asan.exp tsan.exp ubsan.exp' )? Updated patch that passed bootstrap/regtest on

Re: [patch,avr,4.9] Fix PR63633 ICEs for expanders colliding hard-regs

2014-10-28 Thread Georg-Johann Lay
Am 10/28/2014 01:34 PM, schrieb Georg-Johann Lay: Middle-end might come up with hard registers as operands for expanders which clobber respective hard regs. This patch uses freshly created pseudos for respective expander operands and emits pseudo - hard move insn. Ok for 4.9.2? p.s.:

Re: [PATCH] Fix up sign extension in bswap

2014-10-28 Thread Richard Biener
On Tue, 28 Oct 2014, Jakub Jelinek wrote: On Tue, Oct 21, 2014 at 10:28:40AM +0100, Thomas Preud'homme wrote: --- a/gcc/tree-ssa-math-opts.c +++ b/gcc/tree-ssa-math-opts.c @@ -1916,7 +1916,8 @@ find_bswap_or_nop_1 (gimple stmt, struct symbolic_number *n, int limit) if

[PATCH] Fix PR63665

2014-10-28 Thread Richard Biener
It seems that SLP vectorization can somehow generate out-of-bound masks for VEC_PERM. The following fixes that (the ICE reproduces on x86_64 with the added assert). Bootstrap and regtest running on x86_64-unknown-linux-gnu. Richard. 2014-10-28 Richard Biener rguent...@suse.de PR

Re: [PATCH, x86, 63534] Fix '-p' profile for 32 bit PIC mode

2014-10-28 Thread Evgeny Stupachenko
Thank you, Jakub. The following patch passed bootstrap, gcc make check and spec2000 with -p -m32 -fPIC. Is it ok? ChangeLog: 2014-10-28 Evgeny Stupachenko evstu...@gmail.com gcc/testsuite * gcc.target/i386/mcount_pic.c: New. gcc/ * config/i386/i386.c (ix86_init_pic_reg):

[gomp4] Remove goacc_parse_device_num

2014-10-28 Thread Julian Brown
Hi, This patch removes the goacc_parse_device_num function in libgomp's env.c since it is redundant with parse_int. I also added some bounds checking for the device number in oacc-init.c (the behaviour is left as implementation defined in the OpenACC 2.0 spec, so I chose to raise an error for an

[PATCH][7/n] Merge from match-and-simplify, SSA propagators

2014-10-28 Thread Richard Biener
The following hooks the machinery into SSA propagators via gimple_fold_stmt_to_constant[_1]. Unfortunately how SSA propagators work doesn't allow us to walk SSA edges here so to compensate for that shortcoming I am following single-use SSA edges when substitute_and_fold calls fold_stmt (as

Re: [match-and-simplify] reject conditional convert and commutative ops in result operand

2014-10-28 Thread Richard Biener
On Tue, Oct 28, 2014 at 1:26 PM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: On Tue, Oct 28, 2014 at 3:50 PM, Richard Biener richard.guent...@gmail.com wrote: On Mon, Oct 27, 2014 at 3:32 PM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: I suppose we should reject

Re: [PATCH, x86, 63534] Fix '-p' profile for 32 bit PIC mode

2014-10-28 Thread Jakub Jelinek
On Tue, Oct 28, 2014 at 04:10:12PM +0300, Evgeny Stupachenko wrote: Thank you, Jakub. The following patch passed bootstrap, gcc make check and spec2000 with -p -m32 -fPIC. Is it ok? ChangeLog: 2014-10-28 Evgeny Stupachenko evstu...@gmail.com gcc/testsuite *

Re: support operator list

2014-10-28 Thread Richard Biener
On Sun, Oct 26, 2014 at 7:40 AM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: Fixed a silly mistake in match-bitwise.pd (I had put ')' at wrong place). This patch also checks if operator-list is used outside for-pattern (in parser::parse_operation). With recent discussion on how to

Re: [gofrontend-dev] [PATCH 7/9] Gccgo port to s390[x] -- part I

2014-10-28 Thread Dominik Vogt
On Thu, Oct 16, 2014 at 04:45:03PM -0700, Ian Lance Taylor wrote: On Tue, Sep 9, 2014 at 6:02 AM, Dominik Vogt v...@linux.vnet.ibm.com wrote: +case 8: + return (is_unsigned) ? uint8 : int8; No need to parenthesize is_unsigned here and in the following lines. That's just my way of

Re: [debug-early] emit locals early patchset

2014-10-28 Thread Michael Matz
Hi, On Mon, 27 Oct 2014, Aldy Hernandez wrote: Here I use a new tree bit (BLOCK_DIE) to store the DIE-block relationship. This will have to be adapted and streamed for LTO. You might consider using an on-the-side tree-hash map. Saves memory when not generating debug info (there can be many

[match-and-simplify] Merge from trunk

2014-10-28 Thread Richard Biener
2014-10-28 Richard Biener rguent...@suse.de Merge from trunk r216772 through r216799. Brings back next merge piece.

Re: [wwwdocs] Add porting_to.html, describe gnu11 changes

2014-10-28 Thread Marek Polacek
Ping? On Wed, Oct 22, 2014 at 07:16:31PM +0200, Marek Polacek wrote: On Wed, Oct 22, 2014 at 09:56:08AM -0700, Mike Stump wrote: On Oct 22, 2014, at 8:29 AM, Marek Polacek pola...@redhat.com wrote: The following adds the porting_to.html document for GCC 5 and documents issues arising

Re: The nvptx port [7/11+] Inform the port about call arguments

2014-10-28 Thread Bernd Schmidt
On 10/22/2014 08:12 PM, Jeff Law wrote: Yea, let's keep your approach. Just wanted to explore a bit since the PA seems to have a variety of similar characteristics. Here's an updated version of the patch. I experimented a little with ptx calling conventions and ran into an arg that had to be

Re: [debug-early] emit locals early patchset

2014-10-28 Thread Richard Biener
On Tue, Oct 28, 2014 at 1:00 AM, Aldy Hernandez al...@redhat.com wrote: Gentlemen! My apologies for the big patch. In getting locals emitted early (parameters and locally scoped variables), I ran into many things which were in need of surgery, many of which couldn't happen without the other.

Re: The nvptx port [10/11+] Target files

2014-10-28 Thread Bernd Schmidt
On 10/22/2014 08:01 PM, Jeff Law wrote: Please make sure all the functions in nvptx.c have function comments. Done, and replaced regno 4 with NVPTX_RETURN_REGNUM. +const char * +nvptx_output_call_insn (rtx insn, rtx result, rtx callee) If possible, promote first argument to rtx_insn *.

[AArch64, Docs, Patch] Add reference to ACLE in docs.

2014-10-28 Thread Tejas Belagod
Hi, Here is patch that consolidates AArch64 and ARM Intrinsics sections in extend.texi into one ACLE section to avoid information repetition and adds reference to the ARM C Language Extension spec on infocenter.arm.com. Built aarch64-none-elf and viewed gcc.info and associated HTML. OK for

Re: [PATCH, x86, 63534] Fix '-p' profile for 32 bit PIC mode

2014-10-28 Thread Evgeny Stupachenko
Agree. Let't stop at first insn after entry block notes. As for the test it looks like mcount is general i?86 name. Bootstrap and make check are in progress. 2014-10-28 Evgeny Stupachenko evstu...@gmail.com gcc/testsuite PR target/63534 * gcc.target/i386/mcount_pic.c: New.

Re: [PATCH] Redesign jump threading profile updates

2014-10-28 Thread Renlin Li
On 01/10/14 21:04, Teresa Johnson wrote: The block frequencies are very small in this case leading to rounding errors when computing the edge frequency. The rounding error was then propagated into the recomputed probabilities, leading to insanities in the outgoing edge probabilities on the jump

Re: [gomp4] [2/3] OpenACC 2.0 support for libgomp - new tests

2014-10-28 Thread Thomas Schwinge
Hi! Committed in r216804: commit 4f9566b3e2954218c0d9ce3c585e14e539f0c1af Author: tschwinge tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4 Date: Tue Oct 28 15:57:48 2014 + libgomp: Don't refer to CUDA installation in /opt/nvidia/cuda-5.5/. libgomp/ *

[PATCH, IPA ICF] Fix PR63664, PR63574 (segfault in ipa-icf pass)

2014-10-28 Thread Ilya Enkovich
Hi, This patch fixes PR63664 and PR63574. Problem is in NULL types for labels not handled by ICF properly. I assume it is OK for labels to have NULL type and added check into ICF rather then fixed label generation. Bootstrapped and checked on linux-x86_64. OK for trunk? Thanks, Ilya --

[gomp4] Don't put acc_notify_var in thread-local struct

2014-10-28 Thread Julian Brown
Hi, This patch moves acc_notify_var out of gomp_task_icv and makes it simply a global variable instead. OK for gomp4 branch? Thanks, Julian ChangeLog libgomp/ * env.c (goacc_notify_var): New. (initialize_env): Use above instead of gomp_global_icv.acc_notify_var. * error.c

[PATCH, Pointer Bounds Checker 40/x] Support in IPA ICF

2014-10-28 Thread Ilya Enkovich
Hi, After recent merge with trunk I found that new IPA pass ICF requires few modifications for instrumented code: - instrumentation thunk existence means we cannot merge function into another one and should generate thunk instead - thunk generation should set with_bounds flag for instrumented

[gomp4] Remove redundant get_caps hook invocations

2014-10-28 Thread Julian Brown
Hi, This patch causes the get_caps hook to be called only once during device initialisation, and caches the result in the device's capabilities field. OK for gomp4 branch? Thanks, Julian ChangeLog libgomp/ * target.c (gomp_load_plugin_for_device): Only call get_caps once.

[gomp4] Remove stray debugging code

2014-10-28 Thread Julian Brown
Hi, This patch removes some debugging code leftover from development. It's probably not helpful to keep it around now. OK for gomp4 branch? Thanks, Julian ChangeLog libgomp/ * oacc-host.c (DEBUG): Remove undefine. * plugin-nvptx.c (DEBUG, DISABLE_ASYNC): Remove comment-out macro

[gomp4] Remove gomp_map_vars mem_map argument

2014-10-28 Thread Julian Brown
Hi, This patch removes the now-redundant gomp_memory_mapping argument from gomp_map_vars, introduced when OpenACC kept the structure in question in a different place from OpenMP. Both now keep the memory map in the gomp_device_descr structure, so there's no need to pass both that and the memory

Re: [gomp4] Remove gomp_map_vars mem_map argument

2014-10-28 Thread Julian Brown
On Tue, 28 Oct 2014 16:52:22 + Julian Brown jul...@codesourcery.com wrote: Hi, This patch removes the now-redundant gomp_memory_mapping argument from gomp_map_vars, introduced when OpenACC kept the structure in question in a different place from OpenMP. Both now keep the memory map in

RE: [PATCHv2][MIPS] Implement O32 ABI extensions (GCC)

2014-10-28 Thread Matthew Fortune
Moore, Catherine catherine_mo...@mentor.com writes: Review comments are attached. I will tackle the R6 patch next. Thanks, Catherine Thanks Catherine. Depending on whether the fix to the following hunk needs discussion I'll make the changes and commit. static bool

Re: [gofrontend-dev] [PATCH 7/9] Gccgo port to s390[x] -- part I

2014-10-28 Thread Ian Taylor
On Tue, Oct 28, 2014 at 7:31 AM, Dominik Vogt v...@linux.vnet.ibm.com wrote: The attached patch contains all the discussed changes. I made a few formatting changes. I patched the test to work on x86, by making the char types accept either int8 or uint8, and making the long double tests accept

Re: [debug-early] emit locals early patchset

2014-10-28 Thread Jason Merrill
On 10/27/2014 08:00 PM, Aldy Hernandez wrote: 2. Changes to gen_variable_die() to handle multiple passes (early/late dwarf generation). A lot of this is complicated by the fact that old_die's are cached and keyed by `tree', but an abstract instance and an inline instance share trees, while

Re: [PATCH 5/5] add libcc1

2014-10-28 Thread Phil Muldoon
On 28/10/14 13:19, Joseph S. Myers wrote: I'm seeing a different bootstrap failure from those already discussed: In file included from /scratch/jmyers/fsf/gcc-mainline/libcc1/../gcc/gcc-plugin.h:28:0, from /scratch/jmyers/fsf/gcc-mainline/libcc1/plugin.cc:34:

Re: [debug-early] emit locals early patchset

2014-10-28 Thread Aldy Hernandez
On 10/28/14 07:40, Michael Matz wrote: Hi, On Mon, 27 Oct 2014, Aldy Hernandez wrote: Here I use a new tree bit (BLOCK_DIE) to store the DIE-block relationship. This will have to be adapted and streamed for LTO. You might consider using an on-the-side tree-hash map. Saves memory when not

libgo patch committed: Add consts for ioctl

2014-10-28 Thread Ian Taylor
This patch from Lynn Boger ensures that some ioctl constants are available on more systems. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r ec3c929aae72 libgo/mksysinfo.sh --- a/libgo/mksysinfo.shTue Oct 28 10:34:18 2014 -0700 +++

Re: [PATCH, x86, 63534] Fix '-p' profile for 32 bit PIC mode

2014-10-28 Thread Jakub Jelinek
On Tue, Oct 28, 2014 at 06:28:29PM +0300, Evgeny Stupachenko wrote: +/* Delete SET_GOT right after entry block if it is allocated to reg. */ + +static void +ix86_elim_entry_set_got (rtx reg) +{ + basic_block bb = ENTRY_BLOCK_PTR_FOR_FN (cfun)-next_bb; + rtx_insn *c_insn; +

[gimple-classes] Merge trunk r216157-r216746 into branch

2014-10-28 Thread David Malcolm
Merger of changes on trunk from r216157 (2014-10-13) to r216746 (2014-10-27) into the dmalcolm/gimple-classes branch. I committed this in two parts: the basic merger: 1a7adffe0f7c9be5b48042c27bc6cddece467da9 resolving minor conflicts in these files: gcc/builtins.h

Re: [gimple-classes] Merge trunk r216157-r216746 into branch

2014-10-28 Thread David Malcolm
On Tue, 2014-10-28 at 14:47 -0400, David Malcolm wrote: Merger of changes on trunk from r216157 (2014-10-13) to r216746 (2014-10-27) into the dmalcolm/gimple-classes branch. [...] Successfully bootstrappedregrtested on x86_64-unknown-linux-gnu (Fedora 20) - same results relative to an

Re: [gomp4] Don't put acc_notify_var in thread-local struct

2014-10-28 Thread Thomas Schwinge
Hi Julian! On Tue, 28 Oct 2014 16:37:29 +, Julian Brown jul...@codesourcery.com wrote: This patch moves acc_notify_var out of gomp_task_icv and makes it simply a global variable instead. OK for gomp4 branch? Yes, thanks! libgomp/ * env.c (goacc_notify_var): New.

Re: [gomp4] Remove redundant get_caps hook invocations

2014-10-28 Thread Thomas Schwinge
Hi Julian! On Tue, 28 Oct 2014 16:40:31 +, Julian Brown jul...@codesourcery.com wrote: This patch causes the get_caps hook to be called only once during device initialisation, and caches the result in the device's capabilities field. OK for gomp4 branch? Yes, thanks! I think such

Re: [PATCH 2/n] OpenMP 4.0 offloading infrastructure: LTO streaming

2014-10-28 Thread Ilya Verbin
On 24 Oct 16:20, Jakub Jelinek wrote: Can't you do that when creating the cgraph or varpool nodes? I'd expect the attribute to be already present on the decls at those spots. I cached omp declare target attribute in a symtab node. Is this patch better? OpenMP tests passed, make check in

Re: [gomp4] Remove stray debugging code

2014-10-28 Thread Thomas Schwinge
Hi Julian! On Tue, 28 Oct 2014 16:43:11 +, Julian Brown jul...@codesourcery.com wrote: This patch removes some debugging code leftover from development. It's probably not helpful to keep it around now. Agreed. It remains available in the revision control system, but I've found that

Re: [gomp4] Remove gomp_map_vars mem_map argument

2014-10-28 Thread Thomas Schwinge
Hi Julian! On Tue, 28 Oct 2014 16:52:22 +, Julian Brown jul...@codesourcery.com wrote: This patch removes the now-redundant gomp_memory_mapping argument from gomp_map_vars, introduced when OpenACC kept the structure in question in a different place from OpenMP. Both now keep the memory

[gomp4] Synchronous mode? (was: [1/3] OpenACC 2.0 support for libgomp - OpenACC runtime, NVidia PTX/CUDA plugin)

2014-10-28 Thread Thomas Schwinge
Hi! One remark here, not related to the patch itself: On Tue, 14 Oct 2014 17:11:18 +0100, Julian Brown jul...@codesourcery.com wrote: --- /dev/null +++ b/libgomp/plugin-nvptx.c +//#define DISABLE_ASYNC +#ifndef DISABLE_ASYNC + [...] +#else + r = cuCtxSynchronize (); + if (r !=

Re: [gomp4] Remove goacc_parse_device_num

2014-10-28 Thread Thomas Schwinge
Hi Julian! On Tue, 28 Oct 2014 13:19:18 +, Julian Brown jul...@codesourcery.com wrote: This patch removes the goacc_parse_device_num function in libgomp's env.c since it is redundant with parse_int. I also added some bounds checking for the device number in oacc-init.c (the behaviour is

[COMMITTED] longlong.h: Disable alpha umul_ppmm for old g++

2014-10-28 Thread Richard Henderson
I can't tell if this is fixed on mainline, because __builtin expansion happens at a different time, or if it's still broken but hidden somehow. But using gcc 4.8 as a bootstrap compiler for alphaev67-linux, we get a sorry: unexpected AST of kind MULT_HIGHPART. It seems easiest to simply disable

RE: [Patch] Add MIPS flag to avoid use of ldc1/sdc1/ldxc1/sdxc1

2014-10-28 Thread Matthew Fortune
Matthew Fortune matthew.fort...@imgtec.com writes: Do you have an objection to allowing an option to disable these instructions (despite the reason for wanting to do so)? Yes this seems like a bad workaround for broken code. Well, we work around broken hardware all the time.

RE: [Patch] Add MIPS flag to avoid use of ldc1/sdc1/ldxc1/sdxc1

2014-10-28 Thread Steve Ellcey
On Tue, 2014-10-28 at 14:06 -0700, Matthew Fortune wrote: While the patch could be fixed to account for all of this we need to determine if the case which won't work is the exact one which is needed (and I believe it is). I.e. Android applications for MIPS are MIPS32r1 O32 FP32 NAN1985

libgo patch committed: Recognize PPC relocs

2014-10-28 Thread Ian Taylor
This patch to libgo recognizes PPC relocations in the debug/elf package. This is a backport of https://codereview.appspot.com/125910043 which was applied to the PPC development branch of the master Go repository. For this patch bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu.

Re: PATCH: fix breakage from [PATCH] Fix genmatch linking

2014-10-28 Thread Paolo Bonzini
On 10/24/2014 06:32 AM, Hans-Peter Nilsson wrote: It seems more correct to just disable the config.cache sharing between the differently-configured build-subdirectories, as is already is done for host-libraries and target-libraries, even if that may slow down the builds. Yes, please do.

Re: [AArch64, Docs, Patch] Add reference to ACLE in docs.

2014-10-28 Thread Joseph S. Myers
On Tue, 28 Oct 2014, Tejas Belagod wrote: Hi, Here is patch that consolidates AArch64 and ARM Intrinsics sections in extend.texi into one ACLE section to avoid information repetition and adds reference to the ARM C Language Extension spec on infocenter.arm.com. This seems to lose the

Re: [PATCH 5/5] add libcc1

2014-10-28 Thread Joseph S. Myers
On Tue, 28 Oct 2014, Phil Muldoon wrote: Joseph, Hi, sorry for the troubles! I am having difficulty seeing this fail on my system. I built gmp from upstream, installed it, and pointed to the install location with --with-gmp. Which stage does your build fail at? To get the failure you

[BUILDROBOT] Unused static function (was: RFA: AVR: add infrastructure for device packages)

2014-10-28 Thread Jan-Benedict Glaw
On Wed, 2014-10-08 18:50:32 +0100, Joern Rennecke joern.renne...@embecosm.com wrote: Attached is the GCC patch for the basic device package infrastructure. OK to apply? There's some fallout on config-list.mk builds: g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions

[PATCH] Add memory barriers to xbegin/xend/xabort

2014-10-28 Thread Andi Kleen
From: Andi Kleen a...@linux.intel.com xbegin/xend/xabort were missing memory barriers. This can lead to memory operations being moved out of transactions, which would cause unexpected races. Always generate implicit memory barriers for these intrinsics. The compat header versions always

Re: fix math wrt volatile-bitfields vs C++ model

2014-10-28 Thread DJ Delorie
Looks ok to me, but can you add a testcase please? Also check if 4.9 is affected. Sorry for the delay, this finally made it back to the top of my to-do list. Testcase included which fails without and passes with this patch. 4.9 is affected and the same patch fixes it. Tested on rx-elf,