[PING][PATCH] constrain one character optimization to one character stores (PR 90989)

2019-07-08 Thread Martin Sebor
Ping: https://gcc.gnu.org/ml/gcc-patches/2019-06/msg01506.html Jeff (et al.), do you have any outstanding questions/concerns about the patch? Martin On 6/27/19 4:30 PM, Jeff Law wrote: On 6/27/19 12:40 PM, Richard Biener wrote: On June 27, 2019 7:04:32 PM GMT+02:00, Jakub Jelinek wrote: On

Re: [PATCH V4] PR88497 - Extend reassoc for vector bit_field_ref

2019-07-08 Thread Kewen.Lin
Hi Segher, on 2019/7/9 上午12:32, Segher Boessenkool wrote: > Hi Kewen, > > On Mon, Jul 08, 2019 at 04:07:00PM +0800, Kewen.Lin wrote: >> gcc/ChangeLog > > (You have trailing spaces in the changelog, fwiw). > Thanks for catching! >> --- /dev/null >> +++

Re: [PATCH 1/2] Come up with function_decl_type and use it in tree_function_decl.

2019-07-08 Thread Marc Glisse
On Mon, 8 Jul 2019, Martin Liška wrote: The patch apparently has DECL_IS_OPERATOR_DELETE only on the replaceable global deallocation functions, not all delete operators, contrary to DECL_IS_OPERATOR_NEW, so the name is misleading. On the other hand, those seem to be the ones for which the

Re: [PATCH 2/3] change class-key of PODs to struct and others to class (PR 61339)

2019-07-08 Thread Martin Sebor
Hopefully with the right patch this time (thanks Jon). On 7/8/19 4:00 PM, Martin Sebor wrote: The attached patch changes the class-key of class definitions that satisfy the requirements on a POD struct to 'struct', and that of struct definitions that aren't POD to class, according to the GCC

[PATCH] Improve scan_operand_equal_p

2019-07-08 Thread Jakub Jelinek
Hi! The 4 testcases below weren't vectorized, because while tree-vect-data-refs.c now allows more forms of simd lane access, scan_operand_equal_p didn't allow combining them together. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. 2019-07-08 Jakub

Re: [patch, c++ openmp] Improve diagnostics for unmappable types

2019-07-08 Thread Jakub Jelinek
On Thu, Jul 04, 2019 at 12:44:32PM +0100, Andrew Stubbs wrote: > On 03/07/2019 18:58, Jason Merrill wrote: > > OK, thanks. > > Committed. This broke following testcase. error_mark_node type isn't really incomplete, it is errorneous, doesn't have TYPE_MAIN_DECL and we should have diagnosed it

Re: [PATCH] Add generic support for "noinit" attribute

2019-07-08 Thread Martin Sebor
On 7/8/19 5:10 AM, Christophe Lyon wrote: On Sat, 6 Jul 2019 at 19:57, Martin Sebor wrote: On 7/4/19 9:27 AM, Christophe Lyon wrote: Hi, Similar to what already exists for TI msp430 or in TI compilers for arm, this patch adds support for the "noinit" attribute. It is convenient for

[PATCH 2/3] change class-key of PODs to struct and others to class (PR 61339)

2019-07-08 Thread Martin Sebor
The attached patch changes the class-key of class definitions that satisfy the requirements on a POD struct to 'struct', and that of struct definitions that aren't POD to class, according to the GCC coding convention. The patch is also prerequisite for GCC being able to compile cleanly with

Re: [PATCH 1/2] Come up with function_decl_type and use it in tree_function_decl.

2019-07-08 Thread Jason Merrill
On Mon, Jul 8, 2019 at 8:51 AM Martin Liška wrote: > > On 7/5/19 12:09 AM, Marc Glisse wrote: > > On Wed, 3 Jul 2019, Richard Biener wrote: > > > >> On July 3, 2019 4:53:30 PM GMT+02:00, "Martin Liška" > >> wrote: > >>> On 7/2/19 7:15 PM, Marc Glisse wrote: > On Tue, 2 Jul 2019, Martin

[PATCH 1/3] add -Wstruct-not-pod, -Wclass-is-pod, -Wmismatched-tags (PR 61339)

2019-07-08 Thread Martin Sebor
The attached patch implements three new warnings: * -Wstruct-not-pod triggers for struct definitions that are not POD structs, * -Wclass-is-pod triggers for class definitions that satisfy the requirements on POD structs, and * -Wmismatched-tags that triggers for class and struct

[PATCH 0/3] add support for POD struct convention (PR 61339)

2019-07-08 Thread Martin Sebor
A couple of GCC's Coding Conventions call to 1) Use the struct keyword for plain old data (POD) types. https://www.gnu.org/software/gcc/codingrationale.html#struct and 2) Use the class keyword for non-POD types. https://www.gnu.org/software/gcc/codingconventions.html#Class_Use

Re: [C++ Patch] A few additional location improvements to grokdeclarator and check_tag_decl

2019-07-08 Thread Jason Merrill
On 6/23/19 7:58 AM, Paolo Carlini wrote: +error_at (smallest_type_location (get_type_quals (declspecs), + declspecs->locations), How about adding a smallest_type_location overload that just takes declspecs? Jason

Re: [PATCH] Perform case-insensitive comparison when decoding register names (PR target/70320)

2019-07-08 Thread Segher Boessenkool
On Mon, Jul 08, 2019 at 10:21:29PM +0100, Jozef Lawrynowicz wrote: > On Mon, 08 Jul 2019 21:14:36 +0100 > Richard Sandiford wrote: > > > Segher Boessenkool writes: > > > It isn't obviously safe either. Are there any targets that have names > > > for different registers that differ only in

Re: [PATCH] Perform case-insensitive comparison when decoding register names (PR target/70320)

2019-07-08 Thread Jozef Lawrynowicz
On Mon, 08 Jul 2019 21:14:36 +0100 Richard Sandiford wrote: > Segher Boessenkool writes: > > On Thu, Jul 04, 2019 at 01:32:59PM +0100, Jozef Lawrynowicz wrote: > >> The attached patch allows the case of register names used in an asm > >> statement > >> clobber list to be disregarded when

Re: [PATCH, Modula-2 (C/C++/D/F/Go/Jit)] (Register spec fn) (v2)

2019-07-08 Thread Matthias Klose
On 14.06.19 15:09, Gaius Mulley wrote: > > Hello, > > here is version two of the patches which introduce Modula-2 into the > GCC trunk. The patches include: > > (*) a patch to allow all front ends to register a lang spec function. >(included are patches for all front ends to provide

[PATCH] rs6000: Ignore GFXOPT (and GPOPT) for choosing machine

2019-07-08 Thread Segher Boessenkool
The function rs6000_machine_from_flags chooses what .machine string to used based on the rs6000_isa_flags flags. For that it checks for each ISA level if something for its ISA_*_MASKS is selected. This does not work for GFXOPT and GPOPT: these are set as flags in ISA_2_5_MASKS_SERVER, but they

Re: [RFC][PR89245] Check REG_CALL_DECL note during the tail-merging

2019-07-08 Thread Richard Sandiford
Dragan Mladjenovic writes: > From: "Dragan Mladjenovic" > > This patch prevents merging of CALL instructions that that have different > REG_CALL_DECL notes attached to them. > > On most architectures this is not an important distinction. Usually > instruction patterns > for calls to different

[PATCH] rs6000: Add testcase for PR88233

2019-07-08 Thread Segher Boessenkool
This testcase tests that with -mcpu=power8 we do not generate any mtvsr* instructions, and we do the copy with {l,st}xvd2x. This currently fails with -m32. That is an RA problem; I'll open a new PR for that. Committing. 2019-07-08 Segher Boessenkool gcc/testsuite/ PR

Re: [PATCH] Perform case-insensitive comparison when decoding register names (PR target/70320)

2019-07-08 Thread Richard Sandiford
Segher Boessenkool writes: > On Thu, Jul 04, 2019 at 01:32:59PM +0100, Jozef Lawrynowicz wrote: >> The attached patch allows the case of register names used in an asm statement >> clobber list to be disregarded when checking the validity of the register >> names. >> >> Currently, the register

[wwwdocs,C++] Fix projects/cxx-dr-status.html markup (and avoid )

2019-07-08 Thread Gerald Pfeifer
let alone are obsolete elements in current HTML, and validator.w3.org hence has been loudly complaining about projects/cxx-dr-status.html which Marek kindly added and updated in the last couple of days. The patch below addresses all 487 validation errors on that page. :-) Committed (in two

Re: [PATCH] Add -fprofile-note option.

2019-07-08 Thread Sandra Loosemore
On 7/8/19 11:43 AM, Martin Liška wrote: @@ -12407,7 +12407,9 @@ To optimize the program based on the collected profile information, use @item -fprofile-note=@var{path} @opindex fprofile-note -If @var{path} is specified, GCC saves gcno filename into @var{path} location. +If @var{path} is

Re: [COMMITTED] Turn of ipa-ra in builtins test (PR91059)

2019-07-08 Thread Wilco Dijkstra
Hi Alexander, > Would have been nice if the above text also mentioned that PR 78527 has some > background info for the "obvious".  The paragraph went into commit text, but > on > its own it doesn't explain what's "obvious" here at all :( The "obvious" refers to the patch itself under the

Re: [PATCH] PowerPC Prefixed Memory, Patch #4, Add pc-relative reference support

2019-07-08 Thread Segher Boessenkool
On Mon, Jul 08, 2019 at 02:42:13PM -0400, Michael Meissner wrote: > On Wed, Jul 03, 2019 at 05:09:57PM -0500, Segher Boessenkool wrote: > > Hi Mike, > > > > On Fri, Jun 28, 2019 at 02:50:33PM -0400, Michael Meissner wrote: > > > --- gcc/config/rs6000/rs6000-logue.c (revision 272714) > > >

Re: [PATCH] PowerPC Prefixed Memory, Patch #4, Add pc-relative reference support

2019-07-08 Thread Michael Meissner
On Wed, Jul 03, 2019 at 05:09:57PM -0500, Segher Boessenkool wrote: > Hi Mike, > > On Fri, Jun 28, 2019 at 02:50:33PM -0400, Michael Meissner wrote: > > --- gcc/config/rs6000/rs6000-logue.c(revision 272714) > > +++ gcc/config/rs6000/rs6000-logue.c(working copy) > > @@ -1406,23

Re: [patch] Small improvements to coverage info (3/n)

2019-07-08 Thread Jeff Law
On 7/8/19 3:32 AM, Eric Botcazou wrote: > Hi, > > a couple of fixes for the RTL middle-end this time, with the same goal of > preventing instructions from inheriting random source location information > in the debug info generated by the compiler. > > Tested on x86_64-suse-linux, both GCC and

Re: [PATCH] Remove usage of ZSTD_CLEVEL_DEFAULT define.

2019-07-08 Thread Jeff Law
On 7/8/19 11:27 AM, Martin Liška wrote: > Hi. > > As Martin Jambor noticed, a zstd ZSTD_CLEVEL_DEFAULT macro is not > defined in a bit older releases of zstd. However, one can use 0 > as a default compression level. > > Ready to be installed after regression tests & bootstrap? > Thanks, > Martin

Re: [COMMITTED] Turn of ipa-ra in builtins test (PR91059)

2019-07-08 Thread Alexander Monakov
On Mon, 8 Jul 2019, Wilco Dijkstra wrote: > The gcc.c-torture/execute/builtins/lib directory contains a reimplementation > of many C library string functions, which causes non-trivial register > allocation > bugs with LTO and static linked libraries. To fix this long-standing test > issue, >

Re: [PATCH 1/2] [ARC] Fix and refurbish the interrupts.

2019-07-08 Thread Jeff Law
On 7/8/19 2:35 AM, Claudiu Zissulescu wrote: > Hi Jeff, > > Originally, I had the scheduler barrier as you suggested. However, > there were some user cases when an ISR messed up with SP register > leading to errors. As a solution was to add barriers on either part of > frame operations. However,

Re: [PATCH] Add -fprofile-note option.

2019-07-08 Thread Martin Liška
On 7/4/19 1:15 AM, Sandra Loosemore wrote: On 7/2/19 6:37 AM, Martin Liška wrote: @@ -12403,6 +12403,11 @@ the profile feedback data files. See @option{-fprofile-dir}.  To optimize the program based on the collected profile information, use  @option{-fprofile-use}.  @xref{Optimize Options},

[wwwdocs] Introducing C++ DR status table

2019-07-08 Thread Marek Polacek
For a long time I wished we had a table documenting the status of C++ defect reports in the C++ FE, like clang has [1]. I finally got around to tackling this bad boy and created and will now commit the attached patch. The table was created by an

Re: [PATCH] subreg: Add -fsplit-wide-types-early (PR88233)

2019-07-08 Thread Segher Boessenkool
On Mon, Jul 08, 2019 at 12:20:55PM -0500, Segher Boessenkool wrote: > On Mon, Jul 08, 2019 at 01:27:25PM +0200, Richard Biener wrote: > > The docs should mention that the new option doesn't have any effect > > unless -fsplit-wide-types is enabled. > > Yeah I'll make that more explicit. I added

[PATCH] Remove usage of ZSTD_CLEVEL_DEFAULT define.

2019-07-08 Thread Martin Liška
Hi. As Martin Jambor noticed, a zstd ZSTD_CLEVEL_DEFAULT macro is not defined in a bit older releases of zstd. However, one can use 0 as a default compression level. Ready to be installed after regression tests & bootstrap? Thanks, Martin gcc/ChangeLog: 2019-07-08 Martin Liska *

Re: [PATCH] subreg: Add -fsplit-wide-types-early (PR88233)

2019-07-08 Thread Segher Boessenkool
On Mon, Jul 08, 2019 at 01:27:25PM +0200, Richard Biener wrote: > On Sun, Jul 7, 2019 at 7:12 PM Segher Boessenkool > wrote: > > > > Currently the second lower-subreg pass is run right before RA. This > > is much too late to be very useful. At least for targets that do not > > have RTL patterns

[COMMITTED] Turn of ipa-ra in builtins test (PR91059)

2019-07-08 Thread Wilco Dijkstra
The gcc.c-torture/execute/builtins/lib directory contains a reimplementation of many C library string functions, which causes non-trivial register allocation bugs with LTO and static linked libraries. To fix this long-standing test issue, turn off ipa-ra which avoids the register corruption

Re: [PATCH][GCC][AArch64] Make processing less fragile in config.gcc

2019-07-08 Thread James Greenhalgh
On Tue, Jun 25, 2019 at 09:30:30AM +0100, Tamar Christina wrote: > Hi All, > > This is an update to the patch rebased to after the SVE2 options have been > merged. > > Bootstrapped Regtested on aarch64-none-linux-gnu and no issues. > > Ok for trunk? OK. Thanks, James > > Thanks, > Tamar >

RE: [patch 1/2][aarch64]: redefine aes patterns

2019-07-08 Thread Sylvia Taylor
Hi James, I forgot to mention that. Yes, please do commit it on my behalf. Cheers, Syl

Re: [patch 1/2][aarch64]: redefine aes patterns

2019-07-08 Thread James Greenhalgh
On Fri, Jul 05, 2019 at 12:24:42PM +0100, Sylvia Taylor wrote: > Greetings, > > This first patch removes aarch64 usage of the aese/aesmc and aesd/aesimc > fusions (i.e. aes fusion) implemented in the scheduler due to unpredictable > behaviour observed in cases such as: > - when register

Re: [PATCH V4] PR88497 - Extend reassoc for vector bit_field_ref

2019-07-08 Thread Segher Boessenkool
Hi Kewen, On Mon, Jul 08, 2019 at 04:07:00PM +0800, Kewen.Lin wrote: > gcc/ChangeLog (You have trailing spaces in the changelog, fwiw). > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/tree-ssa/pr88497-1.c > @@ -0,0 +1,60 @@ > +/* { dg-do run } */ > +/* { dg-require-effective-target vect_double }

Re: Prevent tree-ssa-dce.c from deleting stores at -Og

2019-07-08 Thread Richard Biener
On Mon, Jul 8, 2019 at 4:41 PM Richard Sandiford wrote: > > Richard Biener writes: > > On Sun, Jul 7, 2019 at 9:07 PM Jeff Law wrote: > >> > >> On 7/7/19 3:45 AM, Richard Sandiford wrote: > >> > DCE tries to delete dead stores to local data and also tries to insert > >> > debug binds for simple

Re: [patch, libfortran] Adjust block size for libgfortran for unformatted reads

2019-07-08 Thread Steve Kargl
On Mon, Jul 08, 2019 at 04:02:17PM +0300, Janne Blomqvist wrote: > > Good point. If you happen to have a USB stick handy, can you try the > simple C benchmark program at > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91030#c38 ? > > (the kernel will coalesce IO's by itself, so the granularity of

Re: [PING][AArch64] Use scvtf fbits option where appropriate

2019-07-08 Thread Joel Hutton
On 01/07/2019 18:03, James Greenhalgh wrote: >> gcc/testsuite/ChangeLog: >> >> 2019-06-12 Joel Hutton >> >> * gcc.target/aarch64/fmul_scvtf_1.c: New test. > This testcase will fail on ILP32 targets where unsigned long will still > live in a 'w' register. Updated to use long long and

Re: [PATCH, Modula-2 (C/C++/D/F/Go/Jit)] (Register spec fn) (v2)

2019-07-08 Thread Gaius Mulley
Gaius Mulley writes: > Hi Rainer, > > it rather depends upon what you want, if you want the latest complete > gm2 grafting onto the svn gcc trunk then these two scripts will create a > patched tree and also rebuild gm2. > > > > [however please be careful with the scripts - they do assume that >

Re: [PATCH, Modula-2 (C/C++/D/F/Go/Jit)] (Register spec fn) (v2)

2019-07-08 Thread Rainer Orth
Hi Gaius, >> I meant to give a build with gm2 included a try on Solaris, but ended up >> pretty much confused: >> >> * I've started with the gm2 repo on savannah. Running the combine-trees >> script on master tried to combine gm2 with gcc 4.7.4. Trying again >> with configure

PING^4: [PATCH] i386: Properly encode xmm16-xmm31/ymm16-ymm31 for vector move

2019-07-08 Thread H.J. Lu
On Tue, Jun 18, 2019 at 8:59 AM H.J. Lu wrote: > > On Fri, May 31, 2019 at 10:38 AM H.J. Lu wrote: > > > > On Tue, May 21, 2019 at 2:43 PM H.J. Lu wrote: > > > > > > On Fri, Feb 22, 2019 at 8:25 AM H.J. Lu wrote: > > > > > > > > Hi Jan, Uros, > > > > > > > > This patch fixes the wrong code

Re: [PATCH, Modula-2 (C/C++/D/F/Go/Jit)] (Register spec fn) (v2)

2019-07-08 Thread Gaius Mulley
Rainer Orth writes: > Hi Gaius, > >> here is version two of the patches which introduce Modula-2 into the >> GCC trunk. The patches include: >> >> (*) a patch to allow all front ends to register a lang spec function. >>(included are patches for all front ends to provide an empty >>

Re: Prevent tree-ssa-dce.c from deleting stores at -Og

2019-07-08 Thread Jeff Law
On 7/8/19 5:34 AM, Richard Biener wrote: > On Sun, Jul 7, 2019 at 9:07 PM Jeff Law wrote: >> >> On 7/7/19 3:45 AM, Richard Sandiford wrote: >>> DCE tries to delete dead stores to local data and also tries to insert >>> debug binds for simple cases: >>> >>> /* If this is a store into a variable

Re: Prevent tree-ssa-dce.c from deleting stores at -Og

2019-07-08 Thread Richard Sandiford
Richard Biener writes: > On Sun, Jul 7, 2019 at 9:07 PM Jeff Law wrote: >> >> On 7/7/19 3:45 AM, Richard Sandiford wrote: >> > DCE tries to delete dead stores to local data and also tries to insert >> > debug binds for simple cases: >> > >> > /* If this is a store into a variable that is being

Re: [PATCH][ARM][testsuite] Fix address of sg stubs in CMSE tests

2019-07-08 Thread Christophe Lyon
ping? I think that's almost obvious? And maybe should be applied to release branches. Christophe On Tue, 2 Jul 2019 at 16:41, Christophe Lyon wrote: > > Hi, > > While running the GCC testsuite with an armv8-m target, I noticed that > a few tests where causing the BFD linker to crash. I opened

Re: [ARM/FDPIC v5 00/21] FDPIC ABI for ARM

2019-07-08 Thread Christophe Lyon
ping^5? On Mon, 1 Jul 2019 at 14:15, Christophe Lyon wrote: > > ping^4 ? > https://gcc.gnu.org/ml/gcc-patches/2019-05/msg00817.html > > On Mon, 17 Jun 2019 at 13:41, Christophe Lyon > wrote: > > > > ping^3 ? > > > > On Thu, 6 Jun 2019 at 14:36, Christophe Lyon > > wrote: > > > > > > Hi, > > >

Re: Don't run DSE at -Og

2019-07-08 Thread Richard Sandiford
Richard Biener writes: > On Sun, Jul 7, 2019 at 9:04 PM Jeff Law wrote: >> >> On 7/7/19 3:43 AM, Richard Sandiford wrote: >> > This patch stops gimple and rtl DSE from running by default at -Og. >> > The idea is both to improve compile time and to stop us from deleting >> > stores that we can't

Re: [PATCH 0/3] S/390: Shift count improvements.

2019-07-08 Thread Andreas Krebbel
On 06.07.19 22:53, Robin Dapp wrote: > Hi, > > these patches introduce a new predicate that recognizes > shift-count operands instead of the subst patterns we > used before. This allows introducing (no-op) subregs in > the patterns which was not possible via subst before > (see

Re: [PATCH,RFC,V3 0/5] Support for CTF in GCC

2019-07-08 Thread Nix
On 5 Jul 2019, Jakub Jelinek outgrape: > On Fri, Jul 05, 2019 at 07:28:12PM +0100, Nix wrote: >> > What makes it superior to DWARF stripped down to the above feature set? >> >> Increased compactness. DWARF fundamentally trades off compactness in >> favour of its regular structure, which makes it

Re: [committed] OpenMP scan for combined for simd

2019-07-08 Thread Rainer Orth
Hi Jakub, > The following patch handles the last yet unsupported scan case, > composite #pragma omp {,parallel }for simd ... reduction(inscan, ...) ... > where we want to both parallelize and vectorize; in the first worksharing > loop use normal scan support we have for > #pragma omp simd ...

Re: [patch, libfortran] Adjust block size for libgfortran for unformatted reads

2019-07-08 Thread Janne Blomqvist
On Sun, Jul 7, 2019 at 11:13 PM Thomas Koenig wrote: > > Hello world, > > the attached patch sets the I/O block size for unformatted files to > 2**17 and makes this, and the block size for formatted files, > adjustable via environment variables. Should the default be affected by the page size

**ping** Re: [PATCH] Automatics in equivalence statements

2019-07-08 Thread Mark Eggleston
**ping** On 01/07/2019 10:35, Mark Eggleston wrote: On 25/06/2019 14:17, Mark Eggleston wrote: On 25/06/2019 00:17, Jeff Law wrote: On 6/24/19 2:19 AM, Bernhard Reutner-Fischer wrote: On Fri, 21 Jun 2019 07:10:11 -0700 Steve Kargl wrote: On Fri, Jun 21, 2019 at 02:31:51PM +0100, Mark

Re: [PATCH, committed] Add myself to MAINTAINERS

2019-07-08 Thread Kito Cheng
Hi Jakub: Thanks, fixed and checked with maintainers-verify.sh now. 2019-07-08 Kito Cheng * MAINTAINERS (Write After Approval): Remove myself, already listed in RISC-V port maitainer. Index: MAINTAINERS === ---

Re: [patch, libfortran] Adjust block size for libgfortran for unformatted reads

2019-07-08 Thread Janne Blomqvist
On Mon, Jul 8, 2019 at 11:18 AM Manfred Schwarb wrote: > > Am 07.07.19 um 22:13 schrieb Thomas Koenig: > > Hello world, > > > > the attached patch sets the I/O block size for unformatted files to > > 2**17 and makes this, and the block size for formatted files, > > adjustable via environment

Re: [PATCH 1/2] Come up with function_decl_type and use it in tree_function_decl.

2019-07-08 Thread Martin Liška
On 7/5/19 12:09 AM, Marc Glisse wrote: > On Wed, 3 Jul 2019, Richard Biener wrote: > >> On July 3, 2019 4:53:30 PM GMT+02:00, "Martin Liška" wrote: >>> On 7/2/19 7:15 PM, Marc Glisse wrote: On Tue, 2 Jul 2019, Martin Liška wrote: > After the discussion with Richi and Nathan, I made

Re: [PATCH, committed] Add myself to MAINTAINERS

2019-07-08 Thread Jakub Jelinek
On Mon, Jul 08, 2019 at 05:16:26PM +0800, Kito Cheng wrote: > Hi Rainer: > > Thanks your reminder, I've fix it now. Still not correct, there is FAIL maintainers-verify.sh. You are already since r246280 listed as riscv CPU port maintainer (one of 4) and maintainers should not be listed in the

[C++] DEFERRED_PARSE

2019-07-08 Thread Nathan Sidwell
Jason, Marek, can DEFERRED_PARSE trees survive past the in-class-context late parsing stage? My assumption was not, but in reducing a module testcase I encountered a situation when one survived to end of compilation (with no errors). It was an exception specifier on a

Re: [bikeshed] include path search for main file

2019-07-08 Thread Nathan Sidwell
On 7/8/19 7:58 AM, Richard Biener wrote: On Mon, Jul 8, 2019 at 1:46 PM Nathan Sidwell wrote: One of the facilities C++ modules provides is turning header files into header units. Thus you can say: import ; (there are some constraints on being able to do that) This involves compiling

Re: [PATCH] Deprecate -frepo option.

2019-07-08 Thread Martin Liška
On 6/21/19 4:28 PM, Richard Biener wrote: > On Fri, Jun 21, 2019 at 4:13 PM Jakub Jelinek wrote: >> >> On Fri, Jun 21, 2019 at 04:04:00PM +0200, Martin Liška wrote: >>> On 6/21/19 1:58 PM, Jakub Jelinek wrote: On Fri, Jun 21, 2019 at 01:52:09PM +0200, Martin Liška wrote: > On 6/21/19

[PATCH] Re-instantiate access-path based analysis during VN

2019-07-08 Thread Richard Biener
This re-instantiates the patch I had to revert earlier, doing it in a safer way. We record the original ref so we can do an additional disambiguation during vn_reference_lookup_3. Bootstrap and regtest running on x86_64-unknown-linux-gnu. Richard. 2019-07-08 Richard Biener *

Re: [bikeshed] include path search for main file

2019-07-08 Thread Richard Biener
On Mon, Jul 8, 2019 at 1:46 PM Nathan Sidwell wrote: > > One of the facilities C++ modules provides is turning header files into > header units. Thus you can say: >import ; > (there are some constraints on being able to do that) > > This involves compiling the header file, similar to PCH.

[bikeshed] include path search for main file

2019-07-08 Thread Nathan Sidwell
One of the facilities C++ modules provides is turning header files into header units. Thus you can say: import ; (there are some constraints on being able to do that) This involves compiling the header file, similar to PCH. However, needing to provide the full path to the header file on

[PATCH] Fix PR91108

2019-07-08 Thread Richard Biener
This fixes bogus non-overlap considerations based on TBAA. Since we also have to care for punning through unions the following uses only align-based checks which are always valid. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Variant for the branch below, also

Re: Prevent tree-ssa-dce.c from deleting stores at -Og

2019-07-08 Thread Richard Biener
On Sun, Jul 7, 2019 at 9:07 PM Jeff Law wrote: > > On 7/7/19 3:45 AM, Richard Sandiford wrote: > > DCE tries to delete dead stores to local data and also tries to insert > > debug binds for simple cases: > > > > /* If this is a store into a variable that is being optimized away, > > add a

Re: Don't run DSE at -Og

2019-07-08 Thread Richard Biener
On Sun, Jul 7, 2019 at 9:04 PM Jeff Law wrote: > > On 7/7/19 3:43 AM, Richard Sandiford wrote: > > This patch stops gimple and rtl DSE from running by default at -Og. > > The idea is both to improve compile time and to stop us from deleting > > stores that we can't track in debug info. > > > > We

Commited: remove uint32_t declaration from testsuite/gcc.dg/vect/slp-reduc-sad.c

2019-07-08 Thread Joern Wolfgang Rennecke
The declaration was not used, and it clashed with a system declaration from newlib. On a 32 bit typical system, uint32_t can be defined using unsigned, unsigned int or unsigned long. gcc.dg/vect/slp-reduc-sad.c includes gcc.dg/vect/tree-vect.h, which includes newlib/libc/include/signal.h,

Re: [PATCH] subreg: Add -fsplit-wide-types-early (PR88233)

2019-07-08 Thread Richard Biener
On Sun, Jul 7, 2019 at 7:12 PM Segher Boessenkool wrote: > > Currently the second lower-subreg pass is run right before RA. This > is much too late to be very useful. At least for targets that do not > have RTL patterns for operations on multi-register modes it is a lot > better to split

Re: [PATCH] Add generic support for "noinit" attribute

2019-07-08 Thread Christophe Lyon
On Sat, 6 Jul 2019 at 19:57, Martin Sebor wrote: > > On 7/4/19 9:27 AM, Christophe Lyon wrote: > > Hi, > > > > Similar to what already exists for TI msp430 or in TI compilers for > > arm, this patch adds support for the "noinit" attribute. > > > > It is convenient for embedded targets where the

[PATCH] RISC-V: Fix splitter for 32-bit AND on 64-bit target.

2019-07-08 Thread Jim Wilson
Fixes github.com/riscv/riscv-gcc issue #161. We were accidentally using BITS_PER_WORD to compute shift counts when we should have been using the bitsize of the operand modes. This was wrong when we had an SImode shift and a 64-bit target. Tested with 32-bit elf and 64-bit linux cross compiler

Re: Make nonoverlapping_component_refs work with duplicated main variants

2019-07-08 Thread Jan Hubicka
> > +/* FIELD1 and FIELD2 are two component refs whose bases are either > > + both at the same address or completely disjoint. > > + Return 1 if FIELD1 and FIELD2 are non-overlapping > > + Return 0 if FIELD1 and FIELD2 are having same addresses or are > > + completely disjoint. > >

[patch] Small improvements to coverage info (3/n)

2019-07-08 Thread Eric Botcazou
Hi, a couple of fixes for the RTL middle-end this time, with the same goal of preventing instructions from inheriting random source location information in the debug info generated by the compiler. Tested on x86_64-suse-linux, both GCC and GDB, OK for mainline? 2019-07-08 Eric Botcazou

Re: [PATCH, committed] Add myself to MAINTAINERS

2019-07-08 Thread Kito Cheng
Hi Rainer: Thanks your reminder, I've fix it now. On Mon, Jul 8, 2019 at 4:14 PM Rainer Orth wrote: > > Kito Cheng writes: > > > ChangeLog: > > > > 2019-07-08 Kito Cheng > > > > * MAINTAINERS (Write After Approval): Add myself. > > > > --- MAINTAINERS (revision 273194) > > +++

Re: [PATCH][armeb] PR 91060 gcc.c-torture/execute/scal-to-vec1.c fails since r272843

2019-07-08 Thread Christophe Lyon
On Mon, 8 Jul 2019 at 11:06, Kyrill Tkachov wrote: > > Hi Christophe > > On 7/8/19 10:01 AM, Christophe Lyon wrote: > > Hi, > > > > This patch fixes PR 91060 where the lane ordering was no longer the > > right one (GCC's vs architecture's). > > > > OK? > > > > Thanks to both Richards for most of

Re: Make nonoverlapping_component_refs work with duplicated main variants

2019-07-08 Thread Richard Biener
On Mon, 8 Jul 2019, Jan Hubicka wrote: > Hi, > this patch avoids == compare of main varinats in nonoverlapping_component_refs > making them work on unmerged type (such as when one is C++ ODR and other is > C). > This is not hard to do >- nonoverlapping_component_refs_since_match is >

Re: [PATCH][armeb] PR 91060 gcc.c-torture/execute/scal-to-vec1.c fails since r272843

2019-07-08 Thread Christophe Lyon
On Mon, 8 Jul 2019 at 11:04, Richard Sandiford wrote: > > Christophe Lyon writes: > > Hi, > > > > This patch fixes PR 91060 where the lane ordering was no longer the > > right one (GCC's vs architecture's). > > Sorry, we clashed :-) > > I'd prefer to go with the version I attached to bugzilla

Re: [PATCH][armeb] PR 91060 gcc.c-torture/execute/scal-to-vec1.c fails since r272843

2019-07-08 Thread Kyrill Tkachov
Hi Christophe On 7/8/19 10:01 AM, Christophe Lyon wrote: Hi, This patch fixes PR 91060 where the lane ordering was no longer the right one (GCC's vs architecture's). OK? Thanks to both Richards for most of the debugging! Thank you to all for tracking this down. Christophe

Re: [PATCH][armeb] PR 91060 gcc.c-torture/execute/scal-to-vec1.c fails since r272843

2019-07-08 Thread Richard Sandiford
Christophe Lyon writes: > Hi, > > This patch fixes PR 91060 where the lane ordering was no longer the > right one (GCC's vs architecture's). Sorry, we clashed :-) I'd prefer to go with the version I attached to bugzilla just now. Thanks, Richard

[PATCH][armeb] PR 91060 gcc.c-torture/execute/scal-to-vec1.c fails since r272843

2019-07-08 Thread Christophe Lyon
Hi, This patch fixes PR 91060 where the lane ordering was no longer the right one (GCC's vs architecture's). OK? Thanks to both Richards for most of the debugging! Christophe gcc/ChangeLog: 2019-07-08 Christophe Lyon PR target/91060 * config/arm/arm.c

Re: [PATCH 1/2] [ARC] Fix and refurbish the interrupts.

2019-07-08 Thread Claudiu Zissulescu
Hi Jeff, Originally, I had the scheduler barrier as you suggested. However, there were some user cases when an ISR messed up with SP register leading to errors. As a solution was to add barriers on either part of frame operations. However, I would need to recheck the original rationale of that

[Ada] New algorithm for Elaboration order v4.0

2019-07-08 Thread Pierre-Marie de Rodat
This patch introduces several changes to the new elaboration order mechanism: * The concept of "strong" and "weak" edges is introduced. Strong edges are the byproduct of language-defined relations between units, such as with clauses. Weak edges are the byproduct of specilative

[Ada] Wrong evaluation of membership test

2019-07-08 Thread Pierre-Marie de Rodat
The code generated by the compiler erroneously evaluates to True membership tests when their left operand is a a class-wide interface object and the right operand is a tagged type that implements such interface type. Tested on x86_64-pc-linux-gnu, committed on trunk 2019-07-08 Javier Miranda

[Ada] More data rates supported on Linux

2019-07-08 Thread Pierre-Marie de Rodat
This patch adds additional data rates to the GNAT.Serial_Communications package (Linux version). Tested on x86_64-pc-linux-gnu, committed on trunk 2019-07-08 Bob Duff gcc/ada/ * libgnat/g-sercom.ads, libgnat/g-sercom__linux.adb (Data_Rate): Support additional data rates.---

[Ada] Remove dead code from Enclosing_Package_Or_Subprogram routine

2019-07-08 Thread Pierre-Marie de Rodat
Calls to Scope always return unique entities, i.e. package/subprogram and not their bodies, so there is no need to expect them. Cleanup only; semantics unaffected. (This routine was only used in CCG and GNATprove backends anyway.) Tested on x86_64-pc-linux-gnu, committed on trunk 2019-07-08

[Ada] Diagnostics for Elaboration order v4.0

2019-07-08 Thread Pierre-Marie de Rodat
This patch adds a missing case to the output of cycle diagnostics here a transition from an Elaborate_Body pair may reach a destination which is in the context of an active Elaborate_All. Tested on x86_64-pc-linux-gnu, committed on trunk 2019-07-08 Hristian Kirtchev gcc/ada/ *

[Ada] Small overhaul in Repinfo unit

2019-07-08 Thread Pierre-Marie de Rodat
This creates a List_Type_Info procedure to deal with type entities other than arrays and records at top level and a List_Common_Type_Info procedure to handle the common part between them. No functional changes. Tested on x86_64-pc-linux-gnu, committed on trunk 2019-07-08 Eric Botcazou

[Ada] Remove dependency on Win32 GDI (Graphical Interface)

2019-07-08 Thread Pierre-Marie de Rodat
CommandLineToArgvW drags a dependency on SHELL32.DLL and thus GDI32.DLL. By loading GDI32.DLL some default GDI objects are allocated. On some Windows versions this cause the use of a lock on the graphical interface during process termination. This can impact parallelism significantly as

[Ada] Do not erase precise type on fixed-point real literal

2019-07-08 Thread Pierre-Marie de Rodat
Real literals of fixed-point type are expected to keep their precise fixed-point type in GNATprove. This is now correctly enforced. There is no impact on compilation. Tested on x86_64-pc-linux-gnu, committed on trunk 2019-07-08 Yannick Moy gcc/ada/ * expander.adb (Expand): Do not

[Ada] Fix crash on extension of private type with -gnatRj

2019-07-08 Thread Pierre-Marie de Rodat
This fixes a crash (or an assertion failure) during the processing done for -gnatRj on the declaration of an extension of a private type. Generally speaking, extension declarations are delicate in this context because the front-end does not duplicate the structure of the parent type, so the

[Ada] Crash in interface derivation with null primitive

2019-07-08 Thread Pierre-Marie de Rodat
The frontend crashes processing the derivation of a tagged type whose ultimate ancestor is an interface type I1 that has a null primitive, implements another interface I2 derived from I2, and does not override the null primitive. Tested on x86_64-pc-linux-gnu, committed on trunk 2019-07-08

[Ada] Assertion failure on validity check for Address

2019-07-08 Thread Pierre-Marie de Rodat
This patch corrects the verification of 'Address clauses to avoid processing a clause where the prefix of the attribute is a generic formal object. Tested on x86_64-pc-linux-gnu, committed on trunk 2019-07-08 Hristian Kirtchev gcc/ada/ * sem_ch13.adb

[Ada] Set dummy Etype for the fake __HEAP entity in GNATprove

2019-07-08 Thread Pierre-Marie de Rodat
GNATprove represents reads and writes via pointers as operations on a fake __HEAP entity. This entity already had various properties set to dummy values (e.g. Scope set to Standard_Standard), so that it can be processed like other entities without crashing and not special-cased everywhere. Now it

[Ada] Crash on named actual in postcondition for generic subprogram

2019-07-08 Thread Pierre-Marie de Rodat
This patch fixes a crash on compiling the postcondtion for a generic subprogram, when the postcondition is a call with both positional and named parameter associations. Tested on x86_64-pc-linux-gnu, committed on trunk 2019-07-08 Ed Schonberg gcc/ada/ * sem_ch13.adb

[Ada] Crash on timed entry call with a delay given by a type conversion

2019-07-08 Thread Pierre-Marie de Rodat
This patch fixes a compiler crash in the compiler on a timed entry call whose delay expression is a type conversion, when FLoat_Overflow checks are enabled. Tested on x86_64-pc-linux-gnu, committed on trunk 2019-07-08 Ed Schonberg gcc/ada/ * exp_ch9.adb (Expand_N_Timed_Entry_Call):

[Ada] Semantics of Delete for fixed strings

2019-07-08 Thread Pierre-Marie de Rodat
This patch corrects a bug in the implementation of Delete in an unusual boundary case: the RM describes the semantics of Delete as equivalent to that of Replace_String with a null argument. As a result, deleting a null string that starts past the end of its argument is a noop and must not raise

[Ada] Arrange not to set DECL_ARTIFICIAL on elab procs

2019-07-08 Thread Pierre-Marie de Rodat
Unlike, say, clones created internally by the compiler, elab procs materialize specific user code and flagging them artificial now takes elab code away from gcov's analysis, a regression compared to previous releases. On the testcase below: package Gcov_Q is function F (X : Integer) return

[Ada] Crash on Image and Value attributes

2019-07-08 Thread Pierre-Marie de Rodat
This patch fixes an issue whereby the creation of an enumeration within package where Default_Scalar_Storage_Order is in effect may lead to a crash when the attributes Image or Value are applied to objects of said type or the type directly. Tested on x86_64-pc-linux-gnu, committed on trunk

[Ada] Spurious visibility error on dynamic_predicate aspect in generic

2019-07-08 Thread Pierre-Marie de Rodat
This patch fixes a spurious error when verifying that the visibility of the expression of an aspect has not changed between the freeze point of the entity to which it applies, and the end of the enclosing declarative part. If the entity is a composite type its components must be made directly

  1   2   >