Re: [PATCH] irange_pool class

2020-09-17 Thread Aldy Hernandez via Gcc-patches
On 9/18/20 3:43 AM, David Malcolm wrote: On Thu, 2020-09-17 at 12:36 +0200, Aldy Hernandez via Gcc-patches wrote: This is the irange storage class. It is used to allocate the minimum amount of storage needed for a given irange. Storage is automatically freed at destruction. It is meant

Re: [RS6000] rs6000_rtx_costs reduce cost for SETs

2020-09-17 Thread Alan Modra via Gcc-patches
On Thu, Sep 17, 2020 at 12:51:25PM -0500, Segher Boessenkool wrote: > Hi! > > On Tue, Sep 15, 2020 at 10:49:45AM +0930, Alan Modra wrote: > > Also use rs6000_cost only for speed. > > More directly: use something completely different for !speed, namely, > code size. Yes, that might be better. >

[pushed] c++: Layout decls with newly-complete type.

2020-09-17 Thread Jason Merrill via Gcc-patches
Martin's -Wplacement-new patch ran into a problem with DECL_SIZE not being set on an extern variable for which the type was not complete until after its declaration. complete_vars was deliberately not calling layout_decl for some reason, instead leaving that for expand_expr_real_1 much later in

[PATCH] vect/test: Don't check for epilogue loop [PR97075]

2020-09-17 Thread Kewen.Lin via Gcc-patches
Hi, The commit r11-3230 brings a nice improvement to use full vectors instead of partial vectors when available. But it caused some vector with length test cases to fail on Power. The failure on gcc.target/powerpc/p9-vec-length-epil-7.c exposed one issue that: we call function

Re: [PATCH V2 0/4] Unify C and C++ handling of loops and switches

2020-09-17 Thread Sandra Loosemore
On 9/17/20 8:32 AM, Jason Merrill wrote: We discussed this in a team meeting the other day, and agreed that it's probably simpler to switch back to gotos for C++ than fix up all the optimizers.  And that there probably isn't much benefit to the middle-end to retain the higher level

Re: [PATCH] irange_pool class

2020-09-17 Thread David Malcolm via Gcc-patches
On Thu, 2020-09-17 at 12:36 +0200, Aldy Hernandez via Gcc-patches wrote: > This is the irange storage class. It is used to allocate the > minimum > amount of storage needed for a given irange. Storage is > automatically > freed at destruction. > > It is meant for long term storage, as opposed

Re: [PATCH 3/4 v3] ivopts: Consider cost_step on different forms during unrolling

2020-09-17 Thread Segher Boessenkool
Hi Jeff, On Thu, Sep 17, 2020 at 05:12:17PM -0600, Jeff Law wrote: > On 9/3/20 4:37 PM, Segher Boessenkool wrote: > >> Apart from that, one P9 specific point is that the update form load isn't > >> preferred, the reason is that the instruction can not retire until both > >> parts complete, it

Re: [PATCH 3/4 v3] ivopts: Consider cost_step on different forms during unrolling

2020-09-17 Thread Jeff Law via Gcc-patches
On 9/3/20 4:37 PM, Segher Boessenkool wrote: >> Apart from that, one P9 specific point is that the update form load isn't >> preferred, the reason is that the instruction can not retire until both >> parts complete, it can hold up subsequent instructions from retiring. >> If the addi stalls

Re: [PATCH V2 0/4] Unify C and C++ handling of loops and switches

2020-09-17 Thread Jeff Law via Gcc-patches
On 9/17/20 8:32 AM, Jason Merrill wrote: > On 9/9/20 8:20 PM, Sandra Loosemore wrote: >> On 9/9/20 3:13 PM, Jason Merrill wrote: >>> >>> My impression from Jeff's analysis in January and David's in March >>> was that many of the testsuite changes were from the C++ approach >>> actually providing

Re: [PATCH] IRA: Don't make a global register eliminable

2020-09-17 Thread Jeff Law via Gcc-patches
On 9/16/20 8:46 AM, Richard Sandiford wrote: > "H.J. Lu" writes: >> On Tue, Sep 15, 2020 at 7:44 AM Richard Sandiford >> wrote: >>> Thanks for looking at this. >>> >>> "H.J. Lu" writes: commit 1bcb4c4faa4bd6b1c917c75b100d618faf9e628c Author: Richard Sandiford Date: Wed Oct 2

Re: [PATCH] bpf: use xBPF signed div, mod insns when available

2020-09-17 Thread Jeff Law via Gcc-patches
On 9/17/20 11:15 AM, David Faust via Gcc-patches wrote: > The 'mod' and 'div' operators in eBPF are unsigned, with no signed > counterpart. xBPF adds two new ALU operations, sdiv and smod, for > signed division and modulus, respectively. Update bpf.md with > 'define_insn' blocks for signed div

Re: [PATCH V2 0/4] Unify C and C++ handling of loops and switches

2020-09-17 Thread Joseph Myers
On Thu, 17 Sep 2020, Jason Merrill via Gcc-patches wrote: > The C++ changes are OK. A C maintainer will need to sign off on the changes > there. The C front-end changes are OK. Note: for a long time there used to be actual (undesired) semantic differences between the C and C++ loop handling,

Re: [PATCH] cfgloop.h: Reword comment describing is_exit flag

2020-09-17 Thread Jeff Law via Gcc-patches
On 8/27/20 7:18 AM, Alex Coplan wrote: > This simple patch rewords a comment in cfgloop.h to improve the > grammar and readability. > > OK for master? > > Thanks, > Alex > > --- > > gcc/ChangeLog: > > * cfgloop.h (nb_iter_bound): Reword comment describing is_exit. OK jeff pEpkey.asc

Re: [PING 2][PATCH 2/5] C front end support to detect out-of-bounds accesses to array parameters

2020-09-17 Thread Joseph Myers
On Wed, 16 Sep 2020, Martin Sebor via Gcc-patches wrote: > Attached is an updated revision of the patch. Besides the tweaks > above it also contains a cosmetic change to the warning issued > for mismatches in unspecified VLA bounds: it points at the decl > with more of them to guide the user to

Re: PING [Patch][Middle-end]Add -fzero-call-used-regs=[skip|used-gpr|all-gpr|used|all]

2020-09-17 Thread Segher Boessenkool
On Thu, Sep 17, 2020 at 05:27:59PM +0100, Richard Sandiford wrote: > Qing Zhao writes: > > The following is what I see from i386.md: (I didn’t look at how > > “UNSPEC_volatile” is used in data flow analysis in GCC yet) > > > > ;; UNSPEC_VOLATILE is considered to use and clobber all hard

Re: [PATCH] C-SKY: Add compatibility of elf target name

2020-09-17 Thread Jeff Law via Gcc-patches
On 8/28/20 12:33 AM, Jojo R wrote: > gcc/ChangeLog: > > * config.gcc (C-SKY): Add compatibility of elf target name. > > libgcc/ChangeLog: > > * config.host (C-SKY): Add compatibility of elf target name. OK jeff pEpkey.asc Description: application/pgp-keys

Re: [PATCH 3/3] Use more ONE_? in GGC functions.

2020-09-17 Thread Jeff Law via Gcc-patches
On 9/2/20 7:29 AM, Martin Liška wrote: > On 9/1/20 2:33 PM, Martin Liška wrote: >> The last patch is a refactoring using ONE_* macros. >> >> Thoughts? >> Thanks, >> Martin > > There's rebassed version of the patch. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > >

Re: [PATCH 2/3] Use MiB unit when displaying memory allocation.

2020-09-17 Thread Jeff Law via Gcc-patches
On 9/2/20 7:28 AM, Martin Liška wrote: > On 9/1/20 4:04 PM, Jan Hubicka wrote: >>> The patch is about usage of MiB in memory allocation reports. >>> I see it much better readable than values displayed in KiB: >>> >>> Reading object files: tramp3d-v4.o {GC released 1 MiB} {GC 19 MiB -> >>> 19 MiB}

Re: [PATCH 1/3] Support new mallinfo2 function.

2020-09-17 Thread Jeff Law via Gcc-patches
On 9/2/20 7:28 AM, Martin Liška wrote: > On 9/1/20 2:31 PM, Martin Liška wrote: >> Hey. >> >> I've just applied to patches to glibc introducing a new mallinfo2 >> function. >> Limitation of the current function mallinfo is usage of int type >> which overflows >> for allocation > 2GB. >> >> The

Re: [PATCH] profile: clarify comment around histogram format

2020-09-17 Thread Jeff Law via Gcc-patches
On 9/4/20 3:24 PM, Sergei Trofimovich via Gcc-patches wrote: > From: Sergei Trofimovich > > gcc/ChangeLog: > > * gcc/profile.c (sort_hist_values): Clarify hist format: > start with a value, not counter. OK jeff pEpkey.asc Description: application/pgp-keys

Re: [PATCH] MSP430: Add 'd', 'e', 'f' and 'g' asm operand modifiers

2020-09-17 Thread Jeff Law via Gcc-patches
On 9/10/20 3:44 AM, Jozef Lawrynowicz wrote: > The new operand modifiers can be used to select odd-numbered bytes of a memory > reference or constant value. > > Successfully regtested on trunk for msp430-elf in the default, -mlarge, > -mcpu=msp430 and

Re: [PATCH][testsuite] Introduce effective target non_strict_prototype

2020-09-17 Thread Jeff Law via Gcc-patches
On 9/10/20 6:01 AM, Tom de Vries wrote: > Hi, > > Consider test-case gcc.c-torture/compile/pr71109.c. > > It contains a prototype-less declaration of foo: > ... > static void foo (); > ... > followed by a call to foo > ... > foo (bar, a); > ... > followed by the definition of foo: > ... >

Re: [PATCH] libiberty/pex-win32.c: Initialize orig_err

2020-09-17 Thread Jeff Law via Gcc-patches
On 9/14/20 3:29 AM, Christophe Lyon via Gcc-patches wrote: > Initializing orig_err avoids a warning: "may be used uninitialized". > > 2020-09-14 Torbjörn SVENSSON > Christophe Lyon > > libiberty/ > * pex-win32 (pex_win32_exec_child): Initialize orig_err. Rather than just

Re: RISC-V: fix a typo in riscv.h

2020-09-17 Thread Jeff Law via Gcc-patches
On 9/14/20 5:06 AM, Yeting Kuo via Gcc-patches wrote: > Hi Kito, > >>> Could you provide a test case for that? > I add the test case and update the git message. > RISC-V: fix a typo in riscv.h > > The missing parentheses would make shorten-memrefs pass give a > wrong base when the

Re: [PATCH] Improve contrib/clang-format to work with C++11 code [PR97076]

2020-09-17 Thread Jeff Law via Gcc-patches
On 9/17/20 3:37 AM, Dimitrij Mijoski via Gcc-patches wrote: > contrib/ChangeLog: > PR other/97076 > * clang-format: Update. THanks.  Installed. jeff pEpkey.asc Description: application/pgp-keys

Re: [PATCH] warn for integer overflow in allocation calls (PR 96838)

2020-09-17 Thread Martin Sebor via Gcc-patches
On 9/17/20 12:39 PM, Andrew MacLeod wrote: On 9/17/20 12:08 PM, Martin Sebor via Gcc-patches wrote: On 9/16/20 9:23 PM, Jeff Law wrote: On 9/15/20 1:47 PM, Martin Sebor wrote: Overflowing the size of a dynamic allocation (e.g., malloc or VLA) can lead to a subsequent buffer overflow

[pushed] c++: Add tests for fixed PRs.

2020-09-17 Thread Marek Polacek via Gcc-patches
Bugzilla inspection turned up a bunch of old(er) PRs that have been fixed. Let's include them not to regress in the future. Tested x86_64-pc-linux-gnu, applying to trunk. PR c++/87530 PR c++/58156 PR c++/68828 PR c++/86002 PR c++/91525 PR

Re: [PATCH] aarch64: Add extend-as-extract-with-shift pattern [PR96998]

2020-09-17 Thread Segher Boessenkool
Hi! On Thu, Sep 17, 2020 at 08:10:22AM +0100, Richard Sandiford wrote: > Alex Coplan writes: > The combine parts LGTM otherwise, but Segher should have the > final say. I am doubtful this does not regress on many targets. I'll test it, we'll see :-) Segher

[r11-3258 Regression] FAIL: gfortran.dg/array_constructor_11.f90 -O3 -g execution test on Linux/x86_64 (-m64)

2020-09-17 Thread sunil.k.pandey via Gcc-patches
On Linux/x86_64, c7f4be78cb61006492d16375aba5392f580cd633 is the first bad commit commit c7f4be78cb61006492d16375aba5392f580cd633 Author: Richard Biener Date: Thu Sep 17 11:48:36 2020 +0200 CSE negated multiplications and divisions caused FAIL: gfortran.dg/array_constructor_11.f90 -O3

libgo patch committed: glibc ptrace is a varargs function

2020-09-17 Thread Ian Lance Taylor via Gcc-patches
This patch by Paul Murphy fixes calls from libgo to ptrace. In glibc, ptrace is actually declared as a variadic function. On ppc64le the ABI requires to the caller to allocate space for the parameters and allows the caller to modify them. On ppc64le, depending on how and what version of GCC is

Re: PING [Patch][Middle-end]Add -fzero-call-used-regs=[skip|used-gpr|all-gpr|used|all]

2020-09-17 Thread Qing Zhao via Gcc-patches
> On Sep 17, 2020, at 11:27 AM, Richard Sandiford > wrote: > > Qing Zhao mailto:qing.z...@oracle.com>> writes: >>> On Sep 17, 2020, at 1:17 AM, Richard Sandiford >>> wrote: >>> >>> Qing Zhao writes: Segher and Richard, Now there are two major concerns from the discussion

Re: Problem with static const objects and LTO

2020-09-17 Thread Jakub Jelinek via Gcc-patches
On Thu, Sep 17, 2020 at 12:18:40PM -0600, Jeff Law via Gcc-patches wrote: > >> In an LTO world the TU isn't indivisible anymore. LTO will happily > >> discard things which don't appear to be used. So parts of the TU may > >> be in the main program, other parts may be in DSOs used by the main >

Re: [PATCH] warn for integer overflow in allocation calls (PR 96838)

2020-09-17 Thread Andrew MacLeod via Gcc-patches
On 9/17/20 12:08 PM, Martin Sebor via Gcc-patches wrote: On 9/16/20 9:23 PM, Jeff Law wrote: On 9/15/20 1:47 PM, Martin Sebor wrote: Overflowing the size of a dynamic allocation (e.g., malloc or VLA) can lead to a subsequent buffer overflow corrupting the heap or stack.  The attached patch

Re: [PATCH] c-family: Macro support in -Wmisleading-indentation [PR80076]

2020-09-17 Thread Patrick Palka via Gcc-patches
On Thu, 10 Sep 2020, Patrick Palka wrote: > On Thu, 10 Sep 2020, David Malcolm wrote: > > > On Tue, 2020-07-28 at 20:22 -0400, Patrick Palka wrote: > > > On Tue, 28 Jul 2020, David Malcolm wrote: > > > > > > > On Tue, 2020-07-28 at 15:50 -0400, Patrick Palka wrote: > > > > > Currently the

Re: [PATCH] MSP430: Fix CFA generation during function epilogues

2020-09-17 Thread Jeff Law via Gcc-patches
On 9/9/20 4:33 AM, Jozef Lawrynowicz wrote: > There is no CFA information generated for instructions which manipulate the > stack during function epilogues. This means a debugger cannot determine the > position of variables on the stack whilst the epilogue is in progress. > > This can cause the

Re: Problem with static const objects and LTO

2020-09-17 Thread Jeff Law via Gcc-patches
On 9/17/20 1:04 AM, Richard Biener wrote: > On Wed, Sep 16, 2020 at 10:24 PM Jeff Law via Gcc-patches > wrote: >> >> On 9/16/20 11:52 AM, Joseph Myers wrote: >>> On Wed, 16 Sep 2020, Jeff Law via Gcc-patches wrote: >>> ISTM this is a lot like the problem we have where we inline functions

Re: [PATCH] irange_pool class

2020-09-17 Thread Martin Sebor via Gcc-patches
On 9/17/20 4:36 AM, Aldy Hernandez via Gcc-patches wrote: This is the irange storage class.  It is used to allocate the minimum amount of storage needed for a given irange.  Storage is automatically freed at destruction. It is meant for long term storage, as opposed to int_range_max which is

Re: [RS6000] rs6000_rtx_costs reduce cost for SETs

2020-09-17 Thread Segher Boessenkool
Hi! On Tue, Sep 15, 2020 at 10:49:45AM +0930, Alan Modra wrote: > Also use rs6000_cost only for speed. More directly: use something completely different for !speed, namely, code size. > - if (CONST_INT_P (XEXP (x, 1)) > - && satisfies_constraint_I (XEXP (x, 1))) > + if (!speed)

Re: [PATCH] aarch64: Fix dejaGNU directive in clastb_8.c testcase

2020-09-17 Thread Andrea Corallo
Richard Sandiford writes: > OK, thanks. FWIW, this would also have been OK under the > “obviously correct” rule (but asking is obviously OK too :-)) > > Richard Installed as ee7aa7e7b9d Thanks for having a look and for the info! Andrea

[r11-3258 Regression] FAIL: gfortran.dg/array_constructor_11.f90 -O3 -g execution test on Linux/x86_64 (-m64 -march=cascadelake)

2020-09-17 Thread sunil.k.pandey via Gcc-patches
On Linux/x86_64, c7f4be78cb61006492d16375aba5392f580cd633 is the first bad commit commit c7f4be78cb61006492d16375aba5392f580cd633 Author: Richard Biener Date: Thu Sep 17 11:48:36 2020 +0200 CSE negated multiplications and divisions caused FAIL: gfortran.dg/array_constructor_11.f90 -O3

[PATCH] bpf: use xBPF signed div, mod insns when available

2020-09-17 Thread David Faust via Gcc-patches
The 'mod' and 'div' operators in eBPF are unsigned, with no signed counterpart. xBPF adds two new ALU operations, sdiv and smod, for signed division and modulus, respectively. Update bpf.md with 'define_insn' blocks for signed div and mod to use them when targetting xBPF, and add new tests to

[OG10] Backporting + merge of GCC 10 into branch + pre-applying (OpenMP: Handle cpp_implicit_alias in declare-target discovery)

2020-09-17 Thread Tobias Burnus
OG10 = devel/omp/gcc-10 Merge:GCC into branch: 18677004f40 Merge remote-tracking branch 'origin/releases/gcc-10' into devel/omp/gcc-10 Applied mainline submitted patch: ef509d1985a OpenMP: Handle cpp_implicit_alias in declare-target discovery (PR96390)

Re: [PATCH V2] aarch64: Fix ICE on fpsr fpcr getters [PR96968]

2020-09-17 Thread Richard Sandiford
Richard Sandiford writes: >> @@ -2034,6 +2034,18 @@ aarch64_expand_fpsr_fpcr_setter (int unspec, >> machine_mode mode, tree exp) >>emit_insn (gen_aarch64_set (unspec, mode, op)); >> } >> >> +/* Expand a fpsr or fpcr getter (depending on UNSPEC) using MODE. >> + Return the target. */ >>

Re: [PATCH V2] aarch64: Fix ICE on fpsr fpcr getters [PR96968]

2020-09-17 Thread Richard Sandiford
Andrea Corallo writes: > Hi all, > > second version of the patch here implementing the suggestion of using > create_output_operand and the expand_insn machinery. > > Regtested and bootsraped on aarch64-linux-gnu. > > Okay for trunk? > > Thanks > > Andrea > > From

Re: [PATCH] aarch64: Fix dejaGNU directive in clastb_8.c testcase

2020-09-17 Thread Richard Sandiford
Andrea Corallo writes: > Hi all, > > this is to fix a typo in a dejaGNU directive introduced with > with 052204fac58 "vec: don't select partial vectors when > unnecessary". > > Okay for trunk? OK, thanks. FWIW, this would also have been OK under the “obviously correct” rule (but asking is

Re: [PATCH 3/5] Add DWARF5 variants of assembly scan tests that use DW_FORM_implicit_const

2020-09-17 Thread Jakub Jelinek via Gcc-patches
On Thu, Sep 17, 2020 at 06:03:28PM +0200, Mark Wielaard wrote: > On Mon, 2020-08-24 at 22:26 +0200, Mark Wielaard wrote: > > On Mon, Aug 24, 2020 at 07:44:27PM +0200, Jakub Jelinek wrote: > > > On Mon, Aug 24, 2020 at 02:56:56PM +0200, Mark Wielaard wrote: > > > > Some DWARF tests scan the

[PATCH] c++: std::is_constant_evaluated inside a constraint [PR97051]

2020-09-17 Thread Patrick Palka via Gcc-patches
According to [expr.const]/14, the result of substitution into an atomic constraint is manifestly constant-evaluated; this patch adjusts the call to maybe_constant_value in satisfy_atom to that effect. Tested on x86_64-pc-linux-gnu, and also tested on the cmcstl2 and range-v3 libraries. Does this

Re: PING [Patch][Middle-end]Add -fzero-call-used-regs=[skip|used-gpr|all-gpr|used|all]

2020-09-17 Thread Richard Sandiford
Qing Zhao writes: >> On Sep 17, 2020, at 1:17 AM, Richard Sandiford >> wrote: >> >> Qing Zhao writes: >>> Segher and Richard, >>> >>> Now there are two major concerns from the discussion so far: >>> >>> 1. (From Richard): Inserting zero insns should be done after >>>

Re: [PATCH] warn for integer overflow in allocation calls (PR 96838)

2020-09-17 Thread Martin Sebor via Gcc-patches
On 9/16/20 9:23 PM, Jeff Law wrote: On 9/15/20 1:47 PM, Martin Sebor wrote: Overflowing the size of a dynamic allocation (e.g., malloc or VLA) can lead to a subsequent buffer overflow corrupting the heap or stack.  The attached patch diagnoses a subset of these cases where the

Re: [PATCH 3/5] Add DWARF5 variants of assembly scan tests that use DW_FORM_implicit_const

2020-09-17 Thread Mark Wielaard
On Mon, 2020-08-24 at 22:26 +0200, Mark Wielaard wrote: > On Mon, Aug 24, 2020 at 07:44:27PM +0200, Jakub Jelinek wrote: > > On Mon, Aug 24, 2020 at 02:56:56PM +0200, Mark Wielaard wrote: > > > Some DWARF tests scan the assembly output looking for constant values. > > > When using DWARF5 those

Re: [PATCH V2] aarch64: Fix ICE on fpsr fpcr getters [PR96968]

2020-09-17 Thread Andrea Corallo
Hi all, second version of the patch here implementing the suggestion of using create_output_operand and the expand_insn machinery. Regtested and bootsraped on aarch64-linux-gnu. Okay for trunk? Thanks Andrea >From bb35b56810f908c575fec11435071d1c37f6f1a3 Mon Sep 17 00:00:00 2001 From:

C++RFC: Extending __builtin_FUNCTION

2020-09-17 Thread Nathan Sidwell
__builtin_FUNCTION () returns __FUNCTION__ of its invoker. Any thoughts about extending it to provide: a) the qualified name of the caller b) the full signature of the invoker (__PRETTY_FUNCTION__) we could do this with another __builtin, or permitting __builtin_FUNCTION to take an optional

Re: PING [Patch][Middle-end]Add -fzero-call-used-regs=[skip|used-gpr|all-gpr|used|all]

2020-09-17 Thread Qing Zhao via Gcc-patches
> On Sep 17, 2020, at 1:17 AM, Richard Sandiford > wrote: > > Qing Zhao writes: >> Segher and Richard, >> >> Now there are two major concerns from the discussion so far: >> >> 1. (From Richard): Inserting zero insns should be done after >> pass_thread_prologue_and_epilogue since later

Re: [PATCH V2 0/4] Unify C and C++ handling of loops and switches

2020-09-17 Thread Jason Merrill via Gcc-patches
On 9/9/20 8:20 PM, Sandra Loosemore wrote: On 9/9/20 3:13 PM, Jason Merrill wrote: My impression from Jeff's analysis in January and David's in March was that many of the testsuite changes were from the C++ approach actually providing better results, so the reversal here surprises me.  Can

RE: [PATCH 5/5][Arm] New pattern for CSEL, CSET and CSETM instructions

2020-09-17 Thread Omar Tahir
Hi Kyrill, > It's been a while, but I believe you had the following comment about > implementing CSEL: > >> (define_insn_and_split "*thumb2_movsicc_insn" >>[(set (match_operand:SI 0 "s_register_operand" "=l,l,r,r,r,r,r,r,r,r,r,r") >> (if_then_else:SI >> @@ -449,17 +473,14 @@ >>

[PATCH] aarch64: Fix dejaGNU directive in clastb_8.c testcase

2020-09-17 Thread Andrea Corallo
Hi all, this is to fix a typo in a dejaGNU directive introduced with with 052204fac58 "vec: don't select partial vectors when unnecessary". Okay for trunk? gcc/testsuite/ChangeLog 2020-09-17 Andre Corallo * gcc.target/aarch64/sve/clastb_8.c: Fix a dg-final scan directive

Re: [PATCH] Canonicalize real X - CST to X + -CST

2020-09-17 Thread Richard Biener
On Thu, 17 Sep 2020, Michael Matz wrote: > Hello, > > On Wed, 16 Sep 2020, Richard Biener wrote: > > > This removes the canonicalization of X + -CST to X - CST to facilitate > > SLP vectorization analysis where we currently treat the added testcase > > as two-operation plus blend vectorization

Re: [PATCH] Canonicalize real X - CST to X + -CST

2020-09-17 Thread Michael Matz
Hello, On Wed, 16 Sep 2020, Richard Biener wrote: > This removes the canonicalization of X + -CST to X - CST to facilitate > SLP vectorization analysis where we currently treat the added testcase > as two-operation plus blend vectorization opportunity. While there > may be the possibility to

RE: [PATCH] libgcc/config/arm/fp16.c: Add missing prototypes

2020-09-17 Thread Kyrylo Tkachov
Hi Christophe, > -Original Message- > From: Christophe Lyon > Sent: 17 September 2020 12:56 > To: Kyrylo Tkachov > Cc: i...@airs.com; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] libgcc/config/arm/fp16.c: Add missing prototypes > > On Thu, 17 Sep 2020 at 12:27, Kyrylo Tkachov >

Re: [PATCH] libgcc/config/arm/fp16.c: Add missing prototypes

2020-09-17 Thread Christophe Lyon via Gcc-patches
On Thu, 17 Sep 2020 at 12:27, Kyrylo Tkachov wrote: > > > > > -Original Message- > > From: Christophe Lyon > > Sent: 11 September 2020 20:05 > > To: Kyrylo Tkachov > > Cc: i...@airs.com; gcc-patches@gcc.gnu.org > > Subject: Re: [PATCH] libgcc/config/arm/fp16.c: Add missing prototypes >

Re: [Patch] Fortran: Avoid double-free with parse error (PR96041, PR93423)

2020-09-17 Thread Andre Vehreschild
Hi Tobias, I see. Then OK for trunk by me. - Andre On Wed, 16 Sep 2020 10:35:53 +0200 Tobias Burnus wrote: > Hi Andre, > > On 9/16/20 9:58 AM, Andre Vehreschild wrote: > > + st->n.sym = NULL; > > > > Don't we need free or unlink the st node from the symtree, too? > > I did not see a

[PATCH] CSE negated multiplications and divisions

2020-09-17 Thread Richard Biener
This adds the capability to look for available negated multiplications and divisions, replacing them with cheaper negates. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. 2020-09-17 Richard Biener * tree-ssa-sccvn.c (visit_nary_op): Value-number multiplications

Re: [patch] Fix dangling references in thunks at -O0

2020-09-17 Thread Eric Botcazou
> This introduces an ICE building the glibc testsuite for alpha (bisected), > s390 and sparc (symptoms appear the same, not bisected to confirm the > exact revision). See bug 97078. Fixed thus, tested on x86_64-suse-linux, applied on mainline as obvious. PR middle-end/97078 *

Fix availability of functions in other partitions

2020-09-17 Thread Jan Hubicka
Hi, this patch fixes rather old bug that prevents ipa-reference to wrok across partition boundary. What happens is that availability code thinks that function is not available and thus we ignore the summary we stream. Bootstrapped/regtested x86_64-linux. Comitted. I have a testcase that I will

Re: [PATCH V2] vec: don't select partial vectors when looping on full vectors

2020-09-17 Thread Andrea Corallo
Christophe Lyon writes: > On Wed, 16 Sep 2020 at 15:40, Andrea Corallo wrote: >> >> Richard Sandiford writes: >> >> > OK with two incredibly petty comments fixed: >> >> [...] >> >> Installed with the two suggestions as 052204fac58. >> > > Hi, > > There is a typo with clastb_8.c: >

[PATCH] irange_pool class

2020-09-17 Thread Aldy Hernandez via Gcc-patches
This is the irange storage class. It is used to allocate the minimum amount of storage needed for a given irange. Storage is automatically freed at destruction. It is meant for long term storage, as opposed to int_range_max which is meant for intermediate temporary results on the stack.

[PATCH] [OG10] Fix warning messages in privatized-ref-1.f95 testcase

2020-09-17 Thread Kwok Cheung Yeung
The libgomp.oacc-fortran/privatized-ref-1.f95 also has the same issue, and has been fixed in the same way. Kwok On 16/09/2020 11:33 am, Kwok Cheung Yeung wrote: Hello The libgomp.oacc-c++/privatized-ref-[23].C testcases request 64 workers in a parallel section, but Nvidia only supports a

RE: [PATCH] libgcc/config/arm/fp16.c: Add missing prototypes

2020-09-17 Thread Kyrylo Tkachov
> -Original Message- > From: Christophe Lyon > Sent: 11 September 2020 20:05 > To: Kyrylo Tkachov > Cc: i...@airs.com; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] libgcc/config/arm/fp16.c: Add missing prototypes > > On Fri, 11 Sep 2020 at 14:35, Kyrylo Tkachov > wrote: > > > > Hi

Re: [PATCH V2] vec: don't select partial vectors when looping on full vectors

2020-09-17 Thread Christophe Lyon via Gcc-patches
On Wed, 16 Sep 2020 at 15:40, Andrea Corallo wrote: > > Richard Sandiford writes: > > > OK with two incredibly petty comments fixed: > > [...] > > Installed with the two suggestions as 052204fac58. > Hi, There is a typo with clastb_8.c: gcc.target/aarch64/sve/clastb_8.c -march=armv8.2-a+sve:

Re: [PATCH] this patch modify an unused variable in aarch64-unwind.h

2020-09-17 Thread Richard Sandiford
Wei Wentao writes: > Hi, > >This patch modify an unused variable in aarch64-unwing.h because the > warning says "unused parameter 'fs'". Thanks, pushed. I also broke the line after the parameter, to keep things within the 80-character limit. RichardR > > Weiwt > regards! > > --- >

[PATCH] Improve contrib/clang-format to work with C++11 code [PR97076]

2020-09-17 Thread Dimitrij Mijoski via Gcc-patches
contrib/ChangeLog: PR other/97076 * clang-format: Update. --- contrib/clang-format | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/clang-format b/contrib/clang-format index 7a4e96f64ca..ceb5c1d524f 100644 --- a/contrib/clang-format +++

Re: [PATCH] fixincludes/fixfixes.c: Fix 'set but not used' warning.

2020-09-17 Thread Christophe Lyon via Gcc-patches
On Thu, 17 Sep 2020 at 06:16, Jeff Law wrote: > > > On 9/11/20 6:21 AM, Christophe Lyon via Gcc-patches wrote: > > pz_tmp_base and pz_tmp_dot are always set, but used only when > > _PC_NAME_MAX is defined. > > > > This patch moves their declaration and definition undef #ifdef > > _PC_NAME_MAX to

Re: [PATCH] aarch64: Add extend-as-extract-with-shift pattern [PR96998]

2020-09-17 Thread Richard Sandiford
Alex Coplan writes: > Hi Richard, > > On 10/09/2020 19:18, Richard Sandiford wrote: >> Alex Coplan writes: >> > Hello, >> > >> > Since r11-2903-g6b3034eaba83935d9f6dfb20d2efbdb34b5b00bf introduced a >> > canonicalization from mult to shift on address reloads, a missing >> > pattern in the

Re: [PATCH] C-SKY: Add -msim option

2020-09-17 Thread Cooper Qu via Gcc-patches
It looks good to me. Approved. Thanks, Cooper On 9/16/20 7:47 PM, Jojo R wrote: gcc/ChangeLog: * config/csky/csky.opt (msim): New. * doc/invoke.texi (C-SKY Options): Document -msim. * config/csky/csky-elf.h (LIB_SPEC): Add simulator runtime. ---

Re: Problem with static const objects and LTO

2020-09-17 Thread Richard Biener via Gcc-patches
On Wed, Sep 16, 2020 at 10:24 PM Jeff Law via Gcc-patches wrote: > > > On 9/16/20 11:52 AM, Joseph Myers wrote: > > On Wed, 16 Sep 2020, Jeff Law via Gcc-patches wrote: > > > >> ISTM this is a lot like the problem we have where we inline functions > >> with static data. To fix those we use

Re: [PATCH] gcc: Make strchr return value pointers const

2020-09-17 Thread JonY via Gcc-patches
On 9/17/20 3:56 AM, Jeff Law wrote: > > If it's been ack'd by a maintainer, yes.  Jakub definitely qualifies as > a maintainer, so feel free to push it on Martin's behalf. > > > jeff Sure, it has been pushed, thanks all. signature.asc Description: OpenPGP digital signature

Re: PING [Patch][Middle-end]Add -fzero-call-used-regs=[skip|used-gpr|all-gpr|used|all]

2020-09-17 Thread Richard Sandiford
Qing Zhao writes: > Segher and Richard, > > Now there are two major concerns from the discussion so far: > > 1. (From Richard): Inserting zero insns should be done after > pass_thread_prologue_and_epilogue since later passes (for example, > pass_regrename) might introduce new used