Re: [PATCH v2] c++: explicit inst of template method not generated [PR110323]

On 3/19/24 15:30, Marek Polacek wrote: On Mon, Mar 18, 2024 at 09:10:27PM -0400, Jason Merrill wrote: On 3/15/24 13:48, Marek Polacek wrote: On Thu, Mar 14, 2024 at 03:39:04PM -0400, Jason Merrill wrote: On 3/8/24 12:02, Marek Polacek wrote: Bootstrapped/regtested on x86_64-pc-linux-gnu, ok

[PATCH] MIPS: Add MIN/MAX.fmt instructions support for MIPS R6

This patch adds MIN/MAX.fmt instructios from MIPS R6 with corresponding tests. gcc/ChangeLog: * config/mips/i6400.md (i6400_fpu_minmax): New define_insn_reservation. * config/mips/mips.h (ISA_HAS_FMIN_FMAX): Define new macro. * config/mips/mips.md (type): Add

Re: [PATCH] c++: direct-init of an array of class type [PR59465]

On 3/1/24 19:58, Marek Polacek wrote: Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? I don't claim that this has to go to 14 though. -- >8 -- ...from another array in a mem-initializer should not be accepted. We already reject struct string {} a[1]; string x[1](a); but

Re: [gcc-15 0/3] RISC-V improve stack/array access by constant mat tweak

On 3/18/24 21:41, Jeff Law wrote: >> The first patch is the main change which improves SPEC cactu by 10%. > Just to confirm. Yup, 10% reduction in icounts and about a 3.5% > improvement in cycles on our target. Which is great! Nice. > This also makes me wonder if cactu is the benchmark

Pushed: [PATCH] LoongArch: Fix a typo [PR 114407]

gcc/ChangeLog: PR target/114407 * config/loongarch/loongarch-opts.cc (loongarch_config_target): Fix typo in diagnostic message, enabing -> enabling. --- Pushed r14-9582 as obvious. gcc/config/loongarch/loongarch-opts.cc | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] cpp: new built-in __EXP_COUNTER__

On 19 March 2024 18:27:13 CET, Kaz Kylheku wrote: >On 2024-03-18 00:30, Jonathan Wakely wrote: >> I don't have an opinion on the implementation, or the proposal itself, >> except that the implementation seems susprisingly simple, which is >> nice. > >Hi Jonathan, > >Here is an updated patch. >

[pushed] analyzer: fix -Wanalyzer-deref-before-check false positive seen in loop header macro [PR109251]

Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Successful run of analyzer integration tests on x86_64-pc-linux-gnu. Pushed to trunk as r14-9586-g9093f275e0a343. gcc/analyzer/ChangeLog: PR analyzer/109251 * sm-malloc.cc (deref_before_check::emit): Reject cases where

Re: [PATCH] tree-optimization/113727 - bogus SRA with BIT_FIELD_REF

Hello, On Tue, Mar 19 2024, Richard Biener wrote: > When SRA analyzes BIT_FIELD_REFs it handles writes and not byte > aligned reads differently from byte aligned reads. Instead of > trying to create replacements for the loaded portion the former > cases try to replace the base object while

Re: [PATCH v2 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

On 19 March 2024 14:40:57 CET, Christophe Lyon wrote: >On Mon, 18 Mar 2024 at 22:35, Evgeny Karpov >wrote: >> >> Monday, March 18, 2024 2:27 PM >> Christophe Lyon wrote: >> >> > > +/* Disable SEH and declare the required SEH-related macros that are >> > > +still needed for compilation. */

Re: [PATCH V2] Document -fexcess-precision=16.

On Wed, 20 Mar 2024, liuhongt wrote: > gcc/ChangeLog: > > * doc/invoke.texi: Document -fexcess-precision=16. OK. -- Joseph S. Myers josmy...@redhat.com

Re: [PATCH 3/3] bpf: Corrected index computation when present with unnamed struct fields

David Faust writes: > On 3/13/24 07:24, Cupertino Miranda wrote: >> Any unnamed structure field if not a member of the BTF_KIND_STRUCT. > typo: if -> is > > I'd suggest to clarify that "any unnamed structure field" is really > any unnamed non-struct-or-union field, since anonymous inner structs

Re: [PATCH 2/3] bpf: Fix access string default for CO-RE type based relocations

David Faust writes: > On 3/13/24 07:24, Cupertino Miranda wrote: >> Although part of all CO-RE relocation data, type based relocations do >> not require an access string. >> Initial implementation defined it as an empty string. >> On the other hand, libbpf when parsing the CO-RE relocations

Re: [PATCH 1/3] bpf: Fix CO-RE field expression builtins

> This patch corrects bugs within the CO-RE builtin field expression > related builtins. > The following bugs were identified and corrected based on the expected > results of bpf-next selftests testsuite. > It addresses the following problems: > - Expressions with

[PATCH, v3] Fortran: improve array component description in runtime error message [PR30802]

Hi Mikael, all, here's now the third version of the patch that implements the following scheme: On 3/15/24 20:29, Mikael Morin wrote: Le 15/03/2024 à 18:26, Harald Anlauf a écrit : OK, that sounds interesting.  To clarify the options: - for ordinary array x it would stay 'x' - when z is a

Re: [PATCH v2 00/13] Add aarch64-w64-mingw32 target

On Wed, Mar 20, 2024, 07:50 Radek Barton wrote: > Hello, everyone. > > I've re-run the `x86_64-w64-mingw32` target tests with all the languages > enabled, except of Ada and JIT, which are harder to bootstrap, and Go, > which is not supported by MinGW. The summarized results are: > > 536176 of

Re: [PATCH gcc] Hurd x86_64: add unwind support for signal trampoline code

Hi! Please note that emails to , or don't reach me anymore, and, at least for the time being, likewise for -- is the new thing; see . (Or use , , , as before.) On 2024-03-01T02:33:10+0100, Samuel

Re: RISC-V: Use convert instructions instead of calling library functions

On Wed, 20 Mar 2024 11:54:34 PDT (-0700), Jeff Law wrote: On 3/19/24 10:23 AM, Palmer Dabbelt wrote: On Mon, 18 Mar 2024 20:50:14 PDT (-0700), jeffreya...@gmail.com wrote: On 3/18/24 3:09 AM, Jivan Hakobyan wrote: As RV has round instructions it is reasonable to use them instead of

Re: [PATCH gcc 1/3] Move GNU/Hurd startfile spec from config/i386/gnu.h to config/gnu.h

Hi! On 2024-01-03T09:49:06+, Richard Sandiford wrote: > The series looks good to me FWIW, but Thomas should have the final say. Richard, thanks for your review. Sergey, great work on aarch64 GNU/Hurd! (... where these GCC bits clearly were the less complicated part...) ;-) Please

Re: [PATCH v7 0/5] New attribute "counted_by" to annotate bounds for C99 FAM(PR108896)

On Wed, Mar 20, 2024 at 01:15:13PM +, Qing Zhao wrote: > This is the 7th version of the patch. This happily builds the Linux kernel with all its hundreds of counted_by annotations. My behavioral regression tests all pass too: # PASSED: 19 / 19 tests passed. # Totals: pass:17 fail:0 xfail:2

Re: [gcc-15 2/3] RISC-V: avoid LUI based const mat: keep stack offsets aligned

On 3/19/24 2:05 PM, Vineet Gupta wrote: Just to be clear, the changes don't misalign the stack pointer at all. They merely have the potential to create *another* pointer into the stack which may or may not be aligned. Which is totally normal, it's no different than taking the address of a

Re: RISC-V: Use convert instructions instead of calling library functions

On 3/19/24 10:23 AM, Palmer Dabbelt wrote: On Mon, 18 Mar 2024 20:50:14 PDT (-0700), jeffreya...@gmail.com wrote: On 3/18/24 3:09 AM, Jivan Hakobyan wrote: As RV has round instructions it is reasonable to use them instead of calling the library functions. With my patch for the following

Re: [committed] m32r: Fix up m32r_setup_incoming_varargs [PR114175]

On 3/20/24 11:29 AM, Jakub Jelinek wrote: On Wed, Mar 20, 2024 at 10:58:05AM -0600, Jeff Law wrote: On 3/20/24 10:06 AM, Jakub Jelinek wrote: Like for x86-64, alpha or rs6000, m32r seems to be affected too. Just visually checked differences in c23-stdarg-9.c assembly in a cross

Re: _LIBCXX_DEBUG value initialized singular iterators assert failures in std algorithms [PR104316]

As proposed below I also updated gcc-13 branch.     libstdc++: [_GLIBCXX_DEBUG] Define __cpp_lib_null_iterators     _GLIBCXX_DEBUG has now fully N3344 compliant iterator checks, we can define     __cpp_lib_null_iterators macros like the normal mode.     libstdc++-v3/ChangeLog:     *

Re: [committed] csky: Fix up csky_setup_incoming_varargs [PR114175]

On 3/20/24 10:04 AM, Jakub Jelinek wrote: Hi! Like for x86-64, alpha or rs6000, csky seems to be affected too. Just visually checked differences in c23-stdarg-9.c assembly in a cross without/with the patch, committed to trunk. 2024-03-20 Jakub Jelinek PR target/114175 *

Re: [committed] m32r: Fix up m32r_setup_incoming_varargs [PR114175]

On Wed, Mar 20, 2024 at 10:58:05AM -0600, Jeff Law wrote: > On 3/20/24 10:06 AM, Jakub Jelinek wrote: > > Like for x86-64, alpha or rs6000, m32r seems to be affected too. > > > > Just visually checked differences in c23-stdarg-9.c assembly in a cross > > without/with the patch, committed to

Re: [committed] visium: Fix up visium_setup_incoming_varargs [PR114175]

On 3/20/24 10:08 AM, Jakub Jelinek wrote: Hi! Like for x86-64, alpha or rs6000, visium seems to be affected too. Just visually checked differences in c23-stdarg-9.c assembly in a cross without/with the patch, committed to trunk. 2024-03-20 Jakub Jelinek PR target/114175

Re: [committed] nds32: Fix up nds32_setup_incoming_varargs [PR114175]

On 3/20/24 10:06 AM, Jakub Jelinek wrote: Hi! Like for x86-64, alpha or rs6000, nds32 seems to be affected too. Just visually checked differences in c23-stdarg-9.c assembly in a cross without/with the patch, committed to trunk. 2024-03-20 Jakub Jelinek PR target/114175

Re: [committed] ft32: Fix up ft32_setup_incoming_varargs [PR114175]

On 3/20/24 10:05 AM, Jakub Jelinek wrote: Hi! Like for x86-64, alpha or rs6000, ft32 seems to be affected too. Just visually checked differences in c23-stdarg-9.c assembly in a cross without/with the patch, committed to trunk. 2024-03-20 Jakub Jelinek PR target/114175 *

Re: [committed] epiphany: Fix up epiphany_setup_incoming_varargs [PR114175]

On 3/20/24 10:05 AM, Jakub Jelinek wrote: Hi! Like for x86-64, alpha or rs6000, epiphany seems to be affected too. Just visually checked differences in c23-stdarg-9.c assembly in a cross without/with the patch, committed to trunk. 2024-03-20 Jakub Jelinek PR target/114175

Re: [committed] m32r: Fix up m32r_setup_incoming_varargs [PR114175]

On 3/20/24 10:06 AM, Jakub Jelinek wrote: Hi! Like for x86-64, alpha or rs6000, m32r seems to be affected too. Just visually checked differences in c23-stdarg-9.c assembly in a cross without/with the patch, committed to trunk. That fixed c23-stdarg-{6,8,9} execution tests. jeff

[committed] visium: Fix up visium_setup_incoming_varargs [PR114175]

Hi! Like for x86-64, alpha or rs6000, visium seems to be affected too. Just visually checked differences in c23-stdarg-9.c assembly in a cross without/with the patch, committed to trunk. 2024-03-20 Jakub Jelinek PR target/114175 * config/visium/visium.cc

[committed] nios2: Fix up nios2_setup_incoming_varargs [PR114175]

Hi! Like for x86-64, alpha or rs6000, nios2 seems to be affected too. Just visually checked differences in c23-stdarg-9.c assembly in a cross without/with the patch, committed to trunk. 2024-03-20 Jakub Jelinek PR target/114175 * config/nios2/nios2.cc

[committed] nds32: Fix up nds32_setup_incoming_varargs [PR114175]

Hi! Like for x86-64, alpha or rs6000, nds32 seems to be affected too. Just visually checked differences in c23-stdarg-9.c assembly in a cross without/with the patch, committed to trunk. 2024-03-20 Jakub Jelinek PR target/114175 * config/nds32/nds32.cc

[committed] m32r: Fix up m32r_setup_incoming_varargs [PR114175]

Hi! Like for x86-64, alpha or rs6000, m32r seems to be affected too. Just visually checked differences in c23-stdarg-9.c assembly in a cross without/with the patch, committed to trunk. 2024-03-20 Jakub Jelinek PR target/114175 * config/m32r/m32r.cc

[committed] ft32: Fix up ft32_setup_incoming_varargs [PR114175]

Hi! Like for x86-64, alpha or rs6000, ft32 seems to be affected too. Just visually checked differences in c23-stdarg-9.c assembly in a cross without/with the patch, committed to trunk. 2024-03-20 Jakub Jelinek PR target/114175 * config/ft32/ft32.cc

[committed] epiphany: Fix up epiphany_setup_incoming_varargs [PR114175]

Hi! Like for x86-64, alpha or rs6000, epiphany seems to be affected too. Just visually checked differences in c23-stdarg-9.c assembly in a cross without/with the patch, committed to trunk. 2024-03-20 Jakub Jelinek PR target/114175 * config/epiphany/epiphany.cc

[committed] csky: Fix up csky_setup_incoming_varargs [PR114175]

Hi! Like for x86-64, alpha or rs6000, csky seems to be affected too. Just visually checked differences in c23-stdarg-9.c assembly in a cross without/with the patch, committed to trunk. 2024-03-20 Jakub Jelinek PR target/114175 * config/csky/csky.cc

Re: [PATCH 1/1] aarch64: Sync aarch64-sys-regs.def with Binutils

Hi Richard, > On 20 Mar 2024, at 1:55 PM, Richard Earnshaw (lists) > wrote: > > On 20/03/2024 11:21, Yury Khrustalev wrote: >> This patch updates `aarch64-sys-regs.def', bringing it into sync with >> the Binutils source. >> >> gcc/ChangeLog: >> >> * config/aarch64/aarch64-sys-regs.def:

Re: [PATCH 1/1] aarch64: Sync aarch64-sys-regs.def with Binutils

On 20/03/2024 11:21, Yury Khrustalev wrote: > This patch updates `aarch64-sys-regs.def', bringing it into sync with > the Binutils source. > > gcc/ChangeLog: > > * config/aarch64/aarch64-sys-regs.def: Copy from Binutils. Thanks, I've pushed this. It's trivial enough and there's value of

[PATCH v7 4/5] Use the .ACCESS_WITH_SIZE in bound sanitizer.

gcc/c-family/ChangeLog: * c-ubsan.cc (get_bound_from_access_with_size): New function. (ubsan_instrument_bounds): Handle call to .ACCESS_WITH_SIZE. gcc/testsuite/ChangeLog: * gcc.dg/ubsan/flex-array-counted-by-bounds-2.c: New test. *

[PATCH v7 5/5] Add the 6th argument to .ACCESS_WITH_SIZE

to carry the TYPE of the flexible array. Such information is needed during tree-object-size.cc. We cannot use the result type or the type of the 1st argument of the routine .ACCESS_WITH_SIZE to decide the element type of the original array due to possible type casting in the source code.

[PATCH v7 3/5] Use the .ACCESS_WITH_SIZE in builtin object size.

gcc/ChangeLog: * tree-object-size.cc (access_with_size_object_size): New function. (call_object_size): Call the new function. gcc/testsuite/ChangeLog: * gcc.dg/builtin-object-size-common.h: Add a new macro EXPECT. * gcc.dg/flex-array-counted-by-3.c: New test.

[PATCH v7 2/5] Convert references with "counted_by" attributes to/from .ACCESS_WITH_SIZE.

Including the following changes: * The definition of the new internal function .ACCESS_WITH_SIZE in internal-fn.def. * C FE converts every reference to a FAM with a "counted_by" attribute to a call to the internal function .ACCESS_WITH_SIZE. (build_component_ref in c_typeck.cc) This

[PATCH v7 1/5] Provide counted_by attribute to flexible array member field (PR108896)

'counted_by (COUNT)' The 'counted_by' attribute may be attached to the C99 flexible array member of a structure. It indicates that the number of the elements of the array is given by the field named "COUNT" in the same structure as the flexible array member. GCC may use

[PATCH v7 0/5] New attribute "counted_by" to annotate bounds for C99 FAM(PR108896)

Hi, This is the 7th version of the patch. compare with the 6th version, the difference are: updates per Siddhesh's comments: 1. update the error messages in "handle_counted_by_attribute" then update the testing case accordingly; 2. update the error messages in "verify_counted_by_attribute"

Re: [PATCH v2 00/13] Add aarch64-w64-mingw32 target

Hello, everyone. I've re-run the `x86_64-w64-mingw32` target tests with all the languages enabled, except of Ada and JIT, which are harder to bootstrap, and Go, which is not supported by MinGW. The summarized results are: 536176 of expected passes 13859 of unexpected failures 188 of unexpected

[PATCH 1/1] aarch64: Sync aarch64-sys-regs.def with Binutils

This patch updates `aarch64-sys-regs.def', bringing it into sync with the Binutils source. gcc/ChangeLog: * config/aarch64/aarch64-sys-regs.def: Copy from Binutils. --- gcc/config/aarch64/aarch64-sys-regs.def | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 0/1] aarch64: Sync aarch64-sys-regs.def with Binutils

Hi, This patch updates `aarch64-sys-regs.def', bringing it into sync with the Binutils source. Regression tested on aarch64-none-linux-gnu and no regressions have been found. Is it OK for GCC master? I don't have commit access so I need someone to commit on my behalf. Thanks, Yury Yury

[PATCH] s390x: Implement vector cost model

Hi, s390x used the basic cost model which does not correctly model the cost of register file crossing or the availability of certain instructions to simplify reversed operations. Implement an own cost model to better control when to vectorize. gcc/ChangeLog: * config/s390/s390.cc

Re: [PATCH] Use integer_{zero,one}_node some more

On Wed, 20 Mar 2024, Jakub Jelinek wrote: > Hi! > > When looking at the analyzer MEM_REF invalid second arg issue, I've noticed > tons of build_int_cst (integer_type_node, {0,1}) or build_zero_cst > (integer_type_node) cases. > That just wastes compile time (albeit not very much). > > The

Re: [PATCH] bitint: Fix handling of conditional bitfield loads [PR114365]

On Wed, 20 Mar 2024, Jakub Jelinek wrote: > Hi! > > For the m_var_msb (aka left shift) case of large/huge _BitInt bitfield loads > handle_load adds a PHI node, but I forgot to actually update the temporary > the code later on uses, so the PHI result was unused and the code > incorrectly used

Re: [PATCH] testsuite: add the case to cover vectorization of A[(i+x)*stride] [PR114322]

> So - OK with using { target vect_int } instead. Sure, it's much better to be target independent. Refactored and committed in r14-9569-g4c276896 Thanks, - Hao From: Richard Biener Sent: Wednesday, March 20, 2024 16:21 To: Hao Liu OS Cc:

[committed] tree-ssa-loop-ch: Fix comment typos

Hi! When looking at PR109596, I've noticed some comment typos. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk as obvious. 2024-03-20 Jakub Jelinek * tree-ssa-loop-ch.cc (update_profile_after_ch): Fix comment typo: probabbility -> probability.

[PATCH] Use integer_{zero,one}_node some more

Hi! When looking at the analyzer MEM_REF invalid second arg issue, I've noticed tons of build_int_cst (integer_type_node, {0,1}) or build_zero_cst (integer_type_node) cases. That just wastes compile time (albeit not very much). The following patch fixes what my sed script found. Ok for trunk

[PATCH] bitint: Fix handling of conditional bitfield loads [PR114365]

Hi! For the m_var_msb (aka left shift) case of large/huge _BitInt bitfield loads handle_load adds a PHI node, but I forgot to actually update the temporary the code later on uses, so the PHI result was unused and the code incorrectly used something that wasn't valid SSA form. In particular, we

Re: _LIBCXX_DEBUG value initialized singular iterators assert failures in std algorithms [PR104316]

On Wed, 20 Mar 2024 at 05:59, François Dumont wrote: > > Thanks to you doc: > > libstdc++: [_GLIBCXX_DEBUG] Define __[glibcxx,cpp_lib]_null_iterators > > _GLIBCXX_DEBUG has now fully N3344 compliant iterator checks, we > can define > __glibcxx_null_iterators and

Re: [PATCH] handle unwind tables that are embedded within unwinding code, [PR111731]

On Fri, Mar 15, 2024 at 11:31 AM Thomas Neumann wrote: > > Original bug report: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111731 > Given that this is a regression, is this okay for gcc 13 and mainline? It does look straightforward but I hope Jason or Florian can provide the ACK. Thanks,

[PATCH] MIPS: Predefine __mips_strict_alignment if STRICT_ALIGNMENT

Arm32 predefines __ARM_FEATURE_UNALIGNED if -mno-unaligned-access, and RISC-V predefines __riscv_misaligned_avoid. Let's define __mips_strict_alignment for MIPSr6 and -mstrict-align is used. Not that, this macro is always defined for pre-R6. gcc config/mips/mips.h

Re: [PATCH] testsuite: add the case to cover vectorization of A[(i+x)*stride] [PR114322]

On Wed, 20 Mar 2024, Hao Liu OS wrote: > Hi Richard, > > As mentioned in the comments of PR114322 (which has been fixed by PR114151 > r14-9540-ge0e9499a), this patch is to cover the case. > > Bootstrapped and regression tested on aarch64-linux-gnu, OK for trunk? > > gcc/testsuite/ChangeLog: >

Re: [PATCH] middle-end/113396 - int128 array index and value-ranges

On Tue, 19 Mar 2024, Jakub Jelinek wrote: > On Tue, Mar 19, 2024 at 03:47:37PM +0100, Richard Biener wrote: > > The following fixes bogus truncation of a value-range for an int128 > > array index when computing the maximum extent for a variable array > > reference. Instead of possibly slowing

[PATCH] testsuite: add the case to cover vectorization of A[(i+x)*stride] [PR114322]

Hi Richard, As mentioned in the comments of PR114322 (which has been fixed by PR114151 r14-9540-ge0e9499a), this patch is to cover the case. Bootstrapped and regression tested on aarch64-linux-gnu, OK for trunk? gcc/testsuite/ChangeLog: PR tree-optimization/114322 *

[PATCH] mips: Fix C23 (...) functions returning large aggregates [PR114175]

We were assuming TYPE_NO_NAMED_ARGS_STDARG_P don't have any named arguments and there is nothing to advance, but that is not the case for (...) functions returning by hidden reference which have one such artificial argument. This is causing gcc.dg/c23-stdarg-{6,8,9}.c to fail. Fix the issue by

[PATCH v1] RISC-V: Bugfix function target attribute pollution

From: Pan Li This patch depends on below ICE fix. https://gcc.gnu.org/pipermail/gcc-patches/2024-March/647915.html The function target attribute should be on a per-function basis. For example, we have 3 function as below: void test_1 () {} void __attribute__((target("arch=+v"))) test_2 () {}