[PATCH 05/10] libcc1: use variadic templates for "call"

This changes libcc1 to use variadic templates for the "call" functions. The primary benefit is that this simplifies the code. libcc1/ChangeLog 2021-01-03 Tom Tromey * rpc.hh (call): Use variadic template. Remove overloads. * marshall.hh (marshall): Add base over

[PATCH 01/10] libcc1: use templates to unmarshall enums

Now that C++11 can be used in GCC, libcc1 can be changed to use templates and type traits to handle unmarshalling all kinds of enums. libcc1/ChangeLog 2021-01-03 Tom Tromey * marshall.hh (cc1_plugin::unmarshall): Use type traits. * marshall-cp.hh (cc1_plugin::unmarshall

[PATCH 03/10] libcc1: inline some simple methods

This changes libcc1 to inline a trivial method and to use the default constructor. libcc1/ChangeLog 2021-01-03 Tom Tromey * connection.hh (~connection): Use default. (print): Inline. * connection.cc (cc1_plugin::connection::~connection) (cc1_plugin::connection

[PATCH 02/10] libcc1: use "override"

This changes libcc1 to use "override" where appropriate. libcc1/ChangeLog 2021-01-03 Tom Tromey * libcp1.cc (class compiler_triplet_regexp) (class compiler_driver_filename, class libcp1_connection): Use "override". * libcc1.cc (class com

[PATCH 00/10] C++11-based improvements for libcc1

This short series uses C++11 features to simplify libcc1. This brings the code closer to how I pictured it when I first wrote it. (It would be further improved by std::apply, but this isn't available until C++17.) I built and tested this against git GDB on x86-64 Fedora 32. Note that the C++

Re: [07/23] Add a class that multiplexes two pointer types

> "Richard" == Richard Sandiford via Gcc-patches > writes: Richard> +// A class that stores a choice "A or B", where A has type T1 * and B has Richard> +// type T2 *. Both T1 and T2 must have an alignment greater than 1, since Richard> +// the low bit is used to identify B over A.

Re: [PATCH] libstdc++: Enable without gthreads

> "Jonathan" == Jonathan Wakely writes: Jonathan> Here's a slightly more conservative version of the patch. This moves Jonathan> std::thread and this_thread::get_id() and this_thread::yield() to a Jonathan> new header, and makes *most* of std::thread defined without gthreads Jonathan>

Re: [PATCH] c++: Predefine __STDCPP_THREADS__ in the compiler if thread model is not single

Jakub> If it is done in the library, it will be defined only if any of the library Jakub> headers are included. Jakub> The https://eel.is/c++draft/cpp.predefined wording doesn't look like it Jakub> would allow defining it only if certain headers are included Jakub> (unlike e.g. the __cpp_lib_*

Re: [PATCH] c++: Predefine __STDCPP_THREADS__ in the compiler if thread model is not single

> "Jakub" == Jakub Jelinek via Gcc-patches writes: Jakub> 2020-11-13 Jakub Jelinek Jakub> * c-cppbuiltin.c: Include configargs.h. Jakub> (c_cpp_builtins): For C++11 and later if THREAD_MODEL_SPEC is not Jakub> defined, predefine __STDCPP_THREADS__ to 1 unless thread_model is Jakub>

Re: [PATCH] dwarf: Multi-register CFI address support

> "Andrew" == Andrew Stubbs writes: Andrew> http://llvm.org/docs/AMDGPUDwarfExtensionsForHeterogeneousDebugging.html#composite-location-description-operations Thanks. Adding that to the appropriate spot in the patch would be great. Tom

Re: [PATCH] dwarf: Multi-register CFI address support

> "Andrew" == Andrew Stubbs writes: Andrew> To be fair, the DWARF standard makes a similar assumption; the Andrew> engineers working on LLVM and GDB, at AMD, have therefore invented Andrew> some new DWARF operators that they plan to propose for a future Andrew> standard. Only one is relevant

Re: [PATCH 2/5] Make sure that static data member constexpr isn't optimized away in test.

>> This looks incorrect to me, that is a workaround for a real GCC bug. Mark> I was discussing this after the BoF with Tom Tromey (CCed) and he also Mark> thought gdb could/should actually support the DWARF5 representation, Mark> but because the DW_TAG_variable was removed because

Re: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES

Simon> Since it's debuginfo.m4 that is using PKG_CHECK_MODULES, can you put the include Simon> of pkg.m4 in debuginfo.m4, instead of in {binutils,gdb}/configure.ac? Simon> Otherwise, from GDB's point of view I think it looks good, unless Simon> Tom has some things to add. I'm happy with it.

Re: [PATCH] fortran/95509 - fix spellcheck-operator.f90 regression

Bernhard> Yes, this is probably OK although Fortran is case- Bernhard> insensitive. I think we lowercase names coming in from the Bernhard> source (at least for the internal identifier nodes), so we Bernhard> should not be affected by any case change. I already checked it in, but FWIW it would be

[PATCH] fortran/95509 - fix spellcheck-operator.f90 regression

My earlier patch to add case handling to the spell checker caused a Fortran regression. I believe I must have misread the test results. This patch fixes the problem by changing the cutoff. I chose this value because the previous patch effectively multiplied the result of get_edit_distance by 2

Re: [PATCH] Prefer simple case changes in spelling suggestions

entioned earlier, an existing test already does what you asked for. Tom commit e897a99dada8d3935343ebf7b14ad7ec36515b3d Author: Tom Tromey Date: Fri May 29 10:46:57 2020 -0600 Prefer simple case changes in spelling suggestions I got this error message when editing gcc

Re: [PATCH] Prefer simple case changes in spelling suggestions

> "David" == David Malcolm writes: >> I tested this using the self-tests. A new self-test is also >> included. > Did the full DejaGnu testsuite get run? There are a lot of tests in it > that make use of this code. I didn't try it, but I can. > The patch should probably update the

[PATCH] Prefer simple case changes in spelling suggestions

I got this error message when editing gcc and recompiling: ../../gcc/gcc/ada/gcc-interface/decl.c:7714:39: error: ‘DWARF_GNAT_ENCODINGS_all’ was not declared in this scope; did you mean ‘DWARF_GNAT_ENCODINGS_GDB’? 7714 | = debug_info && gnat_encodings == DWARF_GNAT_ENCODINGS_all; |

Re: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES

> "Aaron" == Aaron Merey via Binutils writes: Aaron> * Makefile.in: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS. Aaron> * aclocal.m4: Rebuild. Instead of inlining pkg.m4 into aclocal.m4, how about making config/pkg.m4 and then using m4_include from gdb/acinclude.m4? That's

[PATCH] Some top-level configury syncing with gdb

Merge top-level configury changes from gdb We recently rearranged the gdb source tree to move a common library and gdbserver to the top-level. This made the build more uniform and also a bit faster (due to sharing of built objects). This patch re-syncs these changes the top-level configury back

Re: [PATCH] configure: Re-disable building cross-gdbserver

> "Maciej" == Maciej W Rozycki writes: Maciej> Correct fallout from commit 919adfe84092 ("Move gdbserver to top level") Maciej> and revert to not building `gdbserver' in a cross-configuration, that is Maciej> where host != target, matching the documented behaviour. We have no way

Re: [PATCH] Come up with constructors of symtab_node, cgraph_node and varpool_node.

> "Martin" == Martin Liška writes: Martin> + /* Default constructor. */ Martin> + symtab_node (symtab_type t) FWIW, in gdb, we normally make single-argument constructors "explicit". This helps avoid surprises with implicit conversions. Tom

Re: [PATCH 06/49] timevar.h: add auto_client_timevar class

> "Martin" == Martin Sebor writes: >> + private: >> + // Private to disallow copies. >> + auto_client_timevar (const auto_client_timevar &); Martin> I don't know why it's important to disallow making copies of Martin> these classes (they look safe to copy) but usually it goes Martin>

[PATCH] Remove vestiges of MODIFY_JNI_METHOD_CALL

I happened to notice that MODIFY_JNI_METHOD_CALL was defined in cygming.h and documented in tm.texi. However, because it was only needed for gcj, it is obsolete. This patch removes the vestiges. Tested by grep, and rebuilding the documentation. gcc/ChangeLog 2019-11-13 Tom Tromey

Re: [PATCH] Add --with-static-standard-libraries to the top level

> "Jonathan" == Jonathan Wakely writes: Jonathan> Given that the problem does exist, I think being able to disable the Jonathan> GCC build flags for non-GCC components in the build tree makes sense. Jonathan> I'm not sure if Jeff deferring to me means I can approve the patch Jonathan>

Re: [PATCH] Add --with-static-standard-libraries to the top level

Jonathan> What I don't understand is why GDB crashes. It should still be able to Jonathan> catch exceptions from a shared library even if linked to libstdc++.a, Jonathan> unless the static libstdc++.a is somehow incompatible with the shared Jonathan> libstdc++.so the shared lib linked to.

[PATCH] Add --with-static-standard-libraries to the top level

to the top-level configure. It defaults to "auto", which means enabled if gcc is being built, and disabled otherwise. Tom 2019-07-27 Tom Tromey * configure: Rebuild. * configure.ac: Add --with-static-standard-libraries. diff --git a/configure.ac b/configure.ac index 8

[PATCH] Sync top-level change from gdb

This patch syncs a change to the top-level configury from gdb. It should not affect the gcc build at all. Tested by rebuilding. ChangeLog 2019-06-14 Tom Tromey * configure.ac (host_libs): Add gnulib. * configure: Rebuild. * Makefile.def (host_modules, dependencies

Re: [PATCH] Do not warn with warn_unused_result for alloca(0).

> "Jeff" == Jeff Law writes: Jeff> I'd like to move C-alloca support to the ash heap of history. But I'm Jeff> not sure we can realistically do that. Are there still platforms or compilers in use where it's needed? For gdb I was planning to just remove these calls. Tom

Re: Move -Wmaybe-uninitialized to -Wextra

> "Marc" == Marc Glisse writes: >> Lastly, in the case of uninitialized variables, the usual solution >> of initializing them is trivial and always safe (some coding styles >> even require it). Marc> Here it shows that we don't work with the same type of code at all. If Marc> I am using a

[gmane.comp.gdb.patches] [RFA] Fix splay tree KEY leak detected in GDB test gdb.base/macscp.exp

from a splay tree, the splay tree was not using the function splay_tree_delete_key_fn to release the key. This was causing a leak, fixed by Tom Tromey. This patch fixes another key leak, that happens when a key equal to a key already present is inserted. In such a case, we have to release the old KEY

[PATCH] Fix leak in splay-tree

files changed, 6 insertions(+) diff --git a/libiberty/ChangeLog b/libiberty/ChangeLog index bcc0227bdd8..1eb25f928f2 100644 --- a/libiberty/ChangeLog +++ b/libiberty/ChangeLog @@ -1,3 +1,7 @@ +2019-01-18 Tom Tromey + + * splay-tree.c (splay_tree_remove): Delete the key if necessary

Re: RFC: libiberty PATCH to disable demangling of ancient mangling schemes

> "Pedro" == Pedro Alves writes: Pedro> I would say that it's very, very unlikely, and not worth it of the Pedro> maintenance burden. Agreed, and especially true for the more unusual demanglings like Lucid or EDG. On the gdb side perhaps we can get rid of "demangle-style" now. It probably

Re: [PATCH] Backport gettext fixes to get rid of warnings on macOS

> "Simon" == Simon Marchi writes: Simon> intl/ChangeLog: Simon> * libgnuintl.h (_INTL_MAY_RETURN_STRING_ARG, gettext, dgettext, Simon> dcgettext, ngettext, dngettext, dcngettext): Backport changes Simon> from upstream gettext. Thanks, I think you should check this in. Tom

RFA: libiberty: avoid UBSAN complaint in cplus-dem.c

) and re-running the test suite. Ok? Tom 2018-07-27 Tom Tromey * cplus-dem.c (remember_Btype): Don't call memcpy with LEN==0. diff --git a/libiberty/cplus-dem.c b/libiberty/cplus-dem.c index 6d58bd899bf..4f29d54d089 100644 --- a/libiberty/cplus-dem.c +++ b/libiberty/cplus-dem.c

Re: [RFA] Implement __VA_OPT__

s approach makes it possible for __VA_OPT__ to be used in system headers even when the -std/-pedantic settings may otherwise disallow it. Bootstrapped and regression tested on x86-64 Fedora 25. gcc/ChangeLog 2017-09-16 Tom Tromey <t...@tromey.com>

Re: [RFA] Implement __VA_OPT__

Tom> [ __VA_OPT__ ] Tom> Here's v3. Tom> Ping. Tom> Ping #2. Ping #3. Tom

Re: [RFA] Implement __VA_OPT__

>>>>> "Tom" == Tom Tromey <t...@tromey.com> writes: Tom> [ __VA_OPT__ ] Tom> Here's v3. Tom> Ping. Ping #2. Tom

Re: [RFA] Implement __VA_OPT__

>>>>> "Tom" == Tom Tromey <t...@tromey.com> writes: [ __VA_OPT__ ] Tom> Here's v3. Ping. Tom

Re: [RFA] Implement __VA_OPT__

And, darn it, I forgot to save cpp.texi, leaving out a couple of tweaks there. Here's v3. Sorry about the noise. Tom diff --git a/gcc/ChangeLog b/gcc/ChangeLog index e213db6..362f50e 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,7 @@ +2017-09-16 Tom Tromey <t...@tromey.

Re: [RFA] Implement __VA_OPT__

b/gcc/ChangeLog index e213db6..362f50e 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,7 @@ +2017-09-16 Tom Tromey <t...@tromey.com> + + * doc/cpp.texi (Variadic Macros): Document __VA_OPT__. + 2017-09-16 Richard Sandiford <richard.sandif...@linaro.org>

Re: [RFA] Implement __VA_OPT__

> "Alexander" == Alexander Monakov writes: Alexander> This hunk reverts CXX17 back to CXX1Z. Thanks for noticing, I'd written this before Jakub's patch and so the error came in during the rebase. Alexander> These two hunks add more duplication in already-duplicated 'if'

[RFA] Implement __VA_OPT__

. gcc/ChangeLog 2017-09-16 Tom Tromey <t...@tromey.com> * doc/cpp.texi (Variadic Macros): Document __VA_OPT__. gcc/testsuite/ChangeLog 2017-09-16 Tom Tromey <t...@tromey.com> * c-c++-common/cpp/va-opt.c: New file. * c-c++-common/cpp/va-opt-error.c: New f

Re: [PATCH] PR debug/77315 - use DW_OP_form_tls_address

ldn't be guarded with dwarf_version >= 5 Here's what that looks like. Tom commit 7865ede46e519fa6bc3d6367f943a40179b4d380 Author: Tom Tromey <t...@tromey.com> Date: Thu Oct 20 17:03:35 2016 -0600 PR debug/77315 - use DW_OP_form_tls_address This patch chang

Re: [PATCH] PR debug/77315 - use DW_OP_form_tls_address

> "Jakub" == Jakub Jelinek writes: Jakub> I admit I haven't looked at the GDB changes, but how will the debugger know Jakub> if it is an emutls emulation or normal ELF TLS, if the same op is used Jakub> in both cases? Because gdb never implemented DW_OP_form_tls_address,

[PATCH] PR debug/77315 - use DW_OP_form_tls_address

recently -- in fact it isn't even in 7.12 (I thought I had put it in there but it seems not). I'm not sure if that means that this should wait a cycle. Built and regtested on x86-64 Fedora 24. 2016-10-21 Tom Tromey <t...@tromey.com> PR debug/77315: * dwarf2out.c (mem_loc_desc

Re: [PATCH] Fix -Wimplicit-fallthrough -C, handle some more comment styles and comments in between FALLTHRU comment and label

> "Eric" == Eric Botcazou writes: Eric> So, because of its excessive pickiness, the warning ends up making the user Eric> butcher informative comments. How is that helpful? Those comments are not informative. In most cases I kept the original text just to

Re: Implement -Wimplicit-fallthrough (version 9)

> "Jakub" == Jakub Jelinek writes: >> default: >> { >> complaint (_complaints, >> _("Storage class %d not recognized during scan"), >> sclass); >> } >> /* FALLTHROUGH */ >> >> /* C_FCN is .bf and .ef symbols. I think it is sufficient >> to handle only the C_FUN and C_EXT.

Re: Implement -Wimplicit-fallthrough (version 9)

> "Michael" == Michael Matz writes: Michael> Not accepting Michael> /* And here we intentionally fall through because ... */ Michael> and forcing users to replace this by: Michael> /* fallthrough */ Michael> is not robust either. It's actually actively lowering robustness

Re: Implement -Wimplicit-fallthrough (version 9)

> "Michael" == Michael Matz writes: Michael> All those bugs would also have been found as well when it had simply Michael> accepted Michael> /fall.*thr/i Michael> anywhere in the preceding comment on one line. But all the recent Michael> spelling changes of comments to

Re: [PATCH] Automatically generate dependencies for the build-machine object files

> "Pedro" == Pedro Alves writes: >> ISTM we ought to try and rectify the dependency situation for the build >> bits. The haphazard way we've managed dependencies may have made sense >> in 1992, but doesn't today... >> Jeff Pedro> I can't imagine how would anyone

Re: Implement -Wimplicit-fallthrough (take 2): fix missing breaks

> "Marek" == Marek Polacek writes: Marek> gcc/java/ Marek> * jcf-dump.c (print_constant): Add break. This bit is ok. Tom

Re: [PATCH] Fix FFI return type for proxy classes

> "Matthew" == Matthew Fortune writes: Matthew> Tested on: x86_64-pc-linux-gnu (default and -m32), mips-linux-gnu Matthew> mipsel-linux-gnuabi64 with no regressions. The new test only failed Matthew> on mips-linux-gnu prior to patching libjava. Matthew> libjava/

Re: [PATCH] Fix FFI return type for closures in the java interpreter

> "Matthew" == Matthew Fortune writes: Matthew> Sorry for the long delay... No problem. >> This is ok. >> Could you check? I think a -m32 build ought to show it. Maybe your >> x86-64 build already did this? Matthew> Still OK to commit? Yes, thanks. Tom

Re: Implement -Wswitch-fallthrough: java

> "Marek" == Marek Polacek writes: Marek> +++ gcc/gcc/java/jcf-dump.c Marek> @@ -926,6 +926,8 @@ print_constant (FILE *out, JCF *jcf, int index, int verbosity) Marek>if (verbosity > 0) Marek> fprintf (out, "Fieldref: %ld=", (long) JPOOL_USHORT2

Re: [PATCH] Fix FFI return type for closures in the java interpreter

> "Matthew" == Matthew Fortune writes: Matthew> I'm not sure this will matter if the only arch is x86 as Matthew> ffi_arg will be 32-bit anyway there. Aha, right. Thanks for looking. Matthew> There would need to be a Matthew> 64bit arch using the raw api. I

Re: [PATCH] Fix FFI return type for closures in the java interpreter

> "Matthew" == Matthew Fortune writes: Matthew> I've identified a latent bug in the java interpreter that affects MIPS Matthew> n32 and n64 ABIs both little and big endian and, I presume, any 64-bit Matthew> big endian target with int as 32-bit. [...] Matthew>

Re: [PATCH] Fix FFI return type for closures in the java interpreter

> "Matthew" == Matthew Fortune writes: Matthew> I've identified a latent bug in the java interpreter that affects MIPS Matthew> n32 and n64 ABIs both little and big endian and, I presume, any 64-bit Matthew> big endian target with int as 32-bit. Thanks. Matthew>

[RFA] add DW_LANG_Rust

to dwarf2.h. I added DW_LANG_Rust_old because some versions of the Rust compiler use this value and it's nice to have a name for it. Ok? Tom 2016-04-26 Tom Tromey <t...@tromey.com> * dwarf2.h (enum dwarf_source_language) <DW_LANG_Rust, DW_LANG_Rust_old>: New constants.

Re: [PATCH] Add debug_function_graph_to_file

Richard> What does it take to write it in python instead? IIUC you're asking for it to display the function graph at a given point in time. This is easy - you can just dump it to a file and then run the appropriate visualization tool. Once upon a time I also wrote Python code to display a

Re: [PATCH] Fix c/69643, named address space wrong-code

> "rth" == Richard Henderson writes: rth> The user-friendly way to do this would probably be some sort of pragma rth> that allows user-defined address spaces, and user-defined conversion rth> between them. But that's certainly not going to happen in the rth> near-term.

Re: [PATCH] libjava: fix locale handling when sorting JNI methods

Mike> URL: https://bugs.gentoo.org/563710 Mike> Reported-by: Miroslav Šulc Mike> 2015-10-22 Mike Frysinger Mike> * scripts/check_jni_methods.sh.in: Run sort with LC_ALL=C, and Mike> combine `sort|uniq` into `sort -u`. Mike> --- Mike>

Re: [PATCH, libjava/classpath]: Fix overriding recipe for target 'gjdoc' build warning

Andrew No, it isn't. It's still a necessity for initial bootstrapping of Andrew OpenJDK/IcedTea. Andrew Haley said the opposite here: https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00537.html Tom

Re: [PATCH, libjava/classpath]: Fix overriding recipe for target 'gjdoc' build warning

Jeff In the past this has stalled on issues like how will asynch-exceptions Jeff be tested and the like. It seems to me that either there is some other language which needs this -- in which case that language ought to have testing for the feature -- or the feature is only used by gcj, in which

Re: [PATCH, libjava/classpath]: Fix overriding recipe for target 'gjdoc' build warning

Jeff It's probably time for the occasional discussion WRT dropping Jeff gcj/libjava from the default languages and replace them with either Jeff Ada or Go. It's long past time to remove it. It's only had minimal maintenance for years now. No one is writing new features for it or fixing bugs.

Re: [PATCH 3/7] Fix trinary op

Ian == Ian Lance Taylor i...@google.com writes: Ian I don't know of anybody who actually uses the DMGL_TYPES support. I Ian don't know why anybody would. It's used in gdb's DWARF reader, though I no longer remember why. Tom

Re: ping: [gcc patch] libcc1: '@' GDB array operator

Manuel It should be possible to arrange the inferior code in Manuel such a way that GCC parses each side of @ independently and gives the Manuel info necessary to GDB such that it can interpret what @ means or give Manuel a reasonable error. Only if this can be done without requiring gdb to lex

Re: ping: [gcc patch] libcc1: '@' GDB array operator

I did not realize that myself before. I do not think there is an easy fix for the GCC patch, is it? It seems like a VLA would work. Jeff 99% of the time I've used a constant with the @ syntax in gdb. I use a non-constant argument to @ quite a bit. It's common to have something like the

Re: [RFC stage 1] Proposed new warning: -Wmisleading-indentation

Dave == David Malcolm dmalc...@redhat.com writes: Dave However within libcpp and gcc, in linemap's expanded_location and in Dave diagnostic messages, the column numbers are actually 1-based counts of Dave *characters*, so the column numbers emitted in diagnostics for the Dave start of the first

Re: [Java PATCH] Generate declarations in jvgenmain.c

Marek == Marek Polacek pola...@redhat.com writes: Marek [CCing java-patches now] Marek Java testsuite breaks with -std=gnu11 as a default and/or with Marek -Wimplicit-function-declaration on I don't recall how one gets warnings when compiling this generated code, but if it is generally

Re: [Java PATCH] Generate declarations in jvgenmain.c

Marek I saw declarations of JvRunMain{,Name} with no parameters and with Marek some parameters. Oh yeah, duh. Marek So I decided to make it prototype-less function Marek declaration for now. I think we don't have to worry about Marek -Wstrict-prototypes for now. Thanks for looking. Tom

Re: [libstdc++] Refactor python/hook.in

Jonathan I'll commit it later this week unless I hear objections from Jonathan Tom. It looks reasonable to me. Tom

Re: [PATCH] gcc parallel make check

Jakub == Jakub Jelinek ja...@redhat.com writes: Jakub I fear that is going to be too expensive, because e.g. all the Jakub caching that dejagnu and our tcl stuff does would be gone, all Jakub the tests for lp64 etc. would need to be repeated for each test. In gdb I arranged to have this stuff

Re: [PATCH libstdc++ v5] - Add xmethods for std::vector and std::unique_ptr

Siva == Siva Chandra sivachan...@google.com writes: Tom Yeah, that's my view. Siva I am probably not understanding it right again. It's ok. I am having some trouble myself. Siva Are you suggesting that in hook.in, we just have single function Siva call like this: Siva register_python_hooks

Re: [PATCH libstdc++ v5] - Add xmethods for std::vector and std::unique_ptr

Siva == Siva Chandra sivachan...@google.com writes: Siva I had something in hook.in in my very first patch but Tom Tromey said Siva it was not required anymore: Siva https://gcc.gnu.org/ml/gcc-patches/2014-06/msg02405.html What I meant was that there should just be a single function called

Re: [PATCH libstdc++ v5] - Add xmethods for std::vector and std::unique_ptr

Siva == Siva Chandra sivachan...@google.com writes: Tom What I meant was that there should just be a single function called by Tom the hook file, and that it should handle the xmethod additions by some Tom means as well. Siva I misunderstood then. But, I still do not understand what you mean by

Re: [PATCH libstdc++ v5] - Add xmethods for std::vector and std::unique_ptr

Siva My patch is still using a single function to register libstdc++ Siva xmethods. Do you mean there should be a single function for pretty Siva printers and xmethods together? Yeah, that's my view. Tom

Re: [PATCH 5/5] add libcc1

Jeff == Jeff Law l...@redhat.com writes: Jeff Obviously if there are no objections and you check in the change, Jeff please be on the lookout for any fallout. I'm particularly concerned Jeff about AIX, Solaris and other non-linux platforms. I did a build on the AIX box (gcc111) in the compile

Re: [PATCH 5/5] add libcc1

Mike == Mike Stump mikest...@comcast.net writes: Mike So the normal way to do this would be to make the plugin front-end Mike non-default and then never gate any release decisions upon the state Mike of the that front-end. Not sure if this is overly pedantic, but the plugin is just a library,

Re: [PATCH] Add D demangling support to libiberty

Iain == Iain Buclaw ibuc...@gdcproject.org writes: Iain This adds a demangler for the D programming language to libiberty, Iain intended to be used in GDB and Binutils. GDB already has a trimmed Iain down implementation of this, but have been advised that here would be Iain a better location to

Re: Prepare gcc for 64-bit obstacks

Alan == Alan Modra amo...@gmail.com writes: Alan Bootstrapped and regression tested x86_64-linux and powerpc-linux, Alan with both the new obstack.{h,c} and the old versions. OK to apply? Alan gcc/java/ Alan * mangle.c (finish_mangling): Cast result of obstack_base to (char *). Alan *

Re: [PATCH 5/5] add libcc1

Richard Can you briefly elaborate on how this relates to the JIT work from Richard David Malcom? I think Trevor answered this bit well but I had a bit more to add... Richard Just throwing in my mental notes from the Summit here. I really Richard wonder how libcc1 falls in into this picture and

Re: [PATCH 5/5] add libcc1

Trevor == Trevor Saunders tsaund...@mozilla.com writes: Trevor the plugin part seems fine, but I do find my self wondering if there's a Trevor better way of doing the hooks into C, if they can be more genrally Trevor useful. There's just one now, the binding oracle. (There used to be two but we

Re: [PATCH v3 3/3] Port libstdc++ pretty-printers to Python 2 + Python 3

I don't think this comment is applicable. The libstdc++ pretty-printers use gdb.Value.lazy_string, not the built-in Python types. Samuel Hmm, doesn't that just make it a timebomb -- a value that will Samuel explode if, at some point in the future, someone tries to treat Samuel it as a string?

Re: [PATCH] libjava/classpath/native/jni/java-lang/java_lang_VMProcess.c: Be sure 'errbuf' always be zero terminated.

Chen == Chen Gang gang.chen.5...@gmail.com writes: Chen 'errbuf' assumes itself will be zero terminated, and it also assumes Chen cpnative_getErrorString() may get larger length string than 'errbuf'. Chen So after strncpy(), 'errbuf' may not be zero terminated. Chen strncpy() is sure of zero

Re: [PATCH] libjava/classpath/native/jni/java-lang/java_lang_VMProcess.c: Be sure 'errbuf' always be zero terminated.

Chen == Chen Gang gang.chen.5...@gmail.com writes: Chen I shall stop making this kind of patch, next. The reason is that I worry Chen about what I have done have negative effect to others. And next, I shall Chen try to send another kinds of patches for gcc when I have time. It's customary to

Re: [PATCH 0/5] let gdb reuse gcc'c C compiler

Tom This patch series is half of a project to let gdb reuse gcc (which Tom half depends on which list you are seeing this on), so that users can Tom compile small snippets of code and evaluate them in the current Tom context of the inferior. [ ... later ... ] Tom I believe we've addressed all the

Re: [PATCH] add __attribute__ ((designated_init))

Tom I've finally updated this patch. I think I've addressed all the review Tom comments. Ping. Tom

Re: [PATCH][gcc-4.9.0] gcc/Makefile.in: fix parallel building failure

Hongxu == Hongxu Jia hongxu@windriver.com writes: Hongxu I tests on 4.10 (gcc-4.10-20140720), and this issue still existed. It seems to me that the generated_files code should handle this: generated_files = config.h tm.h $(TM_P_H) $(TM_H) multilib.h \ [...] $(ALL_HOST_OBJS) : |

Re: [PATCH v3 3/3] Port libstdc++ pretty-printers to Python 2 + Python 3

Samuel == Samuel Bronson naes...@gmail.com writes: Samuel +# FIXME: The handling of e.g. std::basic_string (at least on char) Samuel +# probably needs updating to work with Python 3's new string rules. Samuel +# Samuel +# In particular, Python 3 has a separate type (called byte) for Samuel +#

Re: Some DWARFv5 proposal prototypes (atomic_type, aligned_type)

Mark == Mark Wielaard m...@redhat.com writes: Hi Mark. Mark The following two patches are based on the earlier dwarf2out.c: Pass Mark one cv_quals argument and Emit DW_tag_restrict_type patches I posted Mark earlier. Since there currently is not even an early draft yet for DWARFv5, Mark just a

Re: [patch] Add libstdc++ type printers for class templates

Jonathan == Jonathan Wakely jwak...@redhat.com writes: Jonathan This defines a new style of Python type printer that Jonathan recognizes templates and can be used to omit default template Jonathan arguments from the typename GDB prints, e.g. showing Jonathan std::vectorT, std::allocatorT as

Re: [patch] Add libstdc++ type printers for class templates

Jonathan == Jonathan Wakely jwak...@redhat.com writes: Jonathan I forgot to say that with these type recognizers we might want to Jonathan revisit the output of the existing printers for the containers, so Jonathan that instead of: Jonathan std::map with 3 elements = { ... } Jonathan GDB could

Re: [PATCH] Add guality [p]type test.

Is what gdb prints for ptype stable across different gdb versions (except for whitespace that you canonicalize)? If yes, this looks good to me. Mark Yes, I believe it is (I tested against gdb git master and gdb 7.6.50). Mark It tries to print the expression as a canonical C type, so it should

Re: [PATCH] add __attribute__ ((designated_init))

from sparse. This is also PR c/59855. Tom 2014-07-01 Tom Tromey tro...@redhat.com PR c/59855 * doc/invoke.texi (Warning Options): Document -Wdesignated-init. * doc/extend.texi (Type Attributes): Document designated_init attribute. 2014-07-01 Tom Tromey tro

Re: [patch libstdc++] Add xmethods for std::vector and std::unique_ptr

Siva == Siva Chandra sivachan...@google.com writes: Siva +# Load the xmethods. Siva +from libstdcxx.v6.xmethods import register_libstdcxx_xmethods Siva +register_libstdcxx_xmethods (gdb.current_objfile ()) I don't think any addition to the hook file should be needed. Siva +# The object

Re: [PATCH 5/5] add libcc1

Trevor hrm, I know basically nothing about the upcoming changes, but I would Trevor have expected linking c++03 code against c++11 code would be fine Trevor especially when the interface doesn't involve any stl. https://gcc.gnu.org/wiki/Cxx11AbiCompatibility This warns against mixing with

Re: [PATCH] DWARFv5 Emit DW_TAG_atomic_type.

Mark == Mark Wielaard m...@redhat.com writes: Mark The following is just a prototype to try out a new qualifier type tag Mark proposed for DWARFv5. There is not even a draft yet of DWARFv5, so this Mark is just based on a proposal that might or might not be adopted and/or Mark changed

Re: [RFC] Add a .gitattributes file for use with git-merge-changelog

Samuel == Samuel Bronson naes...@gmail.com writes: Samuel [Am I really supposed to CC this to gcc@ like binutils/MAINTAINERS Samuel says I should?] I think just for files that are intended to be put in both trees and shared. Samuel Individual users will still have to: Samuel 1. Install

Re: [PATCH 5/5] add libcc1

Trevor == Trevor Saunders tsaund...@mozilla.com writes: Trevor I'm curious, what is the reason you choose not to write this in C++11 or Trevor later? Its distributed with gcc, so the only case where you aren't Trevor building with the in tree compiler and libraries is when your cross Trevor

<    1   2   3   4   5   6   >