the missing call.
Ok?
Tom
2012-11-16 Tom Tromey tro...@redhat.com
* configure.ac: Invoke AM_MAINTAINER_MODE.
* aclocal.m4, configure, Makefile.in, asan/Makefile.in,
interception/Makefile.in, sanitizer_common/Makefile.in: Rebuild.
diff --git a/libsanitizer/configure.ac b
Diego == Diego Novillo dnovi...@google.com writes:
Diego 2012-11-15 Diego Novillo dnovi...@google.com
Diego Adjust for new vec API (http://gcc.gnu.org/wiki/cxx-conversion/cxx-vec)
Diego * boehm.c: Use new vec API in vec.h.
Diego * class.c: Likewise.
Diego * constants.c: Likewise.
Diego *
Tom == Tom Tromey tro...@redhat.com writes:
Jonathan Please go ahead and commit, thanks, Tom!
Tom Thanks. The needed gdb patches are still pending, so I plan to wait
Tom until those go in before committing to libstdc++. I hope it will be
Tom next week sometime.
Hahaha, next week
This patch adds a @direntry for gcov.
I noticed that it was missing today, when I tried to find the gcov
manual from the info dir node. Then I found out that I had filed PR
50899 for this ages ago.
Ok?
Tom
2012-10-30 Tom Tromey tro...@redhat.com
PR other/50899
* doc
Marcus == Marcus Shawcroft marcus.shawcr...@arm.com writes:
Marcus This patch adjusts the libcpp configury for AArch64.
Marcus Proposed ChangeLog:
Marcus * configure.ac: Enable AArch64.
Marcus * configure: Regenerate.
This is ok. Thanks.
Tom
Steven Probably you mean the revised patch here:
Steven http://gcc.gnu.org/ml/gcc-patches/2012-09/msg00459.html
Steven The patch look OK to me but I can't approve it.
I'm sorry about the delay on this.
The libcpp bits are ok.
I can't approve the other parts.
I think new configure options
Jan == Jan Hubicka hubi...@ucw.cz writes:
Jan this patch udpates Java frontend to declare __bulitin_unreachable
Jan and also fixes flags of synchronize bulitins to match ones from C
Jan FE.
Jan Regtested x86_64-linux, OK?
The java bits are ok.
Jan + /* Looping const or pure is imlpies by
Tobias == Tobias Burnus bur...@net-b.de writes:
Tobias Build on x86-64-linux with C/C++/Fortran. I will now do an
Tobias all-language build/regtest.
Tobias OK when it passes?
Tobias 2012-10-03 Tobias Burnus bur...@net-b.de
Tobias * files.c (read_file_guts, _cpp_save_file_entries):
Jonathan Please go ahead and commit, thanks, Tom!
Thanks. The needed gdb patches are still pending, so I plan to wait
until those go in before committing to libstdc++. I hope it will be
next week sometime.
Tom
Florian == Florian Weimer fwei...@redhat.com writes:
Florian This patch adds support for #pragma GCC warning and #pragma GCC
Florian error. These pragmas can be used from preprocessor macros,
Florian unlike the existing #warning and #error directives. Library
Florian authors can use these
char,..., but I thought a test
Magnus case here couldn't hurt?
Here's an updated patch with the new tests.
Tom
2012-09-25 Tom Tromey tro...@redhat.com
* testsuite/libstdc++-prettyprinters/whatis.cc: New file.
* testsuite/lib/gdb-test.exp (whatis-test): New proc.
(gdb
. This lets a library pretend that
some typedefs are canonical.
This includes a fairly comprehensive test case for the new type
printers.
Tom
b/libstdc++-v3/ChangeLog:
2012-09-21 Tom Tromey tro...@redhat.com
* testsuite/libstdc++-prettyprinters/whatis.cc: New file.
* testsuite/lib
Robert == Robert Dewar de...@adacore.com writes:
Robert Sometimes I wonder whether the insistence on -g not changing code
Robert generation is warranted. In practice, gdb for me is so weak in handling
Robert -O1 or -O2, that if I want to debug something I have to recompile
Robert with -O0 -g,
Dehao == Dehao Chen de...@google.com writes:
Dehao + static htab_t location_adhoc_data_htab;
Dehao + static source_location curr_adhoc_loc;
Dehao + static struct location_adhoc_data *location_adhoc_data;
Dehao + static unsigned int allocated_location_adhoc_data;
libcpp was written to allow
Dodji == Dodji Seketeli do...@seketeli.org writes:
Dodji With these changes, the libcpp parts look OK to me if they still
Dodji boostrap post c++ conversion. I am not a maintainer so I a deferring to
Dodji Tom and the other maintainers.
I agree. Dodji, thanks for looking at this.
Dmitris,
Dimitris == Dimitrios Apostolou ji...@gmx.net writes:
Dimitris [...] since I broke things like the static assert in
Dimitris libcpp/identifiers.c, that I don't even understand:
Dimitris /* We don't need a proxy since the hash table's identifier comes
first
Dimitris in cpp_hashnode.
Diego == Diego Novillo dnovi...@google.com writes:
Diego GDB folks, would it be hard to figure out that there is a single
Diego variant of the called function and trust the user that they are
Diego passing the right pointer value?
I asked Keith to resurrect his patch for this.
Tom
Gaby == Gabriel Dos Reis g...@integrable-solutions.net writes:
Tom I asked Keith to resurrect his patch for this.
Gaby Since people are concerned about typing rules, would it
Gaby be an option for GDB to allow people to input pointer
Gaby literals with the p suffix (or 0p prefix instead of 0x)?
Jonathan == Jonathan Wakely jwakely@gmail.com writes:
Jonathan I like it, please go ahead and check that in it you're happy
Jonathan with it.
I did. Thanks.
Tom
Jonathan == Jonathan Wakely jwakely@gmail.com writes:
$11 = std::unique_ptr containing (datum *) 0x6067d0
Jonathan It's inconsistent with the other printers in that it prints
Jonathan the stored type, unlike e.g. std::vectorint which just says
Jonathan std::vector of length ... but I think
Joseph == Joseph S Myers jos...@codesourcery.com writes:
Tom I wasn't really aware of 6.3.2.1, but after reading it and re-reading
Tom 6.5.1.1, I think I agree with his model 0 interpretation: no promotion
Tom or conversion.
Tom I don't have a standards-based reason for this, though; just my
Joseph == Joseph S Myers jos...@codesourcery.com writes:
Joseph On Mon, 30 Jul 2012, Tom Tromey wrote:
6.3 is about conversions, and the first paragraph starts several
operators convert Based on this, and other such phrases in the
text, I think the entire section applies to operators
that good at language lawyering.
Comments?
2012-07-27 Tom Tromey tro...@redhat.com
* c-common.h (enum rid) RID_GENERIC: New constant.
* c-common.c (c_common_reswords): Add _Generic.
2012-07-27 Tom Tromey tro...@redhat.com
* c-parser.c (struct c_generic_association): New
Joseph == Joseph S Myers jos...@codesourcery.com writes:
Joseph Could you explain the choices you have made for the issues
Joseph raised on comp.std.c last month (regarding the handling of
Joseph qualifiers on controlling expressions) and the rationale for
Joseph those choices (and make sure
Laurynas == Laurynas Biveinis laurynas.bivei...@gmail.com writes:
Laurynas 2012-06-24 Laurynas Bivienis laurynas.bivei...@gmail.com
Laurynas * include/line-map.h (line_map_macro): Use the atomic GTY
option
Laurynas for the macro_locations field.
Laurynas gcc/java:
Laurynas
Steven == Steven Bosscher stevenb@gmail.com writes:
Steven Makefile.in is a mess. One of these days, someone (hi, Tromey) will
Steven hopefully get annoyed enough with this again to finish some tool to
Steven auto-generate the dependences list. Until that time, let's try to
Steven avoid
Eli == Eli Zaretskii e...@gnu.org writes:
Eli I understand all that, but why would the eq_f function need to be an
Eli external function on its own?
It is just to avoid other users having to write their own.
Eli E.g., if we were to write a qsort replacement, would we have a
Eli suitable string
Eric == Eric Botcazou ebotca...@adacore.com writes:
Pedro It's not about example, but the fact that host compilers have been
Pedro compiling that code as part of building gcc for years, without anyone
Pedro complaining, afaik. It doesn't matter whether the code pointed at
Pedro is the ugliest
Eric == Eric Botcazou ebotca...@adacore.com writes:
It's true that this is a pedantic violation; but the point here is that
there is no practical barrier to using 'long long'. This code has been
in the tree since 2007; so if there is some issue with it, it ought to
have surfaced by now.
Eric == Eric Botcazou ebotca...@adacore.com writes:
Tom I don't understand what the code being external, or the review, has to
Tom do with anything. This code is compiled with the same host compiler as
Tom everything else.
Eric But, precisely, this line of reasoning is barely defensible in my
Lawrence == Lawrence Crowl cr...@google.com writes:
Lawrence Because libcpp was using a typedef hash_table, that typedef has been
Lawrence renamed cpp_hash_table and uses of it have changed.
The libcpp changes are ok.
Tom
Lawrence == Lawrence Crowl cr...@google.com writes:
Lawrence On 5/24/12, Gabriel Dos Reis g...@integrable-solutions.net wrote:
On May 24, 2012 Lawrence Crowl cr...@google.com wrote:
Add a type-safe hash table, typed_htab. Uses of this table
replace uses of libiberty's htab_t. The benefits
Lawrence == Lawrence Crowl cr...@google.com writes:
Lawrence Should I add that to my patch to gdbinit.in?
I think it would be helpful.
Tom
Mike == Mike Stump mikest...@comcast.net writes:
Mike Yeah, I kinda think the gdb people are wimping out by not just
Mike implementing __extension__ and ({}), which, I think get us most of the
Mike way there. Shh, don't tell them I said that.
We eagerly await your patch.
Tom
Diego == Diego Novillo dnovi...@google.com writes:
Diego +struct GTY(()) vec_prefix
Diego +{
Diego + unsigned num;
Diego + unsigned alloc;
Diego +};
Diego +
Diego +/* Vector type, user visible. */
Diego +templatetypename T
Diego +struct GTY(()) vec_t
Diego +{
Diego + vec_prefix prefix;
Diego
Alexander == Alexander Monakov amona...@ispras.ru writes:
Alexander Hm, isn't GDB's 'set unwindonsignal on' enough to fix it?
Alexander It's useful to have that in your .gdbinit anyway, because the
Alexander same issue arises when calling debug_* functions in cc1 from
Alexander the debugger.
Lawrence == Lawrence Crowl cr...@google.com writes:
Tom Doesn't this mean that if you have checking enabled, and you use the
Tom wrong macro on some tree, cc1 will crash? That seems like a distinct
Tom minus to me.
Lawrence Yes, it does mean that, but it is a net overall improvement.
It is a
Lawrence == Lawrence Crowl cr...@google.com writes:
Lawrence The effect is that it now possible to get useful responses to gdb
Lawrence command like
Lawrence (gdb) print DECL_FUNCTION_CODE (decl)
Doesn't this mean that if you have checking enabled, and you use the
wrong macro on some tree,
Manuel == Manuel López-Ibáñez lopeziba...@gmail.com writes:
Manuel Actually, I wonder how you (Richard) and other GCC hackers work with
Manuel and debug GCC, because it is a real pain in the ass.
Manuel * All the TREE_ macros don't work.
Manuel * __extension__ prevents GDB from evaluating many
Manuel == Manuel López-Ibáñez lopeziba...@gmail.com writes:
Manuel It seems it will never work for statement expressions:
Manuel http://article.gmane.org/gmane.comp.gcc.devel/107339
It could be done, but it is non-trivial for sure.
Manuel I see how these small functions can quickly become
Dodji == Dodji Seketeli do...@redhat.com writes:
Dodji To properly fix this, I think libcpp should keep the token of the
Dodji pasting operator '##', instead of representing it with flag on the LHS
Dodji operand's token. That way, it could use its location.
Originally I had thought that a
Tristan == Tristan Gingold ging...@adacore.com writes:
Tristan 2012-05-04 Tristan Gingold ging...@adacore.com
Tristan* expr.c (interpret_float_suffix): Add a guard.
Ok.
Tom
Jakub == Jakub Jelinek ja...@redhat.com writes:
Jakub On Thu, Apr 26, 2012 at 01:52:31PM -0400, DJ Delorie wrote:
I will not oppose adding more unrelated stuff to libiberty, but
neither will I approve it. I will let one of the other maintainers or
a global maintainer approve it.
Jakub The
HJ You should add extern C for C++ on those functions moved to
HJ libiberty.
Yeah, sorry about that.
I'm testing the fix.
Tom
Tom == Tom Tromey tro...@redhat.com writes:
HJ You should add extern C for C++ on those functions moved to
HJ libiberty.
Tom Yeah, sorry about that.
Tom I'm testing the fix.
Here is what I am checking in.
Tom
ChangeLog:
2012-04-27 Tom Tromey tro...@redhat.com
* dwarf2.h: Wrap
Ollie == Ollie Wild a...@google.com writes:
Ollie 2012-04-22 Ollie Wild a...@google.com
Ollie * gcc/c-family/c-common.c:
Ollie * gcc/c-family/c-opts.c (c_common_handle_option):
Ollie * gcc/c-family/c.opt:
Ollie * gcc/doc/invoke.texi (struct A):
Ollie *
Gaby == Gabriel Dos Reis g...@integrable-solutions.net writes:
Gaby On Wed, Apr 25, 2012 at 9:33 AM, Dodji Seketeli do...@redhat.com wrote:
Hopefully closing the series, this patch switches the compiler to
-ftrack-macro-expansion=2 by default.
Tested and bootstrapped on
Tom Here is a new patch for gcc.
Tom I still haven't updated the src side, but there's little to do there
Tom that isn't already done in this patch.
Tom Ok?
Tom Ping.
Tom Ping.
This is the third ping.
Please review the patch.
There are two choices:
1. Approve the original patch, adding a
Steven == Steven Bosscher stevenb@gmail.com writes:
Steven Subject says all. Will commit as obvious.
Steven * tree.def (CASE_LABEL_EXPR): Fix documentation, mention all
operands.
Thank you.
Tom
Tom Here is a new patch for gcc.
Tom I still haven't updated the src side, but there's little to do there
Tom that isn't already done in this patch.
Tom Ok?
Tom Ping.
Ping.
Tom
Gaby == Gabriel Dos Reis g...@integrable-solutions.net writes:
Manuel So, in fact, libcpp is buggy for not implementing this (as can be seen
Manuel in emacs). If/When libcpp is fixed, the column info will be correct
Manuel for tabs. And then, one may care about printing tabs as anything
Manuel
Doug == Doug Evans d...@google.com writes:
Doug On Thu, Mar 15, 2012 at 11:54 AM, Mike Stump mikest...@comcast.net
wroteDoug btw, is there any interest in mirroring gcc/contrib - src/contrib?
Doug [instead of gdb having its own copy in gdb/testsuite, it *could* use
Doug the one in, e.g.,
Tom == Tom Tromey tro...@redhat.com writes:
Tom Here is a new patch for gcc.
Tom I still haven't updated the src side, but there's little to do there
Tom that isn't already done in this patch.
Tom Ok?
Ping.
Tom
DJ == DJ Delorie d...@redhat.com writes:
DJ The only drawback to adding toplevel libraries is coordinating changes
DJ among the toplevel configury.
And adding crud to Makefiles all over.
Pick a name for the new library and I will implement this.
Tom
Rainer == Rainer Orth r...@cebitec.uni-bielefeld.de writes:
Rainer Continuing with the patches to remove obsolete ports, here's the
Rainer IRIX 6.5 removal patch.
Rainer * libjava/gnu/classpath/natSystemProperties.cc (getpwuid_adaptor) claims
Rainer to be for IRIX, too, but I cannot tell for
DJ == DJ Delorie d...@redhat.com writes:
DJ Sigh, libiberty is supposed to be a portability library, not a
DJ kitchen-sink for common stuff. Should I give up that premise? Or
DJ should we consider a common dwarf2 helper library, and move even more
DJ of the dwarf2 code into it?
My reasoning
DJ == DJ Delorie d...@redhat.com writes:
Tom Finally, there is already stuff in libiberty not related to
Tom portability. E.g., hashtab or the demangler.
DJ Yeah, I know, hence my Should I give up that premise?
Yeah.
I am not sure there will ever be enough shared code to warrant a new
Jakub == Jakub Jelinek ja...@redhat.com writes:
Jakub On Thu, Mar 15, 2012 at 12:41:54PM -0600, Tom Tromey wrote:
I guess I can just put the whole DW_TAG_ prefix in there.
That isn't a big deal. Or if you have some other suggestion, I can
implement it.
Jakub Yeah, I think the either
Rainer == Rainer Orth r...@cebitec.uni-bielefeld.de writes:
Rainer libjava:
Rainer * configure.ac (THREADLIBS): Remove *-*-solaris2.8 handling.
Rainer * configure: Regenerate.
This part is ok. Thanks.
Tom
Rainer == Rainer Orth r...@cebitec.uni-bielefeld.de writes:
Rainer libcpp:
Rainer * lex.c: Remove Solaris 8 reference.
Also ok.
Tom
Kai == Kai Tietz ktiet...@googlemail.com writes:
Kai * include/gc_config_macros.h (GC_DLL): Define it for
Kai mingw-targets only, if
Kai we are actual in boehm-gc's build and DLL_EXPORT macro is defined.
This is ok. Thanks.
Tom
Tom == Tom Tromey tro...@redhat.com writes:
Tom Unless you have other tests to suggest, I am going to say that it has
Tom been sufficiently tested and check it in on Friday.
Jakub said on irc that he thought I had done sufficient testing.
So, I am checking this patch in now.
thanks,
Tom
Jakub == Jakub Jelinek ja...@redhat.com writes:
Jakub Well, even bad debugging experience problems would be very undesirable
Jakub if we generated wrong debug info and everybody compiled it into their
Jakub sources. But pretty-printers stay on the side, it is just a matter of
Jakub updating the
and with the default on x86-64 Fedora 15.
I'm sufficiently out of the loop gcc-wise that I will need some advice
as to whether this can go in immediately or whether it must wait for
some other stage.
Ok?
Tom
2012-01-23 Tom Tromey tro...@redhat.com
PR libstdc++/51649:
* testsuite/libstdc
Ian == Ian Lance Taylor i...@google.com writes:
Ian And I just have to repeat that this patch is an ugly ugly hack, since
Ian -mieee should be the default. Perhaps we should investigate having
Ian gcc/go/gospec.c or gcc/go/lang-specs.h somehow add -mieee for those
Ian targets which require it.
Sterling == Sterling Augustine saugust...@google.com writes:
Sterling The enclosed patch to google/main contains certain small fixes
Sterling for pubnames and pubtypes, which are now emitted completely
Sterling and canonically.
I am curious to know how you ensure that they are canonical.
My
Gary == Gary Funck g...@intrepid.com writes:
Gary I have a specific question re: this new code.
Gary + name = _cpp_get_file_name (pfile-main_file);
Gary + if (!name)
Gary + name = unknown;
Gary I wasn't sure whether 'name' can have a NULL value, and handled
Gary
Jakub == Jakub Jelinek ja...@redhat.com writes:
Jakub another alternative would be to create DW_TAG_dwarf_procedure for
Jakub them or for portions thereof (for subexpressions it would be even
Jakub a potential nice debug info shrinking method, but would mean a
Jakub lot of work and gdb support
Jakub == Jakub Jelinek ja...@redhat.com writes:
Jakub Honza said that GDB doesn't support DW_TAG_dwarf_procedure though.
Jakub We'd need to represent it as nameless artificial DW_TAG_variable
Jakub or something similar.
I think gdb will issue a complaint if it sees one. I'm not sure, I
don't
Ramana == Ramana Radhakrishnan ramana.radhakrish...@linaro.org writes:
Ramana Otherwise looks ok to me .
Sergio was asked me to ping this for him, but instead I re-read the
entire thread and I think that this was an approval conditional on him
making the request changes (just to ChangeLog),
Jakub == Jakub Jelinek ja...@redhat.com writes:
Jakub 2011-11-23 Jakub Jelinek ja...@redhat.com
Jakub PR bootstrap/50888
Jakub * prims.cc: Don't include ctype.h.
Jakub (c_isspace): Define.
Jakub (next_property_key, next_property_value): Use it instead
Jakub of isspace.
This is ok.
Tom
Jakub == Jakub Jelinek ja...@redhat.com writes:
Jakub As discussed in the PR, libjava fails to build against latest
Jakub glibc, because prims.cc is compiled with -fnon-call-exceptions,
Jakub uses ctype.h and libgcj isn't linked against -lsupc++ or -lstdc++.
Jakub isspace in latest glibc is a
Roberto == Roberto Agostino Vitillo raviti...@lbl.gov writes:
Roberto I ended up not using it and it's clear to me that its practical
Roberto uses may be questionable (fast single stepping in a
Roberto debugger?) but I thought it might be worth to share it.
Thanks.
I think that if there is no
Roberto == Roberto Agostino Vitillo raviti...@lbl.gov writes:
Roberto With this patch DW_LNS_set_basic_block opcodes are emitted in
Roberto the .debug_line section marking the instructions that indicate
Roberto the beginning of a basic block as specified by the dwarf
Roberto standards 2,3 and 4.
Jeff == Jeff Law l...@redhat.com writes:
Jeff First, it's perfectly fine to have a NULL pointer dereference in a
Jeff program as long as that code is never executed. Once the code is
Jeff executed, we've entered the realm of undefined behavior.
Jeff Thus in a conforming program we can safely
Jeff == Jeff Law l...@redhat.com writes:
Jeff So, presumably there's no way to know we're throwing to
Jeff NullPointerException from the exception information attached to the
Jeff statement or BB? If not I could disable if the statement with the
Jeff memory op throws anywhere. It's not ideal,
Paolo == Paolo Carlini paolo.carl...@oracle.com writes:
Paolo By the way, I have no idea why I didn't see it, only Fortran includes
Paolo that header in the *libcpp* directory? Anyway, I'm proceeding to
Paolo bootstrap the attached.
It really isn't ok to do this. That header is supposedly
Ed == Ed Smith-Rowland 3dw...@verizon.net writes:
Ed + /* Nonzero for the 2011 C++ Standard. */
Ed + unsigned char cxx11;
I think it would be better if the new field name reflected its purpose,
so something like user_literals.
Ed + if (ISIDST(*cur))
Ed + {
Ed + type =
Tristan == Tristan Gingold ging...@adacore.com writes:
Tom Another way to look at it is that there have been many changes to GCC's
Tom DWARF output in the last few years. Surely these have broken these
Tom DWARF consumers more than this change possibly could.
Tristan Yes, but there is
I'm checking this in as obvious.
Sergio pointed out, via this patch, that gcc/configure didn't properly
emit whether sys/std.h was discovered.
Tested by re-running configure and examining the output.
Tom
2011-10-17 Sergio Durigan Junior sergi...@redhat.com
* configure.ac: Display
Tristan == Tristan Gingold ging...@adacore.com writes:
Tristan I am not against this patch, my only concern is that there are many
Tristan many dwarf consumers and I have no idea how they will react to this
Tristan change.
I tend to think that this is the wrong standard to apply. In this case
Sandeep == Sandeep Soni soni.sande...@gmail.com writes:
Sandeep The following patch is a basic attempt to build a symbol table that
Sandeep stores the names of all the declarations made in the input file.
I don't know anything about gimplefe, but unless you have complicated
needs, it is more
Jeff == Jeff Law l...@redhat.com writes:
Jeff Presumably it hasn't been included because not all gdb's understand
Jeff those bits and we typically don't build with -g3.
GCC is pretty much the perfect candidate for a -g3 build. All those
macros...
The needed gdb changes have been in since
Diego == Diego Novillo dnovi...@google.com writes:
Diego Tom, Cary, Ian, any suggestions? We are trying to figure out a
Diego compromise for tiny inline functions that are generally a nuisance
Diego when debugging. The scenario is a call like this: big_function_foo
Diego (inlined_f (x),
Diego == Diego Novillo dnovi...@google.com writes:
Tom http://sourceware.org/bugzilla/show_bug.cgi?id=8287
Diego I think this could work. I'm not sure I like the idea of having to
Diego specify all these blacklist commands, but I appreciate how it can make
Diego debugging more flexible.
Jakub == Jakub Jelinek ja...@redhat.com writes:
Jakub I don't mind if it goes into gdb, but IMHO the blacklisting should
Jakub definitely default to blacklisting DW_AT_artificial inline functions
Jakub (and allowing to unblacklist them), because the artificial attribute
Jakub has been designed
Tom Any comments on this?
Tom I'd like to get it in; Phil found a bug in the std::tuple printer, and
Tom it would be nice to put in a test case along with the fix.
Benjamin Hey Tom (and Phil!).
Benjamin Sorry for the delay: this looks fine. Please put it in on trunk and
Benjamin enjoy your
Tom That exists -- -fdirectives-only.
Jakub It isn't exactly what would be needed, as e.g. \\\n are removed from
Jakub from #defines and thus they get different location of the tokens.
Dodji Would it be acceptable to just change the output of -fdirective to fit?
Dodji Or are we bound to not
Dodji == Dodji Seketeli do...@redhat.com writes:
Dodji * line-map.c (linemap_add): Assert that reason must not be
Dodji LC_RENAME when called for the first time on a main input file.
This is ok. I can't approve the rest but it seems reasonable.
Tom
Jakub == Jakub Jelinek ja...@redhat.com writes:
Jakub For ccache and friends I think it would be better to have a
Jakub preprocessing mode that would output all lines as is (i.e. no
Jakub macro replacement), except for processing #include/#include_next
Jakub directives.
That exists --
Jason == Jason Merrill ja...@redhat.com writes:
+ LC_ENTER_MACRO
+ /* stringize */
+ /* paste */
Jason What is the purpose of these comments?
That is left over from my initial hack. The new scheme doesn't (yet?)
properly handle locations arising from stringizing or token pasting.
Tom
Gabriel == Gabriel Charette gch...@google.com writes:
Gabriel It nows exposes two libcpp functions to force the
Gabriel source_location for tokens when desired.
I am not really a fan of this approach, but I see why you did it this
way -- anything else would be very invasive.
I can only approve
Dimitrios == Dimitrios Apostolou ji...@gmx.net writes:
Richard Note that sparsely populated hashes come at the cost of increased
Richard cache footprint. Not sure what is more important here though, memory
Richard access or hash computation.
Tom I was only approving the change to the dumping.
Rainer == Rainer Orth r...@cebitec.uni-bielefeld.de writes:
Jason I'm of two minds about this, but I see that clang and edg still
Jason use 199711L in C++0x mode, so let's stick with that for now.
Rainer with the prerequisite patches now installed, here's the reworked version
Rainer of the
Tom == Tom Tromey tro...@redhat.com writes:
Tom I'm finally getting back to this.
Tom This patch adds test suite support for the libstdc++ pretty-printers.
Any comments on this?
I'd like to get it in; Phil found a bug in the std::tuple printer, and
it would be nice to put in a test case along
Jie == Jie Liu lj8...@gmail.com writes:
Jie In my debug, there appears no check for 'this' at start of String.length():
Yeah, I looked for uses of flag_check_references and didn't see one when
building a method's body. So I guess I mis-remembered this.
In any case, the spot you found is just
Gabriel == Gabriel Charette gch...@google.com writes:
Gabriel Removed LINEMAP_POSITION_FOR_COLUMN, it did the EXACT same
Gabriel thing as linemap_position_for_column, so maintaining both in
Gabriel parallel seems like overkill to me. The only thing I can think
Gabriel of is that it's more
Jie == Jie Liu lj8...@gmail.com writes:
Jie + *-*-rtems*)
Jie + can_unwind_signal=no
Jie + CHECKREFSPEC=-fcheck-references
Jie + DIVIDESPEC=-fuse-divide-subroutine
Jie + ;;
This part is OK with a ChangeLog entry.
Jie +
Spurious newline addition.
Jie But it does not work as we want, is
Richard == Richard Guenther richard.guent...@gmail.com writes:
The libcpp part is ok with this change.
Richard Note that sparsely populated hashes come at the cost of increased
Richard cache footprint. Not sure what is more important here though, memory
Richard access or hash computation.
I
Rainer == Rainer Orth r...@cebitec.uni-bielefeld.de writes:
Rainer 2011-08-07 Rainer Orth r...@cebitec.uni-bielefeld.de
Rainer gcc/java:
Rainer * jcf-dump.c (print_constant): Cast first frexp arg.
Rainer libjava:
Rainer * exception.cc (std::abort): Remove
401 - 500 of 541 matches
Mail list logo
