Jie == Jie Liu lj8...@gmail.com writes:
Jie RTEMS does not have virtual memory management, so there is no error
Jie when access the 0 address on rtems.
Jie So 'str-length()' donot throw NPE and just return an meaningless value.
If you compile the Java parts of the library with
Jie == Jie Liu lj8...@gmail.com writes:
Jie + if(str == NULL)
Jie + throw new NullPointerException();
Jie +
Jieint length = str-length();
Why doesn't 'str-length()' throw the NPE?
Tom
Gabriel == Gabriel Charette gch...@google.com writes:
Gabriel This hack, has described in more details in the email labeled
Gabriel Line 0 Hack??, was now causing problem when serializing the
Gabriel line_table in pph.
I think you do have to handle location 0 somehow.
This is UNKNOWN_LOCATION,
.
I tested this against gdb 7.2 (= unsupported) and 7.3 (= all tests
pass).
Let me know what you think.
Tom
2011-08-03 Tom Tromey tro...@redhat.com
* testsuite/libstdc++-prettyprinters/simple.cc: New file.
* testsuite/lib/gdb-test.exp: New file.
* testsuite/libstdc
Gabriel == Gabriel Charette gch...@google.com writes:
Gabriel 2011-07-28 Gabriel Charette gch...@google.com
Gabriel* libcpp/include/line-map.h (struct line_maps):
Gabriel Remove unused field last_listed.
Ok.
Tom
Jakub == Jakub Jelinek ja...@redhat.com writes:
Jakub Ok, based on further discussions here, on Dwarf-discuss and on IRC
Jakub here is a hopefully final version.
I've updated the gdb patch.
Tom
Jakub == Jakub Jelinek ja...@redhat.com writes:
Jakub Ok, so how about this way (as DWARF4 modifications, of course for
Jakub DWARF5 proposal GNU_ would be gone and the ops would have different
Jakub codes):
Thanks very much for writing it up this way. I think it is very
important that all our
Jakub == Jakub Jelinek ja...@redhat.com writes:
Tom I don't think I really understood DW_MACINFO_GNU_define_opcode, so the
Tom implementation here is probably wrong.
Jakub Well, I think you've skipped it correctly and furthermore even patched
Jakub GCC doesn't emit it. The point of it was to
Jakub == Jakub Jelinek ja...@redhat.com writes:
Jakub The patch below implements that slight change, in particular the
Jakub 4 suffixes from the op names were dropped,
Jakub DW_MACINFO_GNU_*_indirect have DW_FORM_udata and DW_FORM_strp
Jakub arguments now (i.e. DWARF_OFFSET_SIZE large) and
Jakub
Dodji == Dodji Seketeli do...@redhat.com writes:
Dodji libcpp/
Dodji * directives.c (struct if_stack): Use source_location as type
Dodji here.
Dodji * include/cpplib.h (struct cpp_callbacks)include, define, undef,
Dodji indent, def_pragma, used_define, used_undef: Properly use
Dodji
Jakub == Jakub Jelinek ja...@redhat.com writes:
The .debug_macinfo section doesn't have any header describing its
contents. How would a consumer know which offset size to use?
Jakub The same way as it knows how to interpret the second operands of
Jakub DW_MACINFO_start_file.
Ok, duh.
I
bigger than it is
because I moved a bunch of code into a new function.
I don't think I really understood DW_MACINFO_GNU_define_opcode, so the
implementation here is probably wrong.
Tom
2011-07-13 Tom Tromey tro...@redhat.com
* dwarf2read.c (read_indirect_string_at_offset): New function
Richard == Richard Guenther rguent...@suse.de writes:
Richardjava/
Richard* builtins.c (static): Use fold_build_pointer_plus.
Richard* class.c (make_class_data): Likewise.
Richard(build_symbol_entry): Likewise.
Richard* except.c
Joern == Joern Rennecke amyl...@spamcop.net writes:
Joern This is basically the same patch as posted before in
Joern http://gcc.gnu.org/ml/gcc-patches/2010-11/msg02772.html and updated in
Joern http://gcc.gnu.org/viewcvs?view=revisionrevision=168273, but with a
Joern few merge conflicts in
Dodji == Dodji Seketeli do...@seketeli.org writes:
Dodji I am pinging this patch first posted to
Dodji http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00697.html.
Thanks, and sorry for not noticing earlier.
Dodji +context of 'P'. The problem is, if we are beeing
Typo, being.
Ok
Pierre == Pierre p.vit...@laposte.net writes:
Pierre I have changed this handler in order to accept a second parameter
Pierre which is a void *, allowing to give extra datas to the handler. I
Pierre think this data field might be of general use: we can have condition
Pierre or data at register
John == John Tytgat john.tyt...@aaug.net writes:
John 2011-05-29 John Tytgat john.tyt...@aaug.net
John * files.c (read_file_guts): Add test on non-zero value of S_ISREG.
It seems reasonable enough to me. I am checking it in.
Out of curiosity, do you know of a platform where this is an
Jan == Jan Hubicka hubi...@ucw.cz writes:
Some typos...
Jan + /* Pack VAL into BP, be more effetive when VAL is small.
Jan +Implementation is sily, we may want to do better later. */
effective and silly.
Jan + /* Pack VAL into BP, be more effetive when VAL is small.
Jan +
Nathan == Nathan Froyd froy...@codesourcery.com writes:
Nathan (C, Java, middle-end)
Nathan [PATCH 18/18] make TS_BLOCK a substructure of TS_BASE
Nathan http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00564.html
The Java parts are ok.
I think these sorts of changes should be obvious once
Joseph == Joseph S Myers jos...@codesourcery.com writes:
Joseph dependencies. For the latter, I looked again at Tom's reverted patch
Joseph from March 2008 to use automatic dependency generation. Although
Joseph there is now a fixed GNU make release (since last July), and although
Joseph I'd
Joseph == Joseph S Myers jos...@codesourcery.com writes:
Joseph 2011-05-20 Joseph Myers jos...@codesourcery.com
Joseph * Make-lang.in ($(XGCJ)$(exeext)): Don't explicitly use intl.o
and
Joseph version.o.
Joseph (JCFDUMP_OBJS): Remove errors.o, version.o and intl.o.
H.J. == H J Lu hjl.to...@gmail.com writes:
H.J. On Thu, May 12, 2011 at 7:56 AM, Jakub Jelinek ja...@redhat.com wrote:
On Wed, May 11, 2011 at 12:28:18PM -0700, H.J. Lu wrote:
This patch restores the old behavior for Pmode. OK for trunk if there
are no regressions?
That is IMHO wrong,
Just for the record...
Tom What my patch does now is that it generally uses a signed integer type
Tom of the appropriate width for legacy DWARF values. Then, for mod, if
Tom the value's type is this special type, it converts it to an
Tom identically-sized unsigned type, and converts back after
Tom I have since changed this. For explicitly-typed values, I tried
Tom DW_OP_shr and DW_OP_shra identically. The type encodes the desired
Tom operation.
Jakub pinged me on irc to say that this is not what GCC actually emits.
So, I am going to change GDB to follow. That is, GDB will pick a
Nathan == Nathan Froyd froy...@codesourcery.com writes:
Nathan gcc/java/
Nathan * java-tree.h (TYPE_ARGUMENT_SIGNATURE): Use TYPE_MINVAL.
This is ok.
Tom
Joseph I don't know if Fortran, Java or Go use variable-size types at
Joseph all.
Java doesn't have variable-size types.
AFAIK, gcj does not generate them internally for anything, either.
Tom
Jakub == Jakub Jelinek ja...@redhat.com writes:
Tom Should DW_OP_bra be restricted to integral types? Several other opcodes
Jakub Yes. If you want to test other types, just compare them against 0
Jakub using DW_OP_ne etc.
Great, thanks.
Tom Currently, the comparison operators are all
Joseph == Joseph S Myers jos...@codesourcery.com writes:
Joseph This patch, relative to a tree with
Joseph http://gcc.gnu.org/ml/gcc-patches/2011-04/msg02123.html applied,
Joseph continues the cleanup of toplevel cases relating to disabling Java or
Joseph Java libraries by arranging for Java to
Rainer == Rainer Orth r...@cebitec.uni-bielefeld.de writes:
Rainer 2011-04-14 Rainer Orth r...@cebitec.uni-bielefeld.de
Rainer * testsuite/libjava.jni/jni.exp
(gcj_jni_get_cxxflags_invocation):
Rainer Add $libiconv to cxxflags for alpha*-dec-osf*.
This is ok, thanks.
Tom
Diego == Diego Novillo dnovi...@google.com writes:
Unfortunately, five bits are not sufficient for the alternate use of
cpp_hashnode.directive_index as a named operator index. So, I have reverted
the number of bits from five back to seven. As a result, we now have 34 bits
in small fields,
Jim == Jim Meyering j...@meyering.net writes:
Jim Since v3, I've rebased these and moved the fortran changes to precede
Jim these (changing gfc_free to free introduced a few more instances
Jim that this transformation deals with). As mentioned before, the
Jim conditional-removing transformation
Janne == Janne Blomqvist blomqvist.ja...@gmail.com writes:
Jim Can someone add me to the gcc group? That would help.
Jim I already have ssh access to sourceware.org.
Janne I'm not sure if I'm considered to be well-established
Janne enough, so could someone help Jim out here, please?
I added
Dodji == Dodji Seketeli do...@redhat.com writes:
Tom One thing to note is that there may be some code that assumes an
Tom ordering of location values. If you hand out ordinary and macro
Tom locations separately (which I think is what is going on), then code
Tom doing this may break.
[...]
Diego == Diego Novillo dnovi...@google.com writes:
Lawrence This change is not source compatible with existing code using
Lawrence the callbacks (which may not be in the gcc svn). Perhaps a new
Lawrence callback is needed?
Diego Well, it only changes the return value for the callback.
Lawrence == Lawrence Crowl cr...@google.com writes:
Diego Hm, and 5 bits are still enough for directive_index?
Lawrence Yes there are enough. I added a comment at the table definition
Lawrence to ensure that future changes keep it so.
I suggest a static assertion of some kind. Or in lieu of
Kai == Kai Tietz ktiet...@googlemail.com writes:
Kai this patch fixes some issues in libjava for windows targets. It
Kai addresses for now only 32-bit target, but for JNICALL definition I
Kai introduced already logic for 64-bit windows target too as preparation.
Most of this seems ok to me.
on x86-64 (compile farm).
New test case included.
I did not check to see whether this is a regression.
Tom
2011-03-16 Tom Tromey tro...@redhat.com
PR c/48116
* c-typeck.c (c_finish_return): Check warn_return_type.
2011-03-16 Tom Tromey tro...@redhat.com
* gcc.dg
2011-02-02 Tom Tromey tro...@redhat.com
* c-parser.c (c_parser_asm_string_literal): Clear
warn_overlength_strings.
2011-02-02 Tom Tromey tro...@redhat.com
* gcc.dg/Woverlength-strings-pedantic-c90-asm.c: New file.
* gcc.dg/Woverlength-strings-pedantic-c89-asm.c: New file.
* gcc.dg
Roland That test would work. (That macro is not defined at all in
Roland earlier versions.)
Tom Here is an updated version.
Tom 2011-01-14 Tom Tromey tro...@redhat.com
Tom* unwind-dw2.c: Include sys/sdt.h if it exists.
Tom(_Unwind_DebugHook): Use STAP_PROBE2.
Tom* config.in
Nathan == Nathan Froyd froy...@codesourcery.com writes:
Nathan gcc/java/
Nathan * expr.c (expand_java_switch): Call build_case_label.
Nathan (expand_java_add_case): Likewise.
The java parts are ok.
FWIW, I tend to think that if a core change like this one is accepted,
then
Michael How come 'xfree' in gdb/utils.c still checks for null?
I don't know, but I assume just because nobody has bothered to remove
the check. I think we also still have code doing `if (x) xfree (x);',
which is kind of doubly wrong :)
Tom
501 - 541 of 541 matches
Mail list logo
