Re: [google gcc-4_7] offline profile merge tool (issue 8508048)

https://codereview.appspot.com/8508048/diff/4001/contrib/profile_merge.py File contrib/profile_merge.py (right): https://codereview.appspot.com/8508048/diff/4001/contrib/profile_merge.py#newcode53 contrib/profile_merge.py:53: data_file = open(path, 'rb') On 2013/04/09 17:32:11, martint wrote:

Re: [google gcc-4_7] new module grouping method (issue 7393058)

https://codereview.appspot.com/7393058/diff/1/libgcc/dyn-ipa.c File libgcc/dyn-ipa.c (right): https://codereview.appspot.com/7393058/diff/1/libgcc/dyn-ipa.c#newcode77 libgcc/dyn-ipa.c:77: /* Used by new algo. This dyn_pointer_set only On 2013/02/26 00:49:17, davidxl wrote: algo -- algorithm.

Re: [google gcc-4_7] new module grouping method (issue 7393058)

https://codereview.appspot.com/7393058/diff/8001/libgcc/dyn-ipa.c File libgcc/dyn-ipa.c (right): https://codereview.appspot.com/7393058/diff/8001/libgcc/dyn-ipa.c#newcode1212 libgcc/dyn-ipa.c:1212: mod_id = get_module_id_from_func_glob_uid (node-guid) - 1; Send the wrong patch. Actually. This

Re: Backported r185231 from trunk. (issue 6878045)

Look good to me. Please check with David if google-main branch is currently opened for check-in. -Rong https://codereview.appspot.com/6878045/

Re: [google-4_6] indirect_call promotion for streaming LIPO (issue 6306054)

will send the new patch set in a few minutes. http://codereview.appspot.com/6306054/diff/1/cgraph.h File cgraph.h (right): http://codereview.appspot.com/6306054/diff/1/cgraph.h#newcode410 cgraph.h:410: They are referenced in lto-cgraph.c etc. On 2012/06/07 21:46:53, davidxl wrote: Why not

Re: [4.7][google] Adding a new option -fstack-protector-strong. (issue 5461043)

OK for google branches. http://codereview.appspot.com/5461043/diff/16001/gcc/cfgexpand.c File gcc/cfgexpand.c (right): http://codereview.appspot.com/5461043/diff/16001/gcc/cfgexpand.c#newcode1597 gcc/cfgexpand.c:1597: contain an array or are arrays. */ , before or, and two spaces before */.