Re: [C++ Patch] PR 50660

2011-10-10 Thread Jason Merrill
On 10/10/2011 12:44 AM, Paolo Carlini wrote: If I just do this (I hope it's what you had in mind): - tree t = non_reference (totype); + tree t = totype; /*non_reference (totype); */ variadic111.C:16:22: warning: converting ‘false’ to pointer type for argument 3 of ‘void SArgs1::f(Args1 ...,

Re: [C++ Patch] PR 50660

2011-10-10 Thread Paolo Carlini
On 10/11/2011 01:46 AM, Jason Merrill wrote: On 10/10/2011 12:44 AM, Paolo Carlini wrote: If I just do this (I hope it's what you had in mind): - tree t = non_reference (totype); + tree t = totype; /*non_reference (totype); */ variadic111.C:16:22: warning: converting ‘false’ to pointer type

Re: [C++ Patch] PR 50660

2011-10-10 Thread Jason Merrill
On 10/11/2011 01:10 AM, Paolo Carlini wrote: Great, this works (and I even learned something ;) Shall I commit it when testing finishes? Please. Jason

[C++ Patch] PR 50660

2011-10-09 Thread Paolo Carlini
Hi, another duplicated diagnostic message. This one happens for snippets like the below due to the temporary for the const ref: int g(const int); int m2() { return g(__null); } 50660.C:4:18: warning: passing NULL to non-pointer argument 1 of ‘int g(const int)’ 50660.C:4:18: warning: passing

Re: [C++ Patch] PR 50660

2011-10-09 Thread Jason Merrill
Hmm, I guess it's unlikely that a conversion is going to hit both that warning and another one. OK. Jason

Re: [C++ Patch] PR 50660

2011-10-09 Thread Jason Merrill
On 10/09/2011 11:40 PM, Jason Merrill wrote: Hmm, I guess it's unlikely that a conversion is going to hit both that warning and another one. OK. Wait...how about changing conversion_null_warnings to stop looking through references? Does that break anything? Jason

Re: [C++ Patch] PR 50660

2011-10-09 Thread Paolo Carlini
On 10/10/2011 12:41 AM, Jason Merrill wrote: On 10/09/2011 11:40 PM, Jason Merrill wrote: Hmm, I guess it's unlikely that a conversion is going to hit both that warning and another one. OK. Wait...how about changing conversion_null_warnings to stop looking through references? Does that break

Re: [C++ Patch] PR 50660

2011-10-09 Thread Paolo Carlini
On 10/10/2011 12:41 AM, Jason Merrill wrote: On 10/09/2011 11:40 PM, Jason Merrill wrote: Hmm, I guess it's unlikely that a conversion is going to hit both that warning and another one. OK. Wait...how about changing conversion_null_warnings to stop looking through references? Does that