Re: [PATCH] Refactor coverage.c, outline the construction of gcov constructor

2013-05-03 Thread Richard Biener
On Thu, May 2, 2013 at 10:41 PM, Carrot Wei car...@google.com wrote: This patch outline the construction of gcov constructor from coverage_obj_init as a separate function build_init_ctor. It passed bootstrap and regression test on x86-64. OK for trunk and google 4.7 branch? Please pass

Re: [PATCH] Refactor coverage.c, outline the construction of gcov constructor

2013-05-03 Thread Carrot Wei
On Fri, May 3, 2013 at 1:03 AM, Richard Biener richard.guent...@gmail.com wrote: On Thu, May 2, 2013 at 10:41 PM, Carrot Wei car...@google.com wrote: This patch outline the construction of gcov constructor from coverage_obj_init as a separate function build_init_ctor. It passed bootstrap

Re: [PATCH] Refactor coverage.c, outline the construction of gcov constructor

2013-05-03 Thread Xinliang David Li
Please do what Richard suggested. gcov_info_type can be obtained from gcov_info_var decl. David On Fri, May 3, 2013 at 11:31 AM, Carrot Wei car...@google.com wrote: On Fri, May 3, 2013 at 1:03 AM, Richard Biener richard.guent...@gmail.com wrote: On Thu, May 2, 2013 at 10:41 PM, Carrot Wei

Re: [PATCH] Refactor coverage.c, outline the construction of gcov constructor

2013-05-03 Thread Carrot Wei
commited as 198591. On Fri, May 3, 2013 at 11:51 AM, Xinliang David Li davi...@google.com wrote: Please do what Richard suggested. gcov_info_type can be obtained from gcov_info_var decl. David On Fri, May 3, 2013 at 11:31 AM, Carrot Wei car...@google.com wrote: On Fri, May 3, 2013 at 1:03

[PATCH] Refactor coverage.c, outline the construction of gcov constructor

2013-05-02 Thread Carrot Wei
This patch outline the construction of gcov constructor from coverage_obj_init as a separate function build_init_ctor. It passed bootstrap and regression test on x86-64. OK for trunk and google 4.7 branch? thanks Carrot 2013-05-02 Guozhi Wei car...@google.com * coverage.c