Re: [PATCH] Remove unreachable gcc_unreachable () at the end of functions

2021-11-29 Thread Richard Biener via Gcc-patches
On Sun, 28 Nov 2021, Jeff Law wrote: > > > On 11/25/2021 6:33 AM, Richard Biener via Gcc-patches wrote: > > It seems to be a style to place gcc_unreachable () after a > > switch that handles all cases with every case returning. > > Those are unreachable (well, yes!), so they will be elided > >

Re: [PATCH] Remove unreachable gcc_unreachable () at the end of functions

2021-11-28 Thread Jeff Law via Gcc-patches
On 11/25/2021 6:33 AM, Richard Biener via Gcc-patches wrote: It seems to be a style to place gcc_unreachable () after a switch that handles all cases with every case returning. Those are unreachable (well, yes!), so they will be elided at CFG construction time and the middle-end will place

Re: [PATCH] Remove unreachable gcc_unreachable () at the end of functions

2021-11-25 Thread Richard Biener via Gcc-patches
On Thu, 25 Nov 2021, Michael Matz wrote: > Hello, > > On Thu, 25 Nov 2021, Richard Biener via Gcc-patches wrote: > > > It seems to be a style to place gcc_unreachable () after a > > switch that handles all cases with every case returning. > > Those are unreachable (well, yes!), so they will be

Re: [PATCH] Remove unreachable gcc_unreachable () at the end of functions

2021-11-25 Thread Michael Matz via Gcc-patches
Hello, On Thu, 25 Nov 2021, Richard Biener via Gcc-patches wrote: > It seems to be a style to place gcc_unreachable () after a > switch that handles all cases with every case returning. > Those are unreachable (well, yes!), so they will be elided > at CFG construction time and the middle-end

[PATCH] Remove unreachable gcc_unreachable () at the end of functions

2021-11-25 Thread Richard Biener via Gcc-patches
It seems to be a style to place gcc_unreachable () after a switch that handles all cases with every case returning. Those are unreachable (well, yes!), so they will be elided at CFG construction time and the middle-end will place another __builtin_unreachable "after" them to note the path doesn't