[PATCH v1 05/13] Reuse MinGW from i386 for AArch64

2024-02-26 Thread Evgeny Karpov
Thank you for the fix, Bernhard! Please send it as a separate patch. Regards, Evgeny -Original Message- Sent: Monday, February 26, 2024 9:18 AM Bernhard Reutner-Fischer PS: Please don't forget to add an entry to contrib/config-list.mk thanks

Re: [PATCH v1 05/13] Reuse MinGW from i386 for AArch64

2024-02-26 Thread Bernhard Reutner-Fischer
On Sun, 25 Feb 2024 at 22:12, Mark Harmstone wrote: > Also, there are relocation types needed for Windows programs that are > supported in COFF but not in ELF object files. > Right, it's been a long time since i last dealt with PECOFF and i had assumed that things might have changed in the

Re: [PATCH v1 05/13] Reuse MinGW from i386 for AArch64

2024-02-25 Thread Mark Harmstone
On 22/2/24 11:11, Richard Earnshaw (lists) wrote: Most of the free world has left COFF behind since several decades, so I won't comment on that. YMMV. This isn't helpful. Windows platforms use (a derivative of) COFF, so that's what the tools need to use when targetting that platform. Also,

Re: [PATCH v1 05/13] Reuse MinGW from i386 for AArch64

2024-02-23 Thread Bernhard Reutner-Fischer
On Thu, 22 Feb 2024 15:56:46 + Evgeny Karpov wrote: > A ChangeLog template using "Moved... ...here" has been generated by > contrib/mklog.py. > It seems that it needs modification. > > Regards, > Evgeny > > -Original Message- > Thursday, February 22, 2024 12:11 PM > Richard

Re: [PATCH v1 05/13] Reuse MinGW from i386 for AArch64

2024-02-22 Thread Joseph Myers
On Thu, 22 Feb 2024, Richard Earnshaw (lists) wrote: > On 21/02/2024 21:34, rep.dot@gmail.com wrote: > > On 21 February 2024 19:34:43 CET, Evgeny Karpov > > wrote: > >> > > > > Please use git send-email. Your mail ends up as empty as here, otherwise. > > I don't see anything wrong with

[PATCH v1 05/13] Reuse MinGW from i386 for AArch64

2024-02-22 Thread Evgeny Karpov
A ChangeLog template using "Moved... ...here" has been generated by contrib/mklog.py. It seems that it needs modification. Regards, Evgeny -Original Message- Thursday, February 22, 2024 12:11 PM Richard Earnshaw (lists) wrote: > The ChangeLog has to be expressed in present tense, as

[PATCH v1 05/13] Reuse MinGW from i386 for AArch64

2024-02-22 Thread Evgeny Karpov
Hello Andrew, Thank you for the review! Renaming functions and comments that reference functions with the i386_ prefix can trigger extensive changes. This task should ideally be handled in a separate follow-up patch. The primary goal of the renaming changes in

Re: [PATCH v1 05/13] Reuse MinGW from i386 for AArch64

2024-02-22 Thread Richard Earnshaw (lists)
On 21/02/2024 21:34, rep.dot@gmail.com wrote: > On 21 February 2024 19:34:43 CET, Evgeny Karpov > wrote: >> > > Please use git send-email. Your mail ends up as empty as here, otherwise. I don't see anything wrong with it; niether does patchwork

Re: [PATCH v1 05/13] Reuse MinGW from i386 for AArch64

2024-02-21 Thread rep . dot . nop
On 21 February 2024 19:34:43 CET, Evgeny Karpov wrote: > Please use git send-email. Your mail ends up as empty as here, otherwise. The ChangeLog has to be expressed in present tense, as mandated by the standard; s/Moved/Move/g etc. In any sane world ( and in gcc ) to fold, respectively a

Re: [PATCH v1 05/13] Reuse MinGW from i386 for AArch64

2024-02-21 Thread Andrew Pinski
On Wed, Feb 21, 2024 at 10:38 AM Evgeny Karpov wrote: > > In config/i386/winnt.cc there are many x86_64 comments and many function names that use i386 in them? When moving it seems like better to rename them and remove references to 86. I don't see any changes that rename the functions or

[PATCH v1 05/13] Reuse MinGW from i386 for AArch64

2024-02-21 Thread Evgeny Karpov
From 408ca45f7c5c6e58208a7b8004f764dc0c1afdd3 Mon Sep 17 00:00:00 2001 From: Zac Walker Date: Tue, 20 Feb 2024 18:15:27 +0100 Subject: [PATCH v1 05/13] Reuse MinGW from i386 for AArch64 This patch creates a new config/mingw directory to share MinGW related definitions, and moves