Re: [google][4.7] Move the building of gcov constructor function after initialization of gcov_info_var

2013-05-06 Thread Carrot Wei
After the refactoring has been checked in, the bug fixing part is simply a moving a function call. Tested by running ./buildit with both x86-64 and power64 targets. The last time regression of tls-tests.c disappeared. So it is really flaky in our testing environment. thanks Carrot 2013-05-02

Re: [google][4.7] Move the building of gcov constructor function after initialization of gcov_info_var

2013-05-06 Thread Xinliang David Li
ok. David On Mon, May 6, 2013 at 6:03 PM, Carrot Wei car...@google.com wrote: After the refactoring has been checked in, the bug fixing part is simply a moving a function call. Tested by running ./buildit with both x86-64 and power64 targets. The last time regression of tls-tests.c

[google][4.7] Move the building of gcov constructor function after initialization of gcov_info_var

2013-05-02 Thread Carrot Wei
This patch fixes google bug 8397853 and targets google 4.7 branch. In LIPO mode, when coverage_obj_init is called, cgraph_state is CGRAPH_STATE_FINISHED. The variable gcov_info_var is created but not initialized. When cgraph_build_static_cdtor is called, the new function and variables are

Re: [google][4.7] Move the building of gcov constructor function after initialization of gcov_info_var

2013-05-02 Thread Xinliang David Li
I suggest submitting the refactoring part of the changes to GCC trunk first. thanks, David On Thu, May 2, 2013 at 11:06 AM, Carrot Wei car...@google.com wrote: This patch fixes google bug 8397853 and targets google 4.7 branch. In LIPO mode, when coverage_obj_init is called, cgraph_state is