Re: [google] Disable getpagesize() for Android toolchain (issue4515131)

2011-05-26 Thread Carrot Wei
Hi I've tested the #ifndef __ANDROID__ on arm qemu without regression. And also built Android toolchain without this error. thanks Carrot 2011-05-26 Jing Yu jin...@google.com * ChangeLog.google-main: New file. * getpagesize.c(getpagesize): Disable it for bionic. Index:

Re: [google] Disable getpagesize() for Android toolchain (issue4515131)

2011-05-26 Thread Joseph S. Myers
On Wed, 25 May 2011, Jing Yu wrote: I am wondering how to disable build of libiberty for target? I Tear out all the target-libiberty code unconditionally? See http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01308.html and references therein; building target libiberty at all is a bug in my view.

Re: [google] Disable getpagesize() for Android toolchain (issue4515131)

2011-05-26 Thread Jing Yu
I have tested the following patch to skip building target libiberty for arm*-*-linux-androideabi. It works as intended when building Android arm-linux-androideabi toolchain. Doug, do we want to skip building libiberty for non arm android toolchain, say *-linux-android*? Joseph, do you think if

Re: [google] Disable getpagesize() for Android toolchain (issue4515131)

2011-05-25 Thread Jing Yu
Hi Joseph, We notice that gcc starts to build libiberty for target as a multilib since gcc-4.6, even if we give --disable-stdc++-v3. Since then, we run into the incompatible getpagesize() error. I am wondering how to disable build of libiberty for target? I searched mailing list. One guy said

Re: [google] Disable getpagesize() for Android toolchain (issue4515131)

2011-05-25 Thread 關振德
Jing Can't we just skip libiberty in top-level configure.ac? Look for the comment Disable target libiberty for some systems. -Doug On Wed, May 25, 2011 at 5:17 PM, Jing Yu jin...@google.com wrote: Hi Joseph, We notice that gcc starts to build libiberty for target as a multilib since

Re: [google] Disable getpagesize() for Android toolchain (issue4515131)

2011-05-25 Thread Jing Yu
Actually I don't know why in gcc-4.6 libiberty is built for target when --disable-stdc++-v3 is given. Is libiberty used by other target libraries now? If not, we can skip libiberty for general Android toolchain. But, I still think it would be nice to make libiberty work, in case it is needed in

[google] Disable getpagesize() for Android toolchain (issue4515131)

2011-05-24 Thread Guozhi Wei
Hi This patch is for google/main. In order to be compatible with current bionic and sysroot, we need to disable getpagesize(). After getpagesize() in bionic is changed and ndk contains that change, we can reenable it. Jing can give more details about it. This patch has been tested on arm qemu

Re: [google] Disable getpagesize() for Android toolchain (issue4515131)

2011-05-24 Thread Joseph S. Myers
On Tue, 24 May 2011, Guozhi Wei wrote: Index: getpagesize.c === --- getpagesize.c (revision 174099) +++ getpagesize.c (working copy) @@ -60,11 +60,13 @@ BUGS # endif /* PAGESIZE */ #endif /* GNU_OUR_PAGESIZE */

Re: [google] Disable getpagesize() for Android toolchain (issue4515131)

2011-05-24 Thread 關振德
Shouldn't we test ifndef __ANDROID__ instead? -Doug On Tue, May 24, 2011 at 2:39 AM, Guozhi Wei car...@google.com wrote: Hi This patch is for google/main. In order to be compatible with current bionic and sysroot, we need to disable getpagesize(). After getpagesize() in bionic is changed