Re: [pph] Add streamer hook for preloading common nodes (issue4478043)

2011-05-05 Thread Richard Guenther
On Wed, May 4, 2011 at 10:26 PM, Diego Novillo dnovi...@google.com wrote: This patch adds a new streamer hook to populate the streamer cache with common nodes. The nodes we populate for GIMPLE in lto_get_common_nodes is not sufficient for C++, unsurprisingly. The patch fixes these

Re: [pph] Add streamer hook for preloading common nodes (issue4478043)

2011-05-05 Thread Richard Guenther
On Thu, May 5, 2011 at 1:03 PM, Diego Novillo dnovi...@google.com wrote: On Thu, May 5, 2011 at 05:06, Richard Guenther richard.guent...@gmail.com wrote: I think we should move away from pre-loading the streamer cache, that has caused enough trouble when the common nodes are originating from

Re: [pph] Add streamer hook for preloading common nodes (issue4478043)

2011-05-05 Thread Diego Novillo
On Thu, May 5, 2011 at 07:07, Richard Guenther richard.guent...@gmail.com wrote: For LTO we have type-merging for that, and we'd continue to pre-load the type merger with the (LTO frontend specific) common tree nodes. OK. For LTO it may make sense to eventually make this hook a nop, then. I

[pph] Add streamer hook for preloading common nodes (issue4478043)

2011-05-04 Thread Diego Novillo
This patch adds a new streamer hook to populate the streamer cache with common nodes. The nodes we populate for GIMPLE in lto_get_common_nodes is not sufficient for C++, unsurprisingly. The patch fixes these regressions in pph.exp: FAIL: g++.dg/pph/p1stdlib.cc -fpph-map=pph.map -I. (test for