Re: [trunk][RFA] Add __i686.get_pc_thunk.bx to libgcc i386 morestack.S

2011-05-04 Thread Chris Demetriou
On Tue, May 3, 2011 at 16:39, Chris Demetriou c...@google.com wrote: It is also OK if you s/__i686/__x86/ to correspond to your earlier change.  Either way is OK. Well, that change is not in trunk. Should that change move to trunk, yes, it's appropriate to change this as well (though

[trunk][RFA] Add __i686.get_pc_thunk.bx to libgcc i386 morestack.S

2011-05-03 Thread Chris Demetriou
After I submitted http://gcc.gnu.org/ml/gcc-patches/2011-04/msg02422.html, Rong Xu noted that the resulting sources, if configured --with-pic, would not actually build properly due to missing __i686.get_pc_thunk.bx (due to my renaming that to __x86...). While that issue was exposed by my change,

Re: [trunk][RFA] Add __i686.get_pc_thunk.bx to libgcc i386 morestack.S

2011-05-03 Thread Ian Lance Taylor
Chris Demetriou c...@google.com writes: 2011-05-03 Chris Demetriou c...@google.com * libgcc/config/i386/morestack.S (__i686.get_pc_thunk.bx): New. No libgcc in libgcc/ChangeLog. This is OK. It is also OK if you s/__i686/__x86/ to correspond to your earlier change. Either way is

Re: [trunk][RFA] Add __i686.get_pc_thunk.bx to libgcc i386 morestack.S

2011-05-03 Thread Chris Demetriou
On Tue, May 3, 2011 at 15:05, Ian Lance Taylor i...@google.com wrote: 2011-05-03  Chris Demetriou  c...@google.com         * libgcc/config/i386/morestack.S (__i686.get_pc_thunk.bx): New. No libgcc in libgcc/ChangeLog. Fixed, sorry.  (That's what I get for pasting from svn status output.